From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 9892DC05027
	for <netdev@archiver.kernel.org>; Wed,  8 Feb 2023 05:56:54 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229743AbjBHF4v (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 8 Feb 2023 00:56:51 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41898 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229668AbjBHF4u (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 8 Feb 2023 00:56:50 -0500
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B58AF3C32
        for <netdev@vger.kernel.org>; Tue,  7 Feb 2023 21:56:47 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id 59C37B81B08
        for <netdev@vger.kernel.org>; Wed,  8 Feb 2023 05:56:46 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7455C433EF;
        Wed,  8 Feb 2023 05:56:44 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1675835805;
        bh=qbR60NxxkK1kVNTeRRozyH5Mmu5Oq5BsDlB7QqrD8HI=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=YurLbLqRwM+auDU/uoiC3/AWXxqYNJizogdeqTItMnkn8nYELhHTGHH331dbpRbNM
         JavddafCJKuVeVRaxbnz0nAvsx/LkpLEMDyQ7c4pi44OsPmwKGcFh/VQ2Is2cgWjiJ
         olRsB56acPcAVFCfTCfrRWSRYMpOgtEA+/Atr8QylAOaRlIqWkhdmTsmYDNK0THdHJ
         8++3fmxbYwjaFTXvdoBiwjCWD29/J9jmTA8EgfvqeggWAt/Cc+Xr19EtFm+p8IJD3s
         bV7geggwjSSNdbu0NIUMmJwBAopipZGEuxTTaumtZeklO+iGyQW1ag+EoSf6f5bd1B
         Fx37fFavAgPkw==
Date:   Tue, 7 Feb 2023 21:56:43 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Tony Nguyen <anthony.l.nguyen@intel.com>
Cc:     davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
        Sebastian Czapla <sebastianx.czapla@intel.com>,
        netdev@vger.kernel.org,
        Grzegorz Szczurek <grzegorzx.szczurek@intel.com>,
        Marek Szlosek <marek.szlosek@intel.com>
Subject: Re: [PATCH net-next 1/6] i40e: Add flag for disabling VF source
 pruning
Message-ID: <20230207215643.43f76bdd@kernel.org>
In-Reply-To: <20230206235635.662263-2-anthony.l.nguyen@intel.com>
References: <20230206235635.662263-1-anthony.l.nguyen@intel.com>
        <20230206235635.662263-2-anthony.l.nguyen@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Mon,  6 Feb 2023 15:56:30 -0800 Tony Nguyen wrote:
> Allow user to change source pruning for VF VSIs. This allows VFs to
> receive packets with MAC_SRC and MAC_DST equal to VFs mac.
> 
> Added priv flag vf-source-pruning to allow user to change
> source pruning setting. Reset all VSIs to commit the setting.
> If vf-source-pruning is off and VF is trusted on with spoofchk off
> then disable source pruning on specific VF takes effect.
> 
> Without this patch it is not possible to change source pruning
> setting on VF VSIs.

Intel keeps trickling in private flags to adjust the behavior of legacy
SR-IOV NDOs. No documentation, no well understood semantics.
This does not seem defensible upstream when we already started rejecting
any use of legacy SR-IOV NDOs in new drivers.

Quite sad this is bundled in the same series as the much appreciated
removal of magic status codes.