All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: virtio-comment@lists.oasis-open.org,
	virtio-dev@lists.oasis-open.org, jasowang@redhat.com,
	mst@redhat.com, cohuck@redhat.com, sgarzare@redhat.com,
	stefanha@redhat.com, nrupal.jani@intel.com,
	Piotr.Uminski@intel.com, hang.yuan@intel.com
Cc: virtio@lists.oasis-open.org,
	Zhu Lingshan <lingshan.zhu@intel.com>,
	pasic@linux.ibm.com, Shahaf Shuler <shahafs@nvidia.com>,
	Parav Pandit <parav@nvidia.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [virtio-dev] [PATCH v10 00/10] Introduce device group and device management
Date: Thu, 9 Feb 2023 07:13:28 -0500	[thread overview]
Message-ID: <20230209121221.15118-1-mst@redhat.com> (raw)


Thanks to everyone who commented!  Here's v10 after a longish
hiccup - I hope this is close to being ready. I'm especially
interested to hear whether this is in a good enough shape to
serve as basis for vq transport.

Thanks!

Change log:

since v9:
	addressed review comments:
		multiple typo fixes
		made command list array 64 bit - easier future proofing
		clarifications around group type and admin command concepts
		lots of clarifications around structure
			trucation for forwards and backwards compatibility -
			hopefully things are clear now

since v8:
	addressed comments by Cornelia - as we agreed on list
	
since v7:
	make high level error codes match linux, with virtio specific codes
		in a separate field
	renamed _ACCEPT to _USE since that's what it does
	clarified forward compatibility and non pci transports
	support multiple admin vqs
	conformance statements
	lots of changes all over the place to I changed author from Max
	to myself. Don't need to take credit but also don't want
	to blame Max for my mistakes.

since v6:

	- removed some extentions intended for future use.
	  We'll do them when we get there.

	- brought back command list query from v5 in a simplified form -
	  it's here to address the case where a single parent
	  can address multiple groups, such as PF addressing
	  transport vq and sriov vfs.

	- attempt to make terminology more formal.
	In particular a term for whoever controls the group.
 	I am still going back
	and forth between "parent" and "owner" - owner might
	be better after all since it will work if we ever
	have a self group. For now it's parent.

TODO (maybe?) - probably ok to defer until this part is upstream:

	Add "all members" member id.

	Add commands for MSI, feature discovery.

	Add commands for transport vq.


My intent is to try and support both SR-IOV and SIOV
usecases with the same structure and maybe even the same
VQ.

For example, it might make sense to split creating/destroying
SIOV devices from the transport passing data from the guest - the
driver would then not negotiate VIRTIO_F_SR_IOV (which
then means auto-provisioning).

This is out of RFC, since we have two commands which are useful
to discover supported group types (ATM can be none or SR-IOV).


Michael S. Tsirkin (10):
  virtio: document forward compatibility guarantees
  admin: introduce device group and related concepts
  admin: introduce group administration commands
  admin: introduce virtio admin virtqueues
  pci: add admin vq registers to virtio over pci
  mmio: document ADMIN_VQ as reserved
  ccw: document ADMIN_VQ as reserved
  admin: command list discovery
  admin: conformance clauses
  ccw: document more reserved features

 admin.tex   | 501 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 content.tex | 111 +++++++++++-
 2 files changed, 610 insertions(+), 2 deletions(-)
 create mode 100644 admin.tex

-- 
MST


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


             reply	other threads:[~2023-02-09 12:13 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09 12:13 Michael S. Tsirkin [this message]
2023-02-09 12:13 ` [PATCH v10 01/10] virtio: document forward compatibility guarantees Michael S. Tsirkin
2023-02-09 14:52   ` [virtio-comment] Re: [virtio-dev] " David Edmondson
2023-02-13 12:06     ` [virtio-dev] " Cornelia Huck
2023-02-13 12:28       ` Michael S. Tsirkin
2023-02-11 18:50   ` [virtio-dev] " Parav Pandit
2023-02-09 12:13 ` [PATCH v10 02/10] admin: introduce device group and related concepts Michael S. Tsirkin
2023-02-09 15:00   ` [virtio-comment] " David Edmondson
2023-02-09 15:13     ` Michael S. Tsirkin
2023-02-09 15:22       ` David Edmondson
2023-02-09 17:47         ` Max Gurtovoy
2023-02-09 19:58           ` Michael S. Tsirkin
2023-02-12 12:10             ` Max Gurtovoy
2023-02-12 13:15               ` Michael S. Tsirkin
2023-02-12 14:34                 ` Max Gurtovoy
2023-02-12 20:19                   ` Michael S. Tsirkin
2023-02-12 22:49                     ` Max Gurtovoy
2023-02-13  8:12                       ` Michael S. Tsirkin
2023-02-13  9:20                         ` [virtio-dev] " Zhu, Lingshan
2023-02-13 10:55                           ` [virtio] " Michael S. Tsirkin
2023-02-13 10:28                         ` Max Gurtovoy
2023-02-14  1:22             ` Parav Pandit
2023-02-11 16:52   ` Parav Pandit
2023-02-11 18:50   ` Parav Pandit
2023-02-13 12:20   ` [virtio] " Cornelia Huck
2023-02-13 12:28     ` Michael S. Tsirkin
2023-02-09 12:13 ` [PATCH v10 03/10] admin: introduce group administration commands Michael S. Tsirkin
2023-02-10  8:24   ` [virtio-comment] " Zhu Lingshan
2023-02-11 18:50   ` Parav Pandit
2023-02-12  9:49     ` Michael S. Tsirkin
2023-02-13  0:54       ` Max Gurtovoy
2023-02-13  8:16         ` Michael S. Tsirkin
2023-02-13 10:35           ` [virtio-comment] " Max Gurtovoy
2023-02-13 12:42             ` Cornelia Huck
2023-02-13 13:11               ` Max Gurtovoy
2023-02-13 13:13                 ` [virtio] " Cornelia Huck
2023-02-13 13:26                   ` Max Gurtovoy
2023-02-13 13:36                     ` [virtio] " Cornelia Huck
2023-02-13 15:07                       ` Max Gurtovoy
2023-02-13 20:29                   ` [virtio] " Michael S. Tsirkin
2023-02-14  9:01                     ` [virtio-comment] " Cornelia Huck
2023-02-14  1:18       ` Parav Pandit
2023-02-14  7:46         ` Michael S. Tsirkin
2023-02-14 16:44           ` Parav Pandit
2023-02-14 21:57             ` Michael S. Tsirkin
2023-02-15  4:46               ` [virtio-comment] " Parav Pandit
2023-02-15  5:13                 ` Michael S. Tsirkin
2023-02-13 12:37   ` [virtio-comment] Re: [virtio-dev] " David Edmondson
2023-02-15  5:17   ` Parav Pandit
2023-02-15  5:18     ` Michael S. Tsirkin
2023-02-09 12:13 ` [PATCH v10 04/10] admin: introduce virtio admin virtqueues Michael S. Tsirkin
2023-02-11 18:50   ` Parav Pandit
2023-02-09 12:13 ` [PATCH v10 05/10] pci: add admin vq registers to virtio over pci Michael S. Tsirkin
2023-02-11 18:52   ` Parav Pandit
2023-02-13 12:21   ` [virtio-comment] " David Edmondson
2023-02-15  0:53     ` Max Gurtovoy
2023-02-15  5:09       ` Michael S. Tsirkin
2023-02-15  8:49       ` David Edmondson
2023-02-09 12:13 ` [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved Michael S. Tsirkin
2023-02-11 18:52   ` Parav Pandit
2023-02-15  0:56   ` Max Gurtovoy
2023-02-09 12:13 ` [PATCH v10 07/10] ccw: " Michael S. Tsirkin
2023-02-13 12:49   ` [virtio-comment] " Cornelia Huck
2023-02-15  0:58   ` Max Gurtovoy
2023-02-09 12:14 ` [PATCH v10 08/10] admin: command list discovery Michael S. Tsirkin
2023-02-09 17:04   ` Uminski, Piotr
2023-02-11 18:52   ` Parav Pandit
2023-02-13  5:41   ` [virtio-dev] " Zhu Lingshan
2023-02-13 12:27   ` [virtio-comment] " David Edmondson
2023-02-09 12:14 ` [PATCH v10 09/10] admin: conformance clauses Michael S. Tsirkin
2023-02-11 16:43   ` Parav Pandit
2023-02-13  6:43   ` [virtio-comment] Re: [virtio-dev] " Zhu Lingshan
2023-02-13 10:51     ` Michael S. Tsirkin
2023-02-13 13:42   ` [virtio-comment] " David Edmondson
2023-02-09 12:14 ` [PATCH v10 10/10] ccw: document more reserved features Michael S. Tsirkin
2023-02-13 12:54   ` [virtio] " Cornelia Huck
2023-02-13 13:04     ` Cornelia Huck
2023-02-11 18:49 ` [PATCH v10 00/10] Introduce device group and device management Parav Pandit
2023-02-12  9:42   ` Michael S. Tsirkin
2023-02-14  0:52     ` [virtio-comment] " Parav Pandit
2023-03-02 13:04 [virtio-dev] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230209121221.15118-1-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=Piotr.Uminski@intel.com \
    --cc=cohuck@redhat.com \
    --cc=hang.yuan@intel.com \
    --cc=jasowang@redhat.com \
    --cc=lingshan.zhu@intel.com \
    --cc=mgurtovoy@nvidia.com \
    --cc=nrupal.jani@intel.com \
    --cc=parav@nvidia.com \
    --cc=pasic@linux.ibm.com \
    --cc=sgarzare@redhat.com \
    --cc=shahafs@nvidia.com \
    --cc=stefanha@redhat.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtio@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.