All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Michael Roth <michael.roth@amd.com>,
	Markus Armbruster <armbru@redhat.com>,
	John Snow <jsnow@redhat.com>
Subject: [PATCH v3 7/7] qapi: remove JSON value FIXME
Date: Thu,  9 Feb 2023 13:47:58 -0500	[thread overview]
Message-ID: <20230209184758.1017863-8-jsnow@redhat.com> (raw)
In-Reply-To: <20230209184758.1017863-1-jsnow@redhat.com>

With the two major JSON-ish type hierarchies clarified for distinct
purposes; QAPIExpression for parsed expressions and JSONValue for
introspection data, remove this FIXME as no longer an action item.

In theory, it may be possible to define a completely agnostic
one-size-fits-all JSON type hierarchy that any other user could borrow -
in practice, it's tough to wrangle the differences between invariant,
covariant and contravariant types: input and output parameters demand
different properties of such a structure. As such, it's simply more
trouble than it's worth.

So, declare this "done enough for now".

Signed-off-by: John Snow <jsnow@redhat.com>
---
 scripts/qapi/parser.py | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index c165bd3912c..b5afdd703e7 100644
--- a/scripts/qapi/parser.py
+++ b/scripts/qapi/parser.py
@@ -42,10 +42,6 @@
 _ExprValue = Union[List[object], Dict[str, object], str, bool]
 
 
-# FIXME: Consolidate and centralize definitions for _ExprValue and
-# JSONValue; currently scattered across several modules.
-
-
 # 3.6 workaround: can be removed when Python 3.7+ is our required version.
 if TYPE_CHECKING:
     _UserDict = UserDict[str, object]
-- 
2.39.0



  parent reply	other threads:[~2023-02-09 18:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09 18:47 [PATCH v3 0/7] qapi: static typing conversion, pt5c John Snow
2023-02-09 18:47 ` [PATCH v3 1/7] qapi: Update flake8 config John Snow
2023-02-09 18:47 ` [PATCH v3 2/7] qapi: update pylint configuration John Snow
2023-02-09 18:47 ` [PATCH v3 3/7] qapi/expr: Split check_expr out from check_exprs John Snow
2023-02-10 12:14   ` Markus Armbruster
2023-02-10 12:33   ` Markus Armbruster
2023-02-10 15:20     ` John Snow
2023-02-11 10:06       ` Markus Armbruster
2023-02-14 17:04         ` John Snow
2023-02-09 18:47 ` [PATCH v3 4/7] qapi/expr: add typing workaround for AbstractSet John Snow
2023-02-10 15:44   ` Markus Armbruster
2023-02-10 16:26     ` John Snow
2023-02-14 17:08       ` John Snow
2023-02-09 18:47 ` [PATCH v3 5/7] qapi/parser: add QAPIExpression type John Snow
2023-02-11  6:49   ` Markus Armbruster
2023-02-14 16:57     ` John Snow
2023-02-09 18:47 ` [PATCH v3 6/7] qapi: remove _JSONObject John Snow
2023-02-11  6:18   ` Markus Armbruster
2023-02-09 18:47 ` John Snow [this message]
2023-02-11  6:42   ` [PATCH v3 7/7] qapi: remove JSON value FIXME Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230209184758.1017863-8-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.