All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	netdev@vger.kernel.org, eric.dumazet@gmail.com,
	syzbot+d44d88f1d11e6ca8576b@syzkaller.appspotmail.com,
	Kurt Kanzenbach <kurt@linutronix.de>
Subject: Re: [PATCH net-next] net/sched: fix error recovery in qdisc_create()
Date: Fri, 10 Feb 2023 18:16:00 +0200	[thread overview]
Message-ID: <20230210161600.grt472jhup6wfkbb@skbuf> (raw)
In-Reply-To: <20230210152605.1852743-1-edumazet@google.com> <20230210152605.1852743-1-edumazet@google.com>

On Fri, Feb 10, 2023 at 03:26:05PM +0000, Eric Dumazet wrote:
> If TCA_STAB attribute is malformed, qdisc_get_stab() returns
> an error, and we end up calling ops->destroy() while ops->init()
> has not been called yet.
> 
> While we are at it, call qdisc_put_stab() after ops->destroy().
> 
> Fixes: 1f62879e3632 ("net/sched: make stab available before ops->init() call")
> Reported-by: syzbot+d44d88f1d11e6ca8576b@syzkaller.appspotmail.com
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Vladimir Oltean <vladimir.oltean@nxp.com>
> Cc: Kurt Kanzenbach <kurt@linutronix.de>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

  reply	other threads:[~2023-02-10 16:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-10 15:26 [PATCH net-next] net/sched: fix error recovery in qdisc_create() Eric Dumazet
2023-02-10 16:16 ` Vladimir Oltean [this message]
2023-02-13 10:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230210161600.grt472jhup6wfkbb@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=syzbot+d44d88f1d11e6ca8576b@syzkaller.appspotmail.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.