From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D5A6C636D7 for ; Mon, 13 Feb 2023 10:44:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231217AbjBMKoC (ORCPT ); Mon, 13 Feb 2023 05:44:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230034AbjBMKnW (ORCPT ); Mon, 13 Feb 2023 05:43:22 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F21416AC8; Mon, 13 Feb 2023 02:43:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6047F60FA7; Mon, 13 Feb 2023 10:43:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E406AC43339; Mon, 13 Feb 2023 10:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676284996; bh=roctf62/yqPkgEsUS/nfvm5p+4sye80U1pGQ8NLWzxM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i/NB3Z35oO3xp7BNUVdB8aBYC1V46+hJx6gbi9JYyG+4X5Z+ddU0Ifejx1SVieXbd R51bU8IKULnwV0dtRZ6CcTBpcnr+dFODpNe97S38ulqotmTtAaX+oQkYd5+0r81vUC BYl/RR7/lEdqCx++k1z99YPxZ/5KTHghRhvNzlgersrMmzz5u50pA/5uiaTOamVHtB vZfQflnwHXGVFt1FvJBedMI6JEEW/fHg64E9Nxhc5EaEsHhq5zZ6O5NBdGCFghBRzG 1rTD6y3ujNixCWL5oB9/jPEkADHit36hBJhKLm4n8oMjS1HDmWJw2FJHHiz1/rFbKq uQ0lDTo6NIFrA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pRWJb-0004Wp-Vx; Mon, 13 Feb 2023 11:44:08 +0100 From: Johan Hovold To: Marc Zyngier , Thomas Gleixner Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Hsin-Yi Wang , Mark-PK Tsai Subject: [PATCH v6 12/20] x86/ioapic: Use irq_domain_create_hierarchy() Date: Mon, 13 Feb 2023 11:42:54 +0100 Message-Id: <20230213104302.17307-13-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213104302.17307-1-johan+linaro@kernel.org> References: <20230213104302.17307-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the irq_domain_create_hierarchy() helper to create the hierarchical domain, which both serves as documentation and avoids poking at irqdomain internals. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Hsin-Yi Wang Tested-by: Mark-PK Tsai Signed-off-by: Johan Hovold --- arch/x86/kernel/apic/io_apic.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index a868b76cd3d4..1f83b052bb74 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -2364,9 +2364,8 @@ static int mp_irqdomain_create(int ioapic) return -ENODEV; } - ip->irqdomain = irq_domain_create_linear(fn, hwirqs, cfg->ops, - (void *)(long)ioapic); - + ip->irqdomain = irq_domain_create_hierarchy(parent, 0, hwirqs, fn, cfg->ops, + (void *)(long)ioapic); if (!ip->irqdomain) { /* Release fw handle if it was allocated above */ if (!cfg->dev) @@ -2374,8 +2373,6 @@ static int mp_irqdomain_create(int ioapic) return -ENOMEM; } - ip->irqdomain->parent = parent; - if (cfg->type == IOAPIC_DOMAIN_LEGACY || cfg->type == IOAPIC_DOMAIN_STRICT) ioapic_dynirq_base = max(ioapic_dynirq_base, -- 2.39.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08747C636CC for ; Mon, 13 Feb 2023 10:46:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DOzN3iiuESeoVvR/IODOMcI8NwDZlLVWBaGd0fKu4/I=; b=g2iRMqreC5lMCP qD8ur5X/s/MeYuwrMxTcHTiGbDpeTS8eooAJDyZ8oKie6xpVECNvdvBwiAoJ/e/dY/BAu9cxbzLtL HB3Hh5v3hlaaxtJUohsrRTRuwGLeSYaLH/h2IbTrZVuPe7FjPtK2y5CGPRPNhgY2wdfviImix1R1l idyHndOn+ZYvxyN/FkK+/w4qWT5+9RqWHjQYhOSSL8no0NPQsZ2ECbUF8W3YhkavEduO/BFvRBu/j YE4kWDer5rNFeQI9EbDvK/Qw+wKkJilrsCpab1gvlJBt2apKDCsGsi9Z33IHhYFExKkehpov7DoZA 19T3J+NXP1BkCPX/hueQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRWKn-00EALd-Rg; Mon, 13 Feb 2023 10:45:21 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRWIq-00E9M6-1d for linux-arm-kernel@lists.infradead.org; Mon, 13 Feb 2023 10:43:23 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A5F0460FC9; Mon, 13 Feb 2023 10:43:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E406AC43339; Mon, 13 Feb 2023 10:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676284996; bh=roctf62/yqPkgEsUS/nfvm5p+4sye80U1pGQ8NLWzxM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i/NB3Z35oO3xp7BNUVdB8aBYC1V46+hJx6gbi9JYyG+4X5Z+ddU0Ifejx1SVieXbd R51bU8IKULnwV0dtRZ6CcTBpcnr+dFODpNe97S38ulqotmTtAaX+oQkYd5+0r81vUC BYl/RR7/lEdqCx++k1z99YPxZ/5KTHghRhvNzlgersrMmzz5u50pA/5uiaTOamVHtB vZfQflnwHXGVFt1FvJBedMI6JEEW/fHg64E9Nxhc5EaEsHhq5zZ6O5NBdGCFghBRzG 1rTD6y3ujNixCWL5oB9/jPEkADHit36hBJhKLm4n8oMjS1HDmWJw2FJHHiz1/rFbKq uQ0lDTo6NIFrA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pRWJb-0004Wp-Vx; Mon, 13 Feb 2023 11:44:08 +0100 From: Johan Hovold To: Marc Zyngier , Thomas Gleixner Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Hsin-Yi Wang , Mark-PK Tsai Subject: [PATCH v6 12/20] x86/ioapic: Use irq_domain_create_hierarchy() Date: Mon, 13 Feb 2023 11:42:54 +0100 Message-Id: <20230213104302.17307-13-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213104302.17307-1-johan+linaro@kernel.org> References: <20230213104302.17307-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_024320_191967_CE8B3175 X-CRM114-Status: GOOD ( 11.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VXNlIHRoZSBpcnFfZG9tYWluX2NyZWF0ZV9oaWVyYXJjaHkoKSBoZWxwZXIgdG8gY3JlYXRlIHRo ZSBoaWVyYXJjaGljYWwKZG9tYWluLCB3aGljaCBib3RoIHNlcnZlcyBhcyBkb2N1bWVudGF0aW9u IGFuZCBhdm9pZHMgcG9raW5nIGF0CmlycWRvbWFpbiBpbnRlcm5hbHMuCgpSZXZpZXdlZC1ieTog UGhpbGlwcGUgTWF0aGlldS1EYXVkw6kgPHBoaWxtZEBsaW5hcm8ub3JnPgpUZXN0ZWQtYnk6IEhz aW4tWWkgV2FuZyA8aHNpbnlpQGNocm9taXVtLm9yZz4KVGVzdGVkLWJ5OiBNYXJrLVBLIFRzYWkg PG1hcmstcGsudHNhaUBtZWRpYXRlay5jb20+ClNpZ25lZC1vZmYtYnk6IEpvaGFuIEhvdm9sZCA8 am9oYW4rbGluYXJvQGtlcm5lbC5vcmc+Ci0tLQogYXJjaC94ODYva2VybmVsL2FwaWMvaW9fYXBp Yy5jIHwgNyArKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCA1IGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL2FyY2gveDg2L2tlcm5lbC9hcGljL2lvX2FwaWMuYyBiL2Fy Y2gveDg2L2tlcm5lbC9hcGljL2lvX2FwaWMuYwppbmRleCBhODY4Yjc2Y2QzZDQuLjFmODNiMDUy YmI3NCAxMDA2NDQKLS0tIGEvYXJjaC94ODYva2VybmVsL2FwaWMvaW9fYXBpYy5jCisrKyBiL2Fy Y2gveDg2L2tlcm5lbC9hcGljL2lvX2FwaWMuYwpAQCAtMjM2NCw5ICsyMzY0LDggQEAgc3RhdGlj IGludCBtcF9pcnFkb21haW5fY3JlYXRlKGludCBpb2FwaWMpCiAJCXJldHVybiAtRU5PREVWOwog CX0KIAotCWlwLT5pcnFkb21haW4gPSBpcnFfZG9tYWluX2NyZWF0ZV9saW5lYXIoZm4sIGh3aXJx cywgY2ZnLT5vcHMsCi0JCQkJCQkgKHZvaWQgKikobG9uZylpb2FwaWMpOwotCisJaXAtPmlycWRv bWFpbiA9IGlycV9kb21haW5fY3JlYXRlX2hpZXJhcmNoeShwYXJlbnQsIDAsIGh3aXJxcywgZm4s IGNmZy0+b3BzLAorCQkJCQkJICAgICh2b2lkICopKGxvbmcpaW9hcGljKTsKIAlpZiAoIWlwLT5p cnFkb21haW4pIHsKIAkJLyogUmVsZWFzZSBmdyBoYW5kbGUgaWYgaXQgd2FzIGFsbG9jYXRlZCBh Ym92ZSAqLwogCQlpZiAoIWNmZy0+ZGV2KQpAQCAtMjM3NCw4ICsyMzczLDYgQEAgc3RhdGljIGlu dCBtcF9pcnFkb21haW5fY3JlYXRlKGludCBpb2FwaWMpCiAJCXJldHVybiAtRU5PTUVNOwogCX0K IAotCWlwLT5pcnFkb21haW4tPnBhcmVudCA9IHBhcmVudDsKLQogCWlmIChjZmctPnR5cGUgPT0g SU9BUElDX0RPTUFJTl9MRUdBQ1kgfHwKIAkgICAgY2ZnLT50eXBlID09IElPQVBJQ19ET01BSU5f U1RSSUNUKQogCQlpb2FwaWNfZHluaXJxX2Jhc2UgPSBtYXgoaW9hcGljX2R5bmlycV9iYXNlLAot LSAKMi4zOS4xCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=