From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 012FF10F2 for ; Tue, 14 Feb 2023 00:14:10 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 82E431042; Mon, 13 Feb 2023 16:14:52 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B88B63F663; Mon, 13 Feb 2023 16:14:06 -0800 (PST) Date: Tue, 14 Feb 2023 00:12:00 +0000 From: Andre Przywara To: Bastian Germann Cc: Wilken Gottwalt , Ohad Ben-Cohen , Bjorn Andersson , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: [PATCH 3/3] arm64: dts: allwinner: a64: Add hwspinlock node Message-ID: <20230214001200.54504034@slackpad.lan> In-Reply-To: <20230213231931.6546-4-bage@debian.org> References: <20230213231931.6546-1-bage@debian.org> <20230213231931.6546-4-bage@debian.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 14 Feb 2023 00:19:30 +0100 Bastian Germann wrote: Hi, > Add the hwspinlock to A64 which is already implemented for A31. > > Signed-off-by: Bastian Germann > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 77b5349f6087..d4be8be0f2f3 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -851,6 +851,16 @@ wdt0: watchdog@1c20ca0 { > clocks = <&osc24M>; > }; > > + hwspinlock: hwlock@1c18000 { > + compatible = "allwinner,sun6i-a31-hwspinlock"; I wonder if we should add a more specific compatible string here (sun50i-a64-hwspinlock), with the existing one as a fallback. Checked the address and the clock/reset against the manual. I am not entirely sure if it's the best practice to unconditionally enable those devices, but since it needs explicit consumers to be used, it's probably fine. Cheers, Andre > + reg = <0x01c18000 0x1000>; > + clocks = <&ccu CLK_BUS_SPINLOCK>; > + clock-names = "ahb"; > + resets = <&ccu RST_BUS_SPINLOCK>; > + reset-names = "ahb"; > + #hwlock-cells = <1>; > + }; > + > spdif: spdif@1c21000 { > #sound-dai-cells = <0>; > compatible = "allwinner,sun50i-a64-spdif", From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8A77C636D4 for ; Tue, 14 Feb 2023 00:15:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IiSb68FIB0iTDQ2y1jImVT/Mw3ZnK89vq/n2jsTJOtc=; b=LbIo39V2Q9b6Ht SWf2d1m+ILHoy4am7QJx9o56/ew4Zn9d2f+KW9gtZNgo7dHaoNPkf8NhbvePwqFCFQ0WeipgVlgmk IgSr+Dw3APJnfp+5cthX54sH09LiuKtZJD456UYZkngKx3cfGojY9RtEW1eGfQCTsCFb+ZqGV4mOr XW30HGCRQDeNEDxeNzd4qtqCi0d5GZ4X/cJvdmokHLq6lePldglIDhehtdiM39if0tyrTI3gHjpWK QQ44yfo8ck6exm0NmbEwTVourV+kPh+fMlkwVd08HhtiuagUkZNNKkvS6GT1atHHXzl4RGYzFK2K8 2JXQPohrWiTMe2zu0/gg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRixi-00Gs13-0A; Tue, 14 Feb 2023 00:14:22 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRixZ-00GrzL-JH for linux-arm-kernel@lists.infradead.org; Tue, 14 Feb 2023 00:14:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 82E431042; Mon, 13 Feb 2023 16:14:52 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B88B63F663; Mon, 13 Feb 2023 16:14:06 -0800 (PST) Date: Tue, 14 Feb 2023 00:12:00 +0000 From: Andre Przywara To: Bastian Germann Cc: Wilken Gottwalt , Ohad Ben-Cohen , Bjorn Andersson , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: [PATCH 3/3] arm64: dts: allwinner: a64: Add hwspinlock node Message-ID: <20230214001200.54504034@slackpad.lan> In-Reply-To: <20230213231931.6546-4-bage@debian.org> References: <20230213231931.6546-1-bage@debian.org> <20230213231931.6546-4-bage@debian.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_161413_775991_4EE1B1AD X-CRM114-Status: GOOD ( 15.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 14 Feb 2023 00:19:30 +0100 Bastian Germann wrote: Hi, > Add the hwspinlock to A64 which is already implemented for A31. > > Signed-off-by: Bastian Germann > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 77b5349f6087..d4be8be0f2f3 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -851,6 +851,16 @@ wdt0: watchdog@1c20ca0 { > clocks = <&osc24M>; > }; > > + hwspinlock: hwlock@1c18000 { > + compatible = "allwinner,sun6i-a31-hwspinlock"; I wonder if we should add a more specific compatible string here (sun50i-a64-hwspinlock), with the existing one as a fallback. Checked the address and the clock/reset against the manual. I am not entirely sure if it's the best practice to unconditionally enable those devices, but since it needs explicit consumers to be used, it's probably fine. Cheers, Andre > + reg = <0x01c18000 0x1000>; > + clocks = <&ccu CLK_BUS_SPINLOCK>; > + clock-names = "ahb"; > + resets = <&ccu RST_BUS_SPINLOCK>; > + reset-names = "ahb"; > + #hwlock-cells = <1>; > + }; > + > spdif: spdif@1c21000 { > #sound-dai-cells = <0>; > compatible = "allwinner,sun50i-a64-spdif", _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel