From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19D53C61DA4 for ; Thu, 16 Feb 2023 13:40:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 87FD840CA4; Thu, 16 Feb 2023 13:40:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 87FD840CA4 Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eu6sf+9u X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eGUduD0bFG_Y; Thu, 16 Feb 2023 13:40:49 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id F082240339; Thu, 16 Feb 2023 13:40:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org F082240339 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id CCED2C0033; Thu, 16 Feb 2023 13:40:48 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2B6E2C002B for ; Thu, 16 Feb 2023 13:40:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id ED28F82044 for ; Thu, 16 Feb 2023 13:40:47 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org ED28F82044 Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eu6sf+9u X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z9JzxLGurcNF for ; Thu, 16 Feb 2023 13:40:47 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 448DB8203C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id 448DB8203C for ; Thu, 16 Feb 2023 13:40:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676554846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y98TLzC7T3MjlRAfco0hk5x9PJvmulya2RupI5c7FMk=; b=eu6sf+9ulluL7PPyS9xUmzmMaQiKjWuigF0RfzhMm3p/FX+xAEay1UcDdiDgt6RFjJOMGe ONRpS5jm9gIxj6lHCtE9DRRzA3e/si3X4ZLMMJtC8+qciM4T1aGL0MRGT5H/xQWoxgzNtG R3I+NSCGdETpOvH3OyigIZloVfh9DZo= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-43-bixbhn9ZN6ig7Aq0bBgjdw-1; Thu, 16 Feb 2023 08:40:44 -0500 X-MC-Unique: bixbhn9ZN6ig7Aq0bBgjdw-1 Received: by mail-qt1-f198.google.com with SMTP id z12-20020ac8710c000000b003b829a0eda2so1196466qto.21 for ; Thu, 16 Feb 2023 05:40:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y98TLzC7T3MjlRAfco0hk5x9PJvmulya2RupI5c7FMk=; b=N/rYMeAJ0IlYREJB6DAnAg4wCyH26OW4F1X5WC89s0T0P6wK8zPeA3do+VXH2XpolE TG+gQea1GRSUqtbGEOTnzOeTBl6a643lOe7VDHqlHkzGeIC96Vn0mi+XOe7lF+hAtNnG PHt0uNXQ+gOtHkdt0HQ15W627APDvkq5VbUCpffrBmI7bLXZUYK9Ma09MEDW+pV2pwc9 PmE+Oa3LbYI3nkaBgy2qt5IUza4ly/k62vUPamIi2Zklk556/J5vFoFUcHJ0UBADTFrV +0NlaDwRjOc32BaySAMnZnZ91U66Z4q1mVseoyz4u7fxnrnzfaZGhQlRXixkgP+PS1Oq 7KCQ== X-Gm-Message-State: AO0yUKX4pbw/3jm1ar7mYrWhPF74DG9SfZpdB2u6n3S1y2vSkMqvt755 DiWg6HABhL6bwqVcIDprkp5bm8jjtYE5dKQJHvpHc/Cf7lv+Gm1m5JuSMJHyTReGFl3p/ARy3ff 9+cZnrZ6iQqd3My5AyBlNTifcusmObajLr9kF6VZpzQ== X-Received: by 2002:ac8:5c8a:0:b0:3b6:36a0:adbe with SMTP id r10-20020ac85c8a000000b003b636a0adbemr9858806qta.6.1676554844470; Thu, 16 Feb 2023 05:40:44 -0800 (PST) X-Google-Smtp-Source: AK7set+u2XfrViYGYBUOAnQ+C6klosItAnWhnmgPEyZDck8HDSLvs4kyoFZDdTEvpoeeeF5P7hlYrA== X-Received: by 2002:ac8:5c8a:0:b0:3b6:36a0:adbe with SMTP id r10-20020ac85c8a000000b003b636a0adbemr9858769qta.6.1676554844177; Thu, 16 Feb 2023 05:40:44 -0800 (PST) Received: from sgarzare-redhat (host-82-57-51-167.retail.telecomitalia.it. [82.57.51.167]) by smtp.gmail.com with ESMTPSA id z143-20020a376595000000b0073ba211e765sm228285qkb.19.2023.02.16.05.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 05:40:43 -0800 (PST) Date: Thu, 16 Feb 2023 14:40:39 +0100 From: Stefano Garzarella To: Arseniy Krasnov Subject: Re: [RFC PATCH v1 01/12] vsock: check error queue to set EPOLLERR Message-ID: <20230216134039.rgnb2hnzgme2ve76@sgarzare-redhat> References: <0e7c6fc4-b4a6-a27b-36e9-359597bba2b5@sberdevices.ru> <17a276d3-1112-3431-2a33-c17f3da67470@sberdevices.ru> MIME-Version: 1.0 In-Reply-To: <17a276d3-1112-3431-2a33-c17f3da67470@sberdevices.ru> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Krasnov Arseniy , "kvm@vger.kernel.org" , "Michael S. Tsirkin" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , Eric Dumazet , Stefan Hajnoczi , kernel , Jakub Kicinski , Paolo Abeni , "David S. Miller" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Mon, Feb 06, 2023 at 06:53:22AM +0000, Arseniy Krasnov wrote: >If socket's error queue is not empty, EPOLLERR must be set. Could this patch go regardless of this series? Can you explain (even in the commit message) what happens without this patch? Thanks, Stefano > >Signed-off-by: Arseniy Krasnov >--- > net/vmw_vsock/af_vsock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >index 19aea7cba26e..b5e51ef4a74c 100644 >--- a/net/vmw_vsock/af_vsock.c >+++ b/net/vmw_vsock/af_vsock.c >@@ -1026,7 +1026,7 @@ static __poll_t vsock_poll(struct file *file, struct socket *sock, > poll_wait(file, sk_sleep(sk), wait); > mask = 0; > >- if (sk->sk_err) >+ if (sk->sk_err || !skb_queue_empty_lockless(&sk->sk_error_queue)) > /* Signify that there has been an error on this socket. */ > mask |= EPOLLERR; > >-- >2.25.1 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FC31C64EC4 for ; Thu, 16 Feb 2023 13:41:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230162AbjBPNld (ORCPT ); Thu, 16 Feb 2023 08:41:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229653AbjBPNlb (ORCPT ); Thu, 16 Feb 2023 08:41:31 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BABDE474D5 for ; Thu, 16 Feb 2023 05:40:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676554845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y98TLzC7T3MjlRAfco0hk5x9PJvmulya2RupI5c7FMk=; b=IBJcg2OT2zY/8BdsyqyR5rGYAMbv1H7TalSG0ax3sIGv+mHtubMiXm9Tlpb0lj07k8/kEO rp+wkyoWPSf9MWbEZHh3gYt7+pL1yGodAACs5Mdlp7NvBso8zG4r9XfpmGOw0fVlqohzwu 3aUX0wwG/bEfh6YifuA1/4nv7pQr13E= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-652-Uwn3kE2aO9mzLekQcZgC6g-1; Thu, 16 Feb 2023 08:40:44 -0500 X-MC-Unique: Uwn3kE2aO9mzLekQcZgC6g-1 Received: by mail-qv1-f70.google.com with SMTP id i7-20020a056214020700b004ffce246a2bso1087512qvt.3 for ; Thu, 16 Feb 2023 05:40:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y98TLzC7T3MjlRAfco0hk5x9PJvmulya2RupI5c7FMk=; b=7wYScND/Ns+EXONDffUQcnHiaK9d0segDBdIy1uirjbmlve/YzAXGMLMDJZYBFJbFK TgYvZQGM8JaL9bBi9IWXY1ZTKrXH7MsjpwOZ5MRwFB66uJzUcby09gbDH2NrduQEPyfI qLdfgvuuQUNiE/Aud/fhWZ+ysOzIo1kp3kQ0hof+0vAqqHbgnw4RkW5aFuzGKB9G88Us 10xk4V+8FoDeEcftq4DY0kYWBMrjIXdZahcI++E6HAPItKiC7jMMFQ1KCaNFpru2+b4Y EDrEDF6QCrCwSpu2quKS2a2Ka47hHAhiP8YyD0skbyjRsoO1sZg9gzP2wFJXWgssY0fY CSIQ== X-Gm-Message-State: AO0yUKUWIxBizhVZTL9awMDW9GfffWQs7yt+iGKb+PamLZ8cChGEFx3e EIYQg60ripvh0heHoiP4vO/yJmTAf1AxnKv5qHk72oqY3sufrg1gZC0aKlhMNabAxW05GmbPK7O 33ACxHewUxMzifEmk754yyTQi X-Received: by 2002:ac8:5c8a:0:b0:3b6:36a0:adbe with SMTP id r10-20020ac85c8a000000b003b636a0adbemr9858801qta.6.1676554844468; Thu, 16 Feb 2023 05:40:44 -0800 (PST) X-Google-Smtp-Source: AK7set+u2XfrViYGYBUOAnQ+C6klosItAnWhnmgPEyZDck8HDSLvs4kyoFZDdTEvpoeeeF5P7hlYrA== X-Received: by 2002:ac8:5c8a:0:b0:3b6:36a0:adbe with SMTP id r10-20020ac85c8a000000b003b636a0adbemr9858769qta.6.1676554844177; Thu, 16 Feb 2023 05:40:44 -0800 (PST) Received: from sgarzare-redhat (host-82-57-51-167.retail.telecomitalia.it. [82.57.51.167]) by smtp.gmail.com with ESMTPSA id z143-20020a376595000000b0073ba211e765sm228285qkb.19.2023.02.16.05.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 05:40:43 -0800 (PST) Date: Thu, 16 Feb 2023 14:40:39 +0100 From: Stefano Garzarella To: Arseniy Krasnov Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krasnov Arseniy , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , kernel Subject: Re: [RFC PATCH v1 01/12] vsock: check error queue to set EPOLLERR Message-ID: <20230216134039.rgnb2hnzgme2ve76@sgarzare-redhat> References: <0e7c6fc4-b4a6-a27b-36e9-359597bba2b5@sberdevices.ru> <17a276d3-1112-3431-2a33-c17f3da67470@sberdevices.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <17a276d3-1112-3431-2a33-c17f3da67470@sberdevices.ru> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 06, 2023 at 06:53:22AM +0000, Arseniy Krasnov wrote: >If socket's error queue is not empty, EPOLLERR must be set. Could this patch go regardless of this series? Can you explain (even in the commit message) what happens without this patch? Thanks, Stefano > >Signed-off-by: Arseniy Krasnov >--- > net/vmw_vsock/af_vsock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >index 19aea7cba26e..b5e51ef4a74c 100644 >--- a/net/vmw_vsock/af_vsock.c >+++ b/net/vmw_vsock/af_vsock.c >@@ -1026,7 +1026,7 @@ static __poll_t vsock_poll(struct file *file, struct socket *sock, > poll_wait(file, sk_sleep(sk), wait); > mask = 0; > >- if (sk->sk_err) >+ if (sk->sk_err || !skb_queue_empty_lockless(&sk->sk_error_queue)) > /* Signify that there has been an error on this socket. */ > mask |= EPOLLERR; > >-- >2.25.1