From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAB462F2C; Sat, 18 Feb 2023 17:47:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676742435; x=1708278435; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=E4i3WwE5KFasymlEzpdn8N4XaiMJFBRjK8jO3sv+WRg=; b=BLyUn7u01PX1D1oarJeoS7pf8J9hBTVR6r2i80TZ0rtTmuMm70rtdQWU c1oWI+SX3bp/0XQA9cCUME+J9FEDhGWgs/BAUVEb7Aobdijuwy40UMga+ R+hi4IdDm2E7HCWgzXMZP55FjTXAZRdA2HKgp/ScVUuK/3Soa95JjawPF N7vLXeeu44z4CFC1P3Ubj8txNrQz8p5SpBs5IJRyGGhkhwO6YAeGCBMcW UQhweqLNzCBBpaBvzAaVKGSfv/tkQ+IaL/xdOOYPnjU2PSdEiVlF1KR8c gl9mIYr9DJl6//Al5AEoC0SMuT2KjDaCLbTDJQqwyRW8+ij85fVdLeOhH Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10625"; a="332194329" X-IronPort-AV: E=Sophos;i="5.97,309,1669104000"; d="scan'208";a="332194329" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2023 09:47:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10625"; a="739630061" X-IronPort-AV: E=Sophos;i="5.97,309,1669104000"; d="scan'208";a="739630061" Received: from lkp-server01.sh.intel.com (HELO 4455601a8d94) ([10.239.97.150]) by fmsmga004.fm.intel.com with ESMTP; 18 Feb 2023 09:47:09 -0800 Received: from kbuild by 4455601a8d94 with local (Exim 4.96) (envelope-from ) id 1pTRIi-000Cbp-1e; Sat, 18 Feb 2023 17:47:08 +0000 Date: Sun, 19 Feb 2023 01:46:48 +0800 From: kernel test robot To: James Houghton , Mike Kravetz , Muchun Song , Peter Xu , Andrew Morton Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , David Hildenbrand , David Rientjes , Axel Rasmussen , Mina Almasry , Zach O'Keefe , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Frank van der Linden , Jiaqi Yan , linux-kernel@vger.kernel.org, James Houghton Subject: Re: [PATCH v2 12/46] hugetlb: add hugetlb_alloc_pmd and hugetlb_alloc_pte Message-ID: <202302190142.59JVVPVm-lkp@intel.com> References: <20230218002819.1486479-13-jthoughton@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230218002819.1486479-13-jthoughton@google.com> Hi James, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20230217] [cannot apply to kvm/queue shuah-kselftest/next shuah-kselftest/fixes arnd-asm-generic/master linus/master kvm/linux-next v6.2-rc8 v6.2-rc7 v6.2-rc6 v6.2-rc8] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/James-Houghton/hugetlb-don-t-set-PageUptodate-for-UFFDIO_CONTINUE/20230218-083216 patch link: https://lore.kernel.org/r/20230218002819.1486479-13-jthoughton%40google.com patch subject: [PATCH v2 12/46] hugetlb: add hugetlb_alloc_pmd and hugetlb_alloc_pte config: powerpc-randconfig-r001-20230217 (https://download.01.org/0day-ci/archive/20230219/202302190142.59JVVPVm-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project db89896bbbd2251fff457699635acbbedeead27f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc cross compiling tool for clang build # apt-get install binutils-powerpc-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/af805b45df0b60a0ef2231f41413b8265e1e8d93 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review James-Houghton/hugetlb-don-t-set-PageUptodate-for-UFFDIO_CONTINUE/20230218-083216 git checkout af805b45df0b60a0ef2231f41413b8265e1e8d93 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202302190142.59JVVPVm-lkp@intel.com/ All errors (new ones prefixed by >>): __do_insb ^ arch/powerpc/include/asm/io.h:577:56: note: expanded from macro '__do_insb' #define __do_insb(p, b, n) readsb((PCI_IO_ADDR)_IO_BASE+(p), (b), (n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from mm/hugetlb.c:11: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:640: arch/powerpc/include/asm/io-defs.h:45:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(insw, (unsigned long p, void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:637:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ :102:1: note: expanded from here __do_insw ^ arch/powerpc/include/asm/io.h:578:56: note: expanded from macro '__do_insw' #define __do_insw(p, b, n) readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from mm/hugetlb.c:11: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:640: arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:637:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ :104:1: note: expanded from here __do_insl ^ arch/powerpc/include/asm/io.h:579:56: note: expanded from macro '__do_insl' #define __do_insl(p, b, n) readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from mm/hugetlb.c:11: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:640: arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:637:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ :106:1: note: expanded from here __do_outsb ^ arch/powerpc/include/asm/io.h:580:58: note: expanded from macro '__do_outsb' #define __do_outsb(p, b, n) writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from mm/hugetlb.c:11: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:640: arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:637:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ :108:1: note: expanded from here __do_outsw ^ arch/powerpc/include/asm/io.h:581:58: note: expanded from macro '__do_outsw' #define __do_outsw(p, b, n) writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from mm/hugetlb.c:11: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:640: arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:637:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ :110:1: note: expanded from here __do_outsl ^ arch/powerpc/include/asm/io.h:582:58: note: expanded from macro '__do_outsl' #define __do_outsl(p, b, n) writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n)) ~~~~~~~~~~~~~~~~~~~~~^ >> mm/hugetlb.c:581:8: error: call to undeclared function '__pte_alloc_one'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] new = __pte_alloc_one(mm, GFP_PGTABLE_USER); ^ mm/hugetlb.c:581:8: note: did you mean 'pte_alloc_one'? arch/powerpc/include/asm/pgalloc.h:30:25: note: 'pte_alloc_one' declared here static inline pgtable_t pte_alloc_one(struct mm_struct *mm) ^ >> mm/hugetlb.c:581:28: error: use of undeclared identifier 'GFP_PGTABLE_USER' new = __pte_alloc_one(mm, GFP_PGTABLE_USER); ^ >> mm/hugetlb.c:588:25: error: incompatible pointer types passing 'pgtable_t' (aka 'unsigned long *') to parameter of type 'struct page *' [-Werror,-Wincompatible-pointer-types] pgtable_pte_page_dtor(new); ^~~ include/linux/mm.h:2661:55: note: passing argument to parameter 'page' here static inline void pgtable_pte_page_dtor(struct page *page) ^ mm/hugetlb.c:589:3: error: incompatible pointer types passing 'pgtable_t' (aka 'unsigned long *') to parameter of type 'struct page *' [-Werror,-Wincompatible-pointer-types] __free_page(new); ^~~~~~~~~~~~~~~~ include/linux/gfp.h:319:40: note: expanded from macro '__free_page' #define __free_page(page) __free_pages((page), 0) ^~~~~~ include/linux/gfp.h:302:39: note: passing argument to parameter 'page' here extern void __free_pages(struct page *page, unsigned int order); ^ 6 warnings and 4 errors generated. vim +/__pte_alloc_one +581 mm/hugetlb.c 543 544 /* 545 * hugetlb_alloc_pte -- Allocate a PTE beneath a pmd_none PMD-level hpte. 546 * 547 * See the comment above hugetlb_alloc_pmd. 548 */ 549 pte_t *hugetlb_alloc_pte(struct mm_struct *mm, struct hugetlb_pte *hpte, 550 unsigned long addr) 551 { 552 spinlock_t *ptl = hugetlb_pte_lockptr(hpte); 553 pgtable_t new; 554 pmd_t *pmdp; 555 pmd_t pmd; 556 557 if (hpte->level != HUGETLB_LEVEL_PMD) 558 return ERR_PTR(-EINVAL); 559 560 pmdp = (pmd_t *)hpte->ptep; 561 retry: 562 pmd = READ_ONCE(*pmdp); 563 if (likely(pmd_present(pmd))) 564 return unlikely(pmd_leaf(pmd)) 565 ? ERR_PTR(-EEXIST) 566 : pte_offset_kernel(pmdp, addr); 567 else if (!pmd_none(pmd)) 568 /* 569 * Not present and not none means that a swap entry lives here, 570 * and we can't get rid of it. 571 */ 572 return ERR_PTR(-EEXIST); 573 574 /* 575 * With CONFIG_HIGHPTE, calling `pte_alloc_one` directly may result 576 * in page tables being allocated in high memory, needing a kmap to 577 * access. Instead, we call __pte_alloc_one directly with 578 * GFP_PGTABLE_USER to prevent these PTEs being allocated in high 579 * memory. 580 */ > 581 new = __pte_alloc_one(mm, GFP_PGTABLE_USER); 582 if (!new) 583 return ERR_PTR(-ENOMEM); 584 585 spin_lock(ptl); 586 if (!pmd_same(pmd, *pmdp)) { 587 spin_unlock(ptl); > 588 pgtable_pte_page_dtor(new); 589 __free_page(new); 590 goto retry; 591 } 592 593 mm_inc_nr_ptes(mm); 594 smp_wmb(); /* See comment in pmd_install() */ 595 pmd_populate(mm, pmdp, new); 596 spin_unlock(ptl); 597 return pte_offset_kernel(pmdp, addr); 598 } 599 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests