From: Kemeng Shi <shikemeng@huaweicloud.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
shikemeng@huaweicloud.com
Subject: [PATCH 5/7] ext4: remove stale comment in ext4_init_block_bitmap
Date: Tue, 21 Feb 2023 19:59:17 +0800 [thread overview]
Message-ID: <20230221115919.1918161-6-shikemeng@huaweicloud.com> (raw)
In-Reply-To: <20230221115919.1918161-1-shikemeng@huaweicloud.com>
Commit bdfb6ff4a255d ("ext4: mark group corrupt on group descriptor
checksum") added flag to indicate corruption of group instead of
marking all blocks used. Just remove stale comment.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
fs/ext4/balloc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
index 08f1692f7d2f..4de06d68e9e7 100644
--- a/fs/ext4/balloc.c
+++ b/fs/ext4/balloc.c
@@ -187,8 +187,6 @@ static int ext4_init_block_bitmap(struct super_block *sb,
ASSERT(buffer_locked(bh));
- /* If checksum is bad mark all blocks used to prevent allocation
- * essentially implementing a per-group read-only flag. */
if (!ext4_group_desc_csum_verify(sb, block_group, gdp)) {
ext4_mark_group_bitmap_corrupted(sb, block_group,
EXT4_GROUP_INFO_BBITMAP_CORRUPT |
--
2.30.0
next prev parent reply other threads:[~2023-02-21 3:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 11:59 [PATCH 0/7] A few patches to improve ext4 balloc Kemeng Shi
2023-02-21 11:59 ` [PATCH 1/7] ext4: properly handle error of ext4_init_block_bitmap in ext4_read_block_bitmap_nowait Kemeng Shi
2023-02-21 11:59 ` [PATCH 2/7] ext4: correct validation check of inode table in ext4_valid_block_bitmap Kemeng Shi
2023-02-21 11:59 ` [PATCH 3/7] ext4: call ext4_bg_num_gdb_[no]meta directly in ext4_num_base_meta_clusters Kemeng Shi
2023-02-21 11:59 ` [PATCH 4/7] ext4: remove unnecessary check in ext4_bg_num_gdb_nometa Kemeng Shi
[not found] ` <20230613131507.0ce55666@mir>
2023-06-13 12:04 ` Linux regression tracking (Thorsten Leemhuis)
2023-06-13 14:46 ` Kemeng Shi
2023-02-21 11:59 ` Kemeng Shi [this message]
2023-02-21 11:59 ` [PATCH 6/7] ext4: stop trying to verify just initialized bitmap in ext4_read_block_bitmap_nowait Kemeng Shi
2023-02-21 11:59 ` [PATCH 7/7] ext4: improve inode table blocks counting in ext4_num_overhead_clusters Kemeng Shi
2023-03-20 12:44 ` Jan Kara
2023-03-20 13:19 ` Kemeng Shi
2023-03-17 1:52 ` [PATCH 0/7] A few patches to improve ext4 balloc Theodore Ts'o
2023-02-22 15:05 [PATCH 7/7] ext4: improve inode table blocks counting in ext4_num_overhead_clusters kernel test robot
2023-02-22 15:13 ` Dan Carpenter
2023-02-23 1:31 ` Kemeng Shi
2023-02-23 4:04 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221115919.1918161-6-shikemeng@huaweicloud.com \
--to=shikemeng@huaweicloud.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.