From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BD69C636D6 for ; Wed, 22 Feb 2023 17:21:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DE66E859F8; Wed, 22 Feb 2023 18:21:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Mpfpc1/5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 46F6380BA3; Wed, 22 Feb 2023 18:21:51 +0100 (CET) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E1E25859F8 for ; Wed, 22 Feb 2023 18:21:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ralph.siemsen@linaro.org Received: by mail-qt1-x835.google.com with SMTP id l12so8191811qtr.0 for ; Wed, 22 Feb 2023 09:21:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/psaYMyOKzNiIqWCUkPuhCa5BVJ7rdYeDAGZN5ediBU=; b=Mpfpc1/5gJVE6yJYJbAIJ9mDwPKbETxsaDt8qnp5Pgjt1iYCs/xehV0dD49KKzTv9E zVVD48YWhJApFkWbaOq+pvEtMzDR2ypb6IZoVibp7YXU7o3kzda5L4FnCZ2sIvXg0LgP uH+iDhimIEN5jSIy8L/Ye1/roZSR7Mp5da/R9jlWBWTM/VRCxWb4AAbzu77IRL3SamLk w9EOZqP3k7afBnQIBaTP8t2JR6NZ+sJBrS4E/QohbcVg0Xhq4+x3Ro+nbHBF96sgtsUz OWHIZGLnLWQM72BYSBz/eJVWe2qLxGkOC34U9axXM1SYVTOtX7PG8O7fN1L3/NR01FAg wVwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/psaYMyOKzNiIqWCUkPuhCa5BVJ7rdYeDAGZN5ediBU=; b=uOlQtt0QPZjskp90a4jxFuo5Czx/sL7DmEyNf1TR4sYCZeeyprO36ZxbjhJpfranfC eWKAuz8UijP3kNl9ph4LpwUu3SUGzE8PsHElXshW2T4KuMo/fpYEHjNgyj31S0lpkwjr nyTcpipjJcOxMOVoiXl3XMXxUJfhZrzJ+nAu/NRzYXnswhwul4TigG76tySHGHUJ0anO 5sLEdTYkFDO7hTkyODlVyrJ0JrzIYqEgVOy9nXNL499E8A/YeHBPlF8IDmeFVtjnzL75 FCEXDqdSchmOf65nDzXPwc/xTueUvgzvXMd/q0qBmcBRtcR/+X2nkUpw3ub+sQdQtLod EX5w== X-Gm-Message-State: AO0yUKU3dRsMVWDE7zMAEYeYKq2M0EnojVxFyQ+t+36pCDp5fIaAKMl2 bwxKZ4xBdX6W2+PPnA7k3P8mhw== X-Google-Smtp-Source: AK7set+2eQCqh4dO25u94g8RbZCPJiNIR7N/+DJzimsiiVMlvUAuJ5GzjUJQo4kgzhCb10IxfB9bjg== X-Received: by 2002:a05:622a:1a21:b0:3bf:a760:cb5 with SMTP id f33-20020a05622a1a2100b003bfa7600cb5mr7878896qtb.4.1677086506350; Wed, 22 Feb 2023 09:21:46 -0800 (PST) Received: from localhost (rfs.netwinder.org. [206.248.184.2]) by smtp.gmail.com with ESMTPSA id o6-20020ac86986000000b003b9b8ec742csm2273264qtq.14.2023.02.22.09.21.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 09:21:45 -0800 (PST) Date: Wed, 22 Feb 2023 12:21:45 -0500 From: Ralph Siemsen To: Marek Vasut Cc: u-boot@lists.denx.de, Hai Pham , Lukasz Majewski , Marek Vasut , Sean Anderson Subject: Re: [RFC PATCH v3 3/9] clk: renesas: add R906G032 driver Message-ID: <20230222172145.GB50215@maple.netwinder.org> References: <20230222154414.49219-1-ralph.siemsen@linaro.org> <20230222154414.49219-4-ralph.siemsen@linaro.org> <49f64e41-adfe-b426-2a57-9c4721894885@mailbox.org> <20230222165749.GA50215@maple.netwinder.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Wed, Feb 22, 2023 at 06:07:45PM +0100, Marek Vasut wrote: >On 2/22/23 17:57, Ralph Siemsen wrote: >>On Wed, Feb 22, 2023 at 05:06:14PM +0100, Marek Vasut wrote: >>>On 2/22/23 16:44, Ralph Siemsen wrote: >>>>Clock driver for the Renesas RZ/N1 SoC family. This is based >>>>on the Linux kernel drivers/clk/renesas/r9a06g032-clocks.c. >>> >>>For starters, can you please include the exact kernel version , >>>ideally commit ID, from which this way pulled, so that future >>>updates can pull in the diffs from that commit easily ? >> >>Very reasonable request, but a bit difficult to give a concise >>answer. Originally I took the driver as found in the 5.15 kernel. >>The driver actually had not changed since 5.13 commit 6bd913f54f2f >>("clk: renesas: r9a06g032: Switch to .determine_rate()"). So that's >>the starting point. >> >>I incorporated subsequent changes to the clock tables and related >>cleanups. Those were only merged into Linux much later: >> >>2dee50ab9e72 clk: renesas: r9a06g032: Fix UART clkgrp bitsel >>f46efcc4746f clk: renesas: r9a06g032: Drop some unused fields >>2a6da4a11f47 clk: renesas: r9a06g032: Fix the RTC hclock description >> >>Linux driver also had a few other commits, but these are not >>applicable to the u-boot version due to structural changes: >> >>6bd913f54f2f clk: renesas: r9a06g032: Switch to .determine_rate() >>f2fb4fe62390 clk: renesas: Zero init clk_init_data >>2182066d95c3 clk: renesas: r9a06g032: Probe possible children >>885525c1e7e2 clk: renesas: r9a06g032: Export function to set dmamux >>02693e11611e clk: renesas: r9a06g032: Repair grave increment error >> >>So I would say it is "up to date" with the lastest Linux commit, >>even though it is based on an earlier version. Is there a good way >>to include the above in the commit message, succinctly? > >Is this still in sync with Linux 6.1.y ? That's the latest LTS . Yes. Although the commits have different hashes than what I reported above, the 6.1.y LTS branch has the same changes. Note that the u-boot version of the driver has changed considerably from the Linux version. In terms of pulling future diffs over, I would be concerned mostly about keeping the clock tables in sync. There have been a few mistakes found and fixed in those already. Ralph