From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39D17C61DA4 for ; Wed, 22 Feb 2023 18:32:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ECFC485911; Wed, 22 Feb 2023 19:32:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="BhBXMxBy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7568985911; Wed, 22 Feb 2023 19:32:25 +0100 (CET) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C4CC5859E5 for ; Wed, 22 Feb 2023 19:32:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ralph.siemsen@linaro.org Received: by mail-qt1-x82d.google.com with SMTP id s12so8526230qtq.11 for ; Wed, 22 Feb 2023 10:32:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VyYpDFuFM2TNXzIwwu3al7k5WmowJnptKpEhgWvoKbY=; b=BhBXMxBynF9VByJGjLjJdTpdIn3ptPAaVE0vgO5djksAsP2Bh4j7zcg6kAmhdsczfd kdu1BjYJeYbhB0Dh5P6nJkJUOT3cFQ4TmFVx5VIiUSjmQpOuulTaUnQJZbL+3Y5E8HSD VAalKyc8m8gzhptgfTQbcL7ZabgdRlhfxtiu/eBqOyE3lWOi5v0Evn8E4bozoGuFkwHF m5ImJm91mXkL60bMg4cCw207JN7TTjQBtmVyV6mRaYwB3KFzuMlVSSYv3cfHB4OtWnO9 hzE30vq3EALsu6d5n1lMGRVpTlek5qt88N0pe+B0JEk9tjvaG0hmRIbEnPE/vOIygmOY t5rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VyYpDFuFM2TNXzIwwu3al7k5WmowJnptKpEhgWvoKbY=; b=ysZPTrgoIAAVON1zqXR/RY6dshAEfDG8MMA2ocFTScNZcNQBkICf9LbY0PRDLTt1SE dMzxmmr3F2sgeYlVwfJx+naPRenWRIKBFh+8tv5O8H+en4jc855vkKHooGfgzfu3VZ0M 2u18hY4GAXvLG7+JJrczwrxBdQdtPFc7FY+N+QDnKKGyiSARgzQDBHuE14KP2+wO/S2d lhgacbeA3nCUpdN8Y+cZmyavzCBs63nDZu/49Nnwh2vbVY0+ORELJAYLfD5pXCmQJI+Z gWgDZbujirUkvpDV1eEqxc2tJtCZKzAJXGWRPyXYEGy+IewbtTIEq/Rm2GRhjzuH5ZS9 pelA== X-Gm-Message-State: AO0yUKUIDBeO6El8cDp3EIxzrttUYBqPFd7QCqgcgj5D+RC1TfynJMF1 Yrtg3A9iITi6n//axRdphtSOYQ== X-Google-Smtp-Source: AK7set9BN64G5NPxokE6MYwzJPZNMs7YEU9GRVsyVlNqPPqFkcYaIiJ3gT/xSBTdJzXBNtVCP4pZ2g== X-Received: by 2002:a05:622a:1742:b0:3b1:80ab:38e with SMTP id l2-20020a05622a174200b003b180ab038emr1819530qtk.0.1677090741590; Wed, 22 Feb 2023 10:32:21 -0800 (PST) Received: from localhost (rfs.netwinder.org. [206.248.184.2]) by smtp.gmail.com with ESMTPSA id f24-20020ac840d8000000b003b7e8c04d2esm4759835qtm.64.2023.02.22.10.32.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 10:32:21 -0800 (PST) Date: Wed, 22 Feb 2023 13:32:20 -0500 From: Ralph Siemsen To: Marek Vasut Cc: u-boot@lists.denx.de, Hai Pham , Lukasz Majewski , Marek Vasut , Sean Anderson Subject: Re: [RFC PATCH v3 3/9] clk: renesas: add R906G032 driver Message-ID: <20230222183220.GC50215@maple.netwinder.org> References: <20230222154414.49219-1-ralph.siemsen@linaro.org> <20230222154414.49219-4-ralph.siemsen@linaro.org> <49f64e41-adfe-b426-2a57-9c4721894885@mailbox.org> <20230222165749.GA50215@maple.netwinder.org> <20230222172145.GB50215@maple.netwinder.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Wed, Feb 22, 2023 at 06:47:44PM +0100, Marek Vasut wrote: >On 2/22/23 18:21, Ralph Siemsen wrote: >>On Wed, Feb 22, 2023 at 06:07:45PM +0100, Marek Vasut wrote: >>>On 2/22/23 17:57, Ralph Siemsen wrote: >>>>On Wed, Feb 22, 2023 at 05:06:14PM +0100, Marek Vasut wrote: >>>>>On 2/22/23 16:44, Ralph Siemsen wrote: >>>>>>Clock driver for the Renesas RZ/N1 SoC family. This is based >>>>>>on the Linux kernel drivers/clk/renesas/r9a06g032-clocks.c. >>>>> >>>>>For starters, can you please include the exact kernel version >>>>>, ideally commit ID, from which this way pulled, so that >>>>>future updates can pull in the diffs from that commit easily ? >>>> >>>>Very reasonable request, but a bit difficult to give a concise >>>>answer. Originally I took the driver as found in the 5.15 >>>>kernel. The driver actually had not changed since 5.13 commit >>>>6bd913f54f2f ("clk: renesas: r9a06g032: Switch to >>>>.determine_rate()"). So that's the starting point. >>>> >>>>I incorporated subsequent changes to the clock tables and >>>>related cleanups. Those were only merged into Linux much later: >>>> >>>>2dee50ab9e72 clk: renesas: r9a06g032: Fix UART clkgrp bitsel >>>>f46efcc4746f clk: renesas: r9a06g032: Drop some unused fields >>>>2a6da4a11f47 clk: renesas: r9a06g032: Fix the RTC hclock description >>>> >>>>Linux driver also had a few other commits, but these are not >>>>applicable to the u-boot version due to structural changes: >>>> >>>>6bd913f54f2f clk: renesas: r9a06g032: Switch to .determine_rate() >>>>f2fb4fe62390 clk: renesas: Zero init clk_init_data >>>>2182066d95c3 clk: renesas: r9a06g032: Probe possible children >>>>885525c1e7e2 clk: renesas: r9a06g032: Export function to set dmamux >>>>02693e11611e clk: renesas: r9a06g032: Repair grave increment error >>>> >>>>So I would say it is "up to date" with the lastest Linux commit, >>>>even though it is based on an earlier version. Is there a good >>>>way to include the above in the commit message, succinctly? >>> >>>Is this still in sync with Linux 6.1.y ? That's the latest LTS . >> >>Yes. Although the commits have different hashes than what I reported >>above, the 6.1.y LTS branch has the same changes. > >Then please include the Linux 6.1.y commit ID , or Torvalds' tree if >that contains new fixes . Let's not use some old/downstream stuff . I've amended the commit message as follows: Clock driver for the Renesas RZ/N1 SoC family. This is based on the Linux kernel drivers/clk/renesas/r9a06g032-clocks.c as found in commit 02693e11611e ("clk: renesas: r9a06g032: Repair grave increment error") included in Torvalds kernel v6.2. Identical code is in LTS 6.1.y. >>Note that the u-boot version of the driver has changed considerably >>from the Linux version. In terms of pulling future diffs over, I >>would be concerned mostly about keeping the clock tables in sync. >>There have been a few mistakes found and fixed in those already. > >Are those fixes in mainline Linux ? Yes, they are in mainline: 2dee50ab9e72 clk: renesas: r9a06g032: Fix UART clkgrp bitsel merged into 6.0, and also backported to earlier LTS branches 2a6da4a11f47 clk: renesas: r9a06g032: Fix the RTC hclock description merged into 5.19, seems to be missing from LTS branches Regards, Ralph