* [PATCH 0/8] drivers: select REGMAP instead of depending on it
@ 2023-02-26 5:39 Randy Dunlap
2023-02-26 5:39 ` [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO " Randy Dunlap
` (8 more replies)
0 siblings, 9 replies; 22+ messages in thread
From: Randy Dunlap @ 2023-02-26 5:39 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Andrew Jeffery, Corey Minyard, openipmi-developer,
Arnd Bergmann, Greg Kroah-Hartman, Riku Voipio, Stephen Boyd,
Michael Turquette, linux-clk, Michael Walle, Linus Walleij,
Bartosz Golaszewski, linux-gpio, Dan Murphy, Pavel Machek,
Jacek Anaszewski, Lee Jones, linux-leds, Darren Hart,
Hans de Goede, Michael Shych, Mark Gross, Vadim Pasternak,
platform-driver-x86, Yegnesh S Iyer, Bin Gao, Zhang Rui,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, linux-pm,
Oskar Senft, linux-serial
REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.
Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.
REGMAP is selected 94 times and is depended on 11 times in
current linux-next. Eliminate the uses of "depends on" by
converting them to "select".
[PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it
[PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it
[PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it
[PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it
[PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it
[PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it
[PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it
[PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it
diffstat:
drivers/char/ipmi/Kconfig | 3 ++-
drivers/clk/Kconfig | 2 +-
drivers/gpio/Kconfig | 2 +-
drivers/leds/Kconfig | 2 +-
drivers/platform/mellanox/Kconfig | 9 ++++-----
drivers/platform/x86/Kconfig | 3 ++-
drivers/thermal/intel/Kconfig | 3 ++-
drivers/tty/serial/8250/Kconfig | 3 ++-
8 files changed, 15 insertions(+), 12 deletions(-)
Cc: Andrew Jeffery <andrew@aj.id.au>
Cc: Corey Minyard <minyard@acm.org>
Cc: openipmi-developer@lists.sourceforge.net
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Riku Voipio <riku.voipio@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk@vger.kernel.org
Cc: Michael Walle <michael@walle.cc>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-gpio@vger.kernel.org
Cc: Dan Murphy <dmurphy@ti.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Lee Jones <lee@kernel.org>
Cc: linux-leds@vger.kernel.org
Cc: Darren Hart <dvhart@infradead.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Michael Shych <michaelsh@nvidia.com>
Cc: Mark Gross <markgross@kernel.org>
Cc: Vadim Pasternak <vadimp@nvidia.com>
Cc: platform-driver-x86@vger.kernel.org
Cc: Yegnesh S Iyer <yegnesh.s.iyer@intel.com>
Cc: Bin Gao <bin.gao@intel.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Amit Kucheria <amitk@kernel.org>
Cc: linux-pm@vger.kernel.org
Cc: Oskar Senft <osk@google.com>
Cc: linux-serial@vger.kernel.org
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it
2023-02-26 5:39 [PATCH 0/8] drivers: select REGMAP instead of depending on it Randy Dunlap
@ 2023-02-26 5:39 ` Randy Dunlap
2023-02-26 22:59 ` Corey Minyard
2023-02-26 5:39 ` [PATCH 2/8] clk: HI655X: select REGMAP " Randy Dunlap
` (7 subsequent siblings)
8 siblings, 1 reply; 22+ messages in thread
From: Randy Dunlap @ 2023-02-26 5:39 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Andrew Jeffery, Corey Minyard, openipmi-developer,
Arnd Bergmann, Greg Kroah-Hartman
REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.
Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.
Therefore, change the use of "depends on REGMAP_MMIO" to
"select REGMAP_MMIO", which will also set REGMAP.
Fixes: eb994594bc22 ("ipmi: bt-bmc: Use a regmap for register access")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Jeffery <andrew@aj.id.au>
Cc: Corey Minyard <minyard@acm.org>
Cc: openipmi-developer@lists.sourceforge.net
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/char/ipmi/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -- a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
--- a/drivers/char/ipmi/Kconfig
+++ b/drivers/char/ipmi/Kconfig
@@ -162,7 +162,8 @@ config IPMI_KCS_BMC_SERIO
config ASPEED_BT_IPMI_BMC
depends on ARCH_ASPEED || COMPILE_TEST
- depends on REGMAP && REGMAP_MMIO && MFD_SYSCON
+ depends on MFD_SYSCON
+ select REGMAP_MMIO
tristate "BT IPMI bmc driver"
help
Provides a driver for the BT (Block Transfer) IPMI interface
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it
2023-02-26 5:39 [PATCH 0/8] drivers: select REGMAP instead of depending on it Randy Dunlap
2023-02-26 5:39 ` [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO " Randy Dunlap
@ 2023-02-26 5:39 ` Randy Dunlap
2023-03-06 19:30 ` Stephen Boyd
2023-02-26 5:39 ` [PATCH 3/8] gpio: GPIO_REGMAP: " Randy Dunlap
` (6 subsequent siblings)
8 siblings, 1 reply; 22+ messages in thread
From: Randy Dunlap @ 2023-02-26 5:39 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Riku Voipio, Stephen Boyd, Michael Turquette, linux-clk
REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.
Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.
Therefore, change the use of "depends on REGMAP" to "select REGMAP".
Fixes: 3a49afb84ca0 ("clk: enable hi655x common clk automatically")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Riku Voipio <riku.voipio@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk@vger.kernel.org
---
drivers/clk/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -- a/drivers/clk/Kconfig b/drivers/clk/Kconfig
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -91,7 +91,7 @@ config COMMON_CLK_RK808
config COMMON_CLK_HI655X
tristate "Clock driver for Hi655x" if EXPERT
depends on (MFD_HI655X_PMIC || COMPILE_TEST)
- depends on REGMAP
+ select REGMAP
default MFD_HI655X_PMIC
help
This driver supports the hi655x PMIC clock. This
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it
2023-02-26 5:39 [PATCH 0/8] drivers: select REGMAP instead of depending on it Randy Dunlap
2023-02-26 5:39 ` [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO " Randy Dunlap
2023-02-26 5:39 ` [PATCH 2/8] clk: HI655X: select REGMAP " Randy Dunlap
@ 2023-02-26 5:39 ` Randy Dunlap
2023-02-26 18:06 ` Michael Walle
2023-03-06 10:17 ` Bartosz Golaszewski
2023-02-26 5:39 ` [PATCH 4/8] leds: TI_LMU_COMMON: " Randy Dunlap
` (5 subsequent siblings)
8 siblings, 2 replies; 22+ messages in thread
From: Randy Dunlap @ 2023-02-26 5:39 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Michael Walle, Linus Walleij, Bartosz Golaszewski,
linux-gpio
REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.
Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.
Therefore, change the use of "depends on REGMAP" to "select REGMAP".
Fixes: ebe363197e52 ("gpio: add a reusable generic gpio_chip using regmap")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Michael Walle <michael@walle.cc>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-gpio@vger.kernel.org
---
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -- a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -100,7 +100,7 @@ config GPIO_GENERIC
tristate
config GPIO_REGMAP
- depends on REGMAP
+ select REGMAP
tristate
# put drivers in the right section, in alphabetical order
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it
2023-02-26 5:39 [PATCH 0/8] drivers: select REGMAP instead of depending on it Randy Dunlap
` (2 preceding siblings ...)
2023-02-26 5:39 ` [PATCH 3/8] gpio: GPIO_REGMAP: " Randy Dunlap
@ 2023-02-26 5:39 ` Randy Dunlap
2023-02-27 11:37 ` Pavel Machek
2023-03-01 14:21 ` Lee Jones
2023-02-26 5:39 ` [PATCH 5/8] platform: mellanox: " Randy Dunlap
` (4 subsequent siblings)
8 siblings, 2 replies; 22+ messages in thread
From: Randy Dunlap @ 2023-02-26 5:39 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Dan Murphy, Pavel Machek, Jacek Anaszewski,
Lee Jones, linux-leds
REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.
Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.
Therefore, change the use of "depends on REGMAP" to "select REGMAP".
Fixes: 3fce8e1eb994 ("leds: TI LMU: Add common code for TI LMU devices")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Dan Murphy <dmurphy@ti.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Lee Jones <lee@kernel.org>
Cc: linux-leds@vger.kernel.org
---
drivers/leds/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -- a/drivers/leds/Kconfig b/drivers/leds/Kconfig
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -795,7 +795,7 @@ config LEDS_SPI_BYTE
config LEDS_TI_LMU_COMMON
tristate "LED driver for TI LMU"
depends on LEDS_CLASS
- depends on REGMAP
+ select REGMAP
help
Say Y to enable the LED driver for TI LMU devices.
This supports common features between the TI LM3532, LM3631, LM3632,
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it
2023-02-26 5:39 [PATCH 0/8] drivers: select REGMAP instead of depending on it Randy Dunlap
` (3 preceding siblings ...)
2023-02-26 5:39 ` [PATCH 4/8] leds: TI_LMU_COMMON: " Randy Dunlap
@ 2023-02-26 5:39 ` Randy Dunlap
2023-02-26 6:37 ` Vadim Pasternak
2023-02-26 5:39 ` [PATCH 6/8] platform: x86: MLX_PLATFORM: " Randy Dunlap
` (3 subsequent siblings)
8 siblings, 1 reply; 22+ messages in thread
From: Randy Dunlap @ 2023-02-26 5:39 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Darren Hart, Hans de Goede, Michael Shych,
Mark Gross, Vadim Pasternak, platform-driver-x86
REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.
Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.
Therefore, change the use of "depends on REGMAP" to "select REGMAP".
For NVSW_SN2201, select REGMAP_I2C instead of depending on it.
Fixes: c6acad68eb2d ("platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface")
Fixes: 5ec4a8ace06c ("platform/mellanox: Introduce support for Mellanox register access driver")
Fixes: 62f9529b8d5c ("platform/mellanox: mlxreg-lc: Add initial support for Nvidia line card devices")
Fixes: 662f24826f95 ("platform/mellanox: Add support for new SN2201 system")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Michael Shych <michaelsh@nvidia.com>
Cc: Mark Gross <markgross@kernel.org>
Cc: Vadim Pasternak <vadimp@nvidia.com>
Cc: platform-driver-x86@vger.kernel.org
---
drivers/platform/mellanox/Kconfig | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff -- a/drivers/platform/mellanox/Kconfig b/drivers/platform/mellanox/Kconfig
--- a/drivers/platform/mellanox/Kconfig
+++ b/drivers/platform/mellanox/Kconfig
@@ -16,17 +16,17 @@ if MELLANOX_PLATFORM
config MLXREG_HOTPLUG
tristate "Mellanox platform hotplug driver support"
- depends on REGMAP
depends on HWMON
depends on I2C
+ select REGMAP
help
This driver handles hot-plug events for the power suppliers, power
cables and fans on the wide range Mellanox IB and Ethernet systems.
config MLXREG_IO
tristate "Mellanox platform register access driver support"
- depends on REGMAP
depends on HWMON
+ select REGMAP
help
This driver allows access to Mellanox programmable device register
space through sysfs interface. The sets of registers for sysfs access
@@ -36,9 +36,9 @@ config MLXREG_IO
config MLXREG_LC
tristate "Mellanox line card platform driver support"
- depends on REGMAP
depends on HWMON
depends on I2C
+ select REGMAP
help
This driver provides support for the Mellanox MSN4800-XX line cards,
which are the part of MSN4800 Ethernet modular switch systems
@@ -80,10 +80,9 @@ config MLXBF_PMC
config NVSW_SN2201
tristate "Nvidia SN2201 platform driver support"
- depends on REGMAP
depends on HWMON
depends on I2C
- depends on REGMAP_I2C
+ select REGMAP_I2C
help
This driver provides support for the Nvidia SN2201 platform.
The SN2201 is a highly integrated for one rack unit system with
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it
2023-02-26 5:39 [PATCH 0/8] drivers: select REGMAP instead of depending on it Randy Dunlap
` (4 preceding siblings ...)
2023-02-26 5:39 ` [PATCH 5/8] platform: mellanox: " Randy Dunlap
@ 2023-02-26 5:39 ` Randy Dunlap
2023-02-26 6:37 ` Vadim Pasternak
2023-02-26 5:39 ` [PATCH 7/8] thermal: intel: BXT_PMIC: " Randy Dunlap
` (2 subsequent siblings)
8 siblings, 1 reply; 22+ messages in thread
From: Randy Dunlap @ 2023-02-26 5:39 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Vadim Pasternak, Darren Hart, Hans de Goede,
Mark Gross, platform-driver-x86
REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.
Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.
Therefore, change the use of "depends on REGMAP" to "select REGMAP".
Fixes: ef0f62264b2a ("platform/x86: mlx-platform: Add physical bus number auto detection")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Vadim Pasternak <vadimp@mellanox.com>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Gross <markgross@kernel.org>
Cc: platform-driver-x86@vger.kernel.org
---
drivers/platform/x86/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -- a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -955,7 +955,8 @@ config SERIAL_MULTI_INSTANTIATE
config MLX_PLATFORM
tristate "Mellanox Technologies platform support"
- depends on I2C && REGMAP
+ depends on I2C
+ select REGMAP
help
This option enables system support for the Mellanox Technologies
platform. The Mellanox systems provide data center networking
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it
2023-02-26 5:39 [PATCH 0/8] drivers: select REGMAP instead of depending on it Randy Dunlap
` (5 preceding siblings ...)
2023-02-26 5:39 ` [PATCH 6/8] platform: x86: MLX_PLATFORM: " Randy Dunlap
@ 2023-02-26 5:39 ` Randy Dunlap
2023-03-01 18:34 ` Rafael J. Wysocki
2023-02-26 5:39 ` [PATCH 8/8] serial: 8250: ASPEED_VUART: " Randy Dunlap
2023-02-27 9:31 ` [PATCH 0/8] drivers: " Hans de Goede
8 siblings, 1 reply; 22+ messages in thread
From: Randy Dunlap @ 2023-02-26 5:39 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Yegnesh S Iyer, Bin Gao, Zhang Rui,
Rafael J . Wysocki, Daniel Lezcano, Amit Kucheria, linux-pm
REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.
Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.
Therefore, change the use of "depends on REGMAP" to "select REGMAP".
Fixes: b474303ffd57 ("thermal: add Intel BXT WhiskeyCove PMIC thermal driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Yegnesh S Iyer <yegnesh.s.iyer@intel.com>
Cc: Bin Gao <bin.gao@intel.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Amit Kucheria <amitk@kernel.org>
Cc: linux-pm@vger.kernel.org
---
drivers/thermal/intel/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -- a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
--- a/drivers/thermal/intel/Kconfig
+++ b/drivers/thermal/intel/Kconfig
@@ -73,7 +73,8 @@ endmenu
config INTEL_BXT_PMIC_THERMAL
tristate "Intel Broxton PMIC thermal driver"
- depends on X86 && INTEL_SOC_PMIC_BXTWC && REGMAP
+ depends on X86 && INTEL_SOC_PMIC_BXTWC
+ select REGMAP
help
Select this driver for Intel Broxton PMIC with ADC channels monitoring
system temperature measurements and alerts.
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it
2023-02-26 5:39 [PATCH 0/8] drivers: select REGMAP instead of depending on it Randy Dunlap
` (6 preceding siblings ...)
2023-02-26 5:39 ` [PATCH 7/8] thermal: intel: BXT_PMIC: " Randy Dunlap
@ 2023-02-26 5:39 ` Randy Dunlap
2023-02-27 9:31 ` [PATCH 0/8] drivers: " Hans de Goede
8 siblings, 0 replies; 22+ messages in thread
From: Randy Dunlap @ 2023-02-26 5:39 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Greg Kroah-Hartman, Oskar Senft, linux-serial
REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.
Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.
Therefore, change the use of "depends on REGMAP" to "select REGMAP".
Fixes: 8d310c9107a2 ("drivers/tty/serial/8250: Make Aspeed VUART SIRQ polarity configurable")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Oskar Senft <osk@google.com>
Cc: linux-serial@vger.kernel.org
---
drivers/tty/serial/8250/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -- a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -257,8 +257,9 @@ config SERIAL_8250_ASPEED_VUART
tristate "Aspeed Virtual UART"
depends on SERIAL_8250
depends on OF
- depends on REGMAP && MFD_SYSCON
+ depends on MFD_SYSCON
depends on ARCH_ASPEED || COMPILE_TEST
+ select REGMAP
help
If you want to use the virtual UART (VUART) device on Aspeed
BMC platforms, enable this option. This enables the 16550A-
^ permalink raw reply [flat|nested] 22+ messages in thread
* RE: [PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it
2023-02-26 5:39 ` [PATCH 5/8] platform: mellanox: " Randy Dunlap
@ 2023-02-26 6:37 ` Vadim Pasternak
0 siblings, 0 replies; 22+ messages in thread
From: Vadim Pasternak @ 2023-02-26 6:37 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Darren Hart, Hans de Goede, Michael Shych, Mark Gross,
platform-driver-x86
> -----Original Message-----
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Sunday, 26 February 2023 7:40
> To: linux-kernel@vger.kernel.org
> Cc: Randy Dunlap <rdunlap@infradead.org>; Darren Hart
> <dvhart@infradead.org>; Hans de Goede <hdegoede@redhat.com>; Michael
> Shych <michaelsh@nvidia.com>; Mark Gross <markgross@kernel.org>;
> Vadim Pasternak <vadimp@nvidia.com>; platform-driver-
> x86@vger.kernel.org
> Subject: [PATCH 5/8] platform: mellanox: select REGMAP instead of
> depending on it
>
> REGMAP is a hidden (not user visible) symbol. Users cannot set it directly thru
> "make *config", so drivers should select it instead of depending on it if they
> need it.
>
> Consistently using "select" or "depends on" can also help reduce Kconfig
> circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> For NVSW_SN2201, select REGMAP_I2C instead of depending on it.
>
> Fixes: c6acad68eb2d ("platform/mellanox: mlxreg-hotplug: Modify to use a
> regmap interface")
> Fixes: 5ec4a8ace06c ("platform/mellanox: Introduce support for Mellanox
> register access driver")
> Fixes: 62f9529b8d5c ("platform/mellanox: mlxreg-lc: Add initial support for
> Nvidia line card devices")
> Fixes: 662f24826f95 ("platform/mellanox: Add support for new SN2201
> system")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Vadim Pasternak <vadimp@nvidia.com>
> Cc: Darren Hart <dvhart@infradead.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Michael Shych <michaelsh@nvidia.com>
> Cc: Mark Gross <markgross@kernel.org>
> Cc: Vadim Pasternak <vadimp@nvidia.com>
> Cc: platform-driver-x86@vger.kernel.org
> ---
> drivers/platform/mellanox/Kconfig | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff -- a/drivers/platform/mellanox/Kconfig
> b/drivers/platform/mellanox/Kconfig
> --- a/drivers/platform/mellanox/Kconfig
> +++ b/drivers/platform/mellanox/Kconfig
> @@ -16,17 +16,17 @@ if MELLANOX_PLATFORM
>
> config MLXREG_HOTPLUG
> tristate "Mellanox platform hotplug driver support"
> - depends on REGMAP
> depends on HWMON
> depends on I2C
> + select REGMAP
> help
> This driver handles hot-plug events for the power suppliers, power
> cables and fans on the wide range Mellanox IB and Ethernet
> systems.
>
> config MLXREG_IO
> tristate "Mellanox platform register access driver support"
> - depends on REGMAP
> depends on HWMON
> + select REGMAP
> help
> This driver allows access to Mellanox programmable device register
> space through sysfs interface. The sets of registers for sysfs access
> @@ -36,9 +36,9 @@ config MLXREG_IO
>
> config MLXREG_LC
> tristate "Mellanox line card platform driver support"
> - depends on REGMAP
> depends on HWMON
> depends on I2C
> + select REGMAP
> help
> This driver provides support for the Mellanox MSN4800-XX line
> cards,
> which are the part of MSN4800 Ethernet modular switch systems
> @@ -80,10 +80,9 @@ config MLXBF_PMC
>
> config NVSW_SN2201
> tristate "Nvidia SN2201 platform driver support"
> - depends on REGMAP
> depends on HWMON
> depends on I2C
> - depends on REGMAP_I2C
> + select REGMAP_I2C
> help
> This driver provides support for the Nvidia SN2201 platform.
> The SN2201 is a highly integrated for one rack unit system with
^ permalink raw reply [flat|nested] 22+ messages in thread
* RE: [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it
2023-02-26 5:39 ` [PATCH 6/8] platform: x86: MLX_PLATFORM: " Randy Dunlap
@ 2023-02-26 6:37 ` Vadim Pasternak
0 siblings, 0 replies; 22+ messages in thread
From: Vadim Pasternak @ 2023-02-26 6:37 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Darren Hart, Hans de Goede, Mark Gross, platform-driver-x86
> -----Original Message-----
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Sunday, 26 February 2023 7:40
> To: linux-kernel@vger.kernel.org
> Cc: Randy Dunlap <rdunlap@infradead.org>; Vadim Pasternak
> <vadimp@mellanox.com>; Darren Hart <dvhart@infradead.org>; Hans de
> Goede <hdegoede@redhat.com>; Mark Gross <markgross@kernel.org>;
> platform-driver-x86@vger.kernel.org
> Subject: [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead
> of depending on it
>
> REGMAP is a hidden (not user visible) symbol. Users cannot set it directly thru
> "make *config", so drivers should select it instead of depending on it if they
> need it.
>
> Consistently using "select" or "depends on" can also help reduce Kconfig
> circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: ef0f62264b2a ("platform/x86: mlx-platform: Add physical bus number
> auto detection")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Vadim Pasternak <vadimp@nvidia.com>
> Cc: Vadim Pasternak <vadimp@mellanox.com>
> Cc: Darren Hart <dvhart@infradead.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Mark Gross <markgross@kernel.org>
> Cc: platform-driver-x86@vger.kernel.org
> ---
> drivers/platform/x86/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -- a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -955,7 +955,8 @@ config SERIAL_MULTI_INSTANTIATE
>
> config MLX_PLATFORM
> tristate "Mellanox Technologies platform support"
> - depends on I2C && REGMAP
> + depends on I2C
> + select REGMAP
> help
> This option enables system support for the Mellanox Technologies
> platform. The Mellanox systems provide data center networking
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it
2023-02-26 5:39 ` [PATCH 3/8] gpio: GPIO_REGMAP: " Randy Dunlap
@ 2023-02-26 18:06 ` Michael Walle
2023-03-06 10:17 ` Bartosz Golaszewski
1 sibling, 0 replies; 22+ messages in thread
From: Michael Walle @ 2023-02-26 18:06 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Linus Walleij, Bartosz Golaszewski, linux-gpio
Am 2023-02-26 06:39, schrieb Randy Dunlap:
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: ebe363197e52 ("gpio: add a reusable generic gpio_chip using
> regmap")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Michael Walle <michael@walle.cc>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <brgl@bgdev.pl>
> Cc: linux-gpio@vger.kernel.org
Acked-by: Michael Walle <michael@walle.cc>
Thanks,
-michael
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it
2023-02-26 5:39 ` [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO " Randy Dunlap
@ 2023-02-26 22:59 ` Corey Minyard
2023-02-26 23:49 ` Randy Dunlap
0 siblings, 1 reply; 22+ messages in thread
From: Corey Minyard @ 2023-02-26 22:59 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Andrew Jeffery, openipmi-developer, Arnd Bergmann,
Greg Kroah-Hartman
On Sat, Feb 25, 2023 at 09:39:46PM -0800, Randy Dunlap wrote:
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP_MMIO" to
> "select REGMAP_MMIO", which will also set REGMAP.
This seems reasonable. I can take it into my tree, or..
Acked-by: Corey Minyard <cminyard@mvista.com>
>
> Fixes: eb994594bc22 ("ipmi: bt-bmc: Use a regmap for register access")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Corey Minyard <minyard@acm.org>
> Cc: openipmi-developer@lists.sourceforge.net
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/char/ipmi/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -- a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
> --- a/drivers/char/ipmi/Kconfig
> +++ b/drivers/char/ipmi/Kconfig
> @@ -162,7 +162,8 @@ config IPMI_KCS_BMC_SERIO
>
> config ASPEED_BT_IPMI_BMC
> depends on ARCH_ASPEED || COMPILE_TEST
> - depends on REGMAP && REGMAP_MMIO && MFD_SYSCON
> + depends on MFD_SYSCON
> + select REGMAP_MMIO
> tristate "BT IPMI bmc driver"
> help
> Provides a driver for the BT (Block Transfer) IPMI interface
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it
2023-02-26 22:59 ` Corey Minyard
@ 2023-02-26 23:49 ` Randy Dunlap
0 siblings, 0 replies; 22+ messages in thread
From: Randy Dunlap @ 2023-02-26 23:49 UTC (permalink / raw)
To: minyard
Cc: linux-kernel, Andrew Jeffery, openipmi-developer, Arnd Bergmann,
Greg Kroah-Hartman
On 2/26/23 14:59, Corey Minyard wrote:
> On Sat, Feb 25, 2023 at 09:39:46PM -0800, Randy Dunlap wrote:
>> REGMAP is a hidden (not user visible) symbol. Users cannot set it
>> directly thru "make *config", so drivers should select it instead of
>> depending on it if they need it.
>>
>> Consistently using "select" or "depends on" can also help reduce
>> Kconfig circular dependency issues.
>>
>> Therefore, change the use of "depends on REGMAP_MMIO" to
>> "select REGMAP_MMIO", which will also set REGMAP.
>
> This seems reasonable. I can take it into my tree, or..
Just take it, please. I expect that each subsystem maintainer
will take their respective patches.
> Acked-by: Corey Minyard <cminyard@mvista.com>
>
>>
>> Fixes: eb994594bc22 ("ipmi: bt-bmc: Use a regmap for register access")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Andrew Jeffery <andrew@aj.id.au>
>> Cc: Corey Minyard <minyard@acm.org>
>> Cc: openipmi-developer@lists.sourceforge.net
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> ---
>> drivers/char/ipmi/Kconfig | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff -- a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
>> --- a/drivers/char/ipmi/Kconfig
>> +++ b/drivers/char/ipmi/Kconfig
>> @@ -162,7 +162,8 @@ config IPMI_KCS_BMC_SERIO
>>
>> config ASPEED_BT_IPMI_BMC
>> depends on ARCH_ASPEED || COMPILE_TEST
>> - depends on REGMAP && REGMAP_MMIO && MFD_SYSCON
>> + depends on MFD_SYSCON
>> + select REGMAP_MMIO
>> tristate "BT IPMI bmc driver"
>> help
>> Provides a driver for the BT (Block Transfer) IPMI interface
--
~Randy
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/8] drivers: select REGMAP instead of depending on it
2023-02-26 5:39 [PATCH 0/8] drivers: select REGMAP instead of depending on it Randy Dunlap
` (7 preceding siblings ...)
2023-02-26 5:39 ` [PATCH 8/8] serial: 8250: ASPEED_VUART: " Randy Dunlap
@ 2023-02-27 9:31 ` Hans de Goede
2023-02-27 16:07 ` Randy Dunlap
8 siblings, 1 reply; 22+ messages in thread
From: Hans de Goede @ 2023-02-27 9:31 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Andrew Jeffery, Corey Minyard, openipmi-developer, Arnd Bergmann,
Greg Kroah-Hartman, Riku Voipio, Stephen Boyd, Michael Turquette,
linux-clk, Michael Walle, Linus Walleij, Bartosz Golaszewski,
linux-gpio, Dan Murphy, Pavel Machek, Jacek Anaszewski,
Lee Jones, linux-leds, Darren Hart, Michael Shych, Mark Gross,
Vadim Pasternak, platform-driver-x86, Yegnesh S Iyer, Bin Gao,
Zhang Rui, Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria,
linux-pm, Oskar Senft, linux-serial
Hi Randy,
On 2/26/23 06:39, Randy Dunlap wrote:
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> REGMAP is selected 94 times and is depended on 11 times in
> current linux-next. Eliminate the uses of "depends on" by
> converting them to "select".
Thank you for your work on this. Mixing of depends on vs select
is a real problem with many Kconfig symbols.
> [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it
> [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it
> [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it
> [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it
> [PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it
> [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it
> [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it
> [PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it
For patch 5/8 and 6/8, do you want me to merge them through the pdx86
(platform-drivers-x86) tree, or do you plan to merge this whole series
in one go through some other tree?
If you plan to merge the whole series through some other tree,
here is my acked by for doing so for 5/8 and 6/8:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
>
> diffstat:
> drivers/char/ipmi/Kconfig | 3 ++-
> drivers/clk/Kconfig | 2 +-
> drivers/gpio/Kconfig | 2 +-
> drivers/leds/Kconfig | 2 +-
> drivers/platform/mellanox/Kconfig | 9 ++++-----
> drivers/platform/x86/Kconfig | 3 ++-
> drivers/thermal/intel/Kconfig | 3 ++-
> drivers/tty/serial/8250/Kconfig | 3 ++-
> 8 files changed, 15 insertions(+), 12 deletions(-)
>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Corey Minyard <minyard@acm.org>
> Cc: openipmi-developer@lists.sourceforge.net
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Riku Voipio <riku.voipio@linaro.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: linux-clk@vger.kernel.org
> Cc: Michael Walle <michael@walle.cc>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <brgl@bgdev.pl>
> Cc: linux-gpio@vger.kernel.org
> Cc: Dan Murphy <dmurphy@ti.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Lee Jones <lee@kernel.org>
> Cc: linux-leds@vger.kernel.org
> Cc: Darren Hart <dvhart@infradead.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Michael Shych <michaelsh@nvidia.com>
> Cc: Mark Gross <markgross@kernel.org>
> Cc: Vadim Pasternak <vadimp@nvidia.com>
> Cc: platform-driver-x86@vger.kernel.org
> Cc: Yegnesh S Iyer <yegnesh.s.iyer@intel.com>
> Cc: Bin Gao <bin.gao@intel.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Amit Kucheria <amitk@kernel.org>
> Cc: linux-pm@vger.kernel.org
> Cc: Oskar Senft <osk@google.com>
> Cc: linux-serial@vger.kernel.org
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it
2023-02-26 5:39 ` [PATCH 4/8] leds: TI_LMU_COMMON: " Randy Dunlap
@ 2023-02-27 11:37 ` Pavel Machek
2023-03-01 14:21 ` Lee Jones
1 sibling, 0 replies; 22+ messages in thread
From: Pavel Machek @ 2023-02-27 11:37 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Dan Murphy, Jacek Anaszewski, Lee Jones, linux-leds
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
On Sat 2023-02-25 21:39:49, Randy Dunlap wrote:
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: 3fce8e1eb994 ("leds: TI LMU: Add common code for TI LMU devices")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Dan Murphy <dmurphy@ti.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/8] drivers: select REGMAP instead of depending on it
2023-02-27 9:31 ` [PATCH 0/8] drivers: " Hans de Goede
@ 2023-02-27 16:07 ` Randy Dunlap
2023-03-01 12:47 ` Hans de Goede
0 siblings, 1 reply; 22+ messages in thread
From: Randy Dunlap @ 2023-02-27 16:07 UTC (permalink / raw)
To: Hans de Goede, linux-kernel
Cc: Andrew Jeffery, Corey Minyard, openipmi-developer, Arnd Bergmann,
Greg Kroah-Hartman, Riku Voipio, Stephen Boyd, Michael Turquette,
linux-clk, Michael Walle, Linus Walleij, Bartosz Golaszewski,
linux-gpio, Dan Murphy, Pavel Machek, Jacek Anaszewski,
Lee Jones, linux-leds, Darren Hart, Michael Shych, Mark Gross,
Vadim Pasternak, platform-driver-x86, Yegnesh S Iyer, Bin Gao,
Zhang Rui, Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria,
linux-pm, Oskar Senft, linux-serial
On 2/27/23 01:31, Hans de Goede wrote:
> Hi Randy,
>
> On 2/26/23 06:39, Randy Dunlap wrote:
>> REGMAP is a hidden (not user visible) symbol. Users cannot set it
>> directly thru "make *config", so drivers should select it instead of
>> depending on it if they need it.
>>
>> Consistently using "select" or "depends on" can also help reduce
>> Kconfig circular dependency issues.
>>
>> REGMAP is selected 94 times and is depended on 11 times in
>> current linux-next. Eliminate the uses of "depends on" by
>> converting them to "select".
>
> Thank you for your work on this. Mixing of depends on vs select
> is a real problem with many Kconfig symbols.
>
>> [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it
>> [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it
>> [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it
>> [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it
>> [PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it
>> [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it
>> [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it
>> [PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it
>
> For patch 5/8 and 6/8, do you want me to merge them through the pdx86
> (platform-drivers-x86) tree, or do you plan to merge this whole series
> in one go through some other tree?
Hi Hans,
Please merge them thru the pdx86 tree.
Thanks.
> If you plan to merge the whole series through some other tree,
> here is my acked by for doing so for 5/8 and 6/8:
>
> Acked-by: Hans de Goede <hdegoede@redhat.com>
>
> Regards,
>
> Hans
>
>
>
>
>>
>> diffstat:
>> drivers/char/ipmi/Kconfig | 3 ++-
>> drivers/clk/Kconfig | 2 +-
>> drivers/gpio/Kconfig | 2 +-
>> drivers/leds/Kconfig | 2 +-
>> drivers/platform/mellanox/Kconfig | 9 ++++-----
>> drivers/platform/x86/Kconfig | 3 ++-
>> drivers/thermal/intel/Kconfig | 3 ++-
>> drivers/tty/serial/8250/Kconfig | 3 ++-
>> 8 files changed, 15 insertions(+), 12 deletions(-)
>>
>> Cc: Andrew Jeffery <andrew@aj.id.au>
>> Cc: Corey Minyard <minyard@acm.org>
>> Cc: openipmi-developer@lists.sourceforge.net
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Riku Voipio <riku.voipio@linaro.org>
>> Cc: Stephen Boyd <sboyd@kernel.org>
>> Cc: Michael Turquette <mturquette@baylibre.com>
>> Cc: linux-clk@vger.kernel.org
>> Cc: Michael Walle <michael@walle.cc>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: Bartosz Golaszewski <brgl@bgdev.pl>
>> Cc: linux-gpio@vger.kernel.org
>> Cc: Dan Murphy <dmurphy@ti.com>
>> Cc: Pavel Machek <pavel@ucw.cz>
>> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>> Cc: Lee Jones <lee@kernel.org>
>> Cc: linux-leds@vger.kernel.org
>> Cc: Darren Hart <dvhart@infradead.org>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>> Cc: Michael Shych <michaelsh@nvidia.com>
>> Cc: Mark Gross <markgross@kernel.org>
>> Cc: Vadim Pasternak <vadimp@nvidia.com>
>> Cc: platform-driver-x86@vger.kernel.org
>> Cc: Yegnesh S Iyer <yegnesh.s.iyer@intel.com>
>> Cc: Bin Gao <bin.gao@intel.com>
>> Cc: Zhang Rui <rui.zhang@intel.com>
>> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>> Cc: Amit Kucheria <amitk@kernel.org>
>> Cc: linux-pm@vger.kernel.org
>> Cc: Oskar Senft <osk@google.com>
>> Cc: linux-serial@vger.kernel.org
>>
>
--
~Randy
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/8] drivers: select REGMAP instead of depending on it
2023-02-27 16:07 ` Randy Dunlap
@ 2023-03-01 12:47 ` Hans de Goede
0 siblings, 0 replies; 22+ messages in thread
From: Hans de Goede @ 2023-03-01 12:47 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Andrew Jeffery, Corey Minyard, openipmi-developer, Arnd Bergmann,
Greg Kroah-Hartman, Riku Voipio, Stephen Boyd, Michael Turquette,
linux-clk, Michael Walle, Linus Walleij, Bartosz Golaszewski,
linux-gpio, Dan Murphy, Pavel Machek, Jacek Anaszewski,
Lee Jones, linux-leds, Darren Hart, Michael Shych, Mark Gross,
Vadim Pasternak, platform-driver-x86, Yegnesh S Iyer, Bin Gao,
Zhang Rui, Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria,
linux-pm, Oskar Senft, linux-serial
Hi,
On 2/27/23 17:07, Randy Dunlap wrote:
>
>
> On 2/27/23 01:31, Hans de Goede wrote:
>> Hi Randy,
>>
>> On 2/26/23 06:39, Randy Dunlap wrote:
>>> REGMAP is a hidden (not user visible) symbol. Users cannot set it
>>> directly thru "make *config", so drivers should select it instead of
>>> depending on it if they need it.
>>>
>>> Consistently using "select" or "depends on" can also help reduce
>>> Kconfig circular dependency issues.
>>>
>>> REGMAP is selected 94 times and is depended on 11 times in
>>> current linux-next. Eliminate the uses of "depends on" by
>>> converting them to "select".
>>
>> Thank you for your work on this. Mixing of depends on vs select
>> is a real problem with many Kconfig symbols.
>>
>>> [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it
>>> [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it
>>> [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it
>>> [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it
>>> [PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it
>>> [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it
>>> [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it
>>> [PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it
>>
>> For patch 5/8 and 6/8, do you want me to merge them through the pdx86
>> (platform-drivers-x86) tree, or do you plan to merge this whole series
>> in one go through some other tree?
>
> Hi Hans,
> Please merge them thru the pdx86 tree.
Ok, I've applied patch 5/8 + 6/8 to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
I'll rebase that branch once 6.3-rc1 is out and then push the rebased
patch to the fixes branch and include it in my next 6.3 fixes pull-req
to Linus.
Regards,
Hans
>>>
>>> diffstat:
>>> drivers/char/ipmi/Kconfig | 3 ++-
>>> drivers/clk/Kconfig | 2 +-
>>> drivers/gpio/Kconfig | 2 +-
>>> drivers/leds/Kconfig | 2 +-
>>> drivers/platform/mellanox/Kconfig | 9 ++++-----
>>> drivers/platform/x86/Kconfig | 3 ++-
>>> drivers/thermal/intel/Kconfig | 3 ++-
>>> drivers/tty/serial/8250/Kconfig | 3 ++-
>>> 8 files changed, 15 insertions(+), 12 deletions(-)
>>>
>>> Cc: Andrew Jeffery <andrew@aj.id.au>
>>> Cc: Corey Minyard <minyard@acm.org>
>>> Cc: openipmi-developer@lists.sourceforge.net
>>> Cc: Arnd Bergmann <arnd@arndb.de>
>>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>> Cc: Riku Voipio <riku.voipio@linaro.org>
>>> Cc: Stephen Boyd <sboyd@kernel.org>
>>> Cc: Michael Turquette <mturquette@baylibre.com>
>>> Cc: linux-clk@vger.kernel.org
>>> Cc: Michael Walle <michael@walle.cc>
>>> Cc: Linus Walleij <linus.walleij@linaro.org>
>>> Cc: Bartosz Golaszewski <brgl@bgdev.pl>
>>> Cc: linux-gpio@vger.kernel.org
>>> Cc: Dan Murphy <dmurphy@ti.com>
>>> Cc: Pavel Machek <pavel@ucw.cz>
>>> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>>> Cc: Lee Jones <lee@kernel.org>
>>> Cc: linux-leds@vger.kernel.org
>>> Cc: Darren Hart <dvhart@infradead.org>
>>> Cc: Hans de Goede <hdegoede@redhat.com>
>>> Cc: Michael Shych <michaelsh@nvidia.com>
>>> Cc: Mark Gross <markgross@kernel.org>
>>> Cc: Vadim Pasternak <vadimp@nvidia.com>
>>> Cc: platform-driver-x86@vger.kernel.org
>>> Cc: Yegnesh S Iyer <yegnesh.s.iyer@intel.com>
>>> Cc: Bin Gao <bin.gao@intel.com>
>>> Cc: Zhang Rui <rui.zhang@intel.com>
>>> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
>>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>>> Cc: Amit Kucheria <amitk@kernel.org>
>>> Cc: linux-pm@vger.kernel.org
>>> Cc: Oskar Senft <osk@google.com>
>>> Cc: linux-serial@vger.kernel.org
>>>
>>
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it
2023-02-26 5:39 ` [PATCH 4/8] leds: TI_LMU_COMMON: " Randy Dunlap
2023-02-27 11:37 ` Pavel Machek
@ 2023-03-01 14:21 ` Lee Jones
1 sibling, 0 replies; 22+ messages in thread
From: Lee Jones @ 2023-03-01 14:21 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Dan Murphy, Pavel Machek, Jacek Anaszewski, linux-leds
On Sat, 25 Feb 2023, Randy Dunlap wrote:
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: 3fce8e1eb994 ("leds: TI LMU: Add common code for TI LMU devices")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Dan Murphy <dmurphy@ti.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Lee Jones <lee@kernel.org>
> Cc: linux-leds@vger.kernel.org
> ---
> drivers/leds/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it
2023-02-26 5:39 ` [PATCH 7/8] thermal: intel: BXT_PMIC: " Randy Dunlap
@ 2023-03-01 18:34 ` Rafael J. Wysocki
0 siblings, 0 replies; 22+ messages in thread
From: Rafael J. Wysocki @ 2023-03-01 18:34 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Yegnesh S Iyer, Bin Gao, Zhang Rui,
Rafael J . Wysocki, Daniel Lezcano, Amit Kucheria, linux-pm
On Sun, Feb 26, 2023 at 6:40 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: b474303ffd57 ("thermal: add Intel BXT WhiskeyCove PMIC thermal driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Yegnesh S Iyer <yegnesh.s.iyer@intel.com>
> Cc: Bin Gao <bin.gao@intel.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Rafael J. Wysocki <rafael@kernel.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Amit Kucheria <amitk@kernel.org>
> Cc: linux-pm@vger.kernel.org
> ---
> drivers/thermal/intel/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -- a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
> --- a/drivers/thermal/intel/Kconfig
> +++ b/drivers/thermal/intel/Kconfig
> @@ -73,7 +73,8 @@ endmenu
>
> config INTEL_BXT_PMIC_THERMAL
> tristate "Intel Broxton PMIC thermal driver"
> - depends on X86 && INTEL_SOC_PMIC_BXTWC && REGMAP
> + depends on X86 && INTEL_SOC_PMIC_BXTWC
> + select REGMAP
> help
> Select this driver for Intel Broxton PMIC with ADC channels monitoring
> system temperature measurements and alerts.
Applied as 6.3-rc material, thanks!
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it
2023-02-26 5:39 ` [PATCH 3/8] gpio: GPIO_REGMAP: " Randy Dunlap
2023-02-26 18:06 ` Michael Walle
@ 2023-03-06 10:17 ` Bartosz Golaszewski
1 sibling, 0 replies; 22+ messages in thread
From: Bartosz Golaszewski @ 2023-03-06 10:17 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Michael Walle, Linus Walleij, linux-gpio
On Sun, Feb 26, 2023 at 6:40 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: ebe363197e52 ("gpio: add a reusable generic gpio_chip using regmap")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Michael Walle <michael@walle.cc>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <brgl@bgdev.pl>
> Cc: linux-gpio@vger.kernel.org
> ---
> drivers/gpio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -100,7 +100,7 @@ config GPIO_GENERIC
> tristate
>
> config GPIO_REGMAP
> - depends on REGMAP
> + select REGMAP
> tristate
>
> # put drivers in the right section, in alphabetical order
Queued for fixes, thanks!
Bart
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it
2023-02-26 5:39 ` [PATCH 2/8] clk: HI655X: select REGMAP " Randy Dunlap
@ 2023-03-06 19:30 ` Stephen Boyd
0 siblings, 0 replies; 22+ messages in thread
From: Stephen Boyd @ 2023-03-06 19:30 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Randy Dunlap, Riku Voipio, Michael Turquette, linux-clk
Quoting Randy Dunlap (2023-02-25 21:39:47)
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: 3a49afb84ca0 ("clk: enable hi655x common clk automatically")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Riku Voipio <riku.voipio@linaro.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: linux-clk@vger.kernel.org
> ---
Applied to clk-fixes
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2023-03-06 19:30 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-26 5:39 [PATCH 0/8] drivers: select REGMAP instead of depending on it Randy Dunlap
2023-02-26 5:39 ` [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO " Randy Dunlap
2023-02-26 22:59 ` Corey Minyard
2023-02-26 23:49 ` Randy Dunlap
2023-02-26 5:39 ` [PATCH 2/8] clk: HI655X: select REGMAP " Randy Dunlap
2023-03-06 19:30 ` Stephen Boyd
2023-02-26 5:39 ` [PATCH 3/8] gpio: GPIO_REGMAP: " Randy Dunlap
2023-02-26 18:06 ` Michael Walle
2023-03-06 10:17 ` Bartosz Golaszewski
2023-02-26 5:39 ` [PATCH 4/8] leds: TI_LMU_COMMON: " Randy Dunlap
2023-02-27 11:37 ` Pavel Machek
2023-03-01 14:21 ` Lee Jones
2023-02-26 5:39 ` [PATCH 5/8] platform: mellanox: " Randy Dunlap
2023-02-26 6:37 ` Vadim Pasternak
2023-02-26 5:39 ` [PATCH 6/8] platform: x86: MLX_PLATFORM: " Randy Dunlap
2023-02-26 6:37 ` Vadim Pasternak
2023-02-26 5:39 ` [PATCH 7/8] thermal: intel: BXT_PMIC: " Randy Dunlap
2023-03-01 18:34 ` Rafael J. Wysocki
2023-02-26 5:39 ` [PATCH 8/8] serial: 8250: ASPEED_VUART: " Randy Dunlap
2023-02-27 9:31 ` [PATCH 0/8] drivers: " Hans de Goede
2023-02-27 16:07 ` Randy Dunlap
2023-03-01 12:47 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.