From: Benjamin Gray <bgray@linux.ibm.com>
To: linux-i2c@vger.kernel.org
Cc: arnd@arndb.de, Sven Peter <sven@svenpeter.dev>,
mpe@ellerman.id.au, Benjamin Gray <bgray@linux.ibm.com>
Subject: [PATCH v2 1/2] i2c: Disable I2C_APPLE when I2C_PASEMI is a builtin
Date: Tue, 28 Feb 2023 10:33:17 +1100 [thread overview]
Message-ID: <20230227233318.120415-1-bgray@linux.ibm.com> (raw)
The ppc64le_allmodconfig sets I2C_PASEMI=y and leaves COMPILE_TEST to
default to y and I2C_APPLE to default to m, running into a known
incompatible configuration that breaks the build [1]. Specifically,
a common dependency (i2c-pasemi-core.o in this case) cannot be used by
both builtin and module consumers.
Disable I2C_APPLE when I2C_PASEMI is a builtin to prevent this.
[1]: https://lore.kernel.org/all/202112061809.XT99aPrf-lkp@intel.com
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Benjamin Gray <bgray@linux.ibm.com>
---
v1: https://lore.kernel.org/linux-i2c/20230227035414.1461763-1-bgray@linux.ibm.com/
---
drivers/i2c/busses/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index d4975444a32d..c42109e972fe 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -896,6 +896,7 @@ config I2C_PASEMI
config I2C_APPLE
tristate "Apple SMBus platform driver"
+ depends on !I2C_PASEMI
depends on ARCH_APPLE || COMPILE_TEST
default ARCH_APPLE
help
base-commit: ec0a1b360aec1ba0bdfad3dd69e300b028529c0d
--
2.39.2
next reply other threads:[~2023-02-27 23:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 23:33 Benjamin Gray [this message]
2023-02-27 23:33 ` [PATCH v2 2/2] i2c: Build I2C_PASEMI with COMPILE_TEST Benjamin Gray
2023-02-28 3:50 ` kernel test robot
2023-02-28 21:37 ` Benjamin Gray
2023-03-02 17:00 ` Sven Peter
2023-02-28 8:38 ` [PATCH v2 1/2] i2c: Disable I2C_APPLE when I2C_PASEMI is a builtin Arnd Bergmann
2023-03-02 17:00 ` Sven Peter
2023-03-03 19:56 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227233318.120415-1-bgray@linux.ibm.com \
--to=bgray@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=linux-i2c@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.