From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C272C6FA8E for ; Thu, 2 Mar 2023 17:25:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9C6B48589B; Thu, 2 Mar 2023 18:25:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="G9MofZ4i"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 83384858BF; Thu, 2 Mar 2023 18:25:08 +0100 (CET) Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BCECC85798 for ; Thu, 2 Mar 2023 18:25:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf36.google.com with SMTP id nf5so12152354qvb.5 for ; Thu, 02 Mar 2023 09:25:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1677777904; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=31QITcPdMJsVt0fhohZhi6q1mre6mHlY8wMCO5puf/0=; b=G9MofZ4ifNg0lgMaeMSW+qixa/nyB+WG2OXxu5T9AqWEZ2Lc0XjB7UjsmNQfV7fOS/ uSgwDu4blyMaM5+im6qKYaj17l0A2bDI/lhGS0QKZnuTCAe3bZp4+fcaX1xf9pCG+MrH RGU0/BL13AHom15eNKZr1UD7945AP7m0PwTDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677777904; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=31QITcPdMJsVt0fhohZhi6q1mre6mHlY8wMCO5puf/0=; b=sxWQXDKhk7zNcq6hVT8TUX4pi3XsnYQBYyKPphS6DFz65y2DFUhqzuleJwNhgV+Mhj Blm+U6UiohWaHMGXdl8t4qW8p4hEnfh+rgYO9D+CVIDg4+yWLvZlxWl25U1OPUEPiY78 hwjdT7txmF41a4tuQhnC1pKczIk5YgbHa1yClpx1wk1LCOYSQ9iy+geNryM6H8NfG5jy AbG/mZq6uKwB27MKZxPUGprutwVe2jvrUdQBFygh5jRDaKMelYLNSixYzqaEsQzrF2dm ZQ5LPrmV6Q+5rsJIrFKtZU4rO3wEPjEpwHZ8IvuyONsX5/pQUe3rcq03TNy2f0qC7rUY u31Q== X-Gm-Message-State: AO0yUKXLHgdu4F9n8ZWPh0kMTnVHYQ2njOPlFZ5Z7AkbwrnzrQNYHiTf a0FfHiPOB/KmEXPCegM7rKW90w== X-Google-Smtp-Source: AK7set8nXVcIWAphY4IFdTmCcfHtPrW8FspI9yvUkJFUkaZlPxnafAP4kazA9YgTUjriO+mWg/ZAng== X-Received: by 2002:a05:6214:250a:b0:56b:fb58:c350 with SMTP id gf10-20020a056214250a00b0056bfb58c350mr22682524qvb.26.1677777904543; Thu, 02 Mar 2023 09:25:04 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0000-0000-0000-036b.res6.spectrum.com. [2603:6081:7b00:6400::36b]) by smtp.gmail.com with ESMTPSA id x22-20020a05620a0b5600b0070648cf78bdsm31368qkg.54.2023.03.02.09.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 09:25:04 -0800 (PST) Date: Thu, 2 Mar 2023 12:25:02 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Joe Hershberger , Samuel Dionne-Riel Subject: Re: [PATCH v5 18/44] env: Avoid checking ENV_IS_IN when env disabled Message-ID: <20230302172502.GA1080820@bill-the-cat> References: <20230222163425.2043934-1-sjg@chromium.org> <20230222163425.2043934-19-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eGR4mD299rpoB4Ye" Content-Disposition: inline In-Reply-To: <20230222163425.2043934-19-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --eGR4mD299rpoB4Ye Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 22, 2023 at 09:33:59AM -0700, Simon Glass wrote: > This check is not needed when the environment is not enabled, e.g. in > SPL. Add a condition to handle this. >=20 > Signed-off-by: Simon Glass > --- >=20 > (no changes since v1) >=20 > cmd/nvedit.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/cmd/nvedit.c b/cmd/nvedit.c > index 7cbc3fd573a..277293679df 100644 > --- a/cmd/nvedit.c > +++ b/cmd/nvedit.c > @@ -59,11 +59,13 @@ DECLARE_GLOBAL_DATA_PTR; > =20 > #endif > =20 > +#if CONFIG_IS_ENABLED(ENV_SUPPORT) > #if !defined(ENV_IS_IN_DEVICE) && \ > !defined(CONFIG_ENV_IS_NOWHERE) > # error Define one of CONFIG_ENV_IS_IN_{EEPROM|FLASH|MMC|FAT|EXT4|\ > NAND|NVRAM|ONENAND|SATA|SPI_FLASH|REMOTE|UBI} or CONFIG_ENV_IS_NOWHERE > #endif > +#endif /* ENV_SUPPORT */ We need to move this kind of sanity enforcement to Kconfig, and drop the #error. --=20 Tom --eGR4mD299rpoB4Ye Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQA2+cACgkQFHw5/5Y0 tyzlsQv/cqSFutZqW5QO5O/6iUwwrI13un9j7jC1L8km52+iKO5wJRNlizLA7X5u erE7ZG26knUvLxhAC/AOoYvpwKu69vJGuL1NSMcAADCdI+RYXFD8RtaJnHcDJJJ1 5SKRpLVLCUd6L4i+rPgQb+fyGAM3NWWTWm9b2Q6I3FW9n6S+fjbv+36Gn0DZZKl5 C+YEXtVwb4+66zb+kjHBVBC7WsoAAaI8lPf/bJegHxnqUKzkRGUdq/6y0fafILP3 X5z8gZCsOWjy+BHcLRmuobOce0DFrefAd7LHEgeiMvyZESli4w4GXbHdw+H4rtse F4N8O2Ttm6OfjUQctYOWSziOdMpu4vuEmFQfNEQULoYZ88Z5hjjAzCf1X8+UYwix oJ5oVZoa70510zVFKrrks5zic4s8a6a+yEu7/OOZWBLOBkCbhWlAx+RbMQdW186H XNOozEOaE5Gy77vcGEWrPNysJe2WI+QTPw072KuDg+cT/97+MqLCyKGpQEZDKjYr rv2LTeX1 =LJcv -----END PGP SIGNATURE----- --eGR4mD299rpoB4Ye--