From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 522C8C6FA8E for ; Thu, 2 Mar 2023 20:30:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1553385A80; Thu, 2 Mar 2023 21:30:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="tORQQ1YB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 348A885B1B; Thu, 2 Mar 2023 21:30:30 +0100 (CET) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A76668572C for ; Thu, 2 Mar 2023 21:30:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id ay9so624376qtb.9 for ; Thu, 02 Mar 2023 12:30:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1677789026; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IuyJNvq7UxdE1vD//7atVNSL5RUC/2AAlpXVHA+SadM=; b=tORQQ1YBbkPtLezj36LpT//E46E4SYsUjvwooz+quAPqTOv3WfAXl9e81kwkCo0COE nvUCG5dySRizOb0LF8Gfdj9eJENzjQBFxKQ2fIihi6cIR2ycgfSTU+hpH+7Wa+x+4xmn kMdc3XPqY3U0nHgEbxC1UN5W0rvOu5fd1FtOs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677789026; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IuyJNvq7UxdE1vD//7atVNSL5RUC/2AAlpXVHA+SadM=; b=jY5CtcSd7gHL8Q+afuIVCG78uURiDqxuFNqD4c341AciFf6rXmR0boAoASeMKTRAXW pqkzB9cL/9M9BIweebCg3r+uMKlgI3JhHeA6lhShQfHIPSHoqeX79EaH+tfu95am+/fQ JwWwBCL9Qkg/STpkdk87LhDR/D3yYnJNzmyYZGE3+HYVpCsngFt1hMvqUxe03SchmB/f SmRYO0LLdDB+4u4MbHlD4mWpOqn2eRYaP4jdfO+SII3502fD/S7Mhi/Ra3kKPVYUsAse Xx+97LBv5NcmWIEPHuXTZQbmJ1yl5xoeOTMegRrs29afYMY3JIQcOTnNddHEgUVnkALy zejw== X-Gm-Message-State: AO0yUKXgi+UifYf9upGXx/zgxKoRz3AvnqmIRuPquJ3DkTK/EFZ79wH+ eflU/v4Q8UUW1Ujy1goGkWydQg== X-Google-Smtp-Source: AK7set/4nJXSbJHmc8H7OywqhVN87b9EhuiRzQQ+hiqVCFBzYwrTtcXozeFtjK9xYZSG3wt83pORuQ== X-Received: by 2002:a05:622a:242:b0:3bf:bb9a:8e44 with SMTP id c2-20020a05622a024200b003bfbb9a8e44mr20741682qtx.4.1677789026210; Thu, 02 Mar 2023 12:30:26 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0000-0000-0000-036b.res6.spectrum.com. [2603:6081:7b00:6400::36b]) by smtp.gmail.com with ESMTPSA id r62-20020a374441000000b00706c1f7a608sm317235qka.89.2023.03.02.12.30.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 12:30:25 -0800 (PST) Date: Thu, 2 Mar 2023 15:30:23 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Heinrich Schuchardt , John Keeping Subject: Re: [PATCH v5 44/44] command: Don't allow commands in SPL Message-ID: <20230302203023.GA4002859@bill-the-cat> References: <20230222163425.2043934-1-sjg@chromium.org> <20230222163425.2043934-45-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cMdsmwesS8M0/KrH" Content-Disposition: inline In-Reply-To: <20230222163425.2043934-45-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --cMdsmwesS8M0/KrH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 22, 2023 at 09:34:25AM -0700, Simon Glass wrote: > At present we compile commands into U-Boot SPL even though they cannot > be used. This wastes space. Adjust the condition to avoid this. >=20 > Signed-off-by: Simon Glass > --- >=20 > Changes in v5: > - Drop FSL_ISBC_KEY_EXT patch as it changes the size > - Drop PHY_CADENCE_SIERRA patch as it changes the size >=20 > Changes in v3: > - Add a new patch to disallow commands in SPL >=20 > include/command.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) As a follow-up, "git grep -l u_boot_list_2_cmd" shows some lds scripts that I believe can be updated, after this change. And in reviewing this change, yes, a few boards now discard some functionality, but, it looks like it's reasonable and not that we're removing some intentional but odd configurations. --=20 Tom --cMdsmwesS8M0/KrH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQBB1wACgkQFHw5/5Y0 tyzNSQwAosiPAbb2oHoxgx6b29AiQaDuiE/cLc5FjfyqtPCf2KuWVcUmtu/PSUf5 TuvnNsNRl7yc62eUC8FZZUcRvV3I0vxFLC6UEHTbd5EFxpsXEXNLW62prxuRX+kv KzXYU9lJPNPyIVTQwFDw8J46x7798/r//Zen8VkxGMfpfdxCbf8pnZKU3dS4mBgm +LSKa7xFfbahrX4j+x2tR+HdMjSdtUeXKCcsDNxSiT22bsM0SCMa/RIAIP2Yq6s0 o/7LUTrFaGx9U69hTaYw5SsXpwkBrtKjX8A+vhOMCmNgeIbyK0JPRjw85819C98F aEheO0ebQb8eFGYUeGboHx67xHDHKXUq/s7ZT7k1+Kz0r40e1gv9jqea7ssigIcW QajvVOZOqd/Ztnubay6qi910UGHeeJTWDhWnEdMMu43Lx9VhG9W+GYx32224Sa6+ Q7JczUatJrUsRuCWjf/Zd6y5I1i3Wl/NM+z7lNdD9qTD8BuiQWLYgobnkTEQsjhI cN1o7tW/ =lj2z -----END PGP SIGNATURE----- --cMdsmwesS8M0/KrH--