From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B34B5C64EC4 for ; Fri, 3 Mar 2023 15:02:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229804AbjCCPCm (ORCPT ); Fri, 3 Mar 2023 10:02:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229803AbjCCPCk (ORCPT ); Fri, 3 Mar 2023 10:02:40 -0500 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07A4660AB3 for ; Fri, 3 Mar 2023 07:02:38 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 55C025C016C; Fri, 3 Mar 2023 10:02:38 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 03 Mar 2023 10:02:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1677855758; x=1677942158; bh=9y lX5UXlyEJ6YkH4fBnLfYnJwUQf1lSf0593M1gUNNw=; b=nbN1lEu1jDCrvrRtOP 5Q9zwqzH0wADCbm7cmBizSTwNUjIs5qSwDxjC40n4PPryIBvvckBEHX/dxn/7Qs8 Kr7r9jYd9FTFgcwvrwlO99BkFAui3ZZxoFPrXXLvLplvnaZ8OfYSFsUE34qPV4WI Ctjh+UcfNCeW5iFNwpvgxQsPgIdAMKyuQWRQJZgQP8NioETV9Pe2KmJoJzzECcpI f8ycLxK3qcKK11vuhNcLimuPVajFLXEO81Y3uYpO4VO3DuWni5d//yUZM8euz7nf nVruS2GY6R1FkJI3Ml/XbZLPzpn0O2Wr6T/q7eFIggmxEDS0+0tGA1V8Ynkzc2AE k9Qg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1677855758; x=1677942158; bh=9ylX5UXlyEJ6Y kH4fBnLfYnJwUQf1lSf0593M1gUNNw=; b=dLB72Zzi00vW8o0663CkYPUtjawkp SldyACAI6M5QWKbgXwNP7vEV7/cUAUjJHi7Vrr6KRQfJtqMF6FFWes4eSXY4IPGj zHe+RZa+d/aMr9CpUa7Wrdkidsa4102EdbiVHGGQFEdUDrwNYeDDNvIZ9HQTFw8w kYNlUGeI2wN6MYu78KKNpdFnEqDL39OXvevseRpdl70T7EZIRY2zJan6Xaeuqu67 LnPd7uL8jXvj07wLlQ6zrRnnN5JSgq1PVNHNdcGCzTqORcQF+Vsd1HXNdH14MiYv XdGirKpIpmi3o6+Qv/QKrepEYVUI0BCShX1Fw7wMIf0YlnSSapwMm3xvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudelledgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeetfefffefgkedtfefgledugfdtjeefjedvtddtkeetieffjedvgfehheff hfevudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Mar 2023 10:02:36 -0500 (EST) Date: Fri, 3 Mar 2023 16:02:35 +0100 From: Maxime Ripard To: Jagan Teki Cc: Andrzej Hajda , Inki Dae , Marek Szyprowski , Neil Armstrong , Marek Vasut , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Tim Harvey , Adam Ford , Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-amarula Subject: Re: [PATCH v15 08/16] drm: exynos: dsi: Add input_bus_flags Message-ID: <20230303150235.qol4nuoqt77nxmzf@houat> References: <20230303145138.29233-1-jagan@amarulasolutions.com> <20230303145138.29233-9-jagan@amarulasolutions.com> <20230303150019.bqxhaqtwwr5xiep4@houat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sskvigagtttvb4bb" Content-Disposition: inline In-Reply-To: <20230303150019.bqxhaqtwwr5xiep4@houat> Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org --sskvigagtttvb4bb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 03, 2023 at 04:00:19PM +0100, Maxime Ripard wrote: > On Fri, Mar 03, 2023 at 08:21:30PM +0530, Jagan Teki wrote: > > LCDIF-DSIM glue logic inverts the HS/VS/DE signals and expecting > > the i.MX8M Mini/Nano DSI host to add additional Data Enable signal > > active low (DE_LOW). This makes the valid data transfer on each > > horizontal line. > >=20 > > So, add additional bus flags DE_LOW setting via input_bus_flags > > for i.MX8M Mini/Nano platforms. > >=20 > > Reviewed-by: Marek Vasut > > Reviewed-by: Frieder Schrempf > > Suggested-by: Marek Vasut > > Signed-off-by: Jagan Teki > > --- > > Changes for v15, v13: > > - none > > Changes for v12: > > - collect RB from Marek > > Changes for v11: > > - collect RB from Frieder > > Changes for v10, v9: > > - none > > Changes for v8: > > - add DE_LOW for i.MX8M Mini/Nano platforms. > > Changes for v7, v6: > > - none > > Changes for v5: > > - rebased based on updated bridge changes > > Changes for v4 - v1: > > - none > >=20 > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > >=20 > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/= exynos/exynos_drm_dsi.c > > index 796480e4a18b..5d971b607e1a 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > > @@ -1736,6 +1736,10 @@ static const struct component_ops exynos_dsi_com= ponent_ops =3D { > > .unbind =3D exynos_dsi_unbind, > > }; > > =20 > > +static const struct drm_bridge_timings dsim_bridge_timings_de_low =3D { > > + .input_bus_flags =3D DRM_BUS_FLAG_DE_LOW, > > +}; > > + > > static int exynos_dsi_probe(struct platform_device *pdev) > > { > > struct device *dev =3D &pdev->dev; > > @@ -1822,6 +1826,10 @@ static int exynos_dsi_probe(struct platform_devi= ce *pdev) > > dsi->bridge.type =3D DRM_MODE_CONNECTOR_DSI; > > dsi->bridge.pre_enable_prev_first =3D true; > > =20 > > + /* DE_LOW: i.MX8M Mini/Nano LCDIF-DSIM glue logic inverts HS/VS/DE */ > > + if (dsi->plat_data->hw_type =3D=3D DSIM_TYPE_IMX8MM) >=20 > That commit isn't bisectable, you add that enum variant in the last > patch so this won't compile. Scratch that, it's defined in the previous patch, sorry Maxime --sskvigagtttvb4bb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZAIMCwAKCRDj7w1vZxhR xZzIAQCd1oDdXVSebyvNY7DnspeAtzLN1G1dQqMtaMpqy+WwQQD/W6k5ib1l/Ld/ DqCDTNQ/1puNAcglDetAATSe6ZJpzQo= =mRrV -----END PGP SIGNATURE----- --sskvigagtttvb4bb-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18F9BC7EE32 for ; Fri, 3 Mar 2023 15:02:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 68FAE10E688; Fri, 3 Mar 2023 15:02:40 +0000 (UTC) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 05B6B10E67D for ; Fri, 3 Mar 2023 15:02:39 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 55C025C016C; Fri, 3 Mar 2023 10:02:38 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 03 Mar 2023 10:02:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1677855758; x=1677942158; bh=9y lX5UXlyEJ6YkH4fBnLfYnJwUQf1lSf0593M1gUNNw=; b=nbN1lEu1jDCrvrRtOP 5Q9zwqzH0wADCbm7cmBizSTwNUjIs5qSwDxjC40n4PPryIBvvckBEHX/dxn/7Qs8 Kr7r9jYd9FTFgcwvrwlO99BkFAui3ZZxoFPrXXLvLplvnaZ8OfYSFsUE34qPV4WI Ctjh+UcfNCeW5iFNwpvgxQsPgIdAMKyuQWRQJZgQP8NioETV9Pe2KmJoJzzECcpI f8ycLxK3qcKK11vuhNcLimuPVajFLXEO81Y3uYpO4VO3DuWni5d//yUZM8euz7nf nVruS2GY6R1FkJI3Ml/XbZLPzpn0O2Wr6T/q7eFIggmxEDS0+0tGA1V8Ynkzc2AE k9Qg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1677855758; x=1677942158; bh=9ylX5UXlyEJ6Y kH4fBnLfYnJwUQf1lSf0593M1gUNNw=; b=dLB72Zzi00vW8o0663CkYPUtjawkp SldyACAI6M5QWKbgXwNP7vEV7/cUAUjJHi7Vrr6KRQfJtqMF6FFWes4eSXY4IPGj zHe+RZa+d/aMr9CpUa7Wrdkidsa4102EdbiVHGGQFEdUDrwNYeDDNvIZ9HQTFw8w kYNlUGeI2wN6MYu78KKNpdFnEqDL39OXvevseRpdl70T7EZIRY2zJan6Xaeuqu67 LnPd7uL8jXvj07wLlQ6zrRnnN5JSgq1PVNHNdcGCzTqORcQF+Vsd1HXNdH14MiYv XdGirKpIpmi3o6+Qv/QKrepEYVUI0BCShX1Fw7wMIf0YlnSSapwMm3xvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudelledgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeetfefffefgkedtfefgledugfdtjeefjedvtddtkeetieffjedvgfehheff hfevudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Mar 2023 10:02:36 -0500 (EST) Date: Fri, 3 Mar 2023 16:02:35 +0100 From: Maxime Ripard To: Jagan Teki Subject: Re: [PATCH v15 08/16] drm: exynos: dsi: Add input_bus_flags Message-ID: <20230303150235.qol4nuoqt77nxmzf@houat> References: <20230303145138.29233-1-jagan@amarulasolutions.com> <20230303145138.29233-9-jagan@amarulasolutions.com> <20230303150019.bqxhaqtwwr5xiep4@houat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sskvigagtttvb4bb" Content-Disposition: inline In-Reply-To: <20230303150019.bqxhaqtwwr5xiep4@houat> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Neil Armstrong , linux-samsung-soc@vger.kernel.org, Matteo Lisi , linux-amarula , Seung-Woo Kim , Frieder Schrempf , Kyungmin Park , dri-devel@lists.freedesktop.org, Andrzej Hajda , Adam Ford , Marek Szyprowski Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --sskvigagtttvb4bb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 03, 2023 at 04:00:19PM +0100, Maxime Ripard wrote: > On Fri, Mar 03, 2023 at 08:21:30PM +0530, Jagan Teki wrote: > > LCDIF-DSIM glue logic inverts the HS/VS/DE signals and expecting > > the i.MX8M Mini/Nano DSI host to add additional Data Enable signal > > active low (DE_LOW). This makes the valid data transfer on each > > horizontal line. > >=20 > > So, add additional bus flags DE_LOW setting via input_bus_flags > > for i.MX8M Mini/Nano platforms. > >=20 > > Reviewed-by: Marek Vasut > > Reviewed-by: Frieder Schrempf > > Suggested-by: Marek Vasut > > Signed-off-by: Jagan Teki > > --- > > Changes for v15, v13: > > - none > > Changes for v12: > > - collect RB from Marek > > Changes for v11: > > - collect RB from Frieder > > Changes for v10, v9: > > - none > > Changes for v8: > > - add DE_LOW for i.MX8M Mini/Nano platforms. > > Changes for v7, v6: > > - none > > Changes for v5: > > - rebased based on updated bridge changes > > Changes for v4 - v1: > > - none > >=20 > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > >=20 > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/= exynos/exynos_drm_dsi.c > > index 796480e4a18b..5d971b607e1a 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > > @@ -1736,6 +1736,10 @@ static const struct component_ops exynos_dsi_com= ponent_ops =3D { > > .unbind =3D exynos_dsi_unbind, > > }; > > =20 > > +static const struct drm_bridge_timings dsim_bridge_timings_de_low =3D { > > + .input_bus_flags =3D DRM_BUS_FLAG_DE_LOW, > > +}; > > + > > static int exynos_dsi_probe(struct platform_device *pdev) > > { > > struct device *dev =3D &pdev->dev; > > @@ -1822,6 +1826,10 @@ static int exynos_dsi_probe(struct platform_devi= ce *pdev) > > dsi->bridge.type =3D DRM_MODE_CONNECTOR_DSI; > > dsi->bridge.pre_enable_prev_first =3D true; > > =20 > > + /* DE_LOW: i.MX8M Mini/Nano LCDIF-DSIM glue logic inverts HS/VS/DE */ > > + if (dsi->plat_data->hw_type =3D=3D DSIM_TYPE_IMX8MM) >=20 > That commit isn't bisectable, you add that enum variant in the last > patch so this won't compile. Scratch that, it's defined in the previous patch, sorry Maxime --sskvigagtttvb4bb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZAIMCwAKCRDj7w1vZxhR xZzIAQCd1oDdXVSebyvNY7DnspeAtzLN1G1dQqMtaMpqy+WwQQD/W6k5ib1l/Ld/ DqCDTNQ/1puNAcglDetAATSe6ZJpzQo= =mRrV -----END PGP SIGNATURE----- --sskvigagtttvb4bb--