From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B2DDC7EE32 for ; Fri, 3 Mar 2023 15:08:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231294AbjCCPIO (ORCPT ); Fri, 3 Mar 2023 10:08:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231346AbjCCPIN (ORCPT ); Fri, 3 Mar 2023 10:08:13 -0500 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1ED3149A7 for ; Fri, 3 Mar 2023 07:08:11 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id E82C25C018A; Fri, 3 Mar 2023 10:08:10 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 03 Mar 2023 10:08:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1677856090; x=1677942490; bh=AQ vAWBCpKh+OXyoXHEj1+6yBxi/X10+bIJofCu8bNLo=; b=d2URbeiDRmV+cmJyAp XKfMhxrG3lG6/HiWUo+/KEwqdz4bG93R8+ec9ZllE1rUWJ3Lrp3cLQrDbPclTszt 2SKK/hH09jsQeN2umGusP5LeTC13NS6+v36DwHyXuYSW1UUulv/jJLorYo81pmWc m4sQoId2A9/sSesKGCATpDWA0xKKRK5MPbx9BZf0WQZPIOspDarhEunsqYBGsA4V 6K1wAw3vbFm/y/TMZoxIvADcjfSKrIljB46P6iqMy554fY0D4FgFvtyOA1hvaEeh HIKr8DFlXryoOPeDLsIK4JBd9ix+32Zd6tJ6ZqZIxd9B2b9jvx/N9DYP9VndSEpr rDVQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1677856090; x=1677942490; bh=AQvAWBCpKh+OX yoXHEj1+6yBxi/X10+bIJofCu8bNLo=; b=hk6IXWe488hM1XU3LlZnlA32K2l2k BH1RSbkRPQpL0c6o/XSWkvgCib2rr+FSsxbdAgFOdtUzjrHi6dXVFB0l3/YBexQv qglCZ8aog+i9iKDaIhtZ0uxtjUhtjJXE9Kcb0Dnu79P8ihM0wwycgsT/92VbcDQP PtYs84vurHQlsynWswzwZqDZ7YEX7oe1SA905ZL0nIaVGcMVOW+P0Ykdug6JyZhy Vf6SRpsdggi9ncwlrkKxr861qOwQiuy1ZX/Fvgi1+otu+js+DWybQ892Wjl72ZNP iuz6Zty8gmaIkLEDcgUZYcGjoGRuXPdBJhxwQWo7bqtRPey99OWT2XmPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudelledgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeetfefffefgkedtfefgledugfdtjeefjedvtddtkeetieffjedvgfehheff hfevudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Mar 2023 10:08:08 -0500 (EST) Date: Fri, 3 Mar 2023 16:08:07 +0100 From: Maxime Ripard To: Jagan Teki Cc: Andrzej Hajda , Inki Dae , Marek Szyprowski , Neil Armstrong , Marek Vasut , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Tim Harvey , Adam Ford , Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-amarula Subject: Re: [PATCH v15 12/16] drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge Message-ID: <20230303150807.4hhpjinuac6uyj3p@houat> References: <20230303145138.29233-1-jagan@amarulasolutions.com> <20230303145138.29233-13-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lyd376o5ks52xdet" Content-Disposition: inline In-Reply-To: <20230303145138.29233-13-jagan@amarulasolutions.com> Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org --lyd376o5ks52xdet Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 03, 2023 at 08:21:34PM +0530, Jagan Teki wrote: > +static int samsung_dsim_host_detach(struct mipi_dsi_host *host, > + struct mipi_dsi_device *device) > +{ > + struct samsung_dsim *dsi = host_to_dsi(host); > + const struct samsung_dsim_plat_data *pdata = dsi->plat_data; > + > + if (dsi->out_bridge->funcs->detach) > + dsi->out_bridge->funcs->detach(dsi->out_bridge); You should never call into the bridge ops directly. If there's an issue in the helpers somewhere else, fix that instead. Maxime --lyd376o5ks52xdet Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZAINVwAKCRDj7w1vZxhR xRHKAP9x8Qms3QfdWfBYHyfguem/IEU+Bpet7iyp2d5df7LJmQD8CM6pXlSWcIkt 6lb7wlxZKEOwCaQX70n6278IFKKgEQk= =oyIt -----END PGP SIGNATURE----- --lyd376o5ks52xdet-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7882C7EE2F for ; Fri, 3 Mar 2023 15:08:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9EF5C10E67D; Fri, 3 Mar 2023 15:08:13 +0000 (UTC) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id A76B910E67D for ; Fri, 3 Mar 2023 15:08:11 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id E82C25C018A; Fri, 3 Mar 2023 10:08:10 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 03 Mar 2023 10:08:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1677856090; x=1677942490; bh=AQ vAWBCpKh+OXyoXHEj1+6yBxi/X10+bIJofCu8bNLo=; b=d2URbeiDRmV+cmJyAp XKfMhxrG3lG6/HiWUo+/KEwqdz4bG93R8+ec9ZllE1rUWJ3Lrp3cLQrDbPclTszt 2SKK/hH09jsQeN2umGusP5LeTC13NS6+v36DwHyXuYSW1UUulv/jJLorYo81pmWc m4sQoId2A9/sSesKGCATpDWA0xKKRK5MPbx9BZf0WQZPIOspDarhEunsqYBGsA4V 6K1wAw3vbFm/y/TMZoxIvADcjfSKrIljB46P6iqMy554fY0D4FgFvtyOA1hvaEeh HIKr8DFlXryoOPeDLsIK4JBd9ix+32Zd6tJ6ZqZIxd9B2b9jvx/N9DYP9VndSEpr rDVQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1677856090; x=1677942490; bh=AQvAWBCpKh+OX yoXHEj1+6yBxi/X10+bIJofCu8bNLo=; b=hk6IXWe488hM1XU3LlZnlA32K2l2k BH1RSbkRPQpL0c6o/XSWkvgCib2rr+FSsxbdAgFOdtUzjrHi6dXVFB0l3/YBexQv qglCZ8aog+i9iKDaIhtZ0uxtjUhtjJXE9Kcb0Dnu79P8ihM0wwycgsT/92VbcDQP PtYs84vurHQlsynWswzwZqDZ7YEX7oe1SA905ZL0nIaVGcMVOW+P0Ykdug6JyZhy Vf6SRpsdggi9ncwlrkKxr861qOwQiuy1ZX/Fvgi1+otu+js+DWybQ892Wjl72ZNP iuz6Zty8gmaIkLEDcgUZYcGjoGRuXPdBJhxwQWo7bqtRPey99OWT2XmPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudelledgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeetfefffefgkedtfefgledugfdtjeefjedvtddtkeetieffjedvgfehheff hfevudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Mar 2023 10:08:08 -0500 (EST) Date: Fri, 3 Mar 2023 16:08:07 +0100 From: Maxime Ripard To: Jagan Teki Subject: Re: [PATCH v15 12/16] drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge Message-ID: <20230303150807.4hhpjinuac6uyj3p@houat> References: <20230303145138.29233-1-jagan@amarulasolutions.com> <20230303145138.29233-13-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lyd376o5ks52xdet" Content-Disposition: inline In-Reply-To: <20230303145138.29233-13-jagan@amarulasolutions.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Neil Armstrong , linux-samsung-soc@vger.kernel.org, Matteo Lisi , linux-amarula , Seung-Woo Kim , Frieder Schrempf , Kyungmin Park , dri-devel@lists.freedesktop.org, Andrzej Hajda , Adam Ford , Marek Szyprowski Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --lyd376o5ks52xdet Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 03, 2023 at 08:21:34PM +0530, Jagan Teki wrote: > +static int samsung_dsim_host_detach(struct mipi_dsi_host *host, > + struct mipi_dsi_device *device) > +{ > + struct samsung_dsim *dsi = host_to_dsi(host); > + const struct samsung_dsim_plat_data *pdata = dsi->plat_data; > + > + if (dsi->out_bridge->funcs->detach) > + dsi->out_bridge->funcs->detach(dsi->out_bridge); You should never call into the bridge ops directly. If there's an issue in the helpers somewhere else, fix that instead. Maxime --lyd376o5ks52xdet Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZAINVwAKCRDj7w1vZxhR xRHKAP9x8Qms3QfdWfBYHyfguem/IEU+Bpet7iyp2d5df7LJmQD8CM6pXlSWcIkt 6lb7wlxZKEOwCaQX70n6278IFKKgEQk= =oyIt -----END PGP SIGNATURE----- --lyd376o5ks52xdet--