All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-wired-lan] [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable
@ 2023-03-07 18:19 ` Bjorn Helgaas
  0 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: Ajit Khaparde, Chris Snook, Somnath Kotur, Tony Nguyen,
	Manish Chopra, Rahul Verma, Jesse Brandeburg, Yisen Zhuang,
	intel-wired-lan, Veerasenareddy Burru, Martin Habets,
	Mengyuan Lou, Abhijit Ayarekar, Shahed Shaikh, Ariel Elior,
	Jiawen Wu, Bjorn Helgaas, Michael Chan, Salil Mehta,
	GR-Linux-NIC-Dev, Sriharsha Basavapatna, Rasesh Mody, netdev,
	linux-kernel, Edward Cree, Raju Rangoju, Dimitris Michailidis,
	Sudarsana Kalluru

From: Bjorn Helgaas <bhelgaas@google.com>

Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"),
which appeared in v6.0, the PCI core has enabled PCIe error reporting for
all devices during enumeration.

Remove driver code to do this and remove unnecessary includes of
<linux/aer.h> from several other drivers.

Intel folks, sorry that I missed removing the <linux/aer.h> includes in the
first series.


Bjorn Helgaas (28):
  alx: Drop redundant pci_enable_pcie_error_reporting()
  be2net: Drop redundant pci_enable_pcie_error_reporting()
  bnx2: Drop redundant pci_enable_pcie_error_reporting()
  bnx2x: Drop redundant pci_enable_pcie_error_reporting()
  bnxt: Drop redundant pci_enable_pcie_error_reporting()
  cxgb4: Drop redundant pci_enable_pcie_error_reporting()
  net/fungible: Drop redundant pci_enable_pcie_error_reporting()
  net: hns3: remove unnecessary aer.h include
  netxen_nic: Drop redundant pci_enable_pcie_error_reporting()
  octeon_ep: Drop redundant pci_enable_pcie_error_reporting()
  qed: Drop redundant pci_enable_pcie_error_reporting()
  net: qede: Remove unnecessary aer.h include
  qlcnic: Drop redundant pci_enable_pcie_error_reporting()
  qlcnic: Remove unnecessary aer.h include
  sfc: Drop redundant pci_enable_pcie_error_reporting()
  sfc: falcon: Drop redundant pci_enable_pcie_error_reporting()
  sfc/siena: Drop redundant pci_enable_pcie_error_reporting()
  sfc_ef100: Drop redundant pci_disable_pcie_error_reporting()
  net: ngbe: Drop redundant pci_enable_pcie_error_reporting()
  net: txgbe: Drop redundant pci_enable_pcie_error_reporting()
  e1000e: Remove unnecessary aer.h include
  fm10k: Remove unnecessary aer.h include
  i40e: Remove unnecessary aer.h include
  iavf: Remove unnecessary aer.h include
  ice: Remove unnecessary aer.h include
  igb: Remove unnecessary aer.h include
  igc: Remove unnecessary aer.h include
  ixgbe: Remove unnecessary aer.h include

 drivers/net/ethernet/atheros/alx/main.c       |  4 ----
 drivers/net/ethernet/broadcom/bnx2.c          | 21 -------------------
 drivers/net/ethernet/broadcom/bnx2.h          |  1 -
 drivers/net/ethernet/broadcom/bnx2x/bnx2x.h   |  1 -
 .../net/ethernet/broadcom/bnx2x/bnx2x_main.c  | 19 -----------------
 drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  4 ----
 .../net/ethernet/chelsio/cxgb4/cxgb4_main.c   |  4 ----
 drivers/net/ethernet/emulex/benet/be_main.c   |  8 -------
 .../net/ethernet/fungible/funcore/fun_dev.c   |  5 -----
 .../net/ethernet/hisilicon/hns3/hns3_enet.c   |  1 -
 drivers/net/ethernet/intel/e1000e/netdev.c    |  1 -
 drivers/net/ethernet/intel/fm10k/fm10k_pci.c  |  1 -
 drivers/net/ethernet/intel/i40e/i40e.h        |  1 -
 drivers/net/ethernet/intel/iavf/iavf.h        |  1 -
 drivers/net/ethernet/intel/ice/ice.h          |  1 -
 drivers/net/ethernet/intel/igb/igb_main.c     |  1 -
 drivers/net/ethernet/intel/igc/igc_main.c     |  1 -
 drivers/net/ethernet/intel/ixgbe/ixgbe.h      |  1 -
 .../ethernet/marvell/octeon_ep/octep_main.c   |  4 ----
 .../ethernet/qlogic/netxen/netxen_nic_main.c  | 10 +--------
 drivers/net/ethernet/qlogic/qed/qed_main.c    |  9 --------
 drivers/net/ethernet/qlogic/qede/qede_main.c  |  1 -
 .../ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c   |  1 -
 .../net/ethernet/qlogic/qlcnic/qlcnic_main.c  |  4 ----
 .../net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c |  1 -
 drivers/net/ethernet/sfc/ef100.c              |  3 ---
 drivers/net/ethernet/sfc/efx.c                |  5 -----
 drivers/net/ethernet/sfc/falcon/efx.c         |  9 --------
 drivers/net/ethernet/sfc/siena/efx.c          |  5 -----
 drivers/net/ethernet/wangxun/ngbe/ngbe_main.c |  4 ----
 .../net/ethernet/wangxun/txgbe/txgbe_main.c   |  5 -----
 31 files changed, 1 insertion(+), 136 deletions(-)

-- 
2.25.1

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

^ permalink raw reply	[flat|nested] 44+ messages in thread
* [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable
@ 2023-03-07 18:19 ` Bjorn Helgaas
  0 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Abhijit Ayarekar,
	Ajit Khaparde, Ariel Elior, Chris Snook, Dimitris Michailidis,
	Edward Cree, Jesse Brandeburg, Jiawen Wu, Manish Chopra,
	Martin Habets, Mengyuan Lou, Michael Chan, Rahul Verma,
	Raju Rangoju, Rasesh Mody, Salil Mehta, Shahed Shaikh,
	Somnath Kotur, Sriharsha Basavapatna, Sudarsana Kalluru,
	Tony Nguyen, Veerasenareddy Burru, Yisen Zhuang,
	GR-Linux-NIC-Dev, intel-wired-lan

From: Bjorn Helgaas <bhelgaas@google.com>

Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"),
which appeared in v6.0, the PCI core has enabled PCIe error reporting for
all devices during enumeration.

Remove driver code to do this and remove unnecessary includes of
<linux/aer.h> from several other drivers.

Intel folks, sorry that I missed removing the <linux/aer.h> includes in the
first series.


Bjorn Helgaas (28):
  alx: Drop redundant pci_enable_pcie_error_reporting()
  be2net: Drop redundant pci_enable_pcie_error_reporting()
  bnx2: Drop redundant pci_enable_pcie_error_reporting()
  bnx2x: Drop redundant pci_enable_pcie_error_reporting()
  bnxt: Drop redundant pci_enable_pcie_error_reporting()
  cxgb4: Drop redundant pci_enable_pcie_error_reporting()
  net/fungible: Drop redundant pci_enable_pcie_error_reporting()
  net: hns3: remove unnecessary aer.h include
  netxen_nic: Drop redundant pci_enable_pcie_error_reporting()
  octeon_ep: Drop redundant pci_enable_pcie_error_reporting()
  qed: Drop redundant pci_enable_pcie_error_reporting()
  net: qede: Remove unnecessary aer.h include
  qlcnic: Drop redundant pci_enable_pcie_error_reporting()
  qlcnic: Remove unnecessary aer.h include
  sfc: Drop redundant pci_enable_pcie_error_reporting()
  sfc: falcon: Drop redundant pci_enable_pcie_error_reporting()
  sfc/siena: Drop redundant pci_enable_pcie_error_reporting()
  sfc_ef100: Drop redundant pci_disable_pcie_error_reporting()
  net: ngbe: Drop redundant pci_enable_pcie_error_reporting()
  net: txgbe: Drop redundant pci_enable_pcie_error_reporting()
  e1000e: Remove unnecessary aer.h include
  fm10k: Remove unnecessary aer.h include
  i40e: Remove unnecessary aer.h include
  iavf: Remove unnecessary aer.h include
  ice: Remove unnecessary aer.h include
  igb: Remove unnecessary aer.h include
  igc: Remove unnecessary aer.h include
  ixgbe: Remove unnecessary aer.h include

 drivers/net/ethernet/atheros/alx/main.c       |  4 ----
 drivers/net/ethernet/broadcom/bnx2.c          | 21 -------------------
 drivers/net/ethernet/broadcom/bnx2.h          |  1 -
 drivers/net/ethernet/broadcom/bnx2x/bnx2x.h   |  1 -
 .../net/ethernet/broadcom/bnx2x/bnx2x_main.c  | 19 -----------------
 drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  4 ----
 .../net/ethernet/chelsio/cxgb4/cxgb4_main.c   |  4 ----
 drivers/net/ethernet/emulex/benet/be_main.c   |  8 -------
 .../net/ethernet/fungible/funcore/fun_dev.c   |  5 -----
 .../net/ethernet/hisilicon/hns3/hns3_enet.c   |  1 -
 drivers/net/ethernet/intel/e1000e/netdev.c    |  1 -
 drivers/net/ethernet/intel/fm10k/fm10k_pci.c  |  1 -
 drivers/net/ethernet/intel/i40e/i40e.h        |  1 -
 drivers/net/ethernet/intel/iavf/iavf.h        |  1 -
 drivers/net/ethernet/intel/ice/ice.h          |  1 -
 drivers/net/ethernet/intel/igb/igb_main.c     |  1 -
 drivers/net/ethernet/intel/igc/igc_main.c     |  1 -
 drivers/net/ethernet/intel/ixgbe/ixgbe.h      |  1 -
 .../ethernet/marvell/octeon_ep/octep_main.c   |  4 ----
 .../ethernet/qlogic/netxen/netxen_nic_main.c  | 10 +--------
 drivers/net/ethernet/qlogic/qed/qed_main.c    |  9 --------
 drivers/net/ethernet/qlogic/qede/qede_main.c  |  1 -
 .../ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c   |  1 -
 .../net/ethernet/qlogic/qlcnic/qlcnic_main.c  |  4 ----
 .../net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c |  1 -
 drivers/net/ethernet/sfc/ef100.c              |  3 ---
 drivers/net/ethernet/sfc/efx.c                |  5 -----
 drivers/net/ethernet/sfc/falcon/efx.c         |  9 --------
 drivers/net/ethernet/sfc/siena/efx.c          |  5 -----
 drivers/net/ethernet/wangxun/ngbe/ngbe_main.c |  4 ----
 .../net/ethernet/wangxun/txgbe/txgbe_main.c   |  5 -----
 31 files changed, 1 insertion(+), 136 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 44+ messages in thread
* [PATCH 01/28] alx: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Chris Snook

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Chris Snook <chris.snook@gmail.com>
---
 drivers/net/ethernet/atheros/alx/main.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/atheros/alx/main.c b/drivers/net/ethernet/atheros/alx/main.c
index 306393f8eeca..49bb9a8f00e6 100644
--- a/drivers/net/ethernet/atheros/alx/main.c
+++ b/drivers/net/ethernet/atheros/alx/main.c
@@ -39,7 +39,6 @@
 #include <linux/ipv6.h>
 #include <linux/if_vlan.h>
 #include <linux/mdio.h>
-#include <linux/aer.h>
 #include <linux/bitops.h>
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
@@ -1745,7 +1744,6 @@ static int alx_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 		goto out_pci_disable;
 	}
 
-	pci_enable_pcie_error_reporting(pdev);
 	pci_set_master(pdev);
 
 	if (!pdev->pm_cap) {
@@ -1879,7 +1877,6 @@ static int alx_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	free_netdev(netdev);
 out_pci_release:
 	pci_release_mem_regions(pdev);
-	pci_disable_pcie_error_reporting(pdev);
 out_pci_disable:
 	pci_disable_device(pdev);
 	return err;
@@ -1897,7 +1894,6 @@ static void alx_remove(struct pci_dev *pdev)
 	iounmap(hw->hw_addr);
 	pci_release_mem_regions(pdev);
 
-	pci_disable_pcie_error_reporting(pdev);
 	pci_disable_device(pdev);
 
 	mutex_destroy(&alx->mtx);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 02/28] be2net: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
  (?)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Ajit Khaparde,
	Sriharsha Basavapatna, Somnath Kotur

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration,  so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>
---
 drivers/net/ethernet/emulex/benet/be_main.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 46fe3d74e2e9..aed1b622f51f 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -16,7 +16,6 @@
 #include "be.h"
 #include "be_cmds.h"
 #include <asm/div64.h>
-#include <linux/aer.h>
 #include <linux/if_bridge.h>
 #include <net/busy_poll.h>
 #include <net/vxlan.h>
@@ -5726,8 +5725,6 @@ static void be_remove(struct pci_dev *pdev)
 	be_unmap_pci_bars(adapter);
 	be_drv_cleanup(adapter);
 
-	pci_disable_pcie_error_reporting(pdev);
-
 	pci_release_regions(pdev);
 	pci_disable_device(pdev);
 
@@ -5845,10 +5842,6 @@ static int be_probe(struct pci_dev *pdev, const struct pci_device_id *pdev_id)
 		goto free_netdev;
 	}
 
-	status = pci_enable_pcie_error_reporting(pdev);
-	if (!status)
-		dev_info(&pdev->dev, "PCIe error reporting enabled\n");
-
 	status = be_map_pci_bars(adapter);
 	if (status)
 		goto free_netdev;
@@ -5893,7 +5886,6 @@ static int be_probe(struct pci_dev *pdev, const struct pci_device_id *pdev_id)
 unmap_bars:
 	be_unmap_pci_bars(adapter);
 free_netdev:
-	pci_disable_pcie_error_reporting(pdev);
 	free_netdev(netdev);
 rel_reg:
 	pci_release_regions(pdev);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 03/28] bnx2: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (2 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  2023-03-08  0:21   ` Michael Chan
  -1 siblings, 1 reply; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Rasesh Mody,
	GR-Linux-NIC-Dev, Michael Chan

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

cd709aa90648 ("bnx2: Add PCI Advanced Error Reporting support.") added
pci_enable_pcie_error_reporting() for all devices, and c239f279e571 ("bnx2:
Enable AER on PCIE devices only") restricted it to BNX2_CHIP_5709 devices
to avoid an error message when it failed on non-PCIe devices.  The PCI core
only enables PCIe error reporting on PCIe devices, which I assume means
BNX2_CHIP_5709.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Rasesh Mody <rmody@marvell.com>
Cc: GR-Linux-NIC-Dev@marvell.com
Cc: Michael Chan <michael.chan@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnx2.c | 21 ---------------------
 drivers/net/ethernet/broadcom/bnx2.h |  1 -
 2 files changed, 22 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers/net/ethernet/broadcom/bnx2.c
index 9f473854b0f4..a66137b8d1a6 100644
--- a/drivers/net/ethernet/broadcom/bnx2.c
+++ b/drivers/net/ethernet/broadcom/bnx2.c
@@ -48,7 +48,6 @@
 #include <linux/cache.h>
 #include <linux/firmware.h>
 #include <linux/log2.h>
-#include <linux/aer.h>
 #include <linux/crash_dump.h>
 
 #if IS_ENABLED(CONFIG_CNIC)
@@ -8093,7 +8092,6 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev)
 	int rc, i, j;
 	u32 reg;
 	u64 dma_mask, persist_dma_mask;
-	int err;
 
 	SET_NETDEV_DEV(dev, &pdev->dev);
 	bp = netdev_priv(dev);
@@ -8176,12 +8174,6 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev)
 		bp->flags |= BNX2_FLAG_PCIE;
 		if (BNX2_CHIP_REV(bp) == BNX2_CHIP_REV_Ax)
 			bp->flags |= BNX2_FLAG_JUMBO_BROKEN;
-
-		/* AER (Advanced Error Reporting) hooks */
-		err = pci_enable_pcie_error_reporting(pdev);
-		if (!err)
-			bp->flags |= BNX2_FLAG_AER_ENABLED;
-
 	} else {
 		bp->pcix_cap = pci_find_capability(pdev, PCI_CAP_ID_PCIX);
 		if (bp->pcix_cap == 0) {
@@ -8460,11 +8452,6 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev)
 	return 0;
 
 err_out_unmap:
-	if (bp->flags & BNX2_FLAG_AER_ENABLED) {
-		pci_disable_pcie_error_reporting(pdev);
-		bp->flags &= ~BNX2_FLAG_AER_ENABLED;
-	}
-
 	pci_iounmap(pdev, bp->regview);
 	bp->regview = NULL;
 
@@ -8638,11 +8625,6 @@ bnx2_remove_one(struct pci_dev *pdev)
 	bnx2_free_stats_blk(dev);
 	kfree(bp->temp_stats_blk);
 
-	if (bp->flags & BNX2_FLAG_AER_ENABLED) {
-		pci_disable_pcie_error_reporting(pdev);
-		bp->flags &= ~BNX2_FLAG_AER_ENABLED;
-	}
-
 	bnx2_release_firmware(bp);
 
 	free_netdev(dev);
@@ -8766,9 +8748,6 @@ static pci_ers_result_t bnx2_io_slot_reset(struct pci_dev *pdev)
 	}
 	rtnl_unlock();
 
-	if (!(bp->flags & BNX2_FLAG_AER_ENABLED))
-		return result;
-
 	return result;
 }
 
diff --git a/drivers/net/ethernet/broadcom/bnx2.h b/drivers/net/ethernet/broadcom/bnx2.h
index a09ec47461c9..315b08c64edd 100644
--- a/drivers/net/ethernet/broadcom/bnx2.h
+++ b/drivers/net/ethernet/broadcom/bnx2.h
@@ -6808,7 +6808,6 @@ struct bnx2 {
 #define BNX2_FLAG_JUMBO_BROKEN		0x00000800
 #define BNX2_FLAG_CAN_KEEP_VLAN		0x00001000
 #define BNX2_FLAG_BROKEN_STATS		0x00002000
-#define BNX2_FLAG_AER_ENABLED		0x00004000
 
 	struct bnx2_napi	bnx2_napi[BNX2_MAX_MSIX_VEC];
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 04/28] bnx2x: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (3 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Ariel Elior,
	Sudarsana Kalluru, Manish Chopra

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Ariel Elior <aelior@marvell.com>
Cc: Sudarsana Kalluru <skalluru@marvell.com>
Cc: Manish Chopra <manishc@marvell.com>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x.h   |  1 -
 .../net/ethernet/broadcom/bnx2x/bnx2x_main.c  | 19 -------------------
 2 files changed, 20 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
index dd5945c4bfec..8bcde0a6e011 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
@@ -1486,7 +1486,6 @@ struct bnx2x {
 #define IS_VF_FLAG			(1 << 22)
 #define BC_SUPPORTS_RMMOD_CMD		(1 << 23)
 #define HAS_PHYS_PORT_ID		(1 << 24)
-#define AER_ENABLED			(1 << 25)
 #define PTP_SUPPORTED			(1 << 26)
 #define TX_TIMESTAMPING_EN		(1 << 27)
 
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 5d1e4fe335aa..3bb5ea570c87 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -29,7 +29,6 @@
 #include <linux/slab.h>
 #include <linux/interrupt.h>
 #include <linux/pci.h>
-#include <linux/aer.h>
 #include <linux/init.h>
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
@@ -13037,14 +13036,6 @@ static const struct net_device_ops bnx2x_netdev_ops = {
 	.ndo_features_check	= bnx2x_features_check,
 };
 
-static void bnx2x_disable_pcie_error_reporting(struct bnx2x *bp)
-{
-	if (bp->flags & AER_ENABLED) {
-		pci_disable_pcie_error_reporting(bp->pdev);
-		bp->flags &= ~AER_ENABLED;
-	}
-}
-
 static int bnx2x_init_dev(struct bnx2x *bp, struct pci_dev *pdev,
 			  struct net_device *dev, unsigned long board_type)
 {
@@ -13157,13 +13148,6 @@ static int bnx2x_init_dev(struct bnx2x *bp, struct pci_dev *pdev,
 	/* Set PCIe reset type to fundamental for EEH recovery */
 	pdev->needs_freset = 1;
 
-	/* AER (Advanced Error reporting) configuration */
-	rc = pci_enable_pcie_error_reporting(pdev);
-	if (!rc)
-		bp->flags |= AER_ENABLED;
-	else
-		BNX2X_DEV_INFO("Failed To configure PCIe AER [%d]\n", rc);
-
 	/*
 	 * Clean the following indirect addresses for all functions since it
 	 * is not used by the driver.
@@ -14020,8 +14004,6 @@ static int bnx2x_init_one(struct pci_dev *pdev,
 	bnx2x_free_mem_bp(bp);
 
 init_one_exit:
-	bnx2x_disable_pcie_error_reporting(bp);
-
 	if (bp->regview)
 		iounmap(bp->regview);
 
@@ -14102,7 +14084,6 @@ static void __bnx2x_remove(struct pci_dev *pdev,
 		pci_set_power_state(pdev, PCI_D3hot);
 	}
 
-	bnx2x_disable_pcie_error_reporting(bp);
 	if (remove_netdev) {
 		if (bp->regview)
 			iounmap(bp->regview);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 05/28] bnxt: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (4 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  2023-03-08  0:23   ` Michael Chan
  -1 siblings, 1 reply; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Michael Chan

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Michael Chan <michael.chan@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 5d4b1f2ebeac..7245fee13ad0 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -48,7 +48,6 @@
 #include <linux/prefetch.h>
 #include <linux/cache.h>
 #include <linux/log2.h>
-#include <linux/aer.h>
 #include <linux/bitmap.h>
 #include <linux/cpu_rmap.h>
 #include <linux/cpumask.h>
@@ -12706,8 +12705,6 @@ static int bnxt_init_board(struct pci_dev *pdev, struct net_device *dev)
 		goto init_err_release;
 	}
 
-	pci_enable_pcie_error_reporting(pdev);
-
 	INIT_WORK(&bp->sp_task, bnxt_sp_task);
 	INIT_DELAYED_WORK(&bp->fw_reset_task, bnxt_fw_reset_task);
 
@@ -13187,7 +13184,6 @@ static void bnxt_remove_one(struct pci_dev *pdev)
 	bnxt_rdma_aux_device_uninit(bp);
 
 	bnxt_ptp_clear(bp);
-	pci_disable_pcie_error_reporting(pdev);
 	unregister_netdev(dev);
 	clear_bit(BNXT_STATE_IN_FW_RESET, &bp->state);
 	/* Flush any pending tasks */
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 06/28] cxgb4: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (5 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Raju Rangoju

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Raju Rangoju <rajur@chelsio.com>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
index 7db2403c4c9c..f0bc7396ce2b 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
@@ -51,7 +51,6 @@
 #include <linux/mutex.h>
 #include <linux/netdevice.h>
 #include <linux/pci.h>
-#include <linux/aer.h>
 #include <linux/rtnetlink.h>
 #include <linux/sched.h>
 #include <linux/seq_file.h>
@@ -6687,7 +6686,6 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 		goto out_free_adapter;
 	}
 
-	pci_enable_pcie_error_reporting(pdev);
 	pci_set_master(pdev);
 	pci_save_state(pdev);
 	adap_idx++;
@@ -7092,7 +7090,6 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
  out_unmap_bar0:
 	iounmap(regs);
  out_disable_device:
-	pci_disable_pcie_error_reporting(pdev);
 	pci_disable_device(pdev);
  out_release_regions:
 	pci_release_regions(pdev);
@@ -7171,7 +7168,6 @@ static void remove_one(struct pci_dev *pdev)
 	}
 #endif
 	iounmap(adapter->regs);
-	pci_disable_pcie_error_reporting(pdev);
 	if ((adapter->flags & CXGB4_DEV_ENABLED)) {
 		pci_disable_device(pdev);
 		adapter->flags &= ~CXGB4_DEV_ENABLED;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 07/28] net/fungible: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (6 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  2023-03-07 19:17   ` Dimitris Michailidis
  -1 siblings, 1 reply; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Dimitris Michailidis

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Dimitris Michailidis <dmichail@fungible.com>
---
 drivers/net/ethernet/fungible/funcore/fun_dev.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/fungible/funcore/fun_dev.c b/drivers/net/ethernet/fungible/funcore/fun_dev.c
index fb5120d90f26..3680f83feba2 100644
--- a/drivers/net/ethernet/fungible/funcore/fun_dev.c
+++ b/drivers/net/ethernet/fungible/funcore/fun_dev.c
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
 
-#include <linux/aer.h>
 #include <linux/bitmap.h>
 #include <linux/delay.h>
 #include <linux/interrupt.h>
@@ -748,7 +747,6 @@ void fun_dev_disable(struct fun_dev *fdev)
 	pci_free_irq_vectors(pdev);
 
 	pci_clear_master(pdev);
-	pci_disable_pcie_error_reporting(pdev);
 	pci_disable_device(pdev);
 
 	fun_unmap_bars(fdev);
@@ -781,8 +779,6 @@ int fun_dev_enable(struct fun_dev *fdev, struct pci_dev *pdev,
 		goto unmap;
 	}
 
-	pci_enable_pcie_error_reporting(pdev);
-
 	rc = sanitize_dev(fdev);
 	if (rc)
 		goto disable_dev;
@@ -830,7 +826,6 @@ int fun_dev_enable(struct fun_dev *fdev, struct pci_dev *pdev,
 free_irqs:
 	pci_free_irq_vectors(pdev);
 disable_dev:
-	pci_disable_pcie_error_reporting(pdev);
 	pci_disable_device(pdev);
 unmap:
 	fun_unmap_bars(fdev);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 08/28] net: hns3: remove unnecessary aer.h include
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (7 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Yisen Zhuang, Salil Mehta

From: Bjorn Helgaas <bhelgaas@google.com>

<linux/aer.h> is unused, so remove it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
Cc: Salil Mehta <salil.mehta@huawei.com>
---
 drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index 25be7f8ac7cd..5caea154362f 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -13,7 +13,6 @@
 #include <linux/ipv6.h>
 #include <linux/module.h>
 #include <linux/pci.h>
-#include <linux/aer.h>
 #include <linux/skbuff.h>
 #include <linux/sctp.h>
 #include <net/gre.h>
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 09/28] netxen_nic: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (8 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Manish Chopra, Rahul Verma,
	GR-Linux-NIC-Dev

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Also note that the driver only called these for NX_IS_REVISION_P3 devices,
so since f26e58bf6f54, error reporting has been enabled for devices other
than NX_IS_REVISION_P3.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Manish Chopra <manishc@marvell.com>
Cc: Rahul Verma <rahulv@marvell.com>
Cc: GR-Linux-NIC-Dev@marvell.com
---
 drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
index de8d54b23f73..59d0dd862fd1 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
@@ -18,7 +18,6 @@
 #include <linux/ipv6.h>
 #include <linux/inetdevice.h>
 #include <linux/sysfs.h>
-#include <linux/aer.h>
 
 MODULE_DESCRIPTION("QLogic/NetXen (1/10) GbE Intelligent Ethernet Driver");
 MODULE_LICENSE("GPL");
@@ -1464,9 +1463,6 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if ((err = pci_request_regions(pdev, netxen_nic_driver_name)))
 		goto err_out_disable_pdev;
 
-	if (NX_IS_REVISION_P3(pdev->revision))
-		pci_enable_pcie_error_reporting(pdev);
-
 	pci_set_master(pdev);
 
 	netdev = alloc_etherdev(sizeof(struct netxen_adapter));
@@ -1603,8 +1599,6 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	free_netdev(netdev);
 
 err_out_free_res:
-	if (NX_IS_REVISION_P3(pdev->revision))
-		pci_disable_pcie_error_reporting(pdev);
 	pci_release_regions(pdev);
 
 err_out_disable_pdev:
@@ -1659,10 +1653,8 @@ static void netxen_nic_remove(struct pci_dev *pdev)
 
 	netxen_release_firmware(adapter);
 
-	if (NX_IS_REVISION_P3(pdev->revision)) {
+	if (NX_IS_REVISION_P3(pdev->revision))
 		netxen_cleanup_minidump(adapter);
-		pci_disable_pcie_error_reporting(pdev);
-	}
 
 	pci_release_regions(pdev);
 	pci_disable_device(pdev);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 10/28] octeon_ep: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (9 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Veerasenareddy Burru,
	Abhijit Ayarekar

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Veerasenareddy Burru <vburru@marvell.com>
Cc: Abhijit Ayarekar <aayarekar@marvell.com>
---
 drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
index 5a898fb88e37..fdce78ceea87 100644
--- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
+++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
@@ -8,7 +8,6 @@
 #include <linux/types.h>
 #include <linux/module.h>
 #include <linux/pci.h>
-#include <linux/aer.h>
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
 #include <linux/rtnetlink.h>
@@ -1050,7 +1049,6 @@ static int octep_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 		goto err_pci_regions;
 	}
 
-	pci_enable_pcie_error_reporting(pdev);
 	pci_set_master(pdev);
 
 	netdev = alloc_etherdev_mq(sizeof(struct octep_device),
@@ -1106,7 +1104,6 @@ static int octep_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 err_octep_config:
 	free_netdev(netdev);
 err_alloc_netdev:
-	pci_disable_pcie_error_reporting(pdev);
 	pci_release_mem_regions(pdev);
 err_pci_regions:
 err_dma_mask:
@@ -1139,7 +1136,6 @@ static void octep_remove(struct pci_dev *pdev)
 	octep_device_cleanup(oct);
 	pci_release_mem_regions(pdev);
 	free_netdev(netdev);
-	pci_disable_pcie_error_reporting(pdev);
 	pci_disable_device(pdev);
 }
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 11/28] qed: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (10 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Ariel Elior, Manish Chopra

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Ariel Elior <aelior@marvell.com>
Cc: Manish Chopra <manishc@marvell.com>
---
 drivers/net/ethernet/qlogic/qed/qed_main.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c
index c91898be7c03..f5af83342856 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_main.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
@@ -23,7 +23,6 @@
 #include <linux/qed/qed_if.h>
 #include <linux/qed/qed_ll2_if.h>
 #include <net/devlink.h>
-#include <linux/aer.h>
 #include <linux/phylink.h>
 
 #include "qed.h"
@@ -259,8 +258,6 @@ static void qed_free_pci(struct qed_dev *cdev)
 {
 	struct pci_dev *pdev = cdev->pdev;
 
-	pci_disable_pcie_error_reporting(pdev);
-
 	if (cdev->doorbells && cdev->db_size)
 		iounmap(cdev->doorbells);
 	if (cdev->regview)
@@ -366,12 +363,6 @@ static int qed_init_pci(struct qed_dev *cdev, struct pci_dev *pdev)
 		return -ENOMEM;
 	}
 
-	/* AER (Advanced Error reporting) configuration */
-	rc = pci_enable_pcie_error_reporting(pdev);
-	if (rc)
-		DP_VERBOSE(cdev, NETIF_MSG_DRV,
-			   "Failed to configure PCIe AER [%d]\n", rc);
-
 	return 0;
 
 err2:
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 12/28] net: qede: Remove unnecessary aer.h include
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (11 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Ariel Elior, Manish Chopra

From: Bjorn Helgaas <bhelgaas@google.com>

<linux/aer.h> is unused, so remove it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Ariel Elior <aelior@marvell.com>
Cc: Manish Chopra <manishc@marvell.com>
---
 drivers/net/ethernet/qlogic/qede/qede_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
index 261f982ca40d..4c6c685820e3 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_main.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
@@ -35,7 +35,6 @@
 #include <net/ip6_checksum.h>
 #include <linux/bitops.h>
 #include <linux/vmalloc.h>
-#include <linux/aer.h>
 #include "qede.h"
 #include "qede_ptp.h"
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 13/28] qlcnic: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (12 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Shahed Shaikh,
	Manish Chopra, GR-Linux-NIC-Dev

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Shahed Shaikh <shshaikh@marvell.com>
Cc: Manish Chopra <manishc@marvell.com>
Cc: GR-Linux-NIC-Dev@marvell.com
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c  | 4 ----
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 1 -
 2 files changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index 44dac3c0908e..90df4a0909fa 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -12,7 +12,6 @@
 #include <net/ip.h>
 #include <linux/ipv6.h>
 #include <linux/inetdevice.h>
-#include <linux/aer.h>
 #include <linux/log2.h>
 #include <linux/pci.h>
 #include <net/vxlan.h>
@@ -2445,7 +2444,6 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 		goto err_out_disable_pdev;
 
 	pci_set_master(pdev);
-	pci_enable_pcie_error_reporting(pdev);
 
 	ahw = kzalloc(sizeof(struct qlcnic_hardware_context), GFP_KERNEL);
 	if (!ahw) {
@@ -2675,7 +2673,6 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	kfree(ahw);
 
 err_out_free_res:
-	pci_disable_pcie_error_reporting(pdev);
 	pci_release_regions(pdev);
 
 err_out_disable_pdev:
@@ -2757,7 +2754,6 @@ static void qlcnic_remove(struct pci_dev *pdev)
 
 	qlcnic_release_firmware(adapter);
 
-	pci_disable_pcie_error_reporting(pdev);
 	pci_release_regions(pdev);
 	pci_disable_device(pdev);
 
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
index 5c2edb715d3e..74125188beb8 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
@@ -12,7 +12,6 @@
 #include <linux/ipv6.h>
 #include <linux/inetdevice.h>
 #include <linux/sysfs.h>
-#include <linux/aer.h>
 #include <linux/log2.h>
 #ifdef CONFIG_QLCNIC_HWMON
 #include <linux/hwmon.h>
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 14/28] qlcnic: Remove unnecessary aer.h include
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (13 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Shahed Shaikh,
	Manish Chopra, GR-Linux-NIC-Dev

From: Bjorn Helgaas <bhelgaas@google.com>

<linux/aer.h> is unused, so remove it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Shahed Shaikh <shshaikh@marvell.com>
Cc: Manish Chopra <manishc@marvell.com>
Cc: GR-Linux-NIC-Dev@marvell.com
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
index 2fd5c6fdb500..bcef8ab715bf 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
@@ -8,7 +8,6 @@
 #include <linux/ipv6.h>
 #include <linux/ethtool.h>
 #include <linux/interrupt.h>
-#include <linux/aer.h>
 
 #include "qlcnic.h"
 #include "qlcnic_sriov.h"
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 15/28] sfc: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (14 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  2023-03-08 16:11   ` Edward Cree
  -1 siblings, 1 reply; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Edward Cree, Martin Habets

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>
Cc: Martin Habets <habetsm.xilinx@gmail.com>
---
 drivers/net/ethernet/sfc/efx.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 02c2adeb0a12..92c390ec4735 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -18,7 +18,6 @@
 #include <linux/ethtool.h>
 #include <linux/topology.h>
 #include <linux/gfp.h>
-#include <linux/aer.h>
 #include <linux/interrupt.h>
 #include "net_driver.h"
 #include <net/gre.h>
@@ -892,8 +891,6 @@ static void efx_pci_remove(struct pci_dev *pci_dev)
 	free_netdev(efx->net_dev);
 	probe_data = container_of(efx, struct efx_probe_data, efx);
 	kfree(probe_data);
-
-	pci_disable_pcie_error_reporting(pci_dev);
 };
 
 /* NIC VPD information
@@ -1126,8 +1123,6 @@ static int efx_pci_probe(struct pci_dev *pci_dev,
 		netif_warn(efx, probe, efx->net_dev,
 			   "failed to create MTDs (%d)\n", rc);
 
-	(void)pci_enable_pcie_error_reporting(pci_dev);
-
 	if (efx->type->udp_tnl_push_ports)
 		efx->type->udp_tnl_push_ports(efx);
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 16/28] sfc: falcon: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (15 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  2023-03-08 16:12   ` Edward Cree
  -1 siblings, 1 reply; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Edward Cree, Martin Habets

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>
Cc: Martin Habets <habetsm.xilinx@gmail.com>
---
 drivers/net/ethernet/sfc/falcon/efx.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/net/ethernet/sfc/falcon/efx.c b/drivers/net/ethernet/sfc/falcon/efx.c
index e151b0957751..e001f27085c6 100644
--- a/drivers/net/ethernet/sfc/falcon/efx.c
+++ b/drivers/net/ethernet/sfc/falcon/efx.c
@@ -17,7 +17,6 @@
 #include <linux/ethtool.h>
 #include <linux/topology.h>
 #include <linux/gfp.h>
-#include <linux/aer.h>
 #include <linux/interrupt.h>
 #include "net_driver.h"
 #include "efx.h"
@@ -2765,8 +2764,6 @@ static void ef4_pci_remove(struct pci_dev *pci_dev)
 
 	ef4_fini_struct(efx);
 	free_netdev(efx->net_dev);
-
-	pci_disable_pcie_error_reporting(pci_dev);
 };
 
 /* NIC VPD information
@@ -2927,12 +2924,6 @@ static int ef4_pci_probe(struct pci_dev *pci_dev,
 		netif_warn(efx, probe, efx->net_dev,
 			   "failed to create MTDs (%d)\n", rc);
 
-	rc = pci_enable_pcie_error_reporting(pci_dev);
-	if (rc && rc != -EINVAL)
-		netif_notice(efx, probe, efx->net_dev,
-			     "PCIE error reporting unavailable (%d).\n",
-			     rc);
-
 	return 0;
 
  fail4:
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 17/28] sfc/siena: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (16 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  2023-03-08 16:12   ` Edward Cree
  -1 siblings, 1 reply; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Edward Cree, Martin Habets

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>
Cc: Martin Habets <habetsm.xilinx@gmail.com>
---
 drivers/net/ethernet/sfc/siena/efx.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/sfc/siena/efx.c b/drivers/net/ethernet/sfc/siena/efx.c
index ef52ec71d197..8c557f6a183c 100644
--- a/drivers/net/ethernet/sfc/siena/efx.c
+++ b/drivers/net/ethernet/sfc/siena/efx.c
@@ -18,7 +18,6 @@
 #include <linux/ethtool.h>
 #include <linux/topology.h>
 #include <linux/gfp.h>
-#include <linux/aer.h>
 #include <linux/interrupt.h>
 #include "net_driver.h"
 #include <net/gre.h>
@@ -874,8 +873,6 @@ static void efx_pci_remove(struct pci_dev *pci_dev)
 
 	efx_siena_fini_struct(efx);
 	free_netdev(efx->net_dev);
-
-	pci_disable_pcie_error_reporting(pci_dev);
 };
 
 /* NIC VPD information
@@ -1094,8 +1091,6 @@ static int efx_pci_probe(struct pci_dev *pci_dev,
 		netif_warn(efx, probe, efx->net_dev,
 			   "failed to create MTDs (%d)\n", rc);
 
-	(void)pci_enable_pcie_error_reporting(pci_dev);
-
 	if (efx->type->udp_tnl_push_ports)
 		efx->type->udp_tnl_push_ports(efx);
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 18/28] sfc_ef100: Drop redundant pci_disable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (17 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  2023-03-08 16:16   ` Edward Cree
  -1 siblings, 1 reply; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Edward Cree, Martin Habets

From: Bjorn Helgaas <bhelgaas@google.com>

51b35a454efd ("sfc: skeleton EF100 PF driver") added a call to
pci_disable_pcie_error_reporting() in ef100_pci_remove().

Remove this call since there's no apparent reason to disable error
reporting when it was not previously enabled.

Note that since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core enables PCIe error reporting for all devices during
enumeration, so the driver doesn't need to do it itself.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>
Cc: Martin Habets <habetsm.xilinx@gmail.com>
---
 drivers/net/ethernet/sfc/ef100.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/sfc/ef100.c b/drivers/net/ethernet/sfc/ef100.c
index 71aab3d0480f..6334992b0af4 100644
--- a/drivers/net/ethernet/sfc/ef100.c
+++ b/drivers/net/ethernet/sfc/ef100.c
@@ -11,7 +11,6 @@
 
 #include "net_driver.h"
 #include <linux/module.h>
-#include <linux/aer.h>
 #include "efx_common.h"
 #include "efx_channels.h"
 #include "io.h"
@@ -440,8 +439,6 @@ static void ef100_pci_remove(struct pci_dev *pci_dev)
 
 	pci_dbg(pci_dev, "shutdown successful\n");
 
-	pci_disable_pcie_error_reporting(pci_dev);
-
 	pci_set_drvdata(pci_dev, NULL);
 	efx_fini_struct(efx);
 	kfree(probe_data);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 19/28] net: ngbe: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (18 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Jiawen Wu, Mengyuan Lou

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: Mengyuan Lou <mengyuanlou@net-swift.com>
---
 drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
index 5b564d348c09..0e4163e1106f 100644
--- a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
+++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
@@ -6,7 +6,6 @@
 #include <linux/pci.h>
 #include <linux/netdevice.h>
 #include <linux/string.h>
-#include <linux/aer.h>
 #include <linux/etherdevice.h>
 #include <net/ip.h>
 #include <linux/phy.h>
@@ -520,7 +519,6 @@ static int ngbe_probe(struct pci_dev *pdev,
 		goto err_pci_disable_dev;
 	}
 
-	pci_enable_pcie_error_reporting(pdev);
 	pci_set_master(pdev);
 
 	netdev = devm_alloc_etherdev_mqs(&pdev->dev,
@@ -669,7 +667,6 @@ static int ngbe_probe(struct pci_dev *pdev,
 err_free_mac_table:
 	kfree(wx->mac_table);
 err_pci_release_regions:
-	pci_disable_pcie_error_reporting(pdev);
 	pci_release_selected_regions(pdev,
 				     pci_select_bars(pdev, IORESOURCE_MEM));
 err_pci_disable_dev:
@@ -698,7 +695,6 @@ static void ngbe_remove(struct pci_dev *pdev)
 
 	kfree(wx->mac_table);
 	wx_clear_interrupt_scheme(wx);
-	pci_disable_pcie_error_reporting(pdev);
 
 	pci_disable_device(pdev);
 }
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 20/28] net: txgbe: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (19 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Jiawen Wu, Mengyuan Lou

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: Mengyuan Lou <mengyuanlou@net-swift.com>
---
 drivers/net/ethernet/wangxun/txgbe/txgbe_main.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c
index 6c0a98230557..859feaafd350 100644
--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c
+++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c
@@ -6,7 +6,6 @@
 #include <linux/pci.h>
 #include <linux/netdevice.h>
 #include <linux/string.h>
-#include <linux/aer.h>
 #include <linux/etherdevice.h>
 #include <net/ip.h>
 
@@ -538,7 +537,6 @@ static int txgbe_probe(struct pci_dev *pdev,
 		goto err_pci_disable_dev;
 	}
 
-	pci_enable_pcie_error_reporting(pdev);
 	pci_set_master(pdev);
 
 	netdev = devm_alloc_etherdev_mqs(&pdev->dev,
@@ -698,7 +696,6 @@ static int txgbe_probe(struct pci_dev *pdev,
 err_free_mac_table:
 	kfree(wx->mac_table);
 err_pci_release_regions:
-	pci_disable_pcie_error_reporting(pdev);
 	pci_release_selected_regions(pdev,
 				     pci_select_bars(pdev, IORESOURCE_MEM));
 err_pci_disable_dev:
@@ -729,8 +726,6 @@ static void txgbe_remove(struct pci_dev *pdev)
 	kfree(wx->mac_table);
 	wx_clear_interrupt_scheme(wx);
 
-	pci_disable_pcie_error_reporting(pdev);
-
 	pci_disable_device(pdev);
 }
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [Intel-wired-lan] [PATCH 21/28] e1000e: Remove unnecessary aer.h include
  2023-03-07 18:19 ` Bjorn Helgaas
@ 2023-03-07 18:19   ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Jesse Brandeburg, intel-wired-lan,
	Bjorn Helgaas, Tony Nguyen

From: Bjorn Helgaas <bhelgaas@google.com>

<linux/aer.h> is unused, so remove it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: intel-wired-lan@lists.osuosl.org
---
 drivers/net/ethernet/intel/e1000e/netdev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index e1eb1de88bf9..6f5c16aebcbf 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -23,7 +23,6 @@
 #include <linux/smp.h>
 #include <linux/pm_qos.h>
 #include <linux/pm_runtime.h>
-#include <linux/aer.h>
 #include <linux/prefetch.h>
 #include <linux/suspend.h>
 
-- 
2.25.1

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 21/28] e1000e: Remove unnecessary aer.h include
@ 2023-03-07 18:19   ` Bjorn Helgaas
  0 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Jesse Brandeburg,
	Tony Nguyen, intel-wired-lan

From: Bjorn Helgaas <bhelgaas@google.com>

<linux/aer.h> is unused, so remove it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: intel-wired-lan@lists.osuosl.org
---
 drivers/net/ethernet/intel/e1000e/netdev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index e1eb1de88bf9..6f5c16aebcbf 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -23,7 +23,6 @@
 #include <linux/smp.h>
 #include <linux/pm_qos.h>
 #include <linux/pm_runtime.h>
-#include <linux/aer.h>
 #include <linux/prefetch.h>
 #include <linux/suspend.h>
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 22/28] fm10k: Remove unnecessary aer.h include
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (21 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Jesse Brandeburg, Tony Nguyen

From: Bjorn Helgaas <bhelgaas@google.com>

<linux/aer.h> is unused, so remove it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
index 027d721feb18..d748b98274e7 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
@@ -3,7 +3,6 @@
 
 #include <linux/module.h>
 #include <linux/interrupt.h>
-#include <linux/aer.h>
 
 #include "fm10k.h"
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 23/28] i40e: Remove unnecessary aer.h include
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (22 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Jesse Brandeburg, Tony Nguyen

From: Bjorn Helgaas <bhelgaas@google.com>

<linux/aer.h> is unused, so remove it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h
index 60ce4d15d82a..6e310a539467 100644
--- a/drivers/net/ethernet/intel/i40e/i40e.h
+++ b/drivers/net/ethernet/intel/i40e/i40e.h
@@ -10,7 +10,6 @@
 #include <linux/errno.h>
 #include <linux/module.h>
 #include <linux/pci.h>
-#include <linux/aer.h>
 #include <linux/netdevice.h>
 #include <linux/ioport.h>
 #include <linux/iommu.h>
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 24/28] iavf: Remove unnecessary aer.h include
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (23 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Jesse Brandeburg, Tony Nguyen

From: Bjorn Helgaas <bhelgaas@google.com>

<linux/aer.h> is unused, so remove it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/iavf/iavf.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/iavf/iavf.h b/drivers/net/ethernet/intel/iavf/iavf.h
index 232bc61d9eee..2cdce251472c 100644
--- a/drivers/net/ethernet/intel/iavf/iavf.h
+++ b/drivers/net/ethernet/intel/iavf/iavf.h
@@ -6,7 +6,6 @@
 
 #include <linux/module.h>
 #include <linux/pci.h>
-#include <linux/aer.h>
 #include <linux/netdevice.h>
 #include <linux/vmalloc.h>
 #include <linux/interrupt.h>
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 25/28] ice: Remove unnecessary aer.h include
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (24 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Jesse Brandeburg, Tony Nguyen

From: Bjorn Helgaas <bhelgaas@google.com>

<linux/aer.h> is unused, so remove it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/ice/ice.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h
index b0e29e342401..d79a48d27f1a 100644
--- a/drivers/net/ethernet/intel/ice/ice.h
+++ b/drivers/net/ethernet/intel/ice/ice.h
@@ -20,7 +20,6 @@
 #include <linux/pci.h>
 #include <linux/workqueue.h>
 #include <linux/wait.h>
-#include <linux/aer.h>
 #include <linux/interrupt.h>
 #include <linux/ethtool.h>
 #include <linux/timer.h>
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 26/28] igb: Remove unnecessary aer.h include
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (25 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Jesse Brandeburg, Tony Nguyen

From: Bjorn Helgaas <bhelgaas@google.com>

<linux/aer.h> is unused, so remove it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/igb/igb_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 03bc1e8af575..a2914298dd69 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -28,7 +28,6 @@
 #include <linux/tcp.h>
 #include <linux/sctp.h>
 #include <linux/if_ether.h>
-#include <linux/aer.h>
 #include <linux/prefetch.h>
 #include <linux/bpf.h>
 #include <linux/bpf_trace.h>
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 27/28] igc: Remove unnecessary aer.h include
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (26 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Jesse Brandeburg, Tony Nguyen

From: Bjorn Helgaas <bhelgaas@google.com>

<linux/aer.h> is unused, so remove it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/igc/igc_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 2928a6c73692..d7ee06d28b50 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -4,7 +4,6 @@
 #include <linux/module.h>
 #include <linux/types.h>
 #include <linux/if_vlan.h>
-#include <linux/aer.h>
 #include <linux/tcp.h>
 #include <linux/udp.h>
 #include <linux/ip.h>
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* [PATCH 28/28] ixgbe: Remove unnecessary aer.h include
  2023-03-07 18:19 ` Bjorn Helgaas
                   ` (27 preceding siblings ...)
  (?)
@ 2023-03-07 18:19 ` Bjorn Helgaas
  -1 siblings, 0 replies; 44+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Jesse Brandeburg, Tony Nguyen

From: Bjorn Helgaas <bhelgaas@google.com>

<linux/aer.h> is unused, so remove it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
index 8736ca4b2628..63d4e32df029 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
@@ -9,7 +9,6 @@
 #include <linux/pci.h>
 #include <linux/netdevice.h>
 #include <linux/cpumask.h>
-#include <linux/aer.h>
 #include <linux/if_vlan.h>
 #include <linux/jiffies.h>
 #include <linux/phy.h>
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 44+ messages in thread
* Re: [PATCH 07/28] net/fungible: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` [PATCH 07/28] net/fungible: " Bjorn Helgaas
@ 2023-03-07 19:17   ` Dimitris Michailidis
  0 siblings, 0 replies; 44+ messages in thread
From: Dimitris Michailidis @ 2023-03-07 19:17 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	netdev, linux-kernel, Bjorn Helgaas, Dimitris Michailidis

On Tue, Mar 7, 2023 at 10:20 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration, so the
> driver doesn't need to do it itself.
>
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
>
> Note that this only controls ERR_* Messages from the device.  An ERR_*
> Message may cause the Root Port to generate an interrupt, depending on the
> AER Root Error Command register managed by the AER service driver.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Dimitris Michailidis <dmichail@fungible.com>

Acked-by: Dimitris Michailidis <dmichail@fungible.com>

> ---
>  drivers/net/ethernet/fungible/funcore/fun_dev.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/fungible/funcore/fun_dev.c b/drivers/net/ethernet/fungible/funcore/fun_dev.c
> index fb5120d90f26..3680f83feba2 100644
> --- a/drivers/net/ethernet/fungible/funcore/fun_dev.c
> +++ b/drivers/net/ethernet/fungible/funcore/fun_dev.c
> @@ -1,6 +1,5 @@
>  // SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
>
> -#include <linux/aer.h>
>  #include <linux/bitmap.h>
>  #include <linux/delay.h>
>  #include <linux/interrupt.h>
> @@ -748,7 +747,6 @@ void fun_dev_disable(struct fun_dev *fdev)
>         pci_free_irq_vectors(pdev);
>
>         pci_clear_master(pdev);
> -       pci_disable_pcie_error_reporting(pdev);
>         pci_disable_device(pdev);
>
>         fun_unmap_bars(fdev);
> @@ -781,8 +779,6 @@ int fun_dev_enable(struct fun_dev *fdev, struct pci_dev *pdev,
>                 goto unmap;
>         }
>
> -       pci_enable_pcie_error_reporting(pdev);
> -
>         rc = sanitize_dev(fdev);
>         if (rc)
>                 goto disable_dev;
> @@ -830,7 +826,6 @@ int fun_dev_enable(struct fun_dev *fdev, struct pci_dev *pdev,
>  free_irqs:
>         pci_free_irq_vectors(pdev);
>  disable_dev:
> -       pci_disable_pcie_error_reporting(pdev);
>         pci_disable_device(pdev);
>  unmap:
>         fun_unmap_bars(fdev);
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 44+ messages in thread
* Re: [Intel-wired-lan] [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable
  2023-03-07 18:19 ` Bjorn Helgaas
@ 2023-03-07 19:28   ` Jesse Brandeburg
  -1 siblings, 0 replies; 44+ messages in thread
From: Jesse Brandeburg @ 2023-03-07 19:28 UTC (permalink / raw)
  To: Bjorn Helgaas, David S . Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni
  Cc: Ajit Khaparde, Chris Snook, Somnath Kotur, Tony Nguyen,
	Manish Chopra, Rahul Verma, Yisen Zhuang, intel-wired-lan,
	Veerasenareddy Burru, Martin Habets, Mengyuan Lou,
	Abhijit Ayarekar, Shahed Shaikh, Ariel Elior, Jiawen Wu,
	Bjorn Helgaas, Michael Chan, Salil Mehta, GR-Linux-NIC-Dev,
	Sriharsha Basavapatna, Rasesh Mody, netdev, linux-kernel,
	Edward Cree, Raju Rangoju, Dimitris Michailidis,
	Sudarsana Kalluru

On 3/7/2023 10:19 AM, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"),
> which appeared in v6.0, the PCI core has enabled PCIe error reporting for
> all devices during enumeration.
> 
> Remove driver code to do this and remove unnecessary includes of
> <linux/aer.h> from several other drivers.
> 
> Intel folks, sorry that I missed removing the <linux/aer.h> includes in the
> first series.

For the Intel Drivers:
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>


_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

^ permalink raw reply	[flat|nested] 44+ messages in thread
* Re: [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable
@ 2023-03-07 19:28   ` Jesse Brandeburg
  0 siblings, 0 replies; 44+ messages in thread
From: Jesse Brandeburg @ 2023-03-07 19:28 UTC (permalink / raw)
  To: Bjorn Helgaas, David S . Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Abhijit Ayarekar,
	Ajit Khaparde, Ariel Elior, Chris Snook, Dimitris Michailidis,
	Edward Cree, Jiawen Wu, Manish Chopra, Martin Habets,
	Mengyuan Lou, Michael Chan, Rahul Verma, Raju Rangoju,
	Rasesh Mody, Salil Mehta, Shahed Shaikh, Somnath Kotur,
	Sriharsha Basavapatna, Sudarsana Kalluru, Tony Nguyen,
	Veerasenareddy Burru, Yisen Zhuang, GR-Linux-NIC-Dev,
	intel-wired-lan

On 3/7/2023 10:19 AM, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"),
> which appeared in v6.0, the PCI core has enabled PCIe error reporting for
> all devices during enumeration.
> 
> Remove driver code to do this and remove unnecessary includes of
> <linux/aer.h> from several other drivers.
> 
> Intel folks, sorry that I missed removing the <linux/aer.h> includes in the
> first series.

For the Intel Drivers:
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>



^ permalink raw reply	[flat|nested] 44+ messages in thread
* Re: [PATCH 03/28] bnx2: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` [PATCH 03/28] bnx2: " Bjorn Helgaas
@ 2023-03-08  0:21   ` Michael Chan
  0 siblings, 0 replies; 44+ messages in thread
From: Michael Chan @ 2023-03-08  0:21 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	netdev, linux-kernel, Bjorn Helgaas, Rasesh Mody,
	GR-Linux-NIC-Dev

[-- Attachment #1: Type: text/plain, Size: 1460 bytes --]

On Tue, Mar 7, 2023 at 10:20 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration, so the
> driver doesn't need to do it itself.
>
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
>
> Note that this only controls ERR_* Messages from the device.  An ERR_*
> Message may cause the Root Port to generate an interrupt, depending on the
> AER Root Error Command register managed by the AER service driver.
>
> cd709aa90648 ("bnx2: Add PCI Advanced Error Reporting support.") added
> pci_enable_pcie_error_reporting() for all devices, and c239f279e571 ("bnx2:
> Enable AER on PCIE devices only") restricted it to BNX2_CHIP_5709 devices
> to avoid an error message when it failed on non-PCIe devices.  The PCI core
> only enables PCIe error reporting on PCIe devices, which I assume means
> BNX2_CHIP_5709.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Rasesh Mody <rmody@marvell.com>
> Cc: GR-Linux-NIC-Dev@marvell.com
> Cc: Michael Chan <michael.chan@broadcom.com>

Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Thanks.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

^ permalink raw reply	[flat|nested] 44+ messages in thread
* Re: [PATCH 05/28] bnxt: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` [PATCH 05/28] bnxt: " Bjorn Helgaas
@ 2023-03-08  0:23   ` Michael Chan
  0 siblings, 0 replies; 44+ messages in thread
From: Michael Chan @ 2023-03-08  0:23 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	netdev, linux-kernel, Bjorn Helgaas

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

On Tue, Mar 7, 2023 at 10:20 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration.
>
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
>
> Note that this only controls ERR_* Messages from the device.  An ERR_*
> Message may cause the Root Port to generate an interrupt, depending on the
> AER Root Error Command register managed by the AER service driver.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Michael Chan <michael.chan@broadcom.com>

Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Thanks.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

^ permalink raw reply	[flat|nested] 44+ messages in thread
* Re: [PATCH 15/28] sfc: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` [PATCH 15/28] sfc: Drop redundant pci_enable_pcie_error_reporting() Bjorn Helgaas
@ 2023-03-08 16:11   ` Edward Cree
  0 siblings, 0 replies; 44+ messages in thread
From: Edward Cree @ 2023-03-08 16:11 UTC (permalink / raw)
  To: Bjorn Helgaas, David S . Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Martin Habets

On 07/03/2023 18:19, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration, so the
> driver doesn't need to do it itself.
> 
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
> 
> Note that this only controls ERR_* Messages from the device.  An ERR_*
> Message may cause the Root Port to generate an interrupt, depending on the
> AER Root Error Command register managed by the AER service driver.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Edward Cree <ecree.xilinx@gmail.com>
> Cc: Martin Habets <habetsm.xilinx@gmail.com>
> ---

Acked-by: Edward Cree <ecree.xilinx@gmail.com>

^ permalink raw reply	[flat|nested] 44+ messages in thread
* Re: [PATCH 16/28] sfc: falcon: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` [PATCH 16/28] sfc: falcon: " Bjorn Helgaas
@ 2023-03-08 16:12   ` Edward Cree
  0 siblings, 0 replies; 44+ messages in thread
From: Edward Cree @ 2023-03-08 16:12 UTC (permalink / raw)
  To: Bjorn Helgaas, David S . Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Martin Habets

On 07/03/2023 18:19, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration, so the
> driver doesn't need to do it itself.
> 
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
> 
> Note that this only controls ERR_* Messages from the device.  An ERR_*
> Message may cause the Root Port to generate an interrupt, depending on the
> AER Root Error Command register managed by the AER service driver.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Edward Cree <ecree.xilinx@gmail.com>
> Cc: Martin Habets <habetsm.xilinx@gmail.com>
> ---

Acked-by: Edward Cree <ecree.xilinx@gmail.com>

^ permalink raw reply	[flat|nested] 44+ messages in thread
* Re: [PATCH 17/28] sfc/siena: Drop redundant pci_enable_pcie_error_reporting()
  2023-03-07 18:19 ` [PATCH 17/28] sfc/siena: " Bjorn Helgaas
@ 2023-03-08 16:12   ` Edward Cree
  0 siblings, 0 replies; 44+ messages in thread
From: Edward Cree @ 2023-03-08 16:12 UTC (permalink / raw)
  To: Bjorn Helgaas, David S . Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Martin Habets

On 07/03/2023 18:19, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration, so the
> driver doesn't need to do it itself.
> 
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
> 
> Note that this only controls ERR_* Messages from the device.  An ERR_*
> Message may cause the Root Port to generate an interrupt, depending on the
> AER Root Error Command register managed by the AER service driver.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Edward Cree <ecree.xilinx@gmail.com>
> Cc: Martin Habets <habetsm.xilinx@gmail.com>
> ---

Acked-by: Edward Cree <ecree.xilinx@gmail.com>

^ permalink raw reply	[flat|nested] 44+ messages in thread
* Re: [PATCH 18/28] sfc_ef100: Drop redundant pci_disable_pcie_error_reporting()
  2023-03-07 18:19 ` [PATCH 18/28] sfc_ef100: Drop redundant pci_disable_pcie_error_reporting() Bjorn Helgaas
@ 2023-03-08 16:16   ` Edward Cree
  0 siblings, 0 replies; 44+ messages in thread
From: Edward Cree @ 2023-03-08 16:16 UTC (permalink / raw)
  To: Bjorn Helgaas, David S . Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni
  Cc: netdev, linux-kernel, Bjorn Helgaas, Martin Habets

On 07/03/2023 18:19, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> 51b35a454efd ("sfc: skeleton EF100 PF driver") added a call to
> pci_disable_pcie_error_reporting() in ef100_pci_remove().
> 
> Remove this call since there's no apparent reason to disable error
> reporting when it was not previously enabled.
> 
> Note that since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core enables PCIe error reporting for all devices during
> enumeration, so the driver doesn't need to do it itself.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Edward Cree <ecree.xilinx@gmail.com>
> Cc: Martin Habets <habetsm.xilinx@gmail.com>
> ---

Yeah it looks like we meant to add an enable too but lost it somewhere
 in the upstreaming process.  Anyway,
Acked-by: Edward Cree <ecree.xilinx@gmail.com>

^ permalink raw reply	[flat|nested] 44+ messages in thread
* Re: [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable
  2023-03-07 18:19 ` Bjorn Helgaas
@ 2023-03-09  7:40   ` patchwork-bot+netdevbpf
  -1 siblings, 0 replies; 44+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-09  7:40 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: davem, edumazet, kuba, pabeni, netdev, linux-kernel, bhelgaas,
	aayarekar, ajit.khaparde, aelior, chris.snook, dmichail,
	ecree.xilinx, jesse.brandeburg, jiawenwu, manishc,
	habetsm.xilinx, mengyuanlou, michael.chan, rahulv, rajur, rmody,
	salil.mehta, shshaikh, somnath.kotur, sriharsha.basavapatna,
	skalluru, anthony.l.nguyen, vburru, yisen.zhuang,
	GR-Linux-NIC-Dev, intel-wired-lan

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  7 Mar 2023 12:19:11 -0600 you wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"),
> which appeared in v6.0, the PCI core has enabled PCIe error reporting for
> all devices during enumeration.
> 
> Remove driver code to do this and remove unnecessary includes of
> <linux/aer.h> from several other drivers.
> 
> [...]

Here is the summary with links:
  - [01/28] alx: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/1de2a84dd060
  - [02/28] be2net: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/b4e24578b484
  - [03/28] bnx2: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/5f00358b5e90
  - [04/28] bnx2x: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/2fba753cc9b5
  - [05/28] bnxt: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/5f29b73d4eba
  - [06/28] cxgb4: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/ca7f175fc24e
  - [07/28] net/fungible: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/49f79ac22f89
  - [08/28] net: hns3: remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/c183033f631a
  - [09/28] netxen_nic: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/2d0e0372069d
  - [10/28] octeon_ep: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/fe3f4c292da1
  - [11/28] qed: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/1263c7b78315
  - [12/28] net: qede: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/5f1fbdc168f4
  - [13/28] qlcnic: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/95e35f599407
  - [14/28] qlcnic: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/e07ce5567194
  - [15/28] sfc: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/bdedf705688c
  - [16/28] sfc: falcon: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/4ac9272691a4
  - [17/28] sfc/siena: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/ecded61ceb89
  - [18/28] sfc_ef100: Drop redundant pci_disable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/c39abdd396bc
  - [19/28] net: ngbe: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/a7edf8e5142f
  - [20/28] net: txgbe: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/1fccc781bf7e
  - [21/28] e1000e: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/ab76f2bff0f3
  - [22/28] fm10k: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/8be901a6715f
  - [23/28] i40e: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/acd2bb015fae
  - [24/28] iavf: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/495b72c79302
  - [25/28] ice: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/ddd652ef30e3
  - [26/28] igb: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/648a2020fdac
  - [27/28] igc: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/1530522f101f
  - [28/28] ixgbe: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/f3468e394439

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 44+ messages in thread
* Re: [Intel-wired-lan] [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable
@ 2023-03-09  7:40   ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 44+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-09  7:40 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: ajit.khaparde, chris.snook, GR-Linux-NIC-Dev, somnath.kotur,
	edumazet, anthony.l.nguyen, manishc, rahulv, jesse.brandeburg,
	yisen.zhuang, intel-wired-lan, vburru, habetsm.xilinx, pabeni,
	aayarekar, shshaikh, aelior, jiawenwu, kuba, bhelgaas,
	michael.chan, salil.mehta, mengyuanlou, sriharsha.basavapatna,
	rmody, netdev, linux-kernel, skalluru, ecree.xilinx, rajur,
	dmichail, davem

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  7 Mar 2023 12:19:11 -0600 you wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"),
> which appeared in v6.0, the PCI core has enabled PCIe error reporting for
> all devices during enumeration.
> 
> Remove driver code to do this and remove unnecessary includes of
> <linux/aer.h> from several other drivers.
> 
> [...]

Here is the summary with links:
  - [01/28] alx: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/1de2a84dd060
  - [02/28] be2net: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/b4e24578b484
  - [03/28] bnx2: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/5f00358b5e90
  - [04/28] bnx2x: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/2fba753cc9b5
  - [05/28] bnxt: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/5f29b73d4eba
  - [06/28] cxgb4: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/ca7f175fc24e
  - [07/28] net/fungible: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/49f79ac22f89
  - [08/28] net: hns3: remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/c183033f631a
  - [09/28] netxen_nic: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/2d0e0372069d
  - [10/28] octeon_ep: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/fe3f4c292da1
  - [11/28] qed: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/1263c7b78315
  - [12/28] net: qede: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/5f1fbdc168f4
  - [13/28] qlcnic: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/95e35f599407
  - [14/28] qlcnic: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/e07ce5567194
  - [15/28] sfc: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/bdedf705688c
  - [16/28] sfc: falcon: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/4ac9272691a4
  - [17/28] sfc/siena: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/ecded61ceb89
  - [18/28] sfc_ef100: Drop redundant pci_disable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/c39abdd396bc
  - [19/28] net: ngbe: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/a7edf8e5142f
  - [20/28] net: txgbe: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/1fccc781bf7e
  - [21/28] e1000e: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/ab76f2bff0f3
  - [22/28] fm10k: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/8be901a6715f
  - [23/28] i40e: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/acd2bb015fae
  - [24/28] iavf: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/495b72c79302
  - [25/28] ice: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/ddd652ef30e3
  - [26/28] igb: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/648a2020fdac
  - [27/28] igc: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/1530522f101f
  - [28/28] ixgbe: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/f3468e394439

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html


_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

^ permalink raw reply	[flat|nested] 44+ messages in thread
* Re: [Intel-wired-lan] [PATCH 21/28] e1000e: Remove unnecessary aer.h include
  2023-03-07 18:19   ` Bjorn Helgaas
@ 2023-03-15 12:00     ` naamax.meir
  -1 siblings, 0 replies; 44+ messages in thread
From: naamax.meir @ 2023-03-15 12:00 UTC (permalink / raw)
  To: Bjorn Helgaas, David S . Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni
  Cc: netdev, linux-kernel, Jesse Brandeburg, intel-wired-lan,
	Bjorn Helgaas, Tony Nguyen

On 3/7/2023 20:19, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> <linux/aer.h> is unused, so remove it.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org
> ---
>   drivers/net/ethernet/intel/e1000e/netdev.c | 1 -
>   1 file changed, 1 deletion(-)
Tested-by: Naama Meir <naamax.meir@linux.intel.com>

^ permalink raw reply	[flat|nested] 44+ messages in thread
* Re: [Intel-wired-lan] [PATCH 21/28] e1000e: Remove unnecessary aer.h include
@ 2023-03-15 12:00     ` naamax.meir
  0 siblings, 0 replies; 44+ messages in thread
From: naamax.meir @ 2023-03-15 12:00 UTC (permalink / raw)
  To: Bjorn Helgaas, David S . Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni
  Cc: netdev, linux-kernel, Jesse Brandeburg, Tony Nguyen,
	Bjorn Helgaas, intel-wired-lan

On 3/7/2023 20:19, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> <linux/aer.h> is unused, so remove it.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org
> ---
>   drivers/net/ethernet/intel/e1000e/netdev.c | 1 -
>   1 file changed, 1 deletion(-)
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

^ permalink raw reply	[flat|nested] 44+ messages in thread
end of thread, other threads:[~2023-03-15 12:01 UTC | newest]

Thread overview: 44+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-07 18:19 [Intel-wired-lan] [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable Bjorn Helgaas
2023-03-07 18:19 ` Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 01/28] alx: Drop redundant pci_enable_pcie_error_reporting() Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 02/28] be2net: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 03/28] bnx2: " Bjorn Helgaas
2023-03-08  0:21   ` Michael Chan
2023-03-07 18:19 ` [PATCH 04/28] bnx2x: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 05/28] bnxt: " Bjorn Helgaas
2023-03-08  0:23   ` Michael Chan
2023-03-07 18:19 ` [PATCH 06/28] cxgb4: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 07/28] net/fungible: " Bjorn Helgaas
2023-03-07 19:17   ` Dimitris Michailidis
2023-03-07 18:19 ` [PATCH 08/28] net: hns3: remove unnecessary aer.h include Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 09/28] netxen_nic: Drop redundant pci_enable_pcie_error_reporting() Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 10/28] octeon_ep: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 11/28] qed: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 12/28] net: qede: Remove unnecessary aer.h include Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 13/28] qlcnic: Drop redundant pci_enable_pcie_error_reporting() Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 14/28] qlcnic: Remove unnecessary aer.h include Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 15/28] sfc: Drop redundant pci_enable_pcie_error_reporting() Bjorn Helgaas
2023-03-08 16:11   ` Edward Cree
2023-03-07 18:19 ` [PATCH 16/28] sfc: falcon: " Bjorn Helgaas
2023-03-08 16:12   ` Edward Cree
2023-03-07 18:19 ` [PATCH 17/28] sfc/siena: " Bjorn Helgaas
2023-03-08 16:12   ` Edward Cree
2023-03-07 18:19 ` [PATCH 18/28] sfc_ef100: Drop redundant pci_disable_pcie_error_reporting() Bjorn Helgaas
2023-03-08 16:16   ` Edward Cree
2023-03-07 18:19 ` [PATCH 19/28] net: ngbe: Drop redundant pci_enable_pcie_error_reporting() Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 20/28] net: txgbe: " Bjorn Helgaas
2023-03-07 18:19 ` [Intel-wired-lan] [PATCH 21/28] e1000e: Remove unnecessary aer.h include Bjorn Helgaas
2023-03-07 18:19   ` Bjorn Helgaas
2023-03-15 12:00   ` [Intel-wired-lan] " naamax.meir
2023-03-15 12:00     ` naamax.meir
2023-03-07 18:19 ` [PATCH 22/28] fm10k: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 23/28] i40e: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 24/28] iavf: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 25/28] ice: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 26/28] igb: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 27/28] igc: " Bjorn Helgaas
2023-03-07 18:19 ` [PATCH 28/28] ixgbe: " Bjorn Helgaas
2023-03-07 19:28 ` [Intel-wired-lan] [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable Jesse Brandeburg
2023-03-07 19:28   ` Jesse Brandeburg
2023-03-09  7:40 ` patchwork-bot+netdevbpf
2023-03-09  7:40   ` [Intel-wired-lan] " patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.