All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, bvanassche@acm.org,
	linux-kernel@vger.kernel.org, dgilbert@interlog.com,
	John Garry <john.g.garry@oracle.com>
Subject: [PATCH RESEND v2 07/11] scsi: scsi_debug: Drop scsi_debug_host_reset() device NULL pointer check
Date: Mon, 13 Mar 2023 09:31:10 +0000	[thread overview]
Message-ID: <20230313093114.1498305-8-john.g.garry@oracle.com> (raw)
In-Reply-To: <20230313093114.1498305-1-john.g.garry@oracle.com>

The check for device pointer for the SCSI command is unnecessary, so drop
it.

The only caller is scsi_try_host_reset() -> eh_host_reset_handler(),
and there that pointer cannot be NULL.

Indeed, there is already code later in the same function which does not
check the device pointer for the SCSI command.

Signed-off-by: John Garry <john.g.garry@oracle.com>
---
 drivers/scsi/scsi_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index 749358b48335..47820b9f6326 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -5440,7 +5440,7 @@ static int scsi_debug_host_reset(struct scsi_cmnd *SCpnt)
 	int k = 0;
 
 	++num_host_resets;
-	if ((SCpnt->device) && (SDEBUG_OPT_ALL_NOISE & sdebug_opts))
+	if (SDEBUG_OPT_ALL_NOISE & sdebug_opts)
 		sdev_printk(KERN_INFO, SCpnt->device, "%s\n", __func__);
 	spin_lock(&sdebug_host_list_lock);
 	list_for_each_entry(sdbg_host, &sdebug_host_list, host_list) {
-- 
2.35.3


  parent reply	other threads:[~2023-03-13  9:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13  9:31 [PATCH RESEND v2 00/11] scsi_debug: Some minor improvements John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 01/11] scsi: scsi_debug: Don't hold driver host struct pointer in host->hostdata[] John Garry
2023-03-14  2:34   ` Douglas Gilbert
2023-03-16  8:48     ` John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 02/11] scsi: scsi_debug: Stop setting devip->sdbg_host twice John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 03/11] scsi: scsi_debug: Drop scsi_debug_abort() NULL pointer checks John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 04/11] scsi: scsi_debug: Drop scsi_debug_device_reset() " John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 05/11] scsi: scsi_debug: Drop scsi_debug_target_reset() " John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 06/11] scsi: scsi_debug: Drop scsi_debug_bus_reset() " John Garry
2023-03-13  9:31 ` John Garry [this message]
2023-03-13  9:31 ` [PATCH RESEND v2 08/11] scsi: scsi_debug: Drop check for num_in_q exceeding queue depth John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 09/11] scsi: scsi_debug: Drop sdebug_dev_info.num_in_q John Garry
2023-03-20  5:31   ` kernel test robot
2023-03-20 11:41     ` John Garry
2023-03-22 13:36       ` John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 10/11] scsi: scsi_debug: Get command abort feature working again John Garry
2023-03-13  9:31 ` [PATCH RESEND v2 11/11] scsi: scsi_debug: Add poll mode deferred completions to statistics John Garry
2023-03-17  3:27 ` [PATCH RESEND v2 00/11] scsi_debug: Some minor improvements Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230313093114.1498305-8-john.g.garry@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=bvanassche@acm.org \
    --cc=dgilbert@interlog.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.