From: Borislav Petkov <bp@alien8.de>
To: Saurabh Singh Sengar <ssengar@microsoft.com>
Cc: Saurabh Sengar <ssengar@linux.microsoft.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"johan+linaro@kernel.org" <johan+linaro@kernel.org>,
"isaku.yamahata@intel.com" <isaku.yamahata@intel.com>,
"Michael Kelley (LINUX)" <mikelley@microsoft.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rahul.tanwar@linux.intel.com" <rahul.tanwar@linux.intel.com>,
"andriy.shevchenko@intel.com" <andriy.shevchenko@intel.com>
Subject: Re: [EXTERNAL] Re: [PATCH] x86/ioapic: Don't return 0 as valid virq
Date: Mon, 13 Mar 2023 12:14:25 +0100 [thread overview]
Message-ID: <20230313111425.GDZA8Fkar9Z9BzSImD@fat_crate.local> (raw)
In-Reply-To: <PUZP153MB074987B356FCB28933B87CCBBEB99@PUZP153MB0749.APCP153.PROD.OUTLOOK.COM>
On Mon, Mar 13, 2023 at 03:29:32AM +0000, Saurabh Singh Sengar wrote:
> To be specific in our system which is a guest VM we don't need IO-APIC and hence
> there is no device tree node for it. It is observed that we get irq 0 assigned to PCI-MSI.
This should be added to your commit message: what guest VM is that and
why should the kernel support it.
Why doesn't it need an IO-APIC and why does the current code need to be
changed just for your guest VM?
What else needs to be changed so that your VM works?
Where is that VM's documentation and why can't that VM be fixed *not* to
need kernel changes? IOW, why can't that VM emulate an IO-APIC like the
others do...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-03-13 11:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 19:34 [PATCH] x86/ioapic: Don't return 0 as valid virq Saurabh Sengar
2023-03-09 17:14 ` Saurabh Singh Sengar
2023-03-12 20:40 ` Borislav Petkov
2023-03-13 3:29 ` [EXTERNAL] " Saurabh Singh Sengar
2023-03-13 3:37 ` Saurabh Singh Sengar
2023-03-13 11:07 ` Borislav Petkov
2023-03-13 11:14 ` Borislav Petkov [this message]
2023-03-14 10:23 ` [EXTERNAL] " Saurabh Singh Sengar
2023-03-24 7:09 ` Saurabh Singh Sengar
2023-03-24 15:39 ` [EXTERNAL] " Thomas Gleixner
2023-03-24 16:24 ` Saurabh Singh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313111425.GDZA8Fkar9Z9BzSImD@fat_crate.local \
--to=bp@alien8.de \
--cc=andriy.shevchenko@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=isaku.yamahata@intel.com \
--cc=johan+linaro@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=rahul.tanwar@linux.intel.com \
--cc=ssengar@linux.microsoft.com \
--cc=ssengar@microsoft.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.