From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@mellanox.com>
Cc: "perezma@redhat.com" <perezma@redhat.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
Eugenio Perez Martin <eperezma@redhat.com>,
Eli Cohen <elic@nvidia.com>
Subject: Re: [PATCH 1/2] vdpa/mlx5: Make VIRTIO_NET_F_MRG_RXBUF off by default
Date: Mon, 13 Mar 2023 17:44:40 -0400 [thread overview]
Message-ID: <20230313174313-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481766116A2C074EDA7B3CCDCB99@PH0PR12MB5481.namprd12.prod.outlook.com>
On Mon, Mar 13, 2023 at 09:34:50PM +0000, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Monday, March 13, 2023 5:24 PM
> > I mean if this is claiming to fix a performance regression it should have a Fixes:
> > tag with the commit that introduced the regression.
>
> The fixes tag should be,
>
> Fixes: deeacf35c922d ("vdpa/mlx5: support device features provisioning")
>
> Eli,
> Please add.
Hmm okay so to make sure, before this commit device by default
is created without mrg buffers? With the commit it's created
with and what the change does it revert the default
back to what it was?
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-03-13 21:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230312083920.2300028-1-elic@nvidia.com>
[not found] ` <20230312083920.2300028-2-elic@nvidia.com>
2023-03-12 8:58 ` [PATCH 1/2] vdpa/mlx5: Make VIRTIO_NET_F_MRG_RXBUF off by default Michael S. Tsirkin
[not found] ` <f01c7204-5629-297e-47b6-06e58bd3f543@nvidia.com>
2023-03-12 10:25 ` Michael S. Tsirkin
[not found] ` <PH0PR12MB54816C24BAA322567BED21A0DCB89@PH0PR12MB5481.namprd12.prod.outlook.com>
2023-03-12 16:24 ` Michael S. Tsirkin
[not found] ` <PH0PR12MB548140734E1A0A8A2FD2CE30DCB99@PH0PR12MB5481.namprd12.prod.outlook.com>
2023-03-13 21:23 ` Michael S. Tsirkin
2023-03-13 21:36 ` Si-Wei Liu
[not found] ` <PH0PR12MB5481766116A2C074EDA7B3CCDCB99@PH0PR12MB5481.namprd12.prod.outlook.com>
2023-03-13 21:44 ` Michael S. Tsirkin [this message]
[not found] ` <PH0PR12MB5481FBB83AF401E598448736DCBE9@PH0PR12MB5481.namprd12.prod.outlook.com>
2023-03-14 3:43 ` Michael S. Tsirkin
2023-03-13 22:19 ` Si-Wei Liu
[not found] ` <PH0PR12MB5481A0629C479A030C8A8EDEDCBE9@PH0PR12MB5481.namprd12.prod.outlook.com>
2023-03-14 3:37 ` Michael S. Tsirkin
[not found] ` <PH0PR12MB54816DE6E7A0594D38019305DCBE9@PH0PR12MB5481.namprd12.prod.outlook.com>
2023-03-14 4:33 ` Michael S. Tsirkin
2023-03-14 19:29 ` Si-Wei Liu
[not found] ` <PH0PR12MB5481F776D35247E6BF3F115EDCBF9@PH0PR12MB5481.namprd12.prod.outlook.com>
2023-03-15 6:56 ` Si-Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313174313-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=elic@nvidia.com \
--cc=eperezma@redhat.com \
--cc=parav@mellanox.com \
--cc=perezma@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.