From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B950C6FD19 for ; Mon, 13 Mar 2023 21:49:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229810AbjCMVtB (ORCPT ); Mon, 13 Mar 2023 17:49:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbjCMVtA (ORCPT ); Mon, 13 Mar 2023 17:49:00 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42E29498AD; Mon, 13 Mar 2023 14:48:57 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 736EE21BDF; Mon, 13 Mar 2023 21:48:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678744136; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d4wzOquh6yhYjXKMctHpNwaRGq9k+Tl1G3kjI6xwMXo=; b=RSyyfjHXxH7tQqoxkDv5OuXrOqe1NHqIjisK2gwc9a8HG/85kA99VmNNLSaLgzTF5gLX0X 2K7uBuxNqmVwEgKl7T1ICbfH4NBnR2av8V0EDIYwwVBKq3Yf+/SIOdEyaFlB0Q+/fNi12r mEi5lXLTzi5kugxG19SzUraRHOLKiy8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678744136; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d4wzOquh6yhYjXKMctHpNwaRGq9k+Tl1G3kjI6xwMXo=; b=xlLQNV7vcLGDwdCBjYektVBc8nJIEuFOVMh5L4jME7Rj+YOs8VmDUvh3G7UjMMQmAJabW0 Gc0nBmFmcvvchZAg== Received: from kitsune.suse.cz (kitsune.suse.cz [10.100.12.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 2EF9B2C141; Mon, 13 Mar 2023 21:48:55 +0000 (UTC) Date: Mon, 13 Mar 2023 22:48:53 +0100 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Andrea Righi Cc: Gary Guo , Kees Cook , Masahiro Yamada , linux-kbuild@vger.kernel.org, Wedson Almeida Filho , Joel Stanley , Alex Gaynor , Miguel Ojeda , Wedson Almeida Filho , Nicolas Schier , rust-for-linux@vger.kernel.org, Guo Zhengkui , Boqun Feng , Nicholas Piggin , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Nathan Chancellor , Nick Desaulniers , linux-kernel@vger.kernel.org, Julia Lawall , Luis Chamberlain , linuxppc-dev@lists.ozlabs.org, linux-modules@vger.kernel.org Subject: Re: [PATCH] modpost: support arbitrary symbol length in modversion Message-ID: <20230313214853.GY19419@kitsune.suse.cz> References: <20230111161155.1349375-1-gary@garyguo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: Hello, On Mon, Mar 13, 2023 at 09:32:16PM +0100, Andrea Righi wrote: > On Wed, Jan 11, 2023 at 04:11:51PM +0000, Gary Guo wrote: > > Currently modversion uses a fixed size array of size (64 - sizeof(long)) > > to store symbol names, thus placing a hard limit on length of symbols. > > Rust symbols (which encodes crate and module names) can be quite a bit > > longer. The length limit in kallsyms is increased to 512 for this reason. > > > > It's a waste of space to simply expand the fixed array size to 512 in > > modversion info entries. I therefore make it variably sized, with offset > > to the next entry indicated by the initial "next" field. > > > > In addition to supporting longer-than-56/60 byte symbols, this patch also > > reduce the size for short symbols by getting rid of excessive 0 paddings. > > There are still some zero paddings to ensure "next" and "crc" fields are > > properly aligned. > > > > This patch does have a tiny drawback that it makes ".mod.c" files generated > > a bit less easy to read, as code like > > > > "\x08\x00\x00\x00\x78\x56\x34\x12" > > "symbol\0\0" > > > > is generated as opposed to > > > > { 0x12345678, "symbol" }, > > > > because the structure is now variable-length. But hopefully nobody reads > > the generated file :) > > > > Link: b8a94bfb3395 ("kallsyms: increase maximum kernel symbol length to 512") > > Link: https://github.com/Rust-for-Linux/linux/pull/379 > > > > Signed-off-by: Gary Guo > > Is there any newer version of this patch? > > I'm doing some tests with it, but I'm getting boot failures on ppc64 > with this applied (at boot kernel is spitting out lots of oops'es and > unfortunately it's really hard to copy paste or just read them from the > console). Are you using the ELF ABI v1 or v2? v1 may have some additional issues when it comes to these symbol tables. Thanks Michal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77A1AC6FD1C for ; Mon, 13 Mar 2023 21:49:57 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Pb9LD09Psz3cS4 for ; Tue, 14 Mar 2023 08:49:56 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=RSyyfjHX; dkim=fail reason="signature verification failed" header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=xlLQNV7v; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=suse.de (client-ip=195.135.220.28; helo=smtp-out1.suse.de; envelope-from=msuchanek@suse.de; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=RSyyfjHX; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=xlLQNV7v; dkim-atps=neutral Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Pb9KB5HgCz3bZx for ; Tue, 14 Mar 2023 08:49:02 +1100 (AEDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 736EE21BDF; Mon, 13 Mar 2023 21:48:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678744136; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d4wzOquh6yhYjXKMctHpNwaRGq9k+Tl1G3kjI6xwMXo=; b=RSyyfjHXxH7tQqoxkDv5OuXrOqe1NHqIjisK2gwc9a8HG/85kA99VmNNLSaLgzTF5gLX0X 2K7uBuxNqmVwEgKl7T1ICbfH4NBnR2av8V0EDIYwwVBKq3Yf+/SIOdEyaFlB0Q+/fNi12r mEi5lXLTzi5kugxG19SzUraRHOLKiy8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678744136; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d4wzOquh6yhYjXKMctHpNwaRGq9k+Tl1G3kjI6xwMXo=; b=xlLQNV7vcLGDwdCBjYektVBc8nJIEuFOVMh5L4jME7Rj+YOs8VmDUvh3G7UjMMQmAJabW0 Gc0nBmFmcvvchZAg== Received: from kitsune.suse.cz (kitsune.suse.cz [10.100.12.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 2EF9B2C141; Mon, 13 Mar 2023 21:48:55 +0000 (UTC) Date: Mon, 13 Mar 2023 22:48:53 +0100 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Andrea Righi Subject: Re: [PATCH] modpost: support arbitrary symbol length in modversion Message-ID: <20230313214853.GY19419@kitsune.suse.cz> References: <20230111161155.1349375-1-gary@garyguo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gary Guo , Nicolas Schier , Masahiro Yamada , Guo Zhengkui , Wedson Almeida Filho , Joel Stanley , Alex Gaynor , Miguel Ojeda , Wedson Almeida Filho , Kees Cook , rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org, Boqun Feng , Nicholas Piggin , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Nathan Chancellor , Nick Desaulniers , linux-kernel@vger.kernel.org, Julia Lawall , Luis Chamberlain , linuxppc-dev@lists.ozlabs.org, linux-modules@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hello, On Mon, Mar 13, 2023 at 09:32:16PM +0100, Andrea Righi wrote: > On Wed, Jan 11, 2023 at 04:11:51PM +0000, Gary Guo wrote: > > Currently modversion uses a fixed size array of size (64 - sizeof(long)) > > to store symbol names, thus placing a hard limit on length of symbols. > > Rust symbols (which encodes crate and module names) can be quite a bit > > longer. The length limit in kallsyms is increased to 512 for this reason. > > > > It's a waste of space to simply expand the fixed array size to 512 in > > modversion info entries. I therefore make it variably sized, with offset > > to the next entry indicated by the initial "next" field. > > > > In addition to supporting longer-than-56/60 byte symbols, this patch also > > reduce the size for short symbols by getting rid of excessive 0 paddings. > > There are still some zero paddings to ensure "next" and "crc" fields are > > properly aligned. > > > > This patch does have a tiny drawback that it makes ".mod.c" files generated > > a bit less easy to read, as code like > > > > "\x08\x00\x00\x00\x78\x56\x34\x12" > > "symbol\0\0" > > > > is generated as opposed to > > > > { 0x12345678, "symbol" }, > > > > because the structure is now variable-length. But hopefully nobody reads > > the generated file :) > > > > Link: b8a94bfb3395 ("kallsyms: increase maximum kernel symbol length to 512") > > Link: https://github.com/Rust-for-Linux/linux/pull/379 > > > > Signed-off-by: Gary Guo > > Is there any newer version of this patch? > > I'm doing some tests with it, but I'm getting boot failures on ppc64 > with this applied (at boot kernel is spitting out lots of oops'es and > unfortunately it's really hard to copy paste or just read them from the > console). Are you using the ELF ABI v1 or v2? v1 may have some additional issues when it comes to these symbol tables. Thanks Michal