From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78C4DC6FD1C for ; Tue, 14 Mar 2023 10:24:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230162AbjCNKYi (ORCPT ); Tue, 14 Mar 2023 06:24:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230229AbjCNKYY (ORCPT ); Tue, 14 Mar 2023 06:24:24 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43B991C5A0 for ; Tue, 14 Mar 2023 03:23:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2AC70B818DF for ; Tue, 14 Mar 2023 10:23:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4109FC433EF; Tue, 14 Mar 2023 10:23:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678789399; bh=Colmwe/i6OWYobVhwYkFbfzZHjZnyzrcBxYvy058VFI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jtMOZPWuupvnSG1fIiwNLMGZ/CFURsLQTvuM1EWdcnQKmiMivkJ9cA3L8LwrIkRl7 CXChAl+us7qctLoZirei1QwBK3oUByQlhtrtLE0MmjUUFU2QxyoNG3zCfHzjQvpF4W ECiWbcMKs3IH4YHDhiXUdYJgrGWN2/MokQqr2w4+23UkiH5PsIPIBotRZdsK4i0RQL 4xAxct1kBEkxHshfErJXGoHGmjrjOQ9Sqdyw7gC8ivLI5at2XdbX1UlLHsYVqh22ye MF2MJ539uRscbH+AkOAc1Dv+32xsjliFr9HiilWnYF70QccsWp8DUP8raR/GD9CpiU 0v0+wENEj/8Cw== Date: Tue, 14 Mar 2023 12:23:13 +0200 From: Leon Romanovsky To: Cheng Xu Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org, KaiShen@linux.alibaba.com Subject: Re: [PATCH for-next v2 2/2] RDMA/erdma: Support non-4K page size in doorbell allocation Message-ID: <20230314102313.GB36557@unreal> References: <20230307102924.70577-1-chengyou@linux.alibaba.com> <20230307102924.70577-3-chengyou@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230307102924.70577-3-chengyou@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Mar 07, 2023 at 06:29:24PM +0800, Cheng Xu wrote: > Doorbell resources are exposed to userspace by mmap. The size unit of mmap > is PAGE_SIZE, previous implementation can not work correctly if PAGE_SIZE > is not 4K. We support non-4K page size in this commit. Why do you need this information in rdma-core? Can you use sysconf(_SC_PAGESIZE) there to understand the page size like other providers? Thanks