From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85482C7618A for ; Tue, 14 Mar 2023 15:07:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231552AbjCNPHO (ORCPT ); Tue, 14 Mar 2023 11:07:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229590AbjCNPHL (ORCPT ); Tue, 14 Mar 2023 11:07:11 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7E32AD039; Tue, 14 Mar 2023 08:07:02 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id y14so16350746ljq.4; Tue, 14 Mar 2023 08:07:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678806421; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vbLXsISyWgbVocJH/scN2oci69TRy0WQAp+UcL8HxWE=; b=p0EHmvR1vBC356rN7/hm4DOqRkE0aTTA91VTR19VIj+t/xskGgPxcVC3Swn6v9ey4F hbZfTPYuaYAyhipmyuQAQiT9RiKEflzSzfvMU8NftKq826q6fQGijvPoAqFXQfhx2YNM DZ0i8d+f5YC8PUInQ/YGggRBNF7L0zduinQoSh/szpA7/UfmEdSQZnXCD88Lw2CyoPd2 AsbYncMjY75d3PAIP65fHKB/efe59KSueM5VSxPJOzIxxOgST+XFh4HkqwTZw7xG5WoD H4IY3tz0HYGYUCEVI5Y7rZ2y+Y0sOCOq+odtg7nB0dEuKuiCUypgbTjBbVm/5a2Jzwas QqGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678806421; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vbLXsISyWgbVocJH/scN2oci69TRy0WQAp+UcL8HxWE=; b=0wIr9/tn4Nwwv7e8J4z7ps/dhSU/ejiOgIlQK7T6knllv8+6iBKjnv7SFU+Z4BFcx7 GRErpxkqMTrmxo39/MffqLtu62UhjcebRFY4HMlpWo2cERUQLEBV8R9hUaXGWn7libgx 6lBAFynF6be6mEYWvKpQTFSzbyL1Gti2VVXeo6NKvrZhKAQiUELv6DrxwniXfttykLBv O1FmRxisovbztgmrupz3B/yjXpWXCQFmwZRRO97/CzzA+l3TsB787HSHUShAeeZP6QFS TYg8N0GkMv5jKSVQHZMHkRxTIYPqKNoUPsz8c84BfQIu+kUJ6/GHZHoFfrEmaDz22hVY +Ebw== X-Gm-Message-State: AO0yUKXnjX7/ro4cwANEL8AAD9HcIEpZ29pdEnKjhMdYzKNKbmxxnFMx iwcK6VT6V4dUUGZ2T2NR/gQ= X-Google-Smtp-Source: AK7set+bnaLvSzK+Qv9g7g8oQCKeqApzg3XCPn/W6kdtRZtalZ50JNrzKxOFyptmqs0wq8VDOrJGng== X-Received: by 2002:a2e:8e8d:0:b0:298:6f36:dd6c with SMTP id z13-20020a2e8e8d000000b002986f36dd6cmr7223147ljk.11.1678806421025; Tue, 14 Mar 2023 08:07:01 -0700 (PDT) Received: from mobilestation ([95.79.133.202]) by smtp.gmail.com with ESMTPSA id f14-20020a2e9e8e000000b00295b1b6e063sm482600ljk.34.2023.03.14.08.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 08:07:00 -0700 (PDT) Date: Tue, 14 Mar 2023 18:06:57 +0300 From: Serge Semin To: Rob Herring Cc: Serge Semin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Coquelin , Krzysztof Kozlowski , Giuseppe Cavallaro , Pavel Parkhomenko , Jakub Kicinski , Jose Abreu , "David S. Miller" , Alexey Malahov , Paolo Abeni , Eric Dumazet , Biao Huang , netdev@vger.kernel.org, Christian Marangi , Yang Yingliang , Alexandre Torgue , Richard Cochran , linux-arm-kernel@lists.infradead.org, Rob Herring , linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH net-next 01/16] dt-bindings: net: dwmac: Validate PBL for all IP-cores Message-ID: <20230314150657.ytgyegi7qlwao6px@mobilestation> References: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> <20230313225103.30512-2-Sergey.Semin@baikalelectronics.ru> <167880254800.26004.7037306365469081272.robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <167880254800.26004.7037306365469081272.robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 14, 2023 at 09:10:19AM -0500, Rob Herring wrote: > > On Tue, 14 Mar 2023 01:50:48 +0300, Serge Semin wrote: > > Indeed the maximum DMA burst length can be programmed not only for DW > > xGMACs, Allwinner EMACs and Spear SoC GMAC, but in accordance with [1] > > for Generic DW *MAC IP-cores. Moreover the STMMAC set of drivers parse > > the property and then apply the configuration for all supported DW MAC > > devices. All of that makes the property being available for all IP-cores > > the bindings supports. Let's make sure the PBL-related properties are > > validated for all of them by the common DW MAC DT schema. > > > > [1] DesignWare Cores Ethernet MAC Universal Databook, Revision 3.73a, > > October 2013, p. 380. > > > > Signed-off-by: Serge Semin > > Reviewed-by: Rob Herring > > > > --- > > > > Changelog v1: > > - Use correct syntax of the JSON pointers, so the later would begin > > with a '/' after the '#'. > > --- > > .../devicetree/bindings/net/snps,dwmac.yaml | 77 +++++++------------ > > 1 file changed, 26 insertions(+), 51 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts', 'mac-address', 'phy-mode', 'reg', 'snps,reset-delays-us', 'snps,reset-gpio', 'snps,rxpbl', 'snps,txpbl' were unexpected) > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml Oops, on rebasing my work from older kernel I missed that the PBL properties constraints have already been extended. I'll drop the next patch in the series then and fix this one so the already defined constraints would be preserved. -Serge(y) > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230313225103.30512-2-Sergey.Semin@baikalelectronics.ru > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2ADEC6FD1D for ; Tue, 14 Mar 2023 15:08:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FXAXbxPa0DbWGcjjqLYhof63wZM+Be42Umb8yfuksGM=; b=N719kgKP7krS2h BhjCVknhelwunod34HXd/rY0p5bTyaP0cGZIB+eWUkzY21Z6LwkmGESvt4TD4hrE1HmRQKJO0RTHu e7Kmq8/rBxdFUqn9iHqPkAJgd/5mXK7WoTKqs1Y842BE4Lf+WE+SG2lAf43FUsauWhdvyDZrycZot pAqBoLfzR4ou1J9u/PEC/UBuSG6JoAjFKzvquAMwBx7l6QEqkggDfjBdrQ/eAW8abTqb6ZcI8EjoN Krr6gpsj39iX6j2IFKmAaDLzilYgToCe0ruq+qYCqnn7TMWwcRaCI+AKrkKJiUqDztIQv2KEB3cjg bVWOZObGQuUIgB5BaAyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pc6F0-00AY8N-2r; Tue, 14 Mar 2023 15:07:06 +0000 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pc6Ex-00AY7s-3C for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 15:07:05 +0000 Received: by mail-lj1-x234.google.com with SMTP id g18so16379267ljl.3 for ; Tue, 14 Mar 2023 08:07:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678806421; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vbLXsISyWgbVocJH/scN2oci69TRy0WQAp+UcL8HxWE=; b=p0EHmvR1vBC356rN7/hm4DOqRkE0aTTA91VTR19VIj+t/xskGgPxcVC3Swn6v9ey4F hbZfTPYuaYAyhipmyuQAQiT9RiKEflzSzfvMU8NftKq826q6fQGijvPoAqFXQfhx2YNM DZ0i8d+f5YC8PUInQ/YGggRBNF7L0zduinQoSh/szpA7/UfmEdSQZnXCD88Lw2CyoPd2 AsbYncMjY75d3PAIP65fHKB/efe59KSueM5VSxPJOzIxxOgST+XFh4HkqwTZw7xG5WoD H4IY3tz0HYGYUCEVI5Y7rZ2y+Y0sOCOq+odtg7nB0dEuKuiCUypgbTjBbVm/5a2Jzwas QqGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678806421; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vbLXsISyWgbVocJH/scN2oci69TRy0WQAp+UcL8HxWE=; b=p10nN+Bi2TaMEFq/ZOPYO6yYBRje3SUm7plA0obbBwODqyDTJpHsjuP6TBEhNfW6fn ZLFIuy4w1attAhJM8POw7NVMquRAw91ffGYnWdVWGZhsdbCl3G/le17onjKRk/4FymVv hX9+ug2Iq81QXh8Fs2ypQxASIkIVGItr5kEcjQdvJnTpWmOOxoNaK/V5wIzi5A7FOWTw 0ttleNJD6okfihWgbU+AFk6L7jZSDS4n6wH81fL2CE677DAfRf/Gw6kfR7x7X7f12IzA aaPBdRtb6WL2Eyzi/w0AIf0AaIq9bcZwxdBwxqCk7z1PgoZ2zbmxhVlRZccGtvv/iufL woRA== X-Gm-Message-State: AO0yUKVg7hsvEn57qILbnupUlC6V/oCYcksCD056nfnWjDm6Z8ko5dqF 0MazVmjq1RzFX788k0EBkTk= X-Google-Smtp-Source: AK7set+bnaLvSzK+Qv9g7g8oQCKeqApzg3XCPn/W6kdtRZtalZ50JNrzKxOFyptmqs0wq8VDOrJGng== X-Received: by 2002:a2e:8e8d:0:b0:298:6f36:dd6c with SMTP id z13-20020a2e8e8d000000b002986f36dd6cmr7223147ljk.11.1678806421025; Tue, 14 Mar 2023 08:07:01 -0700 (PDT) Received: from mobilestation ([95.79.133.202]) by smtp.gmail.com with ESMTPSA id f14-20020a2e9e8e000000b00295b1b6e063sm482600ljk.34.2023.03.14.08.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 08:07:00 -0700 (PDT) Date: Tue, 14 Mar 2023 18:06:57 +0300 From: Serge Semin To: Rob Herring Cc: Serge Semin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Coquelin , Krzysztof Kozlowski , Giuseppe Cavallaro , Pavel Parkhomenko , Jakub Kicinski , Jose Abreu , "David S. Miller" , Alexey Malahov , Paolo Abeni , Eric Dumazet , Biao Huang , netdev@vger.kernel.org, Christian Marangi , Yang Yingliang , Alexandre Torgue , Richard Cochran , linux-arm-kernel@lists.infradead.org, Rob Herring , linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH net-next 01/16] dt-bindings: net: dwmac: Validate PBL for all IP-cores Message-ID: <20230314150657.ytgyegi7qlwao6px@mobilestation> References: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> <20230313225103.30512-2-Sergey.Semin@baikalelectronics.ru> <167880254800.26004.7037306365469081272.robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <167880254800.26004.7037306365469081272.robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_080704_047494_8FA2ADE7 X-CRM114-Status: GOOD ( 26.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 14, 2023 at 09:10:19AM -0500, Rob Herring wrote: > > On Tue, 14 Mar 2023 01:50:48 +0300, Serge Semin wrote: > > Indeed the maximum DMA burst length can be programmed not only for DW > > xGMACs, Allwinner EMACs and Spear SoC GMAC, but in accordance with [1] > > for Generic DW *MAC IP-cores. Moreover the STMMAC set of drivers parse > > the property and then apply the configuration for all supported DW MAC > > devices. All of that makes the property being available for all IP-cores > > the bindings supports. Let's make sure the PBL-related properties are > > validated for all of them by the common DW MAC DT schema. > > > > [1] DesignWare Cores Ethernet MAC Universal Databook, Revision 3.73a, > > October 2013, p. 380. > > > > Signed-off-by: Serge Semin > > Reviewed-by: Rob Herring > > > > --- > > > > Changelog v1: > > - Use correct syntax of the JSON pointers, so the later would begin > > with a '/' after the '#'. > > --- > > .../devicetree/bindings/net/snps,dwmac.yaml | 77 +++++++------------ > > 1 file changed, 26 insertions(+), 51 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts', 'mac-address', 'phy-mode', 'reg', 'snps,reset-delays-us', 'snps,reset-gpio', 'snps,rxpbl', 'snps,txpbl' were unexpected) > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml Oops, on rebasing my work from older kernel I missed that the PBL properties constraints have already been extended. I'll drop the next patch in the series then and fix this one so the already defined constraints would be preserved. -Serge(y) > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230313225103.30512-2-Sergey.Semin@baikalelectronics.ru > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel