From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB1A8C05027 for ; Tue, 14 Mar 2023 17:10:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230478AbjCNRJ7 (ORCPT ); Tue, 14 Mar 2023 13:09:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230388AbjCNRJ4 (ORCPT ); Tue, 14 Mar 2023 13:09:56 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE2A379B23; Tue, 14 Mar 2023 10:09:50 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id m4so7922747lfj.2; Tue, 14 Mar 2023 10:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678813789; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=A3mTGYj7JV/DxYx8PY7Jjtyf3i3A4TY4QKPyGUShY+4=; b=Pt9FXMyV5qPTnBsN9S1/ue6ef/xHOAdmSIiLfyYu0b5z8FVXXS1yj4ZK1ucSROuPRG jDyAlusKmNAaEVi6bK3kDVBpf6AGWU9T7G5LNXbgXRxebGCYrJidVsFdZ+6LCbkTcR59 xnKKxVKWv9z9kJBHtIXobR8p6nSXCU3GzZTqFQP7wexHJsPLFmx2tZSCK/GA+REeelbu 0SxCODAFMY88ynul6wJCGBHe7NI+t6qu825Iptsp1ZbKcS8A9M1zyNkc1e1A84ehOq4o IdU+k74tQ+L39Bk+Fa/ESNr/YZwbgGVjHerqrj0/7/gdEYmlX3/IBoI1i1DggLgPpprn f2+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678813789; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A3mTGYj7JV/DxYx8PY7Jjtyf3i3A4TY4QKPyGUShY+4=; b=Vvp24ywrq1Jzu5HWi+Zxpa77lH+K+uctTX9pfh88EylYZlXXqUBwkA2+U3/gxg0g1d vhwBHMNfwLkyNFs0OVMv8sjesl/CnzF7IudTPzRqYMxo3skLdkgNfjjhA9A2vPeMkI3+ 00RKxSwwHC/5qDrG8cCaYUwI4+Ia1DMNIARTR4wYNmiEDHP6IW9jWiUXUrafxpUmBWNV j84K0jY8xDZssPtEFVfRZdGDGkO+OD8ryKC9fUSJBqsqOEKh8BkxCexv9WbrmA7n+TJy sIwjLW56JnnEIgDZWYQhCK1ggRXmyBgUC+7iqLL/XHQ6HR7v53TUO/C40RZgVIqnqaVW AtYg== X-Gm-Message-State: AO0yUKVlNdkNw1IcDaPcqQKc76RVVbCd73aLfDEsqyuE2O80TfIADrTU VvdXt8QEQLoay4JG8YAjijc= X-Google-Smtp-Source: AK7set+uEt5IoqG9OS+mes6VV9AY4oMiyZ0VVvoQaK5iRVnuv11mr63pkW7lH+CP6HBvafiA2+RvoQ== X-Received: by 2002:ac2:5449:0:b0:4e7:b481:c1c3 with SMTP id d9-20020ac25449000000b004e7b481c1c3mr1072908lfn.20.1678813788840; Tue, 14 Mar 2023 10:09:48 -0700 (PDT) Received: from mobilestation ([95.79.133.202]) by smtp.gmail.com with ESMTPSA id b7-20020a056512024700b004caf992bba9sm464219lfo.268.2023.03.14.10.09.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 10:09:48 -0700 (PDT) Date: Tue, 14 Mar 2023 20:09:45 +0300 From: Serge Semin To: Rob Herring Cc: Serge Semin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Coquelin , Krzysztof Kozlowski , Giuseppe Cavallaro , Pavel Parkhomenko , Jakub Kicinski , Jose Abreu , "David S. Miller" , Alexey Malahov , Paolo Abeni , Eric Dumazet , Biao Huang , netdev@vger.kernel.org, Christian Marangi , Yang Yingliang , Alexandre Torgue , Richard Cochran , linux-arm-kernel@lists.infradead.org, Rob Herring , linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH net-next 01/16] dt-bindings: net: dwmac: Validate PBL for all IP-cores Message-ID: <20230314170945.6yow2i5z4jdubwgt@mobilestation> References: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> <20230313225103.30512-2-Sergey.Semin@baikalelectronics.ru> <167880254800.26004.7037306365469081272.robh@kernel.org> <20230314150657.ytgyegi7qlwao6px@mobilestation> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230314150657.ytgyegi7qlwao6px@mobilestation> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 14, 2023 at 06:07:01PM +0300, Serge Semin wrote: > On Tue, Mar 14, 2023 at 09:10:19AM -0500, Rob Herring wrote: > > > > On Tue, 14 Mar 2023 01:50:48 +0300, Serge Semin wrote: > > > Indeed the maximum DMA burst length can be programmed not only for DW > > > xGMACs, Allwinner EMACs and Spear SoC GMAC, but in accordance with [1] > > > for Generic DW *MAC IP-cores. Moreover the STMMAC set of drivers parse > > > the property and then apply the configuration for all supported DW MAC > > > devices. All of that makes the property being available for all IP-cores > > > the bindings supports. Let's make sure the PBL-related properties are > > > validated for all of them by the common DW MAC DT schema. > > > > > > [1] DesignWare Cores Ethernet MAC Universal Databook, Revision 3.73a, > > > October 2013, p. 380. > > > > > > Signed-off-by: Serge Semin > > > Reviewed-by: Rob Herring > > > > > > --- > > > > > > Changelog v1: > > > - Use correct syntax of the JSON pointers, so the later would begin > > > with a '/' after the '#'. > > > --- > > > .../devicetree/bindings/net/snps,dwmac.yaml | 77 +++++++------------ > > > 1 file changed, 26 insertions(+), 51 deletions(-) > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts', 'mac-address', 'phy-mode', 'reg', 'snps,reset-delays-us', 'snps,reset-gpio', 'snps,rxpbl', 'snps,txpbl' were unexpected) > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > Oops, on rebasing my work from older kernel I missed that the PBL > properties constraints have already been extended. I'll drop the next > patch in the series then and fix this one so the already defined > constraints would be preserved. BTW it's strange I didn't have that bug spotted during my dt_binding_check run... -Serge(y) > > -Serge(y) > > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230313225103.30512-2-Sergey.Semin@baikalelectronics.ru > > > > The base for the series is generally the latest rc1. A different dependency > > should be noted in *this* patch. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit after running the above command yourself. Note > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > > your schema. However, it must be unset to test all examples with your schema. > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21C66C6FD1F for ; Tue, 14 Mar 2023 17:10:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XO/OtK9nsrREW8f3X96CfNm9OGaMW+5E1IQckuMBdB8=; b=eBHB5cU/rm91My ZvzyuEY86sybgn+Rxw768glgyKNhhvQy0D5YTWQKlNEQ11QM4DVgiQvAyeRQSNOURrSdmGdg2EOnA ldgjcJTZwsNU/mpTK8n5gq3LaRM8r78l+25W65gTxpSSSF25P0lUk/NW2zyqEQw1MDA0N+EtB6gJ+ iwCNoiTnsH72w/E+HQkEETLBZG+JvuebQ+BU5J6A+GeGfISmTTCBAzmzKAzu8nwt3cH7wm7EI8QL4 fpRJhIrFSIoYygDp+KrC46jX/yRS7D1ZIS72xid2d7sJFHgoXIBlwWub5OKzJMKP1P/O0XPOQ64F6 z9MjCOxyl7qOwtTpK+3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pc89s-00Awuy-0P; Tue, 14 Mar 2023 17:09:56 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pc89p-00AwtU-0L for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 17:09:54 +0000 Received: by mail-lf1-x135.google.com with SMTP id j11so20894001lfg.13 for ; Tue, 14 Mar 2023 10:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678813789; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=A3mTGYj7JV/DxYx8PY7Jjtyf3i3A4TY4QKPyGUShY+4=; b=Pt9FXMyV5qPTnBsN9S1/ue6ef/xHOAdmSIiLfyYu0b5z8FVXXS1yj4ZK1ucSROuPRG jDyAlusKmNAaEVi6bK3kDVBpf6AGWU9T7G5LNXbgXRxebGCYrJidVsFdZ+6LCbkTcR59 xnKKxVKWv9z9kJBHtIXobR8p6nSXCU3GzZTqFQP7wexHJsPLFmx2tZSCK/GA+REeelbu 0SxCODAFMY88ynul6wJCGBHe7NI+t6qu825Iptsp1ZbKcS8A9M1zyNkc1e1A84ehOq4o IdU+k74tQ+L39Bk+Fa/ESNr/YZwbgGVjHerqrj0/7/gdEYmlX3/IBoI1i1DggLgPpprn f2+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678813789; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A3mTGYj7JV/DxYx8PY7Jjtyf3i3A4TY4QKPyGUShY+4=; b=4i9z95K6Chzbk9oUe7Z4S45nFKsbzDMFk4HZgPtgiplel/O9YpQP72cBAmNMbawE1d 6i9ro3Z2QL++j0G1g3o/3dEiywnqUXfSLjmJlAk6/eUnfOVZZk626fA01mpDZAfRi8LD LbNqvasftfTtm+lqKYEAe4sNREslMXIAMcWTKma+3086tRZ8m3S81PfwXexZiEhAVGIU woaSOgxCs23N9u4s8etduA27SrSXwOmgkJDlehqjw172XWB0oKqgtmXokK8hxseJkAC6 nQzGeN1XkKZBGG/Ak3YFGBhg0FbKgo04FUPyCqeWWwJbtWyWlhqMRAZ1xeBb+eoUtieb u6lg== X-Gm-Message-State: AO0yUKUWILh3bhdpK34dtyRXc0tJ8Cwr/Z4CmWQOlwfWlwcwHwh1g1Yu S74034/rc9UyTiZBYd1/s+s= X-Google-Smtp-Source: AK7set+uEt5IoqG9OS+mes6VV9AY4oMiyZ0VVvoQaK5iRVnuv11mr63pkW7lH+CP6HBvafiA2+RvoQ== X-Received: by 2002:ac2:5449:0:b0:4e7:b481:c1c3 with SMTP id d9-20020ac25449000000b004e7b481c1c3mr1072908lfn.20.1678813788840; Tue, 14 Mar 2023 10:09:48 -0700 (PDT) Received: from mobilestation ([95.79.133.202]) by smtp.gmail.com with ESMTPSA id b7-20020a056512024700b004caf992bba9sm464219lfo.268.2023.03.14.10.09.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 10:09:48 -0700 (PDT) Date: Tue, 14 Mar 2023 20:09:45 +0300 From: Serge Semin To: Rob Herring Cc: Serge Semin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Coquelin , Krzysztof Kozlowski , Giuseppe Cavallaro , Pavel Parkhomenko , Jakub Kicinski , Jose Abreu , "David S. Miller" , Alexey Malahov , Paolo Abeni , Eric Dumazet , Biao Huang , netdev@vger.kernel.org, Christian Marangi , Yang Yingliang , Alexandre Torgue , Richard Cochran , linux-arm-kernel@lists.infradead.org, Rob Herring , linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH net-next 01/16] dt-bindings: net: dwmac: Validate PBL for all IP-cores Message-ID: <20230314170945.6yow2i5z4jdubwgt@mobilestation> References: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> <20230313225103.30512-2-Sergey.Semin@baikalelectronics.ru> <167880254800.26004.7037306365469081272.robh@kernel.org> <20230314150657.ytgyegi7qlwao6px@mobilestation> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230314150657.ytgyegi7qlwao6px@mobilestation> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_100953_145274_CCB2ADAB X-CRM114-Status: GOOD ( 28.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 14, 2023 at 06:07:01PM +0300, Serge Semin wrote: > On Tue, Mar 14, 2023 at 09:10:19AM -0500, Rob Herring wrote: > > > > On Tue, 14 Mar 2023 01:50:48 +0300, Serge Semin wrote: > > > Indeed the maximum DMA burst length can be programmed not only for DW > > > xGMACs, Allwinner EMACs and Spear SoC GMAC, but in accordance with [1] > > > for Generic DW *MAC IP-cores. Moreover the STMMAC set of drivers parse > > > the property and then apply the configuration for all supported DW MAC > > > devices. All of that makes the property being available for all IP-cores > > > the bindings supports. Let's make sure the PBL-related properties are > > > validated for all of them by the common DW MAC DT schema. > > > > > > [1] DesignWare Cores Ethernet MAC Universal Databook, Revision 3.73a, > > > October 2013, p. 380. > > > > > > Signed-off-by: Serge Semin > > > Reviewed-by: Rob Herring > > > > > > --- > > > > > > Changelog v1: > > > - Use correct syntax of the JSON pointers, so the later would begin > > > with a '/' after the '#'. > > > --- > > > .../devicetree/bindings/net/snps,dwmac.yaml | 77 +++++++------------ > > > 1 file changed, 26 insertions(+), 51 deletions(-) > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts', 'mac-address', 'phy-mode', 'reg', 'snps,reset-delays-us', 'snps,reset-gpio', 'snps,rxpbl', 'snps,txpbl' were unexpected) > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > Oops, on rebasing my work from older kernel I missed that the PBL > properties constraints have already been extended. I'll drop the next > patch in the series then and fix this one so the already defined > constraints would be preserved. BTW it's strange I didn't have that bug spotted during my dt_binding_check run... -Serge(y) > > -Serge(y) > > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230313225103.30512-2-Sergey.Semin@baikalelectronics.ru > > > > The base for the series is generally the latest rc1. A different dependency > > should be noted in *this* patch. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit after running the above command yourself. Note > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > > your schema. However, it must be unset to test all examples with your schema. > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel