From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13ED2C61DA4 for ; Wed, 15 Mar 2023 11:29:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229720AbjCOL3V (ORCPT ); Wed, 15 Mar 2023 07:29:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231431AbjCOL3R (ORCPT ); Wed, 15 Mar 2023 07:29:17 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 065C2136F0 for ; Wed, 15 Mar 2023 04:29:16 -0700 (PDT) Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcPJc-0007nK-Ro; Wed, 15 Mar 2023 12:29:08 +0100 Received: from pengutronix.de (unknown [IPv6:2a00:20:3059:9eeb:8134:2053:cf60:de3a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 06E301939E5; Wed, 15 Mar 2023 11:29:06 +0000 (UTC) Date: Wed, 15 Mar 2023 12:29:05 +0100 From: Marc Kleine-Budde To: Markus Schneider-Pargmann Cc: Krzysztof Kozlowski , Chandrasekar Ramakrishnan , Wolfgang Grandegger , Rob Herring , Krzysztof Kozlowski , Vincent MAILHOL , Simon Horman , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] dt-bindings: can: tcan4x5x: Add tcan4552 and tcan4553 variants Message-ID: <20230315112905.qutggrdnpsttbase@pengutronix.de> References: <20230314151201.2317134-1-msp@baylibre.com> <20230314151201.2317134-2-msp@baylibre.com> <680053bc-66fb-729f-ecdc-2f5fe511cecd@linaro.org> <20230315104914.qpwhnv6drjwau5jr@blmsp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nomegujo7vfexmwg" Content-Disposition: inline In-Reply-To: <20230315104914.qpwhnv6drjwau5jr@blmsp> X-SA-Exim-Connect-IP: 2a0a:edc0:0:b01:1d::7b X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-can@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org --nomegujo7vfexmwg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 15.03.2023 11:49:14, Markus Schneider-Pargmann wrote: > Hi Krzysztof, >=20 > On Tue, Mar 14, 2023 at 09:01:10PM +0100, Krzysztof Kozlowski wrote: > > On 14/03/2023 16:11, Markus Schneider-Pargmann wrote: > > > These two new chips do not have state or wake pins. > > >=20 > > > Signed-off-by: Markus Schneider-Pargmann > > > --- > > > .../devicetree/bindings/net/can/tcan4x5x.txt | 11 ++++++++-= -- > > > 1 file changed, 8 insertions(+), 3 deletions(-) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b= /Documentation/devicetree/bindings/net/can/tcan4x5x.txt > > > index e3501bfa22e9..38a2b5369b44 100644 > > > --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt > > > +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt > > > @@ -4,7 +4,10 @@ Texas Instruments TCAN4x5x CAN Controller > > > This file provides device node information for the TCAN4x5x interfac= e contains. > > > =20 > > > Required properties: > > > - - compatible: "ti,tcan4x5x" > > > + - compatible: > > > + "ti,tcan4x5x" or > > > + "ti,tcan4552" or > > > + "ti,tcan4553" > >=20 > > Awesome, they nicely fit into wildcard... Would be useful to deprecate > > the wildcard at some point and switch to proper compatibles in such > > case, because now they became confusing. > >=20 > > Anyway: > >=20 > > Acked-by: Krzysztof Kozlowski >=20 > Thank you. Indeed the old generic name could be replaced, unfortunately > I don't have a list of devices that this generic wildcard matches. The mcp251xfd driver supports "microchip,mcp2517fd", "microchip,mcp2518fd", "microchip,mcp251863", and "microchip,mcp251xfd". It always does auto detection and throws a warning if the found chip is not consistent with the firmware (DT, ACPI). Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --nomegujo7vfexmwg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmQRq/8ACgkQvlAcSiqK BOhz7Af+Ijf/SfgPsTnfv7fBmVGkSnNMyFFNZrx4qRYBaKVOQLO/yM1cbTi9nvpB +8Jb+Dar80wua5kHmFcb/Uipad3/MF/JtA8TPKB1CAagvEWgw2MIAKyzTVGJzPxR sSIlDOINkWgmmhEvN0C+jNT51CgvO/6+0j4ZidDf3lwBgyofKAK6lSD+y5UupLYJ /eKt/oQFhlgDMVeatstmBGh0eMO2XV+T2Q5t/MVdqa/teoUrIfp3i98MPLpfB1uh nPXml9k3s5LDhFGnq31TrCBfcQ8n/S0QnphX+dyIKIuHBoa9YhbYgLXZrCQEm+fu HwpLvTBfsA9deh1Xx9r4avsdU5zz0Q== =AotW -----END PGP SIGNATURE----- --nomegujo7vfexmwg--