From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95BA66123 for ; Wed, 15 Mar 2023 19:52:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 146D4C433EF; Wed, 15 Mar 2023 19:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678909965; bh=iQnIIa3j3jVCIFoKZPD3PBAOjjMIevquBxs1unHicG8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rcyaNxz8/V6etm++j+h2h8xJXf2ngdv4qki9jVImZKCjTKdq6lIcn5ascWngjnfvX LQpNGe6KTTxgd0SSB54YVxzvR/JQ2D704YtvUob7HG0vw+PqnpLUBVPvBQ4y0l/fjS jLShhOWzY/UQ5cJbBXkKXInUg7zIXBGzJtRLu7FECfDr3BQEC9wJc3YSi97Yu9e+k5 gwcu4dcHH/wGR/D8MDJVR1f7MgT0xFlQ6NyFO6HOwVWJ8vJmuMfKY5G3hrAG59KH+Y SA/3k/vSxKOt9tXTrBcLgFkF/I54Z0Pwws4FxuUEl8hzzXeJaAt65gKqIBT4l6WoN1 n2GDpbbm0CgwQ== Date: Wed, 15 Mar 2023 12:52:44 -0700 From: Jakub Kicinski To: Thorsten Leemhuis Cc: Linux regressions mailing list , Kuniyuki Iwashima , "David S. Miller" , Eric Dumazet , Paolo Abeni , David Ahern , Kuniyuki Iwashima , netdev@vger.kernel.org, Paul Holzinger , Martin KaFai Lau Subject: Re: [PATCH v1 net 1/2] tcp: Fix bind() conflict check for dual-stack wildcard address. Message-ID: <20230315125244.1fa0610a@kernel.org> In-Reply-To: <1f37c8d4-8a1d-bc06-5b65-9357a7766ad7@leemhuis.info> References: <20230312031904.4674-1-kuniyu@amazon.com> <20230312031904.4674-2-kuniyu@amazon.com> <533d3c1a-db7e-6ff2-1fdf-fb8bbbb7a14c@leemhuis.info> <20230315002625.49bac132@kernel.org> <1f37c8d4-8a1d-bc06-5b65-9357a7766ad7@leemhuis.info> Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 15 Mar 2023 09:05:29 +0100 Thorsten Leemhuis wrote: > On 15.03.23 08:26, Jakub Kicinski wrote: > > On Sun, 12 Mar 2023 12:42:48 +0100 Linux regression tracking (Thorsten > > Leemhuis) wrote: > >> Link: > >> https://lore.kernel.org/netdev/CAG_fn=Ud3zSW7AZWXc+asfMhZVL5ETnvuY44Pmyv4NPv-ijN-A@mail.gmail.com/ > >> [1] > >> Fixes: 5456262d2baa ("net: Fix incorrect address comparison when > >> searching for a bind2 bucket") > >> Reported-by: Paul Holzinger > >> Link: > >> https://lore.kernel.org/netdev/e21bf153-80b0-9ec0-15ba-e04a4ad42c34@redhat.com/ > >> [0] > > > > I tried to fix this manually when applying but: > > - your email client wraps your replies > > - please don't reply to patches with tags which will look to scripts > > and patchwork like tags it should pull into the submission > > (Reported-by in particular, here) > > Sorry for the mixup and thx for letting me know, will simply quote my > suggestion next time, that should avoid both problems. FWIW indenting with spaces would work too, for our scripts at least. We match on tags only at start of the line.