From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D267FC61DA4 for ; Wed, 15 Mar 2023 13:31:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232420AbjCONbY (ORCPT ); Wed, 15 Mar 2023 09:31:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232318AbjCONbO (ORCPT ); Wed, 15 Mar 2023 09:31:14 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABECB1A955; Wed, 15 Mar 2023 06:30:47 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 65B0768B05; Wed, 15 Mar 2023 14:30:40 +0100 (CET) Date: Wed, 15 Mar 2023 14:30:39 +0100 From: Christoph Hellwig To: Stefan Haberland Cc: Christoph Hellwig , Mike Christie , bvanassche@acm.org, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, james.bottomley@hansenpartnership.com, linux-block@vger.kernel.org, dm-devel@redhat.com, snitzer@kernel.org, axboe@kernel.dk, linux-nvme@lists.infradead.org, chaitanyak@nvidia.com, kbusch@kernel.org, target-devel@vger.kernel.org, Jan Hoeppner Subject: Re: [PATCH v4 02/18] block: Rename BLK_STS_NEXUS to BLK_STS_RESV_CONFLICT Message-ID: <20230315133039.GA24533@lst.de> References: <20230224174502.321490-1-michael.christie@oracle.com> <20230224174502.321490-3-michael.christie@oracle.com> <20230314171119.GB6780@lst.de> <33ed9615-b570-03c7-9a7a-d07f020d3222@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33ed9615-b570-03c7-9a7a-d07f020d3222@linux.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Mar 15, 2023 at 11:04:22AM +0100, Stefan Haberland wrote: > This also fits for the DASD case. We use this error code for a > reservation/locking conflict of the DASD device when the lock we > previously held was stolen. But that's not really a reservation conflict in the sense of the reservation API. Given that DASD doesn't support it it might not matter. Do you have applications that checks for the translated errno value? We'll probably at least want a comment documenting this status code. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 450EFC7618B for ; Wed, 15 Mar 2023 13:36:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678887377; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zVajKjHJH4T8MtlUPgf6h5p6E44FRaAwLhhN3J7nrpY=; b=cBYLEwJ2xp9fV3xh7rTsJC1uxhO8em5vzYm9bZVXF7wUlNRV5oka1EhdxyO+OWOMoOPJFb Nk3PnTIbPJwl7vof/gjb1dBRHoDWoSfqRwgoNaKR/9G9T9JfYQHNrKcK2WpUdqQoJWHa2R lqnE9j/D5yshAAEChH5dW1Txin/DfVA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-610--6jgw6vMMIG5EklO56FUVQ-1; Wed, 15 Mar 2023 09:36:16 -0400 X-MC-Unique: -6jgw6vMMIG5EklO56FUVQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6A92C85A5A3; Wed, 15 Mar 2023 13:36:13 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id A6365140E960; Wed, 15 Mar 2023 13:36:09 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7D78B19465BC; Wed, 15 Mar 2023 13:36:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6098119465B6 for ; Wed, 15 Mar 2023 13:30:50 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 93669140E991; Wed, 15 Mar 2023 13:30:50 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast08.extmail.prod.ext.rdu2.redhat.com [10.11.55.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8B75D1410F1B for ; Wed, 15 Mar 2023 13:30:50 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 47CDE38601A4 for ; Wed, 15 Mar 2023 13:30:50 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-593-49iHHxR2Pe-SqbNA7Ck6sQ-1; Wed, 15 Mar 2023 09:30:48 -0400 X-MC-Unique: 49iHHxR2Pe-SqbNA7Ck6sQ-1 Received: by verein.lst.de (Postfix, from userid 2407) id 65B0768B05; Wed, 15 Mar 2023 14:30:40 +0100 (CET) Date: Wed, 15 Mar 2023 14:30:39 +0100 From: Christoph Hellwig To: Stefan Haberland Message-ID: <20230315133039.GA24533@lst.de> References: <20230224174502.321490-1-michael.christie@oracle.com> <20230224174502.321490-3-michael.christie@oracle.com> <20230314171119.GB6780@lst.de> <33ed9615-b570-03c7-9a7a-d07f020d3222@linux.ibm.com> MIME-Version: 1.0 In-Reply-To: <33ed9615-b570-03c7-9a7a-d07f020d3222@linux.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Subject: Re: [dm-devel] [PATCH v4 02/18] block: Rename BLK_STS_NEXUS to BLK_STS_RESV_CONFLICT X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, linux-block@vger.kernel.org, chaitanyak@nvidia.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, snitzer@kernel.org, Jan Hoeppner , linux-nvme@lists.infradead.org, james.bottomley@hansenpartnership.com, dm-devel@redhat.com, target-devel@vger.kernel.org, kbusch@kernel.org, Christoph Hellwig , Mike Christie , bvanassche@acm.org Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Mar 15, 2023 at 11:04:22AM +0100, Stefan Haberland wrote: > This also fits for the DASD case. We use this error code for a > reservation/locking conflict of the DASD device when the lock we > previously held was stolen. But that's not really a reservation conflict in the sense of the reservation API. Given that DASD doesn't support it it might not matter. Do you have applications that checks for the translated errno value? We'll probably at least want a comment documenting this status code. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel