From: Stefan Hajnoczi <stefanha@redhat.com>
To: Hanna Czenczek <hreitz@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
Eric Blake <eblake@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Fam Zheng <fam@euphon.net>
Subject: Re: [RFC 0/2] Split padded I/O vectors exceeding IOV_MAX
Date: Wed, 15 Mar 2023 11:29:41 -0400 [thread overview]
Message-ID: <20230315152941.GD16636@fedora> (raw)
In-Reply-To: <20230315121330.29679-1-hreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
On Wed, Mar 15, 2023 at 01:13:28PM +0100, Hanna Czenczek wrote:
> Hi,
>
> We accept I/O vectors with up to 1024 (IOV_MAX) elements from guests.
> When a guest request does not conform to the underlying storage's
> alignment requirements, we pad it with head and/or tail buffers as
> necessary, which are simply appended to the I/O vector.
>
> As of 4c002cef, we (sensibly) check that such-padded vectors do not then
> exceed IOV_MAX. However, there seems to be no sensible error handling;
> instead, the guest simply receives an I/O error.
>
> That???s a problem, because it submitted a perfectly sensible I/O request
Looks like there is an encoding issue. I get 3 question marks instead of
an apostrophe. lore.kernel.org also renders mojibake:
https://lore.kernel.org/qemu-devel/20230315121330.29679-1-hreitz@redhat.com/
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-03-15 15:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 12:13 [RFC 0/2] Split padded I/O vectors exceeding IOV_MAX Hanna Czenczek
2023-03-15 12:13 ` [RFC 1/2] block: " Hanna Czenczek
2023-03-15 18:25 ` Eric Blake
2023-03-16 9:43 ` Hanna Czenczek
2023-03-15 18:48 ` Stefan Hajnoczi
2023-03-16 10:10 ` Hanna Czenczek
2023-03-16 17:44 ` Vladimir Sementsov-Ogievskiy
2023-03-17 8:05 ` Hanna Czenczek
2023-03-15 12:13 ` [RFC 2/2] iotests/iov-padding: New test Hanna Czenczek
2023-03-15 15:29 ` Stefan Hajnoczi [this message]
2023-03-15 16:05 ` [RFC 0/2] Split padded I/O vectors exceeding IOV_MAX Hanna Czenczek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315152941.GD16636@fedora \
--to=stefanha@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.