All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 1/2] Move semaphore/ tests to semop/
Date: Wed, 15 Mar 2023 18:47:54 +0100	[thread overview]
Message-ID: <20230315174754.GA172450@pevik> (raw)
In-Reply-To: <20230315131146.GD10248@localhost>

Hi Wei,

> > > There is no point in having two different directories with semop()
> > > testcaes so it would make sense to move these two tests into the
> > > syscalls/ipc/semop/ directory as semop04 and semop05.
> > > So we move ipc/semaphore/ tests to syscalls/ipc/semop/.
> > > Also update runtest files accordingly.

> > As I already stated, I'm not really sure this is good to do, but maybe I'm
> > missing something.  I wonder what others thing about it.

> Ah, you also start work on this?
No, I just shared my doubt about this move.

> Should i still continue work on this patch or not?
> To me this is not bad thing at least, we do some clean work and reorganize the test cases.

Probably yes, but I'd prefer somebody else from LTP maintainers has also acked this.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2023-03-15 17:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 13:25 [LTP] [PATCH v1] Move semaphore/ tests to semop/ Wei Gao via ltp
2023-01-19 18:00 ` Petr Vorel
2023-01-20  1:05 ` [LTP] [PATCH v2] " Wei Gao via ltp
2023-02-28  9:15   ` Richard Palethorpe
2023-03-02  7:15   ` [LTP] [PATCH v3 0/2] Refactor semaphore Wei Gao via ltp
2023-03-02  7:15     ` [LTP] [PATCH v3 1/2] Move semaphore/ tests to semop/ Wei Gao via ltp
2023-03-15 12:31       ` Petr Vorel
2023-03-15 13:11         ` Wei Gao via ltp
2023-03-15 17:47           ` Petr Vorel [this message]
2023-03-17 12:29         ` Li Wang
2023-03-19 17:05           ` Petr Vorel
2023-03-02  7:15     ` [LTP] [PATCH v3 2/2] semop04:Refactor with new API Wei Gao via ltp
2023-03-15 12:36       ` Petr Vorel
2023-03-15 13:03         ` Wei Gao via ltp
2023-03-15 18:39       ` Petr Vorel
2023-03-16  7:22     ` [LTP] [PATCH v4 0/2] Refactor semaphore Wei Gao via ltp
2023-03-16  7:22       ` [LTP] [PATCH v4 1/2] Move semaphore/ tests to semop/ Wei Gao via ltp
2023-03-16  7:22       ` [LTP] [PATCH v4 2/2] semop04:Refactor with new API Wei Gao via ltp
2023-05-29 18:34         ` Petr Vorel
2023-05-30 12:07         ` [LTP] [v5,2/2] semop04: Refactor " Wei Gao via ltp
2023-06-21 10:25           ` Petr Vorel
2023-08-29  9:20             ` Richard Palethorpe
2023-08-29 11:00           ` [LTP] [v6,2/2] " Wei Gao via ltp
2023-08-29 11:18             ` [LTP] [v7,2/2] " Wei Gao via ltp
2023-08-30 11:41               ` Andrea Cervesato via ltp
2023-09-01  7:38                 ` Richard Palethorpe
2023-09-02 11:32               ` [LTP] [PATCH v8] " Wei Gao via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230315174754.GA172450@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=wegao@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.