From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CD08C61DA4 for ; Thu, 16 Mar 2023 03:02:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229608AbjCPDCT (ORCPT ); Wed, 15 Mar 2023 23:02:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbjCPDCR (ORCPT ); Wed, 15 Mar 2023 23:02:17 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 012EEB5AAF for ; Wed, 15 Mar 2023 20:02:15 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id ja10so323294plb.5 for ; Wed, 15 Mar 2023 20:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678935735; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=a7EWiKEbOPUDyB/zyzM3aKt/kTkta+HN39sJbR4GK64=; b=zda6cwqWDW/ZoGfEs0UKEVqsEmth82V2Op4mAzethVMRg93zU57nyUl68JRhzcpOQv YN+splHI4ZJWsS/7IuLDd6eQ6IhqAmExpcMDGFcJH74LsNLvy7nFyJgX8l5XKJPzU29y etx3nvUnF9kQc3+2d644rev8b8j42vSrpcNryJtfor1+0OHitsM1CFkBqQUtMOQTjUMW Ci73rGO108SF3gs5JFXg0tOcVZDwiwQgpLwLDtZ8TkNv8TjbSiyJbfxg7QmfYjCWfzdl xVk2AWAn4INbBEb0vx1Tc4vcGVxouJHGcexIDc6fd6n25NJ45gABMovrDxFO2Pt4S3Oc 0JNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678935735; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a7EWiKEbOPUDyB/zyzM3aKt/kTkta+HN39sJbR4GK64=; b=ElXBj7Yx8DijtIYo1rGaljx0Wt7wjK6MrPqFJtwbkPAqMhr10DQZBpSnMFZgWpk98J eXLXfBU5A/fMFRjBclWMH8+lfaudq1MJqasByIafpjxRcu/l1cEa5v9kvloL1JszCHIk PWyyDI2YZHQzfZZ14VCDD/voLqpm1bdrkvvcvYr+dwzZCwbQ4At4kEqnaZq6bOPs5dX+ wzBTgCfmdzXsA1ouayGLqH+x1zeczsoVz9iaJj3e3abLAuPDT5sPhXApggdI16kKpOF1 faQ4HfRTtOn/P4l7kabeldRsXJ7MK+rj9111E+GYG/gsBuFo5/frcJH0TH7KFHzKthnK WKgg== X-Gm-Message-State: AO0yUKUnC9yu42b6rh9JX1LntQ5h328tGwWtSeSjmBO+E8P55bHpk++l RFbDrybyHRocN5BZidnH4wb9cw== X-Google-Smtp-Source: AK7set8c5ZrGL+nvSbQvYycqwXtRzHVmOwi5GpQiW2J6MANXBQteRhZRjSlj0F7wF52H79vCfsNpFQ== X-Received: by 2002:a05:6a20:729c:b0:cc:eb3b:56e9 with SMTP id o28-20020a056a20729c00b000cceb3b56e9mr2856563pzk.1.1678935735350; Wed, 15 Mar 2023 20:02:15 -0700 (PDT) Received: from leoy-yangtze.lan ([107.151.177.133]) by smtp.gmail.com with ESMTPSA id c20-20020aa78814000000b005907716bf8bsm1729115pfo.60.2023.03.15.20.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 20:02:14 -0700 (PDT) Date: Thu, 16 Mar 2023 11:02:06 +0800 From: Leo Yan To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Ian Rogers , John Garry , James Clark , Adrian Hunter , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 06/16] perf kvm: Introduce histograms data structures Message-ID: <20230316030206.GB2267252@leoy-yangtze.lan> References: <20230315145112.186603-1-leo.yan@linaro.org> <20230315145112.186603-7-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On Wed, Mar 15, 2023 at 04:45:53PM -0300, Arnaldo Carvalho de Melo wrote: [...] > Had to add: > > > diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c > index c4cb34df155fec67..b06c11d306a11cab 100644 > --- a/tools/perf/builtin-kvm.c > +++ b/tools/perf/builtin-kvm.c > @@ -85,7 +85,6 @@ static struct kvm_event_key keys[] = { > DEF_SORT_NAME_KEY(time, mean), > { NULL, NULL } > }; > -#endif // defined(HAVE_KVM_STAT_SUPPORT) && defined(HAVE_LIBTRACEEVENT) > > struct kvm_hists { > struct hists hists; > @@ -100,6 +99,7 @@ static int kvm_hists__init(void) > perf_hpp_list__init(&kvm_hists.list); > return 0; > } > +#endif // defined(HAVE_KVM_STAT_SUPPORT) && defined(HAVE_LIBTRACEEVENT) Thanks for fixing up, this is fine for me. Seems to me it is not a good practice to use macros (and nested macros) to mute or unmute big chunk code. I will try to refine the building builtin-kvm.c and prepare patches based on current code base. P.s. I saw this series has been picked up into your branch acme/tmp.perf-tools-next, if you want me to follow up anything, please let me know. Thank you! Leo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CD01C61DA4 for ; Thu, 16 Mar 2023 03:03:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l804OhwEKqneB/qB8pCLnBwlpgrJXyBj1o7TzGuTqfA=; b=PFppBbMZi8XDBc L/L4QXkc6tO2Q/nrj/SrOyxUoKRGUJxOglr0vGZg3kd5AzOYavwP3in18kcHO28YzAKD7Q/M64eD0 DgBYvzyfCgBzroM7+RG9HDeLQPrEm0e/VPuURUYzgPRqnr+QwcIwMgSe2XoYSzy9FhWOAzm/63PZf VcxLHjThkm1ImNX9v/TXYSV/4ZSlIyO6XXD1PqFhGbq1Enm6cVn4kU4WSW7dkLzpu94xbyKpyppWH zCVkJp+GTQMUkQ8xxJuNpXjeDwGyf8aNy0UVfaW2mu8H+sCYdBYu9i8Jig4UxUXDsqsfswdSZS90c iZ4fxT9AH1PwLb6QwKNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcdsi-00F2hD-2o; Thu, 16 Mar 2023 03:02:20 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcdsf-00F2gC-1C for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 03:02:18 +0000 Received: by mail-pl1-x62e.google.com with SMTP id a2so326571plm.4 for ; Wed, 15 Mar 2023 20:02:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678935735; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=a7EWiKEbOPUDyB/zyzM3aKt/kTkta+HN39sJbR4GK64=; b=zda6cwqWDW/ZoGfEs0UKEVqsEmth82V2Op4mAzethVMRg93zU57nyUl68JRhzcpOQv YN+splHI4ZJWsS/7IuLDd6eQ6IhqAmExpcMDGFcJH74LsNLvy7nFyJgX8l5XKJPzU29y etx3nvUnF9kQc3+2d644rev8b8j42vSrpcNryJtfor1+0OHitsM1CFkBqQUtMOQTjUMW Ci73rGO108SF3gs5JFXg0tOcVZDwiwQgpLwLDtZ8TkNv8TjbSiyJbfxg7QmfYjCWfzdl xVk2AWAn4INbBEb0vx1Tc4vcGVxouJHGcexIDc6fd6n25NJ45gABMovrDxFO2Pt4S3Oc 0JNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678935735; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a7EWiKEbOPUDyB/zyzM3aKt/kTkta+HN39sJbR4GK64=; b=TaJ7occR+wrPs1ebMAY+JIef/N59BJhpQLZmj6EMQeet16EMsk5r540rYp8a9B2y4R hq7ZQQn7TQxvg1EjU9XWAlQjpP+6WthDZfXkepKTCPXWCoCpXxfvQrV60tuEnoF6uZW3 kJVS/zd2G09W7HBJPYO8GPbq8usSipB3IIb42Ggl7SckR3GvO9cYkjmwvWhTvG7RVLG/ if7HxPVafdN2DQOhUKLEnXEW5CyMayyttitGpvTxOoW2OkkJpJ0/TJpPlMr/0lfa9uV7 wnogc5fqp7IrMvz1X3KaYbW7yIir6aozeEbM2HC92znErpnxACM3Pk+qjZGUUgn1kncF V0sg== X-Gm-Message-State: AO0yUKUj8e+XMMTbYtmNYZmU/ciG01ZYGuHZ8/v2AUUWrdysOwM+6G81 X6niPk5UTbY3F+7WbwM2uSSaoA== X-Google-Smtp-Source: AK7set8c5ZrGL+nvSbQvYycqwXtRzHVmOwi5GpQiW2J6MANXBQteRhZRjSlj0F7wF52H79vCfsNpFQ== X-Received: by 2002:a05:6a20:729c:b0:cc:eb3b:56e9 with SMTP id o28-20020a056a20729c00b000cceb3b56e9mr2856563pzk.1.1678935735350; Wed, 15 Mar 2023 20:02:15 -0700 (PDT) Received: from leoy-yangtze.lan ([107.151.177.133]) by smtp.gmail.com with ESMTPSA id c20-20020aa78814000000b005907716bf8bsm1729115pfo.60.2023.03.15.20.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 20:02:14 -0700 (PDT) Date: Thu, 16 Mar 2023 11:02:06 +0800 From: Leo Yan To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Ian Rogers , John Garry , James Clark , Adrian Hunter , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 06/16] perf kvm: Introduce histograms data structures Message-ID: <20230316030206.GB2267252@leoy-yangtze.lan> References: <20230315145112.186603-1-leo.yan@linaro.org> <20230315145112.186603-7-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230315_200217_497153_EA55E465 X-CRM114-Status: GOOD ( 16.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnaldo, On Wed, Mar 15, 2023 at 04:45:53PM -0300, Arnaldo Carvalho de Melo wrote: [...] > Had to add: > > > diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c > index c4cb34df155fec67..b06c11d306a11cab 100644 > --- a/tools/perf/builtin-kvm.c > +++ b/tools/perf/builtin-kvm.c > @@ -85,7 +85,6 @@ static struct kvm_event_key keys[] = { > DEF_SORT_NAME_KEY(time, mean), > { NULL, NULL } > }; > -#endif // defined(HAVE_KVM_STAT_SUPPORT) && defined(HAVE_LIBTRACEEVENT) > > struct kvm_hists { > struct hists hists; > @@ -100,6 +99,7 @@ static int kvm_hists__init(void) > perf_hpp_list__init(&kvm_hists.list); > return 0; > } > +#endif // defined(HAVE_KVM_STAT_SUPPORT) && defined(HAVE_LIBTRACEEVENT) Thanks for fixing up, this is fine for me. Seems to me it is not a good practice to use macros (and nested macros) to mute or unmute big chunk code. I will try to refine the building builtin-kvm.c and prepare patches based on current code base. P.s. I saw this series has been picked up into your branch acme/tmp.perf-tools-next, if you want me to follow up anything, please let me know. Thank you! Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel