From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C63EC74A5B for ; Fri, 17 Mar 2023 00:43:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229519AbjCQAnq (ORCPT ); Thu, 16 Mar 2023 20:43:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbjCQAnp (ORCPT ); Thu, 16 Mar 2023 20:43:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAA3892269 for ; Thu, 16 Mar 2023 17:43:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5304C6215B for ; Fri, 17 Mar 2023 00:43:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E4BFC4339B; Fri, 17 Mar 2023 00:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679013823; bh=YyCfKbxjgvWybnR8bIFObbOCoHv2+Y/xZgI58GUqC5A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qH+xAzcBy354ixBDRfQORl9eALx9vRbkTBGmRRxBNHyBmycLT5KQ/aqcboWIGKHLE YqG6Tlm2BOvUp8W8kfC98WOVVGimW2U5VM2Xd6yAbVhYA/nOT/xBtDaURvoI2CFUCI cdsp6AgsahCq3ntnx7bFOVBOmgilfYZeK47Mw12IwHhtzsgB/TvDc4ifxhgwxNSJ3z +MN9AtOgQAMZXjb/EigFNXXd+snWfaSZCoHN1EWkNw1V5dszx0TcJZa/oAzfY6L79E Xs2cryFI5cczCTvyCQrayDDUl+SmPd8SNxlGIErXMqA8ev8/vjvFYQ1ilKM9/dbLLb pGnpq+UC12iIA== Date: Thu, 16 Mar 2023 17:43:42 -0700 From: Jakub Kicinski To: joshwash@google.com Cc: netdev@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH net] gve: Cache link_speed value from device Message-ID: <20230316174342.3ca1d2bc@kernel.org> In-Reply-To: <20230316174227.6f38803a@kernel.org> References: <20230315174016.4193015-1-joshwash@google.com> <20230316174227.6f38803a@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 16 Mar 2023 17:42:27 -0700 Jakub Kicinski wrote: > If it needs to go in as a fix / to stable we need a bit more info about > the nature of the problem. What user-visible (or hypervisor-visible) > impact will be? What entity needs link info so often that it becomes > a problem? > > The code looks fine as an optimization, i.e. for net-next, but you say > "PATCH net" and there's a Fixes tag... Hm, actually it doesn't apply to either tree..