From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A6FCC7618A for ; Thu, 16 Mar 2023 20:40:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230205AbjCPUkr (ORCPT ); Thu, 16 Mar 2023 16:40:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229581AbjCPUkm (ORCPT ); Thu, 16 Mar 2023 16:40:42 -0400 Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4528DD58BF; Thu, 16 Mar 2023 13:40:41 -0700 (PDT) Received: by mail-il1-f171.google.com with SMTP id h5so1677734ile.13; Thu, 16 Mar 2023 13:40:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678999240; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D2MOq1ae2jmvldoEjIFleYkdU8muYIA0Owxizbdn6tU=; b=4rTp/gOpoCl3PFWORQnZ2F9WObJJ9Ft6PdpNi212uI24YmJl5EPz0u8YlpLTaCTfsk v9baAN/HoNmKslRHimc2jenMJDr1RGCVnUsOXkjmR5tfRLZ3av23a/U7/T/WySRsnf5U IzXG5S5UjNRqs0Min7YzdtXx+5KAD0cV4FFJgrXemOuNSFTpZ9EL++LPIwxnsXXGhRC3 S2QQzQuqsqzw9/pTTMHNJYACR/cmomfhqn6MfzsH4jIG5dIzmqErKhmHdo7kR0RywAdL bIXfix6catMWXKICn2TTEKFyI2Q3O5RHXfFD8q4RVIjXvEre9xZ8a5l/xqxRQcTYjjNh 9Qfg== X-Gm-Message-State: AO0yUKUF23QucrG0EqPJN7ZummLuE7qOV8fbm4Te7Y6u5s92m+mH/NHI OE01LxLlTlLKUk/vtxuByQ== X-Google-Smtp-Source: AK7set9VGmL4NQP8ptL/AQeYRXFeHQSoAkCWC9EhuNamHjr8AzWdzLTX5M2cZtySvCE9EkSC6peA6w== X-Received: by 2002:a92:d090:0:b0:317:99d0:8ad1 with SMTP id h16-20020a92d090000000b0031799d08ad1mr8619161ilh.21.1678999239994; Thu, 16 Mar 2023 13:40:39 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id m21-20020a0566380dd500b003eac69029e5sm81952jaj.79.2023.03.16.13.40.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 13:40:39 -0700 (PDT) Received: (nullmailer pid 3845579 invoked by uid 1000); Thu, 16 Mar 2023 20:40:37 -0000 Date: Thu, 16 Mar 2023 15:40:37 -0500 From: Rob Herring To: Serge Semin Cc: Serge Semin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Coquelin , Krzysztof Kozlowski , Giuseppe Cavallaro , Pavel Parkhomenko , Jakub Kicinski , Jose Abreu , "David S. Miller" , Alexey Malahov , Paolo Abeni , Eric Dumazet , Biao Huang , netdev@vger.kernel.org, Christian Marangi , Yang Yingliang , Alexandre Torgue , Richard Cochran , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH net-next 01/16] dt-bindings: net: dwmac: Validate PBL for all IP-cores Message-ID: <20230316204037.GA3844212-robh@kernel.org> References: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> <20230313225103.30512-2-Sergey.Semin@baikalelectronics.ru> <167880254800.26004.7037306365469081272.robh@kernel.org> <20230314150657.ytgyegi7qlwao6px@mobilestation> <20230314170945.6yow2i5z4jdubwgt@mobilestation> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230314170945.6yow2i5z4jdubwgt@mobilestation> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 14, 2023 at 08:09:45PM +0300, Serge Semin wrote: > On Tue, Mar 14, 2023 at 06:07:01PM +0300, Serge Semin wrote: > > On Tue, Mar 14, 2023 at 09:10:19AM -0500, Rob Herring wrote: > > > > > > On Tue, 14 Mar 2023 01:50:48 +0300, Serge Semin wrote: > > > > Indeed the maximum DMA burst length can be programmed not only for DW > > > > xGMACs, Allwinner EMACs and Spear SoC GMAC, but in accordance with [1] > > > > for Generic DW *MAC IP-cores. Moreover the STMMAC set of drivers parse > > > > the property and then apply the configuration for all supported DW MAC > > > > devices. All of that makes the property being available for all IP-cores > > > > the bindings supports. Let's make sure the PBL-related properties are > > > > validated for all of them by the common DW MAC DT schema. > > > > > > > > [1] DesignWare Cores Ethernet MAC Universal Databook, Revision 3.73a, > > > > October 2013, p. 380. > > > > > > > > Signed-off-by: Serge Semin > > > > Reviewed-by: Rob Herring > > > > > > > > --- > > > > > > > > Changelog v1: > > > > - Use correct syntax of the JSON pointers, so the later would begin > > > > with a '/' after the '#'. > > > > --- > > > > .../devicetree/bindings/net/snps,dwmac.yaml | 77 +++++++------------ > > > > 1 file changed, 26 insertions(+), 51 deletions(-) > > > > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts', 'mac-address', 'phy-mode', 'reg', 'snps,reset-delays-us', 'snps,reset-gpio', 'snps,rxpbl', 'snps,txpbl' were unexpected) > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > > > Oops, on rebasing my work from older kernel I missed that the PBL > > properties constraints have already been extended. I'll drop the next > > patch in the series then and fix this one so the already defined > > constraints would be preserved. > > BTW it's strange I didn't have that bug spotted during my > dt_binding_check run... Perhaps because you set DT_SCHEMA_FILES? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 096CAC6FD1F for ; Thu, 16 Mar 2023 20:41:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U0UWiSXFtCP/hF+61wkrKL6Ux6IZR2QnatcDI+vJjqw=; b=bupQ/16NWo1a25 kVTfEy6RxOtmUwnDNrba6Fk2cskhdy7S7W4p4a95edka/F4oHts3agh8zk4JPDdsmuDf6kLw8CZtY 8FaG+IXvSPYnGKz5RWDdV3gnE9Pk5b0P5oHbx3mHqJA+F1k1UskDZ7ztmnoOZlY10zpDLJ+NaGsvt RKf8Y5grwgDhujGqmYhOp06s1rE7EpAsOClgiwosR5Zez/KVzGqKQL1xSJt3RKaUbvZwbne3fDYGK rNtcVF9dT/fXTOcqJ6H8EXmbnc8cM11SX8BSvuD+G7XUdDZ/vjBlLCSeLcvNAcD3g9JtF6TnAQEoM rfUCbNt+OuDadO/g3ylw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcuOz-00HXIv-2L; Thu, 16 Mar 2023 20:40:45 +0000 Received: from mail-il1-f175.google.com ([209.85.166.175]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcuOw-00HXIH-2L for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 20:40:44 +0000 Received: by mail-il1-f175.google.com with SMTP id h7so1695829ila.5 for ; Thu, 16 Mar 2023 13:40:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678999240; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D2MOq1ae2jmvldoEjIFleYkdU8muYIA0Owxizbdn6tU=; b=Fw8jbYczQiEb3ld3Nti1DKwkcwPgfb15mytsBmlyhy7JiQx6xaqaDPzlr3LgeBXYV0 OnXqpNC8JULHNtQiyI6ohluHIglePCv5x/m/XyGPprfddB8qIlWSW+fS/pYkkXiQ+Bu4 A5vQg5k4mYUUOyxPlvzBNbEfmxmzbJgpNNvfHObaMf3rpcezv42J7LEsyCiRBF7Ime1q kHfvXS5woW2MXnEMbIx7pa9TGbIYt0cfg/FcqEmK7c/qtN3pjiFZ8j6oDiAUvIttjFia BBUxyJNXD3vC2UXTUkwKe2/DpaairjLaLQ3SV3BwnxlkRsEXW+Nab3592/hvnWC7xoFc ObZA== X-Gm-Message-State: AO0yUKWr+y6VdrLjU5f9X994KqkTifps4ulapTenRYkwrJgFyR3ys/6Y juTEPYOWqu/G0yj1qBC8uA== X-Google-Smtp-Source: AK7set9VGmL4NQP8ptL/AQeYRXFeHQSoAkCWC9EhuNamHjr8AzWdzLTX5M2cZtySvCE9EkSC6peA6w== X-Received: by 2002:a92:d090:0:b0:317:99d0:8ad1 with SMTP id h16-20020a92d090000000b0031799d08ad1mr8619161ilh.21.1678999239994; Thu, 16 Mar 2023 13:40:39 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id m21-20020a0566380dd500b003eac69029e5sm81952jaj.79.2023.03.16.13.40.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 13:40:39 -0700 (PDT) Received: (nullmailer pid 3845579 invoked by uid 1000); Thu, 16 Mar 2023 20:40:37 -0000 Date: Thu, 16 Mar 2023 15:40:37 -0500 From: Rob Herring To: Serge Semin Cc: Serge Semin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Coquelin , Krzysztof Kozlowski , Giuseppe Cavallaro , Pavel Parkhomenko , Jakub Kicinski , Jose Abreu , "David S. Miller" , Alexey Malahov , Paolo Abeni , Eric Dumazet , Biao Huang , netdev@vger.kernel.org, Christian Marangi , Yang Yingliang , Alexandre Torgue , Richard Cochran , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH net-next 01/16] dt-bindings: net: dwmac: Validate PBL for all IP-cores Message-ID: <20230316204037.GA3844212-robh@kernel.org> References: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> <20230313225103.30512-2-Sergey.Semin@baikalelectronics.ru> <167880254800.26004.7037306365469081272.robh@kernel.org> <20230314150657.ytgyegi7qlwao6px@mobilestation> <20230314170945.6yow2i5z4jdubwgt@mobilestation> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230314170945.6yow2i5z4jdubwgt@mobilestation> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_134042_765222_0517F8E4 X-CRM114-Status: GOOD ( 23.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 14, 2023 at 08:09:45PM +0300, Serge Semin wrote: > On Tue, Mar 14, 2023 at 06:07:01PM +0300, Serge Semin wrote: > > On Tue, Mar 14, 2023 at 09:10:19AM -0500, Rob Herring wrote: > > > > > > On Tue, 14 Mar 2023 01:50:48 +0300, Serge Semin wrote: > > > > Indeed the maximum DMA burst length can be programmed not only for DW > > > > xGMACs, Allwinner EMACs and Spear SoC GMAC, but in accordance with [1] > > > > for Generic DW *MAC IP-cores. Moreover the STMMAC set of drivers parse > > > > the property and then apply the configuration for all supported DW MAC > > > > devices. All of that makes the property being available for all IP-cores > > > > the bindings supports. Let's make sure the PBL-related properties are > > > > validated for all of them by the common DW MAC DT schema. > > > > > > > > [1] DesignWare Cores Ethernet MAC Universal Databook, Revision 3.73a, > > > > October 2013, p. 380. > > > > > > > > Signed-off-by: Serge Semin > > > > Reviewed-by: Rob Herring > > > > > > > > --- > > > > > > > > Changelog v1: > > > > - Use correct syntax of the JSON pointers, so the later would begin > > > > with a '/' after the '#'. > > > > --- > > > > .../devicetree/bindings/net/snps,dwmac.yaml | 77 +++++++------------ > > > > 1 file changed, 26 insertions(+), 51 deletions(-) > > > > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts', 'mac-address', 'phy-mode', 'reg', 'snps,reset-delays-us', 'snps,reset-gpio', 'snps,rxpbl', 'snps,txpbl' were unexpected) > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > > > Oops, on rebasing my work from older kernel I missed that the PBL > > properties constraints have already been extended. I'll drop the next > > patch in the series then and fix this one so the already defined > > constraints would be preserved. > > BTW it's strange I didn't have that bug spotted during my > dt_binding_check run... Perhaps because you set DT_SCHEMA_FILES? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel