From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89252C6FD1F for ; Thu, 16 Mar 2023 20:49:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230343AbjCPUth (ORCPT ); Thu, 16 Mar 2023 16:49:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229693AbjCPUtf (ORCPT ); Thu, 16 Mar 2023 16:49:35 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1088B2B281 for ; Thu, 16 Mar 2023 13:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678999723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=so3qFG339eU0WcPzgjTpfG6EeynpQDYCHVF6oNptDps=; b=c0mD5/l+s2c6i1G0PymBAEeLo2uD0+3Yykx1lyQPWtaQa+/pHfgJa3CSggI6512ao/Wr6q 6C8BUUQ64SuJ3Zjn8yFwIThUnnnONFv0iTB25gOM5g7PVN+f0ydDZLYzpkJFfyKET+DwhK Olps8576E/WiU+9xRBu9ZxyD+bUiUMw= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-JyKTu_U5M4anpXKgAQ2tig-1; Thu, 16 Mar 2023 16:48:42 -0400 X-MC-Unique: JyKTu_U5M4anpXKgAQ2tig-1 Received: by mail-qv1-f70.google.com with SMTP id a15-20020a0562140c2f00b005ad28a23cffso1723897qvd.6 for ; Thu, 16 Mar 2023 13:48:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678999721; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=so3qFG339eU0WcPzgjTpfG6EeynpQDYCHVF6oNptDps=; b=DPBsD6utEvwH6RYTKBbw/z06U+sPfLcGlqkYSfP4DkD26MhqxDLgdZlxGeAdFzRFTB G8iRflEvtJKTOlIJoA6QjM4WNtTT3fWOVDHZbf8uHEe9PhzvRx7C1Ez4q+aHQ40LyF/N pvd7mLn7Ah8ycTUktrVTv8wY4DxutifOm7BgXiMtVcOR3ItMu7f1VAz0OyDttZA2Tb2f 7xSZmEgLq/RKMQAk+oSLR/PZj3vq/W8Oh/HW9Zda0jK0vXEhK0NS2Qeliq+Te4XSqEKg ksjHqrGOmMBjX3SSrNFzFKmjWbWeHuRttnVUxOn4xXSvkjS8aeScvQfbib4SVajLbLAl lodQ== X-Gm-Message-State: AO0yUKWM14qL51TaXxFkw90uGs73oTiGRxrIyLrGSaZ50YVGyLVUqeyb uxP6YCscNmFZKQ5xq3FcijCF4vTVJ83Z1iKPtLvL8QRVbwS1c3Nzrlp54v+JQCAhIWUcQvCtz52 PlJ2Ocv37BJzutfQ62U8PisBeJvUHq+Fc X-Received: by 2002:ac8:5e0f:0:b0:3bf:be7d:b3e5 with SMTP id h15-20020ac85e0f000000b003bfbe7db3e5mr9466326qtx.41.1678999721610; Thu, 16 Mar 2023 13:48:41 -0700 (PDT) X-Google-Smtp-Source: AK7set8Whyb8vFNdaxwr/MNcdtIiEH3qdcW01Tns1x6/9oemqNNHEKPDuipZJ9O7h1rizKG+bdM1SQ== X-Received: by 2002:ac8:5e0f:0:b0:3bf:be7d:b3e5 with SMTP id h15-20020ac85e0f000000b003bfbe7db3e5mr9466304qtx.41.1678999721376; Thu, 16 Mar 2023 13:48:41 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id n185-20020a3740c2000000b007402fdda195sm236462qka.123.2023.03.16.13.48.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 13:48:40 -0700 (PDT) From: Tom Rix To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] ext4: remove unneeded check of nr_to_submit Date: Thu, 16 Mar 2023 16:48:31 -0400 Message-Id: <20230316204831.2472537-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cppcheck reports fs/ext4/page-io.c:516:51: style: Condition 'nr_to_submit' is always true [knownConditionTrueFalse] if (fscrypt_inode_uses_fs_layer_crypto(inode) && nr_to_submit) { ^ This earlier check to bail, makes this check unncessary /* Nothing to submit? Just unlock the page... */ if (!nr_to_submit) return 0; Signed-off-by: Tom Rix --- fs/ext4/page-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index 8703fd732abb..b847131bc958 100644 --- a/fs/ext4/page-io.c +++ b/fs/ext4/page-io.c @@ -513,7 +513,7 @@ int ext4_bio_write_page(struct ext4_io_submit *io, * (e.g. holes) to be unnecessarily encrypted, but this is rare and * can't happen in the common case of blocksize == PAGE_SIZE. */ - if (fscrypt_inode_uses_fs_layer_crypto(inode) && nr_to_submit) { + if (fscrypt_inode_uses_fs_layer_crypto(inode)) { gfp_t gfp_flags = GFP_NOFS; unsigned int enc_bytes = round_up(len, i_blocksize(inode)); -- 2.27.0