From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B497C6FD1F for ; Thu, 16 Mar 2023 20:50:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230358AbjCPUuv (ORCPT ); Thu, 16 Mar 2023 16:50:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229588AbjCPUus (ORCPT ); Thu, 16 Mar 2023 16:50:48 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E03137607C; Thu, 16 Mar 2023 13:50:46 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id x17so3997666lfu.5; Thu, 16 Mar 2023 13:50:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678999845; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Tm+CR5BUEZPIc6XrcLK40BWz/iwrOweB0rbSxedxb6c=; b=DgFpRDyQ6ojzdXRizZH6TFtk+GAyYW0lqAuQCMMBbGoDuLzPT0H77cdP1mV9opDXwB 6xKWAd7Th/DWIIx4BFYiTDX0yCcjvUuaDmHtHV+YakvBj2YSV2LiGMfn8b3JdMZeXRLD P/mQlgYRFi1Zz5icl6QD8T8iuq6vSd8Ig7g1qBh/N63rahkv78/GhY+ItG9FWuqTAwQC 6+j4mlgSlfPfztlufjqnWDckg6tKHnvUbVDktywcTfMyrxo5QjgRuyw8kI3bEaK/pqbX jMycNKQaHSAlbAIGyVOpgkjvcNByY775FhUI1LpaKp26skX+4dGlPqP0ASIPZ20i6lFv PypA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678999845; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Tm+CR5BUEZPIc6XrcLK40BWz/iwrOweB0rbSxedxb6c=; b=u8DGPALKPoF3yA4kTJNrUh4SCG0opSRYls61FdCI4AvBr8xpW159oy7letyyerMqea jz//PkejOC3pdA+oN39nmgqIHxtY3YJp47pDZOiXkn6Mz3ftMl37WiIK/PQDSMaR381+ w3O8V8earyKH03+8FX0IRrYuwWKkgIloHs+R/PJuUwPdtkXhdQWMfugNF+oNxwKfl/uU P6RVZ8JN9ncSjBkYefxKUxrck3TFx2g7EAJiXm0voatnRlwiHdJKvkh/Lpm5iJKEWql3 GefXI89WUg/TYXgGHg/7S4WnIWWOY9cghi+LFhKlHZVHy5S3geO7aVXncuWDyiWiVSUo Gx1g== X-Gm-Message-State: AO0yUKVbiyAK/NqsD69S/0PJjUbLxVIPGYFBe7p5qpURqL5cnQMVrNpX dGOGwznIBkSeodoJqgtJE+8= X-Google-Smtp-Source: AK7set93Hh4wAnzsV+brV3vssp16g1107+6Kt8j0R3UNFEyry4cAodJdQraD2u1FFr5AcThx4B+/YQ== X-Received: by 2002:a05:6512:33c7:b0:4dc:790c:9100 with SMTP id d7-20020a05651233c700b004dc790c9100mr280464lfg.12.1678999845018; Thu, 16 Mar 2023 13:50:45 -0700 (PDT) Received: from mobilestation ([95.79.133.202]) by smtp.gmail.com with ESMTPSA id 8-20020ac25688000000b004d863fa8681sm36473lfr.173.2023.03.16.13.50.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 13:50:44 -0700 (PDT) Date: Thu, 16 Mar 2023 23:50:41 +0300 From: Serge Semin To: Rob Herring Cc: Serge Semin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Coquelin , Krzysztof Kozlowski , Giuseppe Cavallaro , Pavel Parkhomenko , Jakub Kicinski , Jose Abreu , "David S. Miller" , Alexey Malahov , Paolo Abeni , Eric Dumazet , Biao Huang , netdev@vger.kernel.org, Christian Marangi , Yang Yingliang , Alexandre Torgue , Richard Cochran , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH net-next 01/16] dt-bindings: net: dwmac: Validate PBL for all IP-cores Message-ID: <20230316205041.vr6nrfbrrbwetng7@mobilestation> References: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> <20230313225103.30512-2-Sergey.Semin@baikalelectronics.ru> <167880254800.26004.7037306365469081272.robh@kernel.org> <20230314150657.ytgyegi7qlwao6px@mobilestation> <20230314170945.6yow2i5z4jdubwgt@mobilestation> <20230316204037.GA3844212-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230316204037.GA3844212-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 16, 2023 at 03:40:37PM -0500, Rob Herring wrote: > On Tue, Mar 14, 2023 at 08:09:45PM +0300, Serge Semin wrote: > > On Tue, Mar 14, 2023 at 06:07:01PM +0300, Serge Semin wrote: > > > On Tue, Mar 14, 2023 at 09:10:19AM -0500, Rob Herring wrote: > > > > > > > > On Tue, 14 Mar 2023 01:50:48 +0300, Serge Semin wrote: > > > > > Indeed the maximum DMA burst length can be programmed not only for DW > > > > > xGMACs, Allwinner EMACs and Spear SoC GMAC, but in accordance with [1] > > > > > for Generic DW *MAC IP-cores. Moreover the STMMAC set of drivers parse > > > > > the property and then apply the configuration for all supported DW MAC > > > > > devices. All of that makes the property being available for all IP-cores > > > > > the bindings supports. Let's make sure the PBL-related properties are > > > > > validated for all of them by the common DW MAC DT schema. > > > > > > > > > > [1] DesignWare Cores Ethernet MAC Universal Databook, Revision 3.73a, > > > > > October 2013, p. 380. > > > > > > > > > > Signed-off-by: Serge Semin > > > > > Reviewed-by: Rob Herring > > > > > > > > > > --- > > > > > > > > > > Changelog v1: > > > > > - Use correct syntax of the JSON pointers, so the later would begin > > > > > with a '/' after the '#'. > > > > > --- > > > > > .../devicetree/bindings/net/snps,dwmac.yaml | 77 +++++++------------ > > > > > 1 file changed, 26 insertions(+), 51 deletions(-) > > > > > > > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > > > yamllint warnings/errors: > > > > > > > > dtschema/dtc warnings/errors: > > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts', 'mac-address', 'phy-mode', 'reg', 'snps,reset-delays-us', 'snps,reset-gpio', 'snps,rxpbl', 'snps,txpbl' were unexpected) > > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > > > > > Oops, on rebasing my work from older kernel I missed that the PBL > > > properties constraints have already been extended. I'll drop the next > > > patch in the series then and fix this one so the already defined > > > constraints would be preserved. > > > > BTW it's strange I didn't have that bug spotted during my > > dt_binding_check run... > > Perhaps because you set DT_SCHEMA_FILES? Can't remember now. I might have missed that in the long log as well. Anyway I'll test it out one more time before fixing. Thanks for your response. -Serge(y) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41A08C7618A for ; Thu, 16 Mar 2023 20:51:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fHgK88t60cxYXq98KcyPmmRTx8dxD965AHPcDWH9f74=; b=3bgsd+UNZJuphD HxDNGpW4C+8lPg5HhvyNECe3+2skyF3Fkn+YsRarrkR1ak920AR09EB88d7mT6F1TbhpEPznCvoxG PZYHKCIWcaBfehKdNYtQY1zkRukZz8QzA1DVkWfMsa83LrB4sjAgLzQeouFbLKkfgD8RpoFdDFDbd +9mDp9ickG1xFd3tuoYxjIn38/cb8miCHX1CvLEYJTs7KnhXFDUr9g1JFjufDQpSK+UlRh7pQAzMx /spooDbKlx/guX3pBTQXKnbZbW4jSbdKo1olREBz/7ujod0G9nmqd7agJOvNv2fQfrFRZnmmsC2KL WdyCtHt4OT8go5Ny8/Ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcuYn-00HYWn-14; Thu, 16 Mar 2023 20:50:53 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcuYk-00HYVI-06 for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 20:50:51 +0000 Received: by mail-lf1-x136.google.com with SMTP id bp27so3989144lfb.6 for ; Thu, 16 Mar 2023 13:50:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678999845; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Tm+CR5BUEZPIc6XrcLK40BWz/iwrOweB0rbSxedxb6c=; b=DgFpRDyQ6ojzdXRizZH6TFtk+GAyYW0lqAuQCMMBbGoDuLzPT0H77cdP1mV9opDXwB 6xKWAd7Th/DWIIx4BFYiTDX0yCcjvUuaDmHtHV+YakvBj2YSV2LiGMfn8b3JdMZeXRLD P/mQlgYRFi1Zz5icl6QD8T8iuq6vSd8Ig7g1qBh/N63rahkv78/GhY+ItG9FWuqTAwQC 6+j4mlgSlfPfztlufjqnWDckg6tKHnvUbVDktywcTfMyrxo5QjgRuyw8kI3bEaK/pqbX jMycNKQaHSAlbAIGyVOpgkjvcNByY775FhUI1LpaKp26skX+4dGlPqP0ASIPZ20i6lFv PypA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678999845; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Tm+CR5BUEZPIc6XrcLK40BWz/iwrOweB0rbSxedxb6c=; b=AY0o1uHqqJA+KRtlGsvrCG5nwpibWR84AHBpSvf0S6ulWZurriMm8gdeu6cn0Qlkkk Cx12cMoo2bvWWpvQdn72W4fkmlrrOZC+zCWGS4V1ZIsqQ79QntOkyYnlosFVBXwh5JJV KLOOt+sAzrhFrsBk64j2spj/oTH4iVJnmErX8oglVF+UOK5kli3fMUhfW+1z5XLM3546 A/aSxz5Botleeg2/6FafR4hUKeRS/G7siQ1CazO2XkMAZG1EnMMHBXygv5PFc6Vm25sa beHJM801SydN0IHKQgaBAFz+DA/4mIkIonFwHaLUB0PHmMITu48SYIfwmb1JUaW4utLx 9A+A== X-Gm-Message-State: AO0yUKUrp7i81EQFn/ERP6+LlFmPAJ1AYf880k6S3Rafslwl28eeXOf1 briUxjhTCQBoKuTbb+w6lUU= X-Google-Smtp-Source: AK7set93Hh4wAnzsV+brV3vssp16g1107+6Kt8j0R3UNFEyry4cAodJdQraD2u1FFr5AcThx4B+/YQ== X-Received: by 2002:a05:6512:33c7:b0:4dc:790c:9100 with SMTP id d7-20020a05651233c700b004dc790c9100mr280464lfg.12.1678999845018; Thu, 16 Mar 2023 13:50:45 -0700 (PDT) Received: from mobilestation ([95.79.133.202]) by smtp.gmail.com with ESMTPSA id 8-20020ac25688000000b004d863fa8681sm36473lfr.173.2023.03.16.13.50.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 13:50:44 -0700 (PDT) Date: Thu, 16 Mar 2023 23:50:41 +0300 From: Serge Semin To: Rob Herring Cc: Serge Semin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Coquelin , Krzysztof Kozlowski , Giuseppe Cavallaro , Pavel Parkhomenko , Jakub Kicinski , Jose Abreu , "David S. Miller" , Alexey Malahov , Paolo Abeni , Eric Dumazet , Biao Huang , netdev@vger.kernel.org, Christian Marangi , Yang Yingliang , Alexandre Torgue , Richard Cochran , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH net-next 01/16] dt-bindings: net: dwmac: Validate PBL for all IP-cores Message-ID: <20230316205041.vr6nrfbrrbwetng7@mobilestation> References: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> <20230313225103.30512-2-Sergey.Semin@baikalelectronics.ru> <167880254800.26004.7037306365469081272.robh@kernel.org> <20230314150657.ytgyegi7qlwao6px@mobilestation> <20230314170945.6yow2i5z4jdubwgt@mobilestation> <20230316204037.GA3844212-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230316204037.GA3844212-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_135050_095004_AF1652CD X-CRM114-Status: GOOD ( 25.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 16, 2023 at 03:40:37PM -0500, Rob Herring wrote: > On Tue, Mar 14, 2023 at 08:09:45PM +0300, Serge Semin wrote: > > On Tue, Mar 14, 2023 at 06:07:01PM +0300, Serge Semin wrote: > > > On Tue, Mar 14, 2023 at 09:10:19AM -0500, Rob Herring wrote: > > > > > > > > On Tue, 14 Mar 2023 01:50:48 +0300, Serge Semin wrote: > > > > > Indeed the maximum DMA burst length can be programmed not only for DW > > > > > xGMACs, Allwinner EMACs and Spear SoC GMAC, but in accordance with [1] > > > > > for Generic DW *MAC IP-cores. Moreover the STMMAC set of drivers parse > > > > > the property and then apply the configuration for all supported DW MAC > > > > > devices. All of that makes the property being available for all IP-cores > > > > > the bindings supports. Let's make sure the PBL-related properties are > > > > > validated for all of them by the common DW MAC DT schema. > > > > > > > > > > [1] DesignWare Cores Ethernet MAC Universal Databook, Revision 3.73a, > > > > > October 2013, p. 380. > > > > > > > > > > Signed-off-by: Serge Semin > > > > > Reviewed-by: Rob Herring > > > > > > > > > > --- > > > > > > > > > > Changelog v1: > > > > > - Use correct syntax of the JSON pointers, so the later would begin > > > > > with a '/' after the '#'. > > > > > --- > > > > > .../devicetree/bindings/net/snps,dwmac.yaml | 77 +++++++------------ > > > > > 1 file changed, 26 insertions(+), 51 deletions(-) > > > > > > > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > > > yamllint warnings/errors: > > > > > > > > dtschema/dtc warnings/errors: > > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts', 'mac-address', 'phy-mode', 'reg', 'snps,reset-delays-us', 'snps,reset-gpio', 'snps,rxpbl', 'snps,txpbl' were unexpected) > > > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > > > > > Oops, on rebasing my work from older kernel I missed that the PBL > > > properties constraints have already been extended. I'll drop the next > > > patch in the series then and fix this one so the already defined > > > constraints would be preserved. > > > > BTW it's strange I didn't have that bug spotted during my > > dt_binding_check run... > > Perhaps because you set DT_SCHEMA_FILES? Can't remember now. I might have missed that in the long log as well. Anyway I'll test it out one more time before fixing. Thanks for your response. -Serge(y) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel