All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Rowand <frowand.list@gmail.com>
To: "Rob Herring" <robh+dt@kernel.org>,
	"Clément Léger" <clement.leger@bootlin.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lizhi Hou <lizhi.hou@xilinx.com>,
	Allan Nielsen <allan.nielsen@microchip.com>,
	Horatiu Vultur <horatiu.vultur@microchip.com>,
	Steen Hegelund <steen.hegelund@microchip.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: [PATCH v4 0/2] of: populate of_root_node if not set (alternate)
Date: Fri, 17 Mar 2023 00:34:13 -0500	[thread overview]
Message-ID: <20230317053415.2254616-1-frowand.list@gmail.com> (raw)

This series is a different implementation to achieve the goals of
https://lore.kernel.org/r/20220623105044.152832-1-clement.leger@bootlin.com

In order to apply overlays or create new nodes under the root node, the
kernel expects of_root to be set. On some system where a device-tree was
not provided by firmware (x86 for instance) if CONFIG_OF is enabled,
then we will end up with a null of_root. This series adds support to
create this root node using a builtin dtb and removes the manual
creation of the root node done in unittests.c.

Changes since version 3: (all)
  - also tested on UML (previously only tested on arm)

Changes since version 3: (patch 1/2)
  - refresh for 6.3-rc1
  - unflatten_device_tree() - calculate of_fdt_crc32 if setting
    initial_boot_params to __dtb_empty_root_begin so CRC check
    in of_fdt_raw_init() will not fail

Changes since version 3: (patch 2/2)
  - refresh for 6.3-rc1
  - remove the CONFIG_UML case of populating the devicetree
  - unittest_data_add() - move an EXPECT_BEGIN() to after an error
    check that can result in an early return

Changes since version 2: (patch 1/2)
  - change of __dtb_empty_root_* from "void *" to "uint8_t []"

Changes since version 1: (patch 1/2)
  - refresh for 6.2-rc1
  - update Signed-off-by
  - fix typo in of_fdt.h: s/of_setup/setup_of
  - unflatten_device_tree(): validate size in header field dtb_empty_root
    that will be used to copy dtb_empty_root
  - add Kconfig option to manually select CONFIG_OF_EARLY_FLATTREE

Changes since version 1: (patch 2/2)
  - refresh for 6.2-rc1
  - update Signed-off-by
  - fix formatting error (leading space) in patch comment



Frank Rowand (2):
  of: create of_root if no dtb provided
  of: unittest: treat missing of_root as error instead of fixing up

 drivers/of/Kconfig        |  7 ++++++-
 drivers/of/Makefile       |  2 +-
 drivers/of/empty_root.dts |  6 ++++++
 drivers/of/fdt.c          | 29 ++++++++++++++++++++++++++++-
 drivers/of/unittest.c     | 16 ++++------------
 include/linux/of_fdt.h    |  2 ++
 init/main.c               |  2 ++
 7 files changed, 49 insertions(+), 15 deletions(-)
 create mode 100644 drivers/of/empty_root.dts

-- 
Frank Rowand <frowand.list@gmail.com>


             reply	other threads:[~2023-03-17  5:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17  5:34 Frank Rowand [this message]
2023-03-17  5:34 ` [PATCH v4 1/2] of: create of_root if no dtb provided Frank Rowand
2023-03-31 18:04   ` Rob Herring
2024-03-18 17:09   ` Guenter Roeck
2024-03-18 19:26     ` Rob Herring
2024-03-18 20:47       ` Guenter Roeck
2024-03-18 21:31       ` Guenter Roeck
2024-03-20 19:14         ` Rob Herring
2024-03-20 20:05           ` Guenter Roeck
2024-03-27 13:11             ` Rob Herring
2024-03-27 14:40               ` Guenter Roeck
2024-03-27 18:38                 ` Rob Herring
2024-03-27 19:47                   ` Guenter Roeck
2024-03-27 21:56                     ` Rob Herring
2023-03-17  5:34 ` [PATCH v4 2/2] of: unittest: treat missing of_root as error instead of fixing up Frank Rowand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230317053415.2254616-1-frowand.list@gmail.com \
    --to=frowand.list@gmail.com \
    --cc=allan.nielsen@microchip.com \
    --cc=clement.leger@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=horatiu.vultur@microchip.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizhi.hou@xilinx.com \
    --cc=robh+dt@kernel.org \
    --cc=steen.hegelund@microchip.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.