From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5199C76195 for ; Fri, 17 Mar 2023 20:56:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230316AbjCQU4P (ORCPT ); Fri, 17 Mar 2023 16:56:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229987AbjCQU4N (ORCPT ); Fri, 17 Mar 2023 16:56:13 -0400 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B96AA5DEDD; Fri, 17 Mar 2023 13:56:07 -0700 (PDT) Received: by mail-io1-f54.google.com with SMTP id v10so2854714iol.9; Fri, 17 Mar 2023 13:56:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679086567; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BsmT8NNfgtZ1PRYiAmAwLcJbWZcQsKoINOi+pi4N8hw=; b=FMCL6CC7KnVgF6n47ppyLDq8GgigpeAZh/4pYzGkBESGO7xCC4+zvzb2m5WKR07SI3 NacMCpZtzykQgri5jj6RFihZC5AqzqxzSY51gRfo8iQlYjuchqkVgeUDKD+sPp4N0kDb idTCrIEZ2eNuouR4FDUbsd7s2oO3AkbN4EjmOCiMEl4k1O+DeEYt6jSuZSOX6VAcjHTG knvPGKugfnW3G6nK6wrUEzaYvoLqkYENeRx4/G/pb3LTokJrpmIM9B/SETSI1He/UEYL L8Q/BziRuLc+t5KdJQ5+b3PRqukn0MhmkdSkCo0mv3F3gnQih0FHGZM5+jUp+HbmO7w9 61Wg== X-Gm-Message-State: AO0yUKVxmIK5q2uTDB6059rSBvGSNhVpVq7MjXZGCSJHKjJDnpKLi3xo h7Ev3UaucricBo0W5PkJtA== X-Google-Smtp-Source: AK7set+ToKO0PixBlYFJyzo1fXru242mTxE/nxzBaShob3BSkATM7RWthimVc23v51gN8LFcASQXtw== X-Received: by 2002:a5e:950b:0:b0:74c:91c3:3837 with SMTP id r11-20020a5e950b000000b0074c91c33837mr505432ioj.18.1679086566973; Fri, 17 Mar 2023 13:56:06 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id d65-20020a026244000000b004062d749099sm1011915jac.51.2023.03.17.13.56.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 13:56:06 -0700 (PDT) Received: (nullmailer pid 2787143 invoked by uid 1000); Fri, 17 Mar 2023 20:56:04 -0000 Date: Fri, 17 Mar 2023 15:56:04 -0500 From: Rob Herring To: Serge Semin Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Krzysztof Kozlowski , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Christian Marangi , Richard Cochran , Biao Huang , Yang Yingliang , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 15/16] dt-bindings: net: dwmac: Simplify MTL queue props dependencies Message-ID: <20230317205604.GA2723387-robh@kernel.org> References: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> <20230313225103.30512-16-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230313225103.30512-16-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 14, 2023 at 01:51:02AM +0300, Serge Semin wrote: > Currently the Tx/Rx queues properties interdependencies are described by > means of the pattern: "if: required: X, then: properties: Y: false, Z: > false, etc". Due to very unfortunate MTL Tx/Rx queue DT-node design the > resultant sub-nodes schemas look very bulky and thus hard to read. The > situation can be improved by using the "allOf:/oneOf: required: X, > required: Y, etc" pattern instead thus getting shorter and a bit easier to > comprehend constructions. > > Signed-off-by: Serge Semin > > --- Reviewed-by: Rob Herring > > Note the solution can be shortened out a bit further by replacing the > single-entry allOf statements with just the "not: required: etc" pattern. > But in order to do that the DT-schema validation tool must be fixed like > this: > > --- a/meta-schemas/nodes.yaml 2021-02-08 14:20:56.732447780 +0300 > +++ b/meta-schemas/nodes.yaml 2021-02-08 14:21:00.736492245 +0300 > @@ -22,6 +22,7 @@ > - unevaluatedProperties > - deprecated > - required > + - not > - allOf > - anyOf > - oneOf This should be added regardless. Can you send a patch to devicetree-spec or a GH PR. But I'd skip using that here for now because then we require a new version of dtschema. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6C91C6FD1D for ; Fri, 17 Mar 2023 20:57:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OIGciHmdD0wHbSkCqocW4iPnoub54JPodugwBvozqCw=; b=SzFs9ceKNYsSjC CY12PKJRZLrBWDnRE9a+GkMm5eSvFQq1q6SMYMwyI7LubjxgBqj/nKjlTnMfLA0t3WZgUdCUPUTZc jHYgPqNC5AUhIyHu5QCcxMHq6x/8nPBFLpio9FQwOIuiFLjl+vV5pq4nbWDuQcC3rXLERhpoqwNrv 8kO8OcM0M+t1Dvm4MYeUFJVs9kgbaMqBT3xh7xBISlyP+VcN6xjEMG7XpPDEMtQcxvQUqdQXI8t5N VFA73kZtlKUDiN7U04I/jkKne27EcQe/oUzE1Hjdpw1Fnl7OLmgAA85UxXCLTv4mTtZ/notbVMNlP 6xBEXfhRpkIwZ2+CT75g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdH7S-003Mkb-34; Fri, 17 Mar 2023 20:56:10 +0000 Received: from mail-io1-f43.google.com ([209.85.166.43]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdH7Q-003Mk0-1w for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 20:56:09 +0000 Received: by mail-io1-f43.google.com with SMTP id v10so2854713iol.9 for ; Fri, 17 Mar 2023 13:56:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679086567; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BsmT8NNfgtZ1PRYiAmAwLcJbWZcQsKoINOi+pi4N8hw=; b=w1t7bKEpxf35U8uXoixhOPmqyuMIf0RXh0PS0gS64fMtEJT4MhsWc6oKYxoakQvIP5 nq8+FDvQKq3vxLmgxVv/jsB5iu+geqd/VNS23oktHcBK2QtQpXoimMZ8TgR9iDqy5zoE JhOviQXkJ3MNjLWzEFGNcDJJRqa0k8TVqNCBxhqUqxK/Dz+IqL6ElYfKFnukPBA5dk9l k2NH8c+GHeoM2AXjhNNsR0nWbn/spX0A+wP8s32meQNJ6qFc9Ajy0hekOxWhSjj+lWKj X/BTDJnfUCfYf1Zh0ET6LrNpjsdA78x0PAbdhBEOz6VrCOX/do36C9ETpyuVCAaDfBUN dWew== X-Gm-Message-State: AO0yUKWmGajAZlICmZtI6f00auIvQJfOu8Eu5gEbeTGi+6roS0TjoUMl 1wxrSA9w5oMEpV1MzLbXig== X-Google-Smtp-Source: AK7set+ToKO0PixBlYFJyzo1fXru242mTxE/nxzBaShob3BSkATM7RWthimVc23v51gN8LFcASQXtw== X-Received: by 2002:a5e:950b:0:b0:74c:91c3:3837 with SMTP id r11-20020a5e950b000000b0074c91c33837mr505432ioj.18.1679086566973; Fri, 17 Mar 2023 13:56:06 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id d65-20020a026244000000b004062d749099sm1011915jac.51.2023.03.17.13.56.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 13:56:06 -0700 (PDT) Received: (nullmailer pid 2787143 invoked by uid 1000); Fri, 17 Mar 2023 20:56:04 -0000 Date: Fri, 17 Mar 2023 15:56:04 -0500 From: Rob Herring To: Serge Semin Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Krzysztof Kozlowski , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Christian Marangi , Richard Cochran , Biao Huang , Yang Yingliang , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 15/16] dt-bindings: net: dwmac: Simplify MTL queue props dependencies Message-ID: <20230317205604.GA2723387-robh@kernel.org> References: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> <20230313225103.30512-16-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230313225103.30512-16-Sergey.Semin@baikalelectronics.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_135608_639455_4F6792DC X-CRM114-Status: GOOD ( 14.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 14, 2023 at 01:51:02AM +0300, Serge Semin wrote: > Currently the Tx/Rx queues properties interdependencies are described by > means of the pattern: "if: required: X, then: properties: Y: false, Z: > false, etc". Due to very unfortunate MTL Tx/Rx queue DT-node design the > resultant sub-nodes schemas look very bulky and thus hard to read. The > situation can be improved by using the "allOf:/oneOf: required: X, > required: Y, etc" pattern instead thus getting shorter and a bit easier to > comprehend constructions. > > Signed-off-by: Serge Semin > > --- Reviewed-by: Rob Herring > > Note the solution can be shortened out a bit further by replacing the > single-entry allOf statements with just the "not: required: etc" pattern. > But in order to do that the DT-schema validation tool must be fixed like > this: > > --- a/meta-schemas/nodes.yaml 2021-02-08 14:20:56.732447780 +0300 > +++ b/meta-schemas/nodes.yaml 2021-02-08 14:21:00.736492245 +0300 > @@ -22,6 +22,7 @@ > - unevaluatedProperties > - deprecated > - required > + - not > - allOf > - anyOf > - oneOf This should be added regardless. Can you send a patch to devicetree-spec or a GH PR. But I'd skip using that here for now because then we require a new version of dtschema. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel