From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA59BC74A5B for ; Sat, 18 Mar 2023 09:09:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229881AbjCRJJp (ORCPT ); Sat, 18 Mar 2023 05:09:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbjCRJJn (ORCPT ); Sat, 18 Mar 2023 05:09:43 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4436E532B5; Sat, 18 Mar 2023 02:09:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E387CB80E8E; Sat, 18 Mar 2023 09:09:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFBFEC433D2; Sat, 18 Mar 2023 09:09:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679130579; bh=XJM7bLjC4OnDoVUeihuHqQi5B/L/wn9z6qbuaPa9N9Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pYG+4jZLFWUkmj5opa9edpGSC6VszLhmAtAVy/BPtg6XbRX71w5vDKkIo87RAwbPi K+bydblwq347yN/3IW4kqPsqBgpLYdZQdLXB7XFax8PcQuGCzPXc40FfLzyiVYZCQl gctDTfmfr4B5pPUjGXcRy0+9E//2P1aP4l4GjM1a9yaaSI2gQVqS79PV1TFvRakxaw PRo3Aw9uFFcycO3GN9GW+n0q6NQP2NuH7n8bqTqrPAeiB7EaC4dfI91CZpw/7fnjA5 Hqbfk9o009BD6ss4PQzc7lo0h5MBLnt9I4CsKVlTx9SBHc5iXGV3PPI9bOS1FtXdDb dRBfXX51M2V9Q== Date: Sat, 18 Mar 2023 10:09:36 +0100 From: Andi Shyti To: Ryan Chen Cc: Andrew Jeffery , Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Rob Herring , Krzysztof Kozlowski , Philipp Zabel , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 Message-ID: <20230318090936.qvqozqfskpe5lja7@intel.intel> References: <20230226031321.3126756-1-ryan_chen@aspeedtech.com> <20230226031321.3126756-2-ryan_chen@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230226031321.3126756-2-ryan_chen@aspeedtech.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ryan, On Sun, Feb 26, 2023 at 11:13:20AM +0800, Ryan Chen wrote: > Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,timeout > aspeed,xfer-mode description for ast2600-i2cv2. > > Signed-off-by: Ryan Chen > --- > .../devicetree/bindings/i2c/aspeed,i2c.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > index f597f73ccd87..75de3ce41cf5 100644 > --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > @@ -49,6 +49,25 @@ properties: > description: > states that there is another master active on this bus > > + aspeed,timeout: > + type: boolean > + description: I2C bus timeout enable for master/slave mode Finally you can proceed with this. Please remove "aspeed,timeout" and use "i2c-scl-has-clk-low-timeout" instead. Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78742C74A5B for ; Sat, 18 Mar 2023 09:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2RyQi+kr90DUsFYVvTSLJUsTJLd743v5MaaouZTivsc=; b=BdZX77yL3inGlY spC6pPNCopEToLTmvYaJX98ilWaRJbMOsYl2x5GviRh2wbX1VVV1AIfMiV2/gHP41D7MUr50QlUqc nwQfYE/zjKOYNb+SGwKqmVnDgACQ5U+po/YbTyP9a//7zkslIvzurcXb5IIaYZD4d7oHCWIEs5cLP wOtpCjJc4Tv3xNE6z+LzOth7usswTRErPj6XcAO8ZLgqatoOsMfXbeddtjw0HRb1ZcTojlX12eYik ffwg1b2MVAbj6oatG7MnXPYL14K9FuTD56Pw23FiicWJH9G4+81UlgZXZRJQbFJHIAOI7ipaNjmgC wPMV5exzB/WcJMjqDkzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdSZM-004VDy-0O; Sat, 18 Mar 2023 09:09:44 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdSZJ-004VDc-1y for linux-arm-kernel@lists.infradead.org; Sat, 18 Mar 2023 09:09:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2492C60A2B; Sat, 18 Mar 2023 09:09:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFBFEC433D2; Sat, 18 Mar 2023 09:09:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679130579; bh=XJM7bLjC4OnDoVUeihuHqQi5B/L/wn9z6qbuaPa9N9Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pYG+4jZLFWUkmj5opa9edpGSC6VszLhmAtAVy/BPtg6XbRX71w5vDKkIo87RAwbPi K+bydblwq347yN/3IW4kqPsqBgpLYdZQdLXB7XFax8PcQuGCzPXc40FfLzyiVYZCQl gctDTfmfr4B5pPUjGXcRy0+9E//2P1aP4l4GjM1a9yaaSI2gQVqS79PV1TFvRakxaw PRo3Aw9uFFcycO3GN9GW+n0q6NQP2NuH7n8bqTqrPAeiB7EaC4dfI91CZpw/7fnjA5 Hqbfk9o009BD6ss4PQzc7lo0h5MBLnt9I4CsKVlTx9SBHc5iXGV3PPI9bOS1FtXdDb dRBfXX51M2V9Q== Date: Sat, 18 Mar 2023 10:09:36 +0100 From: Andi Shyti To: Ryan Chen Cc: Andrew Jeffery , Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Rob Herring , Krzysztof Kozlowski , Philipp Zabel , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 Message-ID: <20230318090936.qvqozqfskpe5lja7@intel.intel> References: <20230226031321.3126756-1-ryan_chen@aspeedtech.com> <20230226031321.3126756-2-ryan_chen@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230226031321.3126756-2-ryan_chen@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230318_020941_714472_93A8CB41 X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ryan, On Sun, Feb 26, 2023 at 11:13:20AM +0800, Ryan Chen wrote: > Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,timeout > aspeed,xfer-mode description for ast2600-i2cv2. > > Signed-off-by: Ryan Chen > --- > .../devicetree/bindings/i2c/aspeed,i2c.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > index f597f73ccd87..75de3ce41cf5 100644 > --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > @@ -49,6 +49,25 @@ properties: > description: > states that there is another master active on this bus > > + aspeed,timeout: > + type: boolean > + description: I2C bus timeout enable for master/slave mode Finally you can proceed with this. Please remove "aspeed,timeout" and use "i2c-scl-has-clk-low-timeout" instead. Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0A43C6FD20 for ; Wed, 22 Mar 2023 00:22:33 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Ph8Lc3W04z3cD2 for ; Wed, 22 Mar 2023 11:22:32 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=pYG+4jZL; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=andi.shyti@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=pYG+4jZL; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PdwDl2gDtz3bg5; Sat, 18 Mar 2023 20:09:43 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2492C60A2B; Sat, 18 Mar 2023 09:09:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFBFEC433D2; Sat, 18 Mar 2023 09:09:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679130579; bh=XJM7bLjC4OnDoVUeihuHqQi5B/L/wn9z6qbuaPa9N9Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pYG+4jZLFWUkmj5opa9edpGSC6VszLhmAtAVy/BPtg6XbRX71w5vDKkIo87RAwbPi K+bydblwq347yN/3IW4kqPsqBgpLYdZQdLXB7XFax8PcQuGCzPXc40FfLzyiVYZCQl gctDTfmfr4B5pPUjGXcRy0+9E//2P1aP4l4GjM1a9yaaSI2gQVqS79PV1TFvRakxaw PRo3Aw9uFFcycO3GN9GW+n0q6NQP2NuH7n8bqTqrPAeiB7EaC4dfI91CZpw/7fnjA5 Hqbfk9o009BD6ss4PQzc7lo0h5MBLnt9I4CsKVlTx9SBHc5iXGV3PPI9bOS1FtXdDb dRBfXX51M2V9Q== Date: Sat, 18 Mar 2023 10:09:36 +0100 From: Andi Shyti To: Ryan Chen Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 Message-ID: <20230318090936.qvqozqfskpe5lja7@intel.intel> References: <20230226031321.3126756-1-ryan_chen@aspeedtech.com> <20230226031321.3126756-2-ryan_chen@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230226031321.3126756-2-ryan_chen@aspeedtech.com> X-Mailman-Approved-At: Wed, 22 Mar 2023 11:17:46 +1100 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Philipp Zabel , linux-aspeed@lists.ozlabs.org, Andrew Jeffery , openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, Brendan Higgins , Rob Herring , Joel Stanley , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hi Ryan, On Sun, Feb 26, 2023 at 11:13:20AM +0800, Ryan Chen wrote: > Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,timeout > aspeed,xfer-mode description for ast2600-i2cv2. > > Signed-off-by: Ryan Chen > --- > .../devicetree/bindings/i2c/aspeed,i2c.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > index f597f73ccd87..75de3ce41cf5 100644 > --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > @@ -49,6 +49,25 @@ properties: > description: > states that there is another master active on this bus > > + aspeed,timeout: > + type: boolean > + description: I2C bus timeout enable for master/slave mode Finally you can proceed with this. Please remove "aspeed,timeout" and use "i2c-scl-has-clk-low-timeout" instead. Andi