From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3F2E79C7 for ; Tue, 21 Mar 2023 08:49:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679388573; x=1710924573; h=date:from:to:cc:subject:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=F0Aai9BhaA5K1wsF4Vod4yMCaBMdeTGqMNHzQ0Ugzio=; b=OKqIZ1504Tw0+Hks6nvnI5RRAw8RNC91xnDY3mKqM/5n00p+yKe42O8/ 5UzwL/XsqZm8Zfu8wAFL140o5VrARI4BqRCtWzHo39vbiiinI8U0xP1wL wwhwkJHcLGIxP91J4iEOJRPdeGsBUUIc4FGCRUusxHsbTZdXukxWZC0rO m3oxPfe7F6oHo2od7rY7AEXE/FVP7QdCxRcydrWzXwHb2lv+LElan59pT BNe/6SkPhohikcGhmnzJtXLSGdiYg7qiyFAIxXyKbl/h3RGpjX5jW3M0B LhDdyzeWJKxvKGjTKyXFf6fkCGJhDC0qHq40741ptpI/Om9J/AOaC4D3X A==; X-IronPort-AV: E=McAfee;i="6600,9927,10655"; a="337605724" X-IronPort-AV: E=Sophos;i="5.98,278,1673942400"; d="scan'208";a="337605724" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2023 01:49:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10655"; a="770548037" X-IronPort-AV: E=Sophos;i="5.98,278,1673942400"; d="scan'208";a="770548037" Received: from mtkaczyk-mobl.ger.corp.intel.com (HELO localhost) ([10.252.37.33]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2023 01:49:30 -0700 Date: Tue, 21 Mar 2023 09:49:26 +0100 From: Mariusz Tkaczyk To: Jes Sorensen Cc: NeilBrown , Song Liu , Linux regressions mailing list , linux-raid , LKML , Nikolay Kichukov Subject: Re: [PATCH - mdadm] mdopen: always try create_named_array() Message-ID: <20230321094926.00007a38@linux.intel.com> In-Reply-To: References: <167875238571.8008.9808655454439667586@noble.neil.brown.name> <318ff554-0694-64e1-72bd-d941a775a16f@trained-monkey.org> <167926378352.8008.3450187952660050637@noble.neil.brown.name> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 20 Mar 2023 13:15:35 -0400 Jes Sorensen wrote: > On 3/19/23 18:09, NeilBrown wrote: > > On Mon, 20 Mar 2023, Jes Sorensen wrote: > >> On 3/13/23 20:06, NeilBrown wrote: > >>> > >>> mdopen() will use create_named_array() to ask the kernel to create the > >>> given md array, but only if it is given a number or name. > >>> If it is NOT given a name and is required to choose one itself using > >>> find_free_devnm() it does NOT use create_named_array(). > >>> > >>> On kernels with CONFIG_BLOCK_LEGACY_AUTOLOAD not set, this can result in > >>> failure to assemble an array. This can particularly seen when the > >>> "name" of the array begins with a host name different to the name of the > >>> host running the command. > >>> > >>> So add the missing call to create_named_array(). > >>> > >>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217074 > >>> Signed-off-by: NeilBrown > >> > >> Applied! > > > > Thanks. > > > > Do you have plans for releasing 4.3? I'd like this patch to be in a > > numbered release for at least a few months before we change the kernel > > Kconfig to allow md to be built without CONFIG_BLOCK_LEGACY_AUTOLOAD. > > No immediate plans, but no reason why we shouldn't do it. I think > Mariusz has some pending changes he wants to get in as well, like the > error number stuff. > > So lets make this a call for submitting changes for mdadm that are > needed for the next release. > Hi Jes, My patches around names (where I added those errors) will be too risky to be merged and released in short period. I'm going to limit the supported characters for names- it could bring regressions in some non obvious cases and I would like to give user time to accept it and adopt their solutions to new naming policy. Let me see if the patches recently merged doesn't bring any critical regression, and we are free to go I think :) I will back with a results soon. Thanks, Mariusz