From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E0BAC74A5B for ; Tue, 21 Mar 2023 15:54:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4885D85C7B; Tue, 21 Mar 2023 16:54:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="azNysp6G"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 23B0380BAF; Tue, 21 Mar 2023 16:54:12 +0100 (CET) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A2B4985C95 for ; Tue, 21 Mar 2023 16:54:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id r16so18391365qtx.9 for ; Tue, 21 Mar 2023 08:54:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1679414046; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=l5CnW5gUuFKP26cEQE8J8C9u68v64naA9LvlmGkOXbE=; b=azNysp6Gh00jeRW6IpQafrxDBhji45KnOr9Zf4s3I+Yzu77QmL7NX3dTrbPf73eda/ hWCAejMNFbZlNTUvpT1tU69b/N/ctgumhFuKJm9ZTKYu02ONUY47WEyfCEvgGx6/uGRV wd7aPCOC192PYQxt389Jdb3HvXuygYeaLnbhE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679414046; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l5CnW5gUuFKP26cEQE8J8C9u68v64naA9LvlmGkOXbE=; b=ZEBkstWotQ44pOYafo36djLmosAS5U0ycRzpC+Gho2VMrycdFVBV/tDFfw7Q/KL0Q4 KIqwxI0PwY3c79MkZTbToo6tGABwnPIcdZl6QUIjCFnOW8dcBPNvh53D+J+gA1Lhat2M E2amWCg76KBC7VbzigWRtbAjnrotjOxM1zh9l0gnvXDTl/1vd/mV5e2mCvuIep6gqcXG fu3M1txcsRf6MblsT6zjz7tQUQSVffc7AIIOCmrR3IP8L8T1MReit9TOvV9dCzPbByQa 4Bls/Me4PorS8YnMW77j/SXt9xGR6HI1WOC5sf3j+qTkM08gp/Uvawd4rMyHDUirn7n5 qIiA== X-Gm-Message-State: AO0yUKV4VaUNVGeD3hKHaDl5HEF+BhSyCpEKjPmfSaE35RSpUKXzksTa t3Uqak2eH9oV9ECLd2WQ7LsbQTw+7MHfa42mSIt4LQ== X-Google-Smtp-Source: AK7set9KxlvThE5MmXv/QOAkj4YpFZ2+5QlUXEA4EaKZicuw5b9YVU/kHoAQQPN9HqcRJPBwzDHhMQ== X-Received: by 2002:ac8:5a07:0:b0:3e2:4280:bc5a with SMTP id n7-20020ac85a07000000b003e24280bc5amr495891qta.27.1679414046443; Tue, 21 Mar 2023 08:54:06 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-0c83-dcca-a3a0-54f4.res6.spectrum.com. [2603:6081:7b00:6400:c83:dcca:a3a0:54f4]) by smtp.gmail.com with ESMTPSA id x205-20020a3763d6000000b00741a8e96f25sm9579995qkb.88.2023.03.21.08.54.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 08:54:06 -0700 (PDT) Date: Tue, 21 Mar 2023 11:54:04 -0400 From: Tom Rini To: Stefan Herbrechtsmeier Cc: u-boot@lists.denx.de, Stefan Herbrechtsmeier , Simon Glass Subject: Re: [PATCH] fs: fat: do not mangle short filenames Message-ID: <20230321155404.GX8135@bill-the-cat> References: <20230317120413.11066-1-stefan.herbrechtsmeier-oss@weidmueller.com> <20230320170105.GA8135@bill-the-cat> <20230321153535.GS8135@bill-the-cat> <0ddfb023-08a4-8469-f467-c871cfd596bb@weidmueller.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IDOborKLPg59QAoN" Content-Disposition: inline In-Reply-To: <0ddfb023-08a4-8469-f467-c871cfd596bb@weidmueller.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --IDOborKLPg59QAoN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 21, 2023 at 04:53:22PM +0100, Stefan Herbrechtsmeier wrote: >=20 > Am 21.03.2023 um 16:35 schrieb Tom Rini: > > On Tue, Mar 21, 2023 at 08:43:07AM +0100, Stefan Herbrechtsmeier wrote: > > > Am 20.03.2023 um 18:01 schrieb Tom Rini: > > > > On Fri, Mar 17, 2023 at 01:04:13PM +0100, Stefan Herbrechtsmeier wr= ote: > > > >=20 > > > > > From: Stefan Herbrechtsmeier > > > > >=20 > > > > > Do not mangle lower or mixed case filenames which fit into the up= per > > > > > case 8.3 short filename. This ensures FAT standard compatible sho= rt > > > > > filenames (SFN) to support systems without long filename (LFN) su= pport > > > > > like boot roms (ex. SFN BOOT.BIN instead of BOOT~1.BIN for LFN > > > > > boot.bin). > > > > >=20 > > > > > Signed-off-by: Stefan Herbrechtsmeier > > > > >=20 > > > > > --- > > > > >=20 > > > > > fs/fat/fat_write.c | 11 +++++++---- > > > > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > Can we update test/py/tests/test_fs/ somewhere to have a test for t= his > > > > case? Thanks. > > > What is the recommended approach to test internal behavior? The short= name > > > isn't avialable at the terminal because u-boot support VFAT. > > Well, you triggered this problem with a filesystem that had contents > > that were "just so" and then didn't work as expected, yes? >=20 >=20 > No, I write a file to a file system and the boot rom do not find the file > because the name was wrong (BOOT~1.BIN instead of BOOT.BIN). >=20 > The mdir command shows the short and long file name. I will add a > test_fat.py with a test. Ah, ok, and great, thanks! --=20 Tom --IDOborKLPg59QAoN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQZ0xwACgkQFHw5/5Y0 tyxm7Qv+NUT1R71F/qdgmk5HbAdxNVcfYHQbB2GB7whzAPu/pCgr1ojWR6Kug77W 8TQWpAz7BwdHWWgH9iFGQmhkDmoeHR4KNLA8oX0YegpmS7LVBvy0+uUJmclo2JCK xyY0Ms8N3vxvd2qJj/sz3WYOxZDAXESQ0T1/fKelhR33iYRw/FULx2rMCluYz4OM yk1OCpGy5BSj7z/Y3Fol69H68e9BRNg5drQA01touVX0htPEFQ5zfNUmp+bx+y79 AvAPdj8jCVMwecwf7gIk9C+mdi71QQe9nqUzMODdJk8RL4xU2xqzvxkjK5+XXT9h +3AuAO3AJIKLgEHrBXJRpkvw8pRu3a7pxLMJuv1y8fgZdXBh8ApPe00CJJNoyaeL rA6nOpOyCq0AI55h9G7jH8qUyFIieCTX992LphzusMePfuZ+iGKGHwriCN7n34zp uxtZcf98xrxViKneCw86R0OIXpcJ92REvdr+EXbLGODzHI6DkJE9SMTFKeoL0vZD eUbTD6+9 =pdYV -----END PGP SIGNATURE----- --IDOborKLPg59QAoN--