From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB050C761AF for ; Tue, 21 Mar 2023 19:33:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230012AbjCUTdq (ORCPT ); Tue, 21 Mar 2023 15:33:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230031AbjCUTdn (ORCPT ); Tue, 21 Mar 2023 15:33:43 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A85223667 for ; Tue, 21 Mar 2023 12:32:40 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pehiX-0008Fj-Pz; Tue, 21 Mar 2023 20:32:21 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pehiW-005l6N-Ap; Tue, 21 Mar 2023 20:32:20 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pehiV-006qyD-4e; Tue, 21 Mar 2023 20:32:19 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Ryder Lee , Jianjun Wang , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Matthias Brugger Cc: Rob Herring , AngeloGioacchino Del Regno , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Subject: [PATCH 09/15] PCI: mediatek: Convert to platform remove callback returning void Date: Tue, 21 Mar 2023 20:32:02 +0100 Message-Id: <20230321193208.366561-10-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> References: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1861; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=BqTXbQjpydZd0O5aTX5s2W2EZwwLHi0+7AG52hoX150=; b=owGbwMvMwMXY3/A7olbonx/jabUkhhQpNlGGjOmvjdSlNeu/xc9tVYh2WVPy/73zjXw5rfiNe ZJ35b90MhqzMDByMciKKbLYN67JtKqSi+xc++8yzCBWJrApXJwCMBHZv+z//Taq3FVxK+pl/s2y ia1+7fM+X1bHXebLo+3Zi9duUhG3D0w+uKpcOLfDUST4/bcPF45MSJtpfitqqneb2VP++4u23hF 8Ncv4t5Bf0nXPtgmvgq7qKm32Y7CvvsPlcyK9YnN/5ktFM80XRxLmH+FsYzTs+9/18eXGJ+ot3I 75h6ddtCs75/FOcu7keTWVqhfXlSY+6hfOllUPP7LLP1n85N490/2e7V7uHSZuKjL5VvRVvz+XE zU3Oez/dX/TohUHr5ax+uqWb365+ve0E/bNKz3Z2JSMTHp2/niWfLE0P9lrV0GaSGBdjMvCawZ6 cn/6HB5K+rl27xZexneysPfR2S/5JytVEzwO+ObYdJoBAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pci@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pci/controller/pcie-mediatek.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c index ae5ad05ddc1d..7ee03400961b 100644 --- a/drivers/pci/controller/pcie-mediatek.c +++ b/drivers/pci/controller/pcie-mediatek.c @@ -1134,7 +1134,7 @@ static void mtk_pcie_free_resources(struct mtk_pcie *pcie) pci_free_resource_list(windows); } -static int mtk_pcie_remove(struct platform_device *pdev) +static void mtk_pcie_remove(struct platform_device *pdev) { struct mtk_pcie *pcie = platform_get_drvdata(pdev); struct pci_host_bridge *host = pci_host_bridge_from_priv(pcie); @@ -1146,8 +1146,6 @@ static int mtk_pcie_remove(struct platform_device *pdev) mtk_pcie_irq_teardown(pcie); mtk_pcie_put_resources(pcie); - - return 0; } static int mtk_pcie_suspend_noirq(struct device *dev) @@ -1239,7 +1237,7 @@ MODULE_DEVICE_TABLE(of, mtk_pcie_ids); static struct platform_driver mtk_pcie_driver = { .probe = mtk_pcie_probe, - .remove = mtk_pcie_remove, + .remove_new = mtk_pcie_remove, .driver = { .name = "mtk-pcie", .of_match_table = mtk_pcie_ids, -- 2.39.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BD39C6FD20 for ; Tue, 21 Mar 2023 19:34:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=25Bm1F2R8XNwyXQkVP3iwQqa7KivOMr4YCVBa9FOt6Y=; b=f4Id83lCWj/4mv mfPVhQ3j2tTEgwl6N4ZH9YIqENBOtW14OKE/vlOypNElPehWsM1jzYqdNIz21A/4QCjppbkzHrB6a aRtl62MauenSw73048mw8yeJodh8e82of3qcB2+97OcZf5/ZfbCf8PY6LBW0F13Yr/SdInr6iiyns V38tLKQPOd4Bm3IQvEhR2PvDFd47JCxNMBaPcA/IGgshezHOaAGNXXZhPxWFNl+cL1+zEHvBdGVCs dSRI+PedVV1cDNIqZe93QYxML08B0h0wlIDppO5cataW43Mz931jSwvxMkdpSKWDI+jAgrSTh8k5z txRmU8LJKvvP5QVOI4EQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pehja-00DVBE-1e; Tue, 21 Mar 2023 19:33:26 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pehin-00DUkE-0a for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 19:32:38 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pehiX-0008Fj-Pz; Tue, 21 Mar 2023 20:32:21 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pehiW-005l6N-Ap; Tue, 21 Mar 2023 20:32:20 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pehiV-006qyD-4e; Tue, 21 Mar 2023 20:32:19 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Ryder Lee , Jianjun Wang , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Matthias Brugger Cc: Rob Herring , AngeloGioacchino Del Regno , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Subject: [PATCH 09/15] PCI: mediatek: Convert to platform remove callback returning void Date: Tue, 21 Mar 2023 20:32:02 +0100 Message-Id: <20230321193208.366561-10-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> References: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1861; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=BqTXbQjpydZd0O5aTX5s2W2EZwwLHi0+7AG52hoX150=; b=owGbwMvMwMXY3/A7olbonx/jabUkhhQpNlGGjOmvjdSlNeu/xc9tVYh2WVPy/73zjXw5rfiNe ZJ35b90MhqzMDByMciKKbLYN67JtKqSi+xc++8yzCBWJrApXJwCMBHZv+z//Taq3FVxK+pl/s2y ia1+7fM+X1bHXebLo+3Zi9duUhG3D0w+uKpcOLfDUST4/bcPF45MSJtpfitqqneb2VP++4u23hF 8Ncv4t5Bf0nXPtgmvgq7qKm32Y7CvvsPlcyK9YnN/5ktFM80XRxLmH+FsYzTs+9/18eXGJ+ot3I 75h6ddtCs75/FOcu7keTWVqhfXlSY+6hfOllUPP7LLP1n85N490/2e7V7uHSZuKjL5VvRVvz+XE zU3Oez/dX/TohUHr5ax+uqWb365+ve0E/bNKz3Z2JSMTHp2/niWfLE0P9lrV0GaSGBdjMvCawZ6 cn/6HB5K+rl27xZexneysPfR2S/5JytVEzwO+ObYdJoBAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_123237_268489_3DEFD565 X-CRM114-Status: GOOD ( 16.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhlIC5yZW1vdmUoKSBjYWxsYmFjayBmb3IgYSBwbGF0Zm9ybSBkcml2ZXIgcmV0dXJucyBhbiBp bnQgd2hpY2ggbWFrZXMKbWFueSBkcml2ZXIgYXV0aG9ycyB3cm9uZ2x5IGFzc3VtZSBpdCdzIHBv c3NpYmxlIHRvIGRvIGVycm9yIGhhbmRsaW5nIGJ5CnJldHVybmluZyBhbiBlcnJvciBjb2RlLiBI b3dldmVyIHRoZSB2YWx1ZSByZXR1cm5lZCBpcyAobW9zdGx5KSBpZ25vcmVkCmFuZCB0aGlzIHR5 cGljYWxseSByZXN1bHRzIGluIHJlc291cmNlIGxlYWtzLiBUbyBpbXByb3ZlIGhlcmUgdGhlcmUg aXMgYQpxdWVzdCB0byBtYWtlIHRoZSByZW1vdmUgY2FsbGJhY2sgcmV0dXJuIHZvaWQuIEluIHRo ZSBmaXJzdCBzdGVwIG9mIHRoaXMKcXVlc3QgYWxsIGRyaXZlcnMgYXJlIGNvbnZlcnRlZCB0byAu cmVtb3ZlX25ldygpIHdoaWNoIGFscmVhZHkgcmV0dXJucwp2b2lkLgoKVHJpdmlhbGx5IGNvbnZl cnQgdGhpcyBkcml2ZXIgZnJvbSBhbHdheXMgcmV0dXJuaW5nIHplcm8gaW4gdGhlIHJlbW92ZQpj YWxsYmFjayB0byB0aGUgdm9pZCByZXR1cm5pbmcgdmFyaWFudC4KClNpZ25lZC1vZmYtYnk6IFV3 ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+Ci0tLQogZHJp dmVycy9wY2kvY29udHJvbGxlci9wY2llLW1lZGlhdGVrLmMgfCA2ICsrLS0tLQogMSBmaWxlIGNo YW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2 ZXJzL3BjaS9jb250cm9sbGVyL3BjaWUtbWVkaWF0ZWsuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xs ZXIvcGNpZS1tZWRpYXRlay5jCmluZGV4IGFlNWFkMDVkZGMxZC4uN2VlMDM0MDA5NjFiIDEwMDY0 NAotLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaWUtbWVkaWF0ZWsuYworKysgYi9kcml2 ZXJzL3BjaS9jb250cm9sbGVyL3BjaWUtbWVkaWF0ZWsuYwpAQCAtMTEzNCw3ICsxMTM0LDcgQEAg c3RhdGljIHZvaWQgbXRrX3BjaWVfZnJlZV9yZXNvdXJjZXMoc3RydWN0IG10a19wY2llICpwY2ll KQogCXBjaV9mcmVlX3Jlc291cmNlX2xpc3Qod2luZG93cyk7CiB9CiAKLXN0YXRpYyBpbnQgbXRr X3BjaWVfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCitzdGF0aWMgdm9pZCBt dGtfcGNpZV9yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKIHsKIAlzdHJ1Y3Qg bXRrX3BjaWUgKnBjaWUgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKIAlzdHJ1Y3QgcGNp X2hvc3RfYnJpZGdlICpob3N0ID0gcGNpX2hvc3RfYnJpZGdlX2Zyb21fcHJpdihwY2llKTsKQEAg LTExNDYsOCArMTE0Niw2IEBAIHN0YXRpYyBpbnQgbXRrX3BjaWVfcmVtb3ZlKHN0cnVjdCBwbGF0 Zm9ybV9kZXZpY2UgKnBkZXYpCiAJbXRrX3BjaWVfaXJxX3RlYXJkb3duKHBjaWUpOwogCiAJbXRr X3BjaWVfcHV0X3Jlc291cmNlcyhwY2llKTsKLQotCXJldHVybiAwOwogfQogCiBzdGF0aWMgaW50 IG10a19wY2llX3N1c3BlbmRfbm9pcnEoc3RydWN0IGRldmljZSAqZGV2KQpAQCAtMTIzOSw3ICsx MjM3LDcgQEAgTU9EVUxFX0RFVklDRV9UQUJMRShvZiwgbXRrX3BjaWVfaWRzKTsKIAogc3RhdGlj IHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgbXRrX3BjaWVfZHJpdmVyID0gewogCS5wcm9iZSA9IG10 a19wY2llX3Byb2JlLAotCS5yZW1vdmUgPSBtdGtfcGNpZV9yZW1vdmUsCisJLnJlbW92ZV9uZXcg PSBtdGtfcGNpZV9yZW1vdmUsCiAJLmRyaXZlciA9IHsKIAkJLm5hbWUgPSAibXRrLXBjaWUiLAog CQkub2ZfbWF0Y2hfdGFibGUgPSBtdGtfcGNpZV9pZHMsCi0tIAoyLjM5LjIKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==