From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C516EC6FD20 for ; Tue, 21 Mar 2023 19:33:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229906AbjCUTdc (ORCPT ); Tue, 21 Mar 2023 15:33:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229942AbjCUTdb (ORCPT ); Tue, 21 Mar 2023 15:33:31 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A247356164 for ; Tue, 21 Mar 2023 12:32:30 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pehiX-0008GA-Px; Tue, 21 Mar 2023 20:32:21 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pehiW-005l6S-KJ; Tue, 21 Mar 2023 20:32:20 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pehiV-006qyK-MY; Tue, 21 Mar 2023 20:32:19 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Sergio Paracuellos , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Matthias Brugger Cc: Rob Herring , AngeloGioacchino Del Regno , linux-pci@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH 11/15] PCI: mt7621: Convert to platform remove callback returning void Date: Tue, 21 Mar 2023 20:32:04 +0100 Message-Id: <20230321193208.366561-12-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> References: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1768; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=XIs1m3pob3y8U3JDqdDB0F399dkIu3Xz7ps7Nn8DeQo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkGgYXsgcJ2ulde0UGwO1bCPx5jrsNrNECByn/+ JqPq845BOqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZBoGFwAKCRCPgPtYfRL+ TqqMB/9ISFGGASsk4hij7f9GVng8JBFLx4hkxt8tP3dVXtzaEpJsrW43rj+GMIzWNujRUPUAk5d uxGzbOYhPOTduIaZ/55aj1K4+LZlaVIxkENJfukq0K/93WfUjxXTsR32lgf8fM/iJR1FQ2xhoGD Hk5R/h3+3tg5Rk0UeREiYjSnJovr70hHnFX4FjpGO6fX7yFkqABZ5gA4ZMHzpJUtcdsJhJNM+dU GTHRzKcrk4LwqBWK9XkV7SkPme9GwzjbVa/a4vLg4cR5oGiqNPEQOeAbsZL6YEqp6J10On3J6tg Hv8rVdRa1MVU+sGvGGIPPWSIW+4JbWTob5/KCrLGVbYbs9pu X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pci@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pci/controller/pcie-mt7621.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c index 63a5f4463a9f..a6df50a945d1 100644 --- a/drivers/pci/controller/pcie-mt7621.c +++ b/drivers/pci/controller/pcie-mt7621.c @@ -524,15 +524,13 @@ static int mt7621_pcie_probe(struct platform_device *pdev) return err; } -static int mt7621_pcie_remove(struct platform_device *pdev) +static void mt7621_pcie_remove(struct platform_device *pdev) { struct mt7621_pcie *pcie = platform_get_drvdata(pdev); struct mt7621_pcie_port *port; list_for_each_entry(port, &pcie->ports, list) reset_control_put(port->pcie_rst); - - return 0; } static const struct of_device_id mt7621_pcie_ids[] = { @@ -543,7 +541,7 @@ MODULE_DEVICE_TABLE(of, mt7621_pcie_ids); static struct platform_driver mt7621_pcie_driver = { .probe = mt7621_pcie_probe, - .remove = mt7621_pcie_remove, + .remove_new = mt7621_pcie_remove, .driver = { .name = "mt7621-pci", .of_match_table = mt7621_pcie_ids, -- 2.39.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B57B9C6FD1D for ; Tue, 21 Mar 2023 19:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KI6Q4iPFcGuMU898+k1FxvlS7EZmqQsc/+p8/lhXmKg=; b=u6x8dhvG8Cwro1 gjfBBBRH1HT855J6klfKOtIby6STwxwodabxTHkIFpcxTitq0SZIRGMsPM4MEZljPEmm/MHxB9qrA JzDbveTA1j/T1rjBclndPuwW8t4cFd5wAZOZ6p5sJL33vbjnzij/9iGpyrYgskiWkF5jRrp0uKJWS gLJeKK/NfcxI0ksmWrIFVUpuW3NFTj3WWzV6vkHo9uwgwxD+qSPGfgN8RyIrKMtFQQZOrFNPM5qgx SUt3oF2vt4Tnl+qoT57TEaJktY2Im0yLs6p9DAG4YOgvWFTZ7iuIpVOSolTrQNyy3PiMzQZ/ebkGm ev8LDDMktPPGQ7efHgrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pehil-00DUjM-1b; Tue, 21 Mar 2023 19:32:35 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pehii-00DUeJ-0Q for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 19:32:33 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pehiX-0008GA-Px; Tue, 21 Mar 2023 20:32:21 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pehiW-005l6S-KJ; Tue, 21 Mar 2023 20:32:20 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pehiV-006qyK-MY; Tue, 21 Mar 2023 20:32:19 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Sergio Paracuellos , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Matthias Brugger Cc: Rob Herring , AngeloGioacchino Del Regno , linux-pci@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH 11/15] PCI: mt7621: Convert to platform remove callback returning void Date: Tue, 21 Mar 2023 20:32:04 +0100 Message-Id: <20230321193208.366561-12-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> References: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1768; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=XIs1m3pob3y8U3JDqdDB0F399dkIu3Xz7ps7Nn8DeQo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkGgYXsgcJ2ulde0UGwO1bCPx5jrsNrNECByn/+ JqPq845BOqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZBoGFwAKCRCPgPtYfRL+ TqqMB/9ISFGGASsk4hij7f9GVng8JBFLx4hkxt8tP3dVXtzaEpJsrW43rj+GMIzWNujRUPUAk5d uxGzbOYhPOTduIaZ/55aj1K4+LZlaVIxkENJfukq0K/93WfUjxXTsR32lgf8fM/iJR1FQ2xhoGD Hk5R/h3+3tg5Rk0UeREiYjSnJovr70hHnFX4FjpGO6fX7yFkqABZ5gA4ZMHzpJUtcdsJhJNM+dU GTHRzKcrk4LwqBWK9XkV7SkPme9GwzjbVa/a4vLg4cR5oGiqNPEQOeAbsZL6YEqp6J10On3J6tg Hv8rVdRa1MVU+sGvGGIPPWSIW+4JbWTob5/KCrLGVbYbs9pu X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_123232_181678_145562B9 X-CRM114-Status: GOOD ( 16.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhlIC5yZW1vdmUoKSBjYWxsYmFjayBmb3IgYSBwbGF0Zm9ybSBkcml2ZXIgcmV0dXJucyBhbiBp bnQgd2hpY2ggbWFrZXMKbWFueSBkcml2ZXIgYXV0aG9ycyB3cm9uZ2x5IGFzc3VtZSBpdCdzIHBv c3NpYmxlIHRvIGRvIGVycm9yIGhhbmRsaW5nIGJ5CnJldHVybmluZyBhbiBlcnJvciBjb2RlLiBI b3dldmVyIHRoZSB2YWx1ZSByZXR1cm5lZCBpcyAobW9zdGx5KSBpZ25vcmVkCmFuZCB0aGlzIHR5 cGljYWxseSByZXN1bHRzIGluIHJlc291cmNlIGxlYWtzLiBUbyBpbXByb3ZlIGhlcmUgdGhlcmUg aXMgYQpxdWVzdCB0byBtYWtlIHRoZSByZW1vdmUgY2FsbGJhY2sgcmV0dXJuIHZvaWQuIEluIHRo ZSBmaXJzdCBzdGVwIG9mIHRoaXMKcXVlc3QgYWxsIGRyaXZlcnMgYXJlIGNvbnZlcnRlZCB0byAu cmVtb3ZlX25ldygpIHdoaWNoIGFscmVhZHkgcmV0dXJucwp2b2lkLgoKVHJpdmlhbGx5IGNvbnZl cnQgdGhpcyBkcml2ZXIgZnJvbSBhbHdheXMgcmV0dXJuaW5nIHplcm8gaW4gdGhlIHJlbW92ZQpj YWxsYmFjayB0byB0aGUgdm9pZCByZXR1cm5pbmcgdmFyaWFudC4KClNpZ25lZC1vZmYtYnk6IFV3 ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+Ci0tLQogZHJp dmVycy9wY2kvY29udHJvbGxlci9wY2llLW10NzYyMS5jIHwgNiArKy0tLS0KIDEgZmlsZSBjaGFu Z2VkLCAyIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVy cy9wY2kvY29udHJvbGxlci9wY2llLW10NzYyMS5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9w Y2llLW10NzYyMS5jCmluZGV4IDYzYTVmNDQ2M2E5Zi4uYTZkZjUwYTk0NWQxIDEwMDY0NAotLS0g YS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaWUtbXQ3NjIxLmMKKysrIGIvZHJpdmVycy9wY2kv Y29udHJvbGxlci9wY2llLW10NzYyMS5jCkBAIC01MjQsMTUgKzUyNCwxMyBAQCBzdGF0aWMgaW50 IG10NzYyMV9wY2llX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCiAJcmV0dXJu IGVycjsKIH0KIAotc3RhdGljIGludCBtdDc2MjFfcGNpZV9yZW1vdmUoc3RydWN0IHBsYXRmb3Jt X2RldmljZSAqcGRldikKK3N0YXRpYyB2b2lkIG10NzYyMV9wY2llX3JlbW92ZShzdHJ1Y3QgcGxh dGZvcm1fZGV2aWNlICpwZGV2KQogewogCXN0cnVjdCBtdDc2MjFfcGNpZSAqcGNpZSA9IHBsYXRm b3JtX2dldF9kcnZkYXRhKHBkZXYpOwogCXN0cnVjdCBtdDc2MjFfcGNpZV9wb3J0ICpwb3J0Owog CiAJbGlzdF9mb3JfZWFjaF9lbnRyeShwb3J0LCAmcGNpZS0+cG9ydHMsIGxpc3QpCiAJCXJlc2V0 X2NvbnRyb2xfcHV0KHBvcnQtPnBjaWVfcnN0KTsKLQotCXJldHVybiAwOwogfQogCiBzdGF0aWMg Y29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBtdDc2MjFfcGNpZV9pZHNbXSA9IHsKQEAgLTU0Myw3 ICs1NDEsNyBAQCBNT0RVTEVfREVWSUNFX1RBQkxFKG9mLCBtdDc2MjFfcGNpZV9pZHMpOwogCiBz dGF0aWMgc3RydWN0IHBsYXRmb3JtX2RyaXZlciBtdDc2MjFfcGNpZV9kcml2ZXIgPSB7CiAJLnBy b2JlID0gbXQ3NjIxX3BjaWVfcHJvYmUsCi0JLnJlbW92ZSA9IG10NzYyMV9wY2llX3JlbW92ZSwK KwkucmVtb3ZlX25ldyA9IG10NzYyMV9wY2llX3JlbW92ZSwKIAkuZHJpdmVyID0gewogCQkubmFt ZSA9ICJtdDc2MjEtcGNpIiwKIAkJLm9mX21hdGNoX3RhYmxlID0gbXQ3NjIxX3BjaWVfaWRzLAot LSAKMi4zOS4yCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=