From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55EEBC6FD20 for ; Tue, 21 Mar 2023 19:33:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229942AbjCUTdg (ORCPT ); Tue, 21 Mar 2023 15:33:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229980AbjCUTde (ORCPT ); Tue, 21 Mar 2023 15:33:34 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FAB5567BD for ; Tue, 21 Mar 2023 12:32:37 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pehiZ-0008JI-8m; Tue, 21 Mar 2023 20:32:23 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pehiY-005l6r-HO; Tue, 21 Mar 2023 20:32:22 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pehiW-006qya-WD; Tue, 21 Mar 2023 20:32:21 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Toan Le , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas Cc: Rob Herring , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 15/15] PCI: xgene-msi: Convert to platform remove callback returning void Date: Tue, 21 Mar 2023 20:32:08 +0100 Message-Id: <20230321193208.366561-16-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> References: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1764; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=g4mawOD/hBAIs+EkcP3CuSa/TPVhhAT1rILcKdZNAkA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkGgYcWPE7Y/ad4xZdZSWD/ZWyuqJ5nsaeZwjS+ N3udKv7GH2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZBoGHAAKCRCPgPtYfRL+ TnbIB/wNJy4Gp6R+qf4fCOZwbT+ibDo1HK35x46t90OiBBVxs0xPFsvTfQpgvhITYlEFwd9z3a2 huu5z5R4GkLuGXBVgUds2KrFNAnUAXj2UbLxGmCfsVwxT2hbRpJlM2H1kVDYfk09uu9D6C/bTSD +rrnqLnqW2quPlXQ0iv/kVRrlquHIeFJYXzmr660UODMYf3nNMFcLhP9WgF2S+YwHvuA7+lzpS3 mKbWSK5SoMgJWjXjXdykc4PeO9y5Voh7cBK+Rk6qwqd4WInaFPG0pJqAOwAbK8rvT6ibpckUUMI /m/Tt65Rr6g8h7mxdoUrw3luStocaElGrUnEVZ9woZqPLElJ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pci@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pci/controller/pci-xgene-msi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c index d7987b281f79..0234e528b9a5 100644 --- a/drivers/pci/controller/pci-xgene-msi.c +++ b/drivers/pci/controller/pci-xgene-msi.c @@ -348,7 +348,7 @@ static void xgene_msi_isr(struct irq_desc *desc) static enum cpuhp_state pci_xgene_online; -static int xgene_msi_remove(struct platform_device *pdev) +static void xgene_msi_remove(struct platform_device *pdev) { struct xgene_msi *msi = platform_get_drvdata(pdev); @@ -362,8 +362,6 @@ static int xgene_msi_remove(struct platform_device *pdev) msi->bitmap = NULL; xgene_free_domains(msi); - - return 0; } static int xgene_msi_hwirq_alloc(unsigned int cpu) @@ -521,7 +519,7 @@ static struct platform_driver xgene_msi_driver = { .of_match_table = xgene_msi_match_table, }, .probe = xgene_msi_probe, - .remove = xgene_msi_remove, + .remove_new = xgene_msi_remove, }; static int __init xgene_pcie_msi_init(void) -- 2.39.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E40FC6FD1D for ; Tue, 21 Mar 2023 19:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K4F9bTHi0j3VScHq+bBql7EEWYlU2k+JWTxbx0dWs/o=; b=4aD1vJk3AF4CDu 4577zVgXMtam4z+2BYnUDlOpQykTPMPNh64InlE4+RTd0yTVkWqRsy4OIEVfAi9YEv0aZM6EW0P/W J/uD4ovWoRpXfuMiTIDnkUeXQtJtc19oKJZ1p7gMrgPNTgk8FeroUMJMgSg8s1ro+ZtZyj3RXj8Ko 8J0ahdLZZaSLW4tCTTTNjRYsdTH6uf/nauieNosLVAzkfnKs+KQ4QI0CFkcz/yvp32KIaHB47zs0J 19pbsJf5LWQAy9lWFmXX2dp8hhtMBNzw4TpRJpqXhV8Iwk6ztpcDUR6gKsGq2zzg6hmqU3O9VkbTs 8E7ntRShW1+bj6B8V1lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pehjN-00DV0s-0O; Tue, 21 Mar 2023 19:33:13 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pehii-00DUei-0Q for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 19:32:35 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pehiZ-0008JI-8m; Tue, 21 Mar 2023 20:32:23 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pehiY-005l6r-HO; Tue, 21 Mar 2023 20:32:22 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pehiW-006qya-WD; Tue, 21 Mar 2023 20:32:21 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Toan Le , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas Cc: Rob Herring , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 15/15] PCI: xgene-msi: Convert to platform remove callback returning void Date: Tue, 21 Mar 2023 20:32:08 +0100 Message-Id: <20230321193208.366561-16-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> References: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1764; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=g4mawOD/hBAIs+EkcP3CuSa/TPVhhAT1rILcKdZNAkA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkGgYcWPE7Y/ad4xZdZSWD/ZWyuqJ5nsaeZwjS+ N3udKv7GH2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZBoGHAAKCRCPgPtYfRL+ TnbIB/wNJy4Gp6R+qf4fCOZwbT+ibDo1HK35x46t90OiBBVxs0xPFsvTfQpgvhITYlEFwd9z3a2 huu5z5R4GkLuGXBVgUds2KrFNAnUAXj2UbLxGmCfsVwxT2hbRpJlM2H1kVDYfk09uu9D6C/bTSD +rrnqLnqW2quPlXQ0iv/kVRrlquHIeFJYXzmr660UODMYf3nNMFcLhP9WgF2S+YwHvuA7+lzpS3 mKbWSK5SoMgJWjXjXdykc4PeO9y5Voh7cBK+Rk6qwqd4WInaFPG0pJqAOwAbK8rvT6ibpckUUMI /m/Tt65Rr6g8h7mxdoUrw3luStocaElGrUnEVZ9woZqPLElJ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_123232_296773_F44EDA75 X-CRM114-Status: GOOD ( 16.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhlIC5yZW1vdmUoKSBjYWxsYmFjayBmb3IgYSBwbGF0Zm9ybSBkcml2ZXIgcmV0dXJucyBhbiBp bnQgd2hpY2ggbWFrZXMKbWFueSBkcml2ZXIgYXV0aG9ycyB3cm9uZ2x5IGFzc3VtZSBpdCdzIHBv c3NpYmxlIHRvIGRvIGVycm9yIGhhbmRsaW5nIGJ5CnJldHVybmluZyBhbiBlcnJvciBjb2RlLiBI b3dldmVyIHRoZSB2YWx1ZSByZXR1cm5lZCBpcyAobW9zdGx5KSBpZ25vcmVkCmFuZCB0aGlzIHR5 cGljYWxseSByZXN1bHRzIGluIHJlc291cmNlIGxlYWtzLiBUbyBpbXByb3ZlIGhlcmUgdGhlcmUg aXMgYQpxdWVzdCB0byBtYWtlIHRoZSByZW1vdmUgY2FsbGJhY2sgcmV0dXJuIHZvaWQuIEluIHRo ZSBmaXJzdCBzdGVwIG9mIHRoaXMKcXVlc3QgYWxsIGRyaXZlcnMgYXJlIGNvbnZlcnRlZCB0byAu cmVtb3ZlX25ldygpIHdoaWNoIGFscmVhZHkgcmV0dXJucwp2b2lkLgoKVHJpdmlhbGx5IGNvbnZl cnQgdGhpcyBkcml2ZXIgZnJvbSBhbHdheXMgcmV0dXJuaW5nIHplcm8gaW4gdGhlIHJlbW92ZQpj YWxsYmFjayB0byB0aGUgdm9pZCByZXR1cm5pbmcgdmFyaWFudC4KClNpZ25lZC1vZmYtYnk6IFV3 ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+Ci0tLQogZHJp dmVycy9wY2kvY29udHJvbGxlci9wY2kteGdlbmUtbXNpLmMgfCA2ICsrLS0tLQogMSBmaWxlIGNo YW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2 ZXJzL3BjaS9jb250cm9sbGVyL3BjaS14Z2VuZS1tc2kuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xs ZXIvcGNpLXhnZW5lLW1zaS5jCmluZGV4IGQ3OTg3YjI4MWY3OS4uMDIzNGU1MjhiOWE1IDEwMDY0 NAotLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS14Z2VuZS1tc2kuYworKysgYi9kcml2 ZXJzL3BjaS9jb250cm9sbGVyL3BjaS14Z2VuZS1tc2kuYwpAQCAtMzQ4LDcgKzM0OCw3IEBAIHN0 YXRpYyB2b2lkIHhnZW5lX21zaV9pc3Ioc3RydWN0IGlycV9kZXNjICpkZXNjKQogCiBzdGF0aWMg ZW51bSBjcHVocF9zdGF0ZSBwY2lfeGdlbmVfb25saW5lOwogCi1zdGF0aWMgaW50IHhnZW5lX21z aV9yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKK3N0YXRpYyB2b2lkIHhnZW5l X21zaV9yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKIHsKIAlzdHJ1Y3QgeGdl bmVfbXNpICptc2kgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKIApAQCAtMzYyLDggKzM2 Miw2IEBAIHN0YXRpYyBpbnQgeGdlbmVfbXNpX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl ICpwZGV2KQogCW1zaS0+Yml0bWFwID0gTlVMTDsKIAogCXhnZW5lX2ZyZWVfZG9tYWlucyhtc2kp OwotCi0JcmV0dXJuIDA7CiB9CiAKIHN0YXRpYyBpbnQgeGdlbmVfbXNpX2h3aXJxX2FsbG9jKHVu c2lnbmVkIGludCBjcHUpCkBAIC01MjEsNyArNTE5LDcgQEAgc3RhdGljIHN0cnVjdCBwbGF0Zm9y bV9kcml2ZXIgeGdlbmVfbXNpX2RyaXZlciA9IHsKIAkJLm9mX21hdGNoX3RhYmxlID0geGdlbmVf bXNpX21hdGNoX3RhYmxlLAogCX0sCiAJLnByb2JlID0geGdlbmVfbXNpX3Byb2JlLAotCS5yZW1v dmUgPSB4Z2VuZV9tc2lfcmVtb3ZlLAorCS5yZW1vdmVfbmV3ID0geGdlbmVfbXNpX3JlbW92ZSwK IH07CiAKIHN0YXRpYyBpbnQgX19pbml0IHhnZW5lX3BjaWVfbXNpX2luaXQodm9pZCkKLS0gCjIu MzkuMgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK