From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 505DAC6FD1D for ; Tue, 21 Mar 2023 19:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229854AbjCUTd3 (ORCPT ); Tue, 21 Mar 2023 15:33:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230012AbjCUTd1 (ORCPT ); Tue, 21 Mar 2023 15:33:27 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49246574E8 for ; Tue, 21 Mar 2023 12:32:29 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pehiU-0008Dx-Eu; Tue, 21 Mar 2023 20:32:18 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pehiT-005l5l-Fv; Tue, 21 Mar 2023 20:32:17 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pehiS-006qxi-RX; Tue, 21 Mar 2023 20:32:16 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Thomas Petazzoni , =?utf-8?q?Pali_Roh=C3=A1r?= , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas Cc: Rob Herring , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 01/15] PCI: aardvark: Convert to platform remove callback returning void Date: Tue, 21 Mar 2023 20:31:54 +0100 Message-Id: <20230321193208.366561-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> References: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1826; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=VU8AjyDLbWZ5dqbt4iquWcUdOksnVkBSV+/E2xpJ7XA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkGgYMe8hHIINwAJXwV0g3+hkCe50iFo5TcCjOW FF9FY8qdNGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZBoGDAAKCRCPgPtYfRL+ TrPiB/9Cr48o7v2D92yY9Ucz4v+coWwl7NN3FpOZz5seMKIw2oui8ukSNtrf/TDlIAFiYUoRXy8 S3tX7Mk6ztaE9OnEWyxS1pQSrYiQEp72/NGbvcYzkQHBQOi3aqfd/GQfCbL/yRxyt0nJCmyp4pT P29Uee/RJfW9irKdc51XrslR2qIy+VljgBSpFNSIcRQI7+hM4YNTYstT48BeCV4raZUQ7ve/iGA CP/Ur4sFICxB2KwoIk+FvlyCBIuGFZBtuqvP5aAPEGtPqEdUUMazEKoXW0TItT4lIHqzDDwTxqT h1B30eGGT3xQgl4hbbBz679DzCTB/IS865sMIYW8lgn71S5S X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pci@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pci/controller/pci-aardvark.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index 513d8edf3a5c..71ecd7ddcc8a 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -1927,7 +1927,7 @@ static int advk_pcie_probe(struct platform_device *pdev) return 0; } -static int advk_pcie_remove(struct platform_device *pdev) +static void advk_pcie_remove(struct platform_device *pdev) { struct advk_pcie *pcie = platform_get_drvdata(pdev); struct pci_host_bridge *bridge = pci_host_bridge_from_priv(pcie); @@ -1989,8 +1989,6 @@ static int advk_pcie_remove(struct platform_device *pdev) /* Disable phy */ advk_pcie_disable_phy(pcie); - - return 0; } static const struct of_device_id advk_pcie_of_match_table[] = { @@ -2005,7 +2003,7 @@ static struct platform_driver advk_pcie_driver = { .of_match_table = advk_pcie_of_match_table, }, .probe = advk_pcie_probe, - .remove = advk_pcie_remove, + .remove_new = advk_pcie_remove, }; module_platform_driver(advk_pcie_driver); -- 2.39.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B768C74A5B for ; Tue, 21 Mar 2023 19:34:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t0FbRVK8TazIF3iBo5In9dk6p+kI2uY5P1cUqaq83cc=; b=1AN+PpGd45D+QV PSlMOyhBupp/A4VCBzjciDD1mSve8dAVGeTVmSSkzIAZFCe9rypKmjV4pshzFyp/OeLDsWe01/xOU t+FqMDPVlj9D0SPzTNB7OEfv161vRbngbMFgntNSG1/oxkB7lf4fpsIIValj5mrcblwBIr7JjjQZr 4p1HW/Gy/Pq6JxEI9yenIABMyRDqbABkeWTo7Sl93Bi4+14GJ/Cki09w9QRBeDbvjWXSYmhwP2woD sADywsAT3Mo01xMOAw1DmOCb3ZdJstZOwy8oZoY3W2cvGHdtSnAgXc5t/DPHbaX54VKAMIIctC47F qZ3pNSIGTExeRrjfJabw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pehin-00DUkx-1j; Tue, 21 Mar 2023 19:32:37 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pehii-00DUej-0Q for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 19:32:34 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pehiU-0008Dx-Eu; Tue, 21 Mar 2023 20:32:18 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pehiT-005l5l-Fv; Tue, 21 Mar 2023 20:32:17 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pehiS-006qxi-RX; Tue, 21 Mar 2023 20:32:16 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Thomas Petazzoni , =?utf-8?q?Pali_Roh=C3=A1r?= , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas Cc: Rob Herring , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 01/15] PCI: aardvark: Convert to platform remove callback returning void Date: Tue, 21 Mar 2023 20:31:54 +0100 Message-Id: <20230321193208.366561-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> References: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1826; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=VU8AjyDLbWZ5dqbt4iquWcUdOksnVkBSV+/E2xpJ7XA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkGgYMe8hHIINwAJXwV0g3+hkCe50iFo5TcCjOW FF9FY8qdNGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZBoGDAAKCRCPgPtYfRL+ TrPiB/9Cr48o7v2D92yY9Ucz4v+coWwl7NN3FpOZz5seMKIw2oui8ukSNtrf/TDlIAFiYUoRXy8 S3tX7Mk6ztaE9OnEWyxS1pQSrYiQEp72/NGbvcYzkQHBQOi3aqfd/GQfCbL/yRxyt0nJCmyp4pT P29Uee/RJfW9irKdc51XrslR2qIy+VljgBSpFNSIcRQI7+hM4YNTYstT48BeCV4raZUQ7ve/iGA CP/Ur4sFICxB2KwoIk+FvlyCBIuGFZBtuqvP5aAPEGtPqEdUUMazEKoXW0TItT4lIHqzDDwTxqT h1B30eGGT3xQgl4hbbBz679DzCTB/IS865sMIYW8lgn71S5S X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_123232_204360_A8E76C65 X-CRM114-Status: GOOD ( 16.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhlIC5yZW1vdmUoKSBjYWxsYmFjayBmb3IgYSBwbGF0Zm9ybSBkcml2ZXIgcmV0dXJucyBhbiBp bnQgd2hpY2ggbWFrZXMKbWFueSBkcml2ZXIgYXV0aG9ycyB3cm9uZ2x5IGFzc3VtZSBpdCdzIHBv c3NpYmxlIHRvIGRvIGVycm9yIGhhbmRsaW5nIGJ5CnJldHVybmluZyBhbiBlcnJvciBjb2RlLiBI b3dldmVyIHRoZSB2YWx1ZSByZXR1cm5lZCBpcyAobW9zdGx5KSBpZ25vcmVkCmFuZCB0aGlzIHR5 cGljYWxseSByZXN1bHRzIGluIHJlc291cmNlIGxlYWtzLiBUbyBpbXByb3ZlIGhlcmUgdGhlcmUg aXMgYQpxdWVzdCB0byBtYWtlIHRoZSByZW1vdmUgY2FsbGJhY2sgcmV0dXJuIHZvaWQuIEluIHRo ZSBmaXJzdCBzdGVwIG9mIHRoaXMKcXVlc3QgYWxsIGRyaXZlcnMgYXJlIGNvbnZlcnRlZCB0byAu cmVtb3ZlX25ldygpIHdoaWNoIGFscmVhZHkgcmV0dXJucwp2b2lkLgoKVHJpdmlhbGx5IGNvbnZl cnQgdGhpcyBkcml2ZXIgZnJvbSBhbHdheXMgcmV0dXJuaW5nIHplcm8gaW4gdGhlIHJlbW92ZQpj YWxsYmFjayB0byB0aGUgdm9pZCByZXR1cm5pbmcgdmFyaWFudC4KClNpZ25lZC1vZmYtYnk6IFV3 ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+Ci0tLQogZHJp dmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYyB8IDYgKystLS0tCiAxIGZpbGUgY2hh bmdlZCwgMiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZl cnMvcGNpL2NvbnRyb2xsZXIvcGNpLWFhcmR2YXJrLmMgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVy L3BjaS1hYXJkdmFyay5jCmluZGV4IDUxM2Q4ZWRmM2E1Yy4uNzFlY2Q3ZGRjYzhhIDEwMDY0NAot LS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1hYXJkdmFyay5jCisrKyBiL2RyaXZlcnMv cGNpL2NvbnRyb2xsZXIvcGNpLWFhcmR2YXJrLmMKQEAgLTE5MjcsNyArMTkyNyw3IEBAIHN0YXRp YyBpbnQgYWR2a19wY2llX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCiAJcmV0 dXJuIDA7CiB9CiAKLXN0YXRpYyBpbnQgYWR2a19wY2llX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlICpwZGV2KQorc3RhdGljIHZvaWQgYWR2a19wY2llX3JlbW92ZShzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpwZGV2KQogewogCXN0cnVjdCBhZHZrX3BjaWUgKnBjaWUgPSBwbGF0Zm9ybV9n ZXRfZHJ2ZGF0YShwZGV2KTsKIAlzdHJ1Y3QgcGNpX2hvc3RfYnJpZGdlICpicmlkZ2UgPSBwY2lf aG9zdF9icmlkZ2VfZnJvbV9wcml2KHBjaWUpOwpAQCAtMTk4OSw4ICsxOTg5LDYgQEAgc3RhdGlj IGludCBhZHZrX3BjaWVfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCiAKIAkv KiBEaXNhYmxlIHBoeSAqLwogCWFkdmtfcGNpZV9kaXNhYmxlX3BoeShwY2llKTsKLQotCXJldHVy biAwOwogfQogCiBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBhZHZrX3BjaWVfb2Zf bWF0Y2hfdGFibGVbXSA9IHsKQEAgLTIwMDUsNyArMjAwMyw3IEBAIHN0YXRpYyBzdHJ1Y3QgcGxh dGZvcm1fZHJpdmVyIGFkdmtfcGNpZV9kcml2ZXIgPSB7CiAJCS5vZl9tYXRjaF90YWJsZSA9IGFk dmtfcGNpZV9vZl9tYXRjaF90YWJsZSwKIAl9LAogCS5wcm9iZSA9IGFkdmtfcGNpZV9wcm9iZSwK LQkucmVtb3ZlID0gYWR2a19wY2llX3JlbW92ZSwKKwkucmVtb3ZlX25ldyA9IGFkdmtfcGNpZV9y ZW1vdmUsCiB9OwogbW9kdWxlX3BsYXRmb3JtX2RyaXZlcihhZHZrX3BjaWVfZHJpdmVyKTsKIAot LSAKMi4zOS4yCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=