From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D49F9C6FD1C for ; Wed, 22 Mar 2023 16:50:51 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 3BE461EDC6 for ; Wed, 22 Mar 2023 16:50:51 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 32244986462 for ; Wed, 22 Mar 2023 16:50:51 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 2807B98644E; Wed, 22 Mar 2023 16:50:51 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 18DE6986451 for ; Wed, 22 Mar 2023 16:50:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: cqf2ktiHMkK8hovrjR698w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679503848; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vhqh+BQQBBdbat255WNB0tqjHkcwgGeQB25spk76p0c=; b=TeZXppVr0F27xIG4YwjcTajPHpKBoahyh11CjmI4ryWry0Et5T0N9Fumpb+BfZ4ncq FD+5gtwht5BhmJ5i/P8im2vgK+Aj+3MfyXR4Y4CWc54/yF6KxQLzWKq5HJ/kqjdEHY5C 7UI1JXI6R+9qz6XKfEUlgeh7GeA36XNJ15J3af71KLwHWAodYIMZ7hyHKt/SXWevIFVC Z8CXqbJuJqYoNjLLrk6hFXc17pS0gaWwbrFjS2JAGQZkzHRylRZFcbq8TcIapubgfTc9 MqbWN+1TiynD67zOmI4mcx0IWBhldhQvr0ZTyZrWl5G6SfW3Ch35EaSq09Hyc2oRh5it Lzyw== X-Gm-Message-State: AO0yUKUxb/F2Rm+HF8dyU51C8V0tFmisTzLFNY8nJRMuac6AmYGXceR3 HCH7u5+DkgBXYTHLiJIz/2mLCH5t6HhD7bIZHlmLupu9FVinu3BuBkjjpStX6sMaqQVE2gKtSkJ 7a1+HuXSqdoOo6LqldcOK4JttD3sK X-Received: by 2002:a05:6402:2061:b0:4af:6e95:861b with SMTP id bd1-20020a056402206100b004af6e95861bmr2592853edb.2.1679503848114; Wed, 22 Mar 2023 09:50:48 -0700 (PDT) X-Google-Smtp-Source: AK7set81SGKBifejn140arc2c2+DwGhIUA3UbW/6I9BzGIv0ozTbMEdDxAqFgAt55TnqFL+1IYKchw== X-Received: by 2002:a05:6402:2061:b0:4af:6e95:861b with SMTP id bd1-20020a056402206100b004af6e95861bmr2592836edb.2.1679503847844; Wed, 22 Mar 2023 09:50:47 -0700 (PDT) Date: Wed, 22 Mar 2023 12:50:44 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: Cornelia Huck , Heng Qi , "virtio-dev@lists.oasis-open.org" , "virtio-comment@lists.oasis-open.org" , Jason Wang , Alvaro Karsz , David Edmondson , Xuan Zhuo Message-ID: <20230322124843-mutt-send-email-mst@kernel.org> References: <20230322125153.128385-1-hengqi@linux.alibaba.com> <87sfdwhkxq.fsf@redhat.com> <87pm90hhew.fsf@redhat.com> <87jzz8hh1w.fsf@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [virtio-comment] RE: [PATCH v13] virtio-net: support the virtqueue coalescing moderation On Wed, Mar 22, 2023 at 04:46:36PM +0000, Parav Pandit wrote: > > > From: Cornelia Huck > > Sent: Wednesday, March 22, 2023 12:44 PM > > > > >> Well, I think we want to avoid having to add a normative statement > > >> for the device, so we need to be strict with what the driver is allowed to do. > > > Drivers are untrusted entities. > > > device normative statement is needed, it will do the checks anyway where it > > is applying the config. > > > > But isn't that implementation specific? I.e. if the driver sends junk, the device > > needs to be able to deal with it in any case. > Not sure which part is implementation specific. > The device will deal with it and return an error code when supplied qid is invalid (of cvq or of disabled vq). spec currently defines, generally, how devices behave if driver matches spec. We do not generally specify what happens if driver is out of spec. For example it's ok for device to just get wedged until reset. It's doable to change this but if yes we should do it over the board. And the benefit, IMHO, is limited. And doing it just for the coalescing commands would be super weird. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D49CAC6FD1C for ; Wed, 22 Mar 2023 16:51:02 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 4276742A6D for ; Wed, 22 Mar 2023 16:51:02 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 2DF03986462 for ; Wed, 22 Mar 2023 16:51:02 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 24CD798644E; Wed, 22 Mar 2023 16:51:02 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 0BAA0986451 for ; Wed, 22 Mar 2023 16:50:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: 6nBA8wQEPXCro7bYpOi4qQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679503848; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vhqh+BQQBBdbat255WNB0tqjHkcwgGeQB25spk76p0c=; b=br3B6Y8Bt3+awRp71Io9p7G3Oj+E6G60+EDwjEiNZvibWs3NFkHgfSA9F6lFd2SH8W 9so9niVpTF3LROAdSa9TQQiUkCVz8ZVzTl4KblWNVAG4VIyz/fo+lr7+avuFbPzH5C/M OLsRyEybAUoAyqBEdT8pOJjZRHUoS8dTYTEwQzAd61SH8TmDa3WjzxDx/KdQ8qGnTpcZ gHDhqBKVk3soZkwdz3NZaEYRkwoTY+oTpBbBvlT2WZgKCGveaYSSCScv3fNq2yNP3950 g+E0KYgfIUr3WyFSCRtbh0C8fPY6NwIY4fd1kp8bUt6CQMdKs49Tvd+UWKIqaS+zTmhc R54g== X-Gm-Message-State: AO0yUKVfdQF4o2BnTu96cw+00PJtitYZ+hmCTZ2XdTisPxoeceHVQJES /XTDZ036aGUWbvL6bX7z3b1iG+xT5y/cbmterTPDnYPG86Djks0qhNRXM5kkaoM5JleZRSdABeg ReTwcROYZIUzlg21rTKj6UHXiLs2IhnGoJg== X-Received: by 2002:a05:6402:2061:b0:4af:6e95:861b with SMTP id bd1-20020a056402206100b004af6e95861bmr2592852edb.2.1679503848114; Wed, 22 Mar 2023 09:50:48 -0700 (PDT) X-Google-Smtp-Source: AK7set81SGKBifejn140arc2c2+DwGhIUA3UbW/6I9BzGIv0ozTbMEdDxAqFgAt55TnqFL+1IYKchw== X-Received: by 2002:a05:6402:2061:b0:4af:6e95:861b with SMTP id bd1-20020a056402206100b004af6e95861bmr2592836edb.2.1679503847844; Wed, 22 Mar 2023 09:50:47 -0700 (PDT) Date: Wed, 22 Mar 2023 12:50:44 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: Cornelia Huck , Heng Qi , "virtio-dev@lists.oasis-open.org" , "virtio-comment@lists.oasis-open.org" , Jason Wang , Alvaro Karsz , David Edmondson , Xuan Zhuo Message-ID: <20230322124843-mutt-send-email-mst@kernel.org> References: <20230322125153.128385-1-hengqi@linux.alibaba.com> <87sfdwhkxq.fsf@redhat.com> <87pm90hhew.fsf@redhat.com> <87jzz8hh1w.fsf@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: Re: [virtio-comment] RE: [PATCH v13] virtio-net: support the virtqueue coalescing moderation On Wed, Mar 22, 2023 at 04:46:36PM +0000, Parav Pandit wrote: > > > From: Cornelia Huck > > Sent: Wednesday, March 22, 2023 12:44 PM > > > > >> Well, I think we want to avoid having to add a normative statement > > >> for the device, so we need to be strict with what the driver is allowed to do. > > > Drivers are untrusted entities. > > > device normative statement is needed, it will do the checks anyway where it > > is applying the config. > > > > But isn't that implementation specific? I.e. if the driver sends junk, the device > > needs to be able to deal with it in any case. > Not sure which part is implementation specific. > The device will deal with it and return an error code when supplied qid is invalid (of cvq or of disabled vq). spec currently defines, generally, how devices behave if driver matches spec. We do not generally specify what happens if driver is out of spec. For example it's ok for device to just get wedged until reset. It's doable to change this but if yes we should do it over the board. And the benefit, IMHO, is limited. And doing it just for the coalescing commands would be super weird. -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/