From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 44CD5C76196
	for <linux-kernel@archiver.kernel.org>; Thu, 23 Mar 2023 18:39:52 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231226AbjCWSju (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 23 Mar 2023 14:39:50 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35516 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231443AbjCWSjs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Mar 2023 14:39:48 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51FD465A0;
        Thu, 23 Mar 2023 11:39:47 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id E0C5E626DD;
        Thu, 23 Mar 2023 18:39:46 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED723C433EF;
        Thu, 23 Mar 2023 18:39:45 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1679596786;
        bh=J1tuQBO7/NjxMfKdV01NRxEWxZt9Yl5LPJ9WZFCA3f8=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=i5a/Tksrk2VCYncC8YQR/q/Ma+j17gKS1GEz/NcKydCEPTHeMxkTO3wCBV5JDYKyv
         Skf9XwdkthCVfI5pWEZ2tKszF0BCN1UgMxWwJejw03Mt5I3E/gaE3iC5s/O3XofxVs
         mcBe6CZETTLgpbsRJ6yYBuubkYnL1hsQcUKJoTkFokXpmhMOyrIj7a3/w/+qJHLSQw
         2nSu7JtDPk1f+09pOaf/i88NtZbxoN9kPBGWxiw8K80DLmGKSzhFtPxiaBzIRTxgoo
         DGo2wBHFrKDCdZQ8efET+4JtgVvAAaTVXZZGdNY/fpWUcK2CzkUrXFixDg9xAnqABG
         pE4lcUqSDodGg==
Date:   Thu, 23 Mar 2023 11:39:45 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc:     netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Simon Horman <simon.horman@corigine.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Steve Glendinning <steve.glendinning@shawell.net>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH net v3 1/2] smsc911x: only update stats when interface
 is up
Message-ID: <20230323113945.0915029d@kernel.org>
In-Reply-To: <20230322071959.9101-2-wsa+renesas@sang-engineering.com>
References: <20230322071959.9101-1-wsa+renesas@sang-engineering.com>
        <20230322071959.9101-2-wsa+renesas@sang-engineering.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 22 Mar 2023 08:19:58 +0100 Wolfram Sang wrote:
> -	smsc911x_tx_update_txcounters(dev);
> -	dev->stats.rx_dropped += smsc911x_reg_read(pdata, RX_DROP);
> +
> +	if (netif_running(dev)) {
> +		smsc911x_tx_update_txcounters(dev);
> +		dev->stats.rx_dropped += smsc911x_reg_read(pdata, RX_DROP);
> +	}

Same problem as on the renesas patch, netif_running() can return true
before ndo->open() is called. And stats can be read with just the RCU
lock (via procfs).

Maybe we should add a false-negative version of netif_running() ?
__LINK_STATE_START*ED* ?