All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manorit Chawdhry <m-chawdhry@ti.com>
To: Bryan Brattlof <bb@ti.com>
Cc: <u-boot@lists.denx.de>, Andrew Davis <afd@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Neha Francis <n-francis@ti.com>,
	Jayesh Choudhary <j-choudhary@ti.com>,
	Tom Rini <trini@konsulko.com>, Judith Mendez <jm@ti.com>,
	Kamlesh Gurudasani <kamlesh@ti.com>
Subject: Re: [PATCH v5 2/4] configs: j721e: Merge the HS and non-HS defconfigs
Date: Fri, 24 Mar 2023 11:14:18 +0530	[thread overview]
Message-ID: <20230324054418.urmfszlarg6kqpn4@ula0497581> (raw)
In-Reply-To: <20230324010713.g6x6kurxciviyoll@bryanbrattlof.com>

On 20:07-20230323, Bryan Brattlof wrote:
> Hi Manorit!
> 
> On March 15, 2023 thus sayeth Manorit Chawdhry:
> > K3 devices have runtime type board detection. Make the default defconfig
> > include the secure configuration. Then remove the HS specific config.
> > 
> > Non-HS devices will continue to boot due to runtime device type detection.
> > If TI_SECURE_DEV_PKG is not set the build will emit warnings, for non-HS
> > devices these can be ignored.
> > 
> > Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> > Acked-by: Andrew Davis <afd@ti.com>
> > ---
> >  MAINTAINERS                        |   2 -
> >  configs/j721e_evm_a72_defconfig    |   3 +-
> >  configs/j721e_evm_r5_defconfig     |   1 +
> >  configs/j721e_hs_evm_a72_defconfig | 208 -----------------------------
> >  configs/j721e_hs_evm_r5_defconfig  | 176 ------------------------
> >  5 files changed, 3 insertions(+), 387 deletions(-)
> >  delete mode 100644 configs/j721e_hs_evm_a72_defconfig
> >  delete mode 100644 configs/j721e_hs_evm_r5_defconfig
> >
> 
> ...
> 
> >  CONFIG_OF_BOARD_SETUP=y
> > -CONFIG_BOOTCOMMAND="run findfdt; run distro_bootcmd; run init_${boot}; run main_cpsw0_qsgmii_phyinit; run boot_rprocs; run get_kern_${boot}; run get_fdt_${boot}; run get_overlay_${boot}; run run_kern"
> > +CONFIG_BOOTCOMMAND="run findfdt; run envboot; run init_${boot}; run main_cpsw0_qsgmii_phyinit; run boot_rprocs; if test ${boot_fit} -eq 1; then run get_fit_${boot}; run get_overlaystring; run run_fit; else; run get_kern_${boot}; run get_fdt_${boot}; run get_overlay_${boot}; run run_kern; fi;"
> 
> I'm curious, do we need to drop the distro_bootcmd step?
> 

Hi Bryan,

I believe that was a mistake on my part, need to fix it. Thanks for
noticing!

Regards,
Manorit

> ~Bryan
> 

  reply	other threads:[~2023-03-24  5:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15  6:47 [PATCH v5 0/4] J721E HS Fixes Manorit Chawdhry
2023-03-15  6:47 ` [PATCH v5 1/4] arm: k3: config.mk: Add missing dependencies on tispl.bin HS Manorit Chawdhry
2023-03-15  6:47 ` [PATCH v5 2/4] configs: j721e: Merge the HS and non-HS defconfigs Manorit Chawdhry
2023-03-24  1:07   ` Bryan Brattlof
2023-03-24  5:44     ` Manorit Chawdhry [this message]
2023-03-15  6:47 ` [PATCH v5 3/4] Kconfig: j721e: Change K3_MCU_SCRATCHPAD_BASE to non firewalled region Manorit Chawdhry
2023-03-15  6:47 ` [PATCH v5 4/4] arm: mach-k3: Increase SYSFW max image size Manorit Chawdhry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230324054418.urmfszlarg6kqpn4@ula0497581 \
    --to=m-chawdhry@ti.com \
    --cc=afd@ti.com \
    --cc=bb@ti.com \
    --cc=j-choudhary@ti.com \
    --cc=jm@ti.com \
    --cc=kamlesh@ti.com \
    --cc=n-francis@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.