From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Arun Ramadoss <arun.ramadoss@microchip.com>,
Woojung Huh <woojung.huh@microchip.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver@microchip.com, Eric Dumazet <edumazet@google.com>,
Vladimir Oltean <olteanv@gmail.com>,
kernel@pengutronix.de, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net v1 2/6] net: dsa: microchip: ksz8: fix ksz8_fdb_dump() to extract all 1024 entries
Date: Fri, 24 Mar 2023 09:38:12 -0700 [thread overview]
Message-ID: <20230324093812.331734c7@kernel.org> (raw)
In-Reply-To: <20230324053512.GG23237@pengutronix.de>
On Fri, 24 Mar 2023 06:35:12 +0100 Oleksij Rempel wrote:
> > Any reason you didn't CC Arun, just an omission or they're no longer
> > @microchip?
>
> He is not in MAINTAINERS for drivers/net/dsa/microchip/* even if he is
> practically maintaining it .. :)
get_maintainer is occasionally useful in pointing out people who wrote
the code but mostly the authors of code under Fixes. I use this little
script usually:
#!/usr/bin/env python3
import argparse
import fileinput
import subprocess
import tempfile
import sys
import os
import re
emailpat = re.compile(r'([^ <"]*@[^ >"]*)')
skip = {'kuba@kernel.org',
'davem@davemloft.net',
'pabeni@redhat.com',
'edumazet@google.com',
'netdev@vger.kernel.org',
'linux-kernel@vger.kernel.org'}
def do(lines):
ret = ['---']
for line in lines:
line = line.strip()
if not line:
continue
ret.append('# ' + line)
if "moderated" in line:
ret.append('# skip, moderated')
continue
match = emailpat.search(line)
if match:
addr = match.group(1)
if addr in skip:
ret.append('# skip, always-cc')
else:
ret.append('CC: ' + addr)
else:
ret.append('# Bad line')
return ret
def run(cmd):
p = subprocess.run(cmd, capture_output=True, check=True)
return p.stdout.decode("utf-8").strip()
def git_commit_msg():
return run(["git", "show", "--format=%B", "--no-patch"])
def git_commit(filename):
return run(["git", "commit", "--amend", "-F", filename])
def git_patch_format():
return run(["git", "format-patch", "HEAD~", "-o", "/tmp/"])
def get_maint(patch_file):
return run(["./scripts/get_maintainer.pl",
"--git-min-percent", "30", patch_file])
def main():
parser = argparse.ArgumentParser()
parser.add_argument('--stdin',
help="Read the get_maintainer output from stdin",
action='store_true')
parser.add_argument('--inline', help="Amend HEAD directly",
action='store_true')
args = parser.parse_args()
if args.stdin:
out = do(sys.stdin.readlines())
elif args.inline:
msg = git_commit_msg()
patch_file = git_patch_format()
maint = get_maint(patch_file)
os.unlink(patch_file)
out = do(maint.split("\n"))
out = [l for l in out if l[0] != '#']
tmpf = tempfile.NamedTemporaryFile(mode='w+', encoding="utf-8")
tmpf.write(msg + '\n')
tmpf.write('\n'.join(out))
tmpf.flush()
git_commit(tmpf.name)
tmpf.close()
out = ["Updated inline: " + msg.split("\n")[0]]
else:
patch_file = git_patch_format()
maint = get_maint(patch_file)
os.remove(patch_file)
out = do(maint.split("\n"))
print('\n'.join(out))
if __name__ == '__main__':
sys.exit(main())
next prev parent reply other threads:[~2023-03-24 16:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 14:31 [PATCH net v1 0/6] net: dsa: microchip: ksz8: fixes for stable Oleksij Rempel
2023-03-22 14:31 ` [PATCH net v1 1/6] net: dsa: microchip: ksz8: fix ksz8_fdb_dump() Oleksij Rempel
2023-03-24 4:20 ` Arun.Ramadoss
2023-03-22 14:31 ` [PATCH net v1 2/6] net: dsa: microchip: ksz8: fix ksz8_fdb_dump() to extract all 1024 entries Oleksij Rempel
2023-03-23 22:41 ` Jakub Kicinski
2023-03-24 5:35 ` Oleksij Rempel
2023-03-24 16:38 ` Jakub Kicinski [this message]
2023-03-24 3:51 ` Arun.Ramadoss
2023-03-22 14:31 ` [PATCH net v1 3/6] net: dsa: microchip: ksz8: fix offset for the timestamp filed Oleksij Rempel
2023-03-24 3:58 ` Arun.Ramadoss
2023-03-22 14:31 ` [PATCH net v1 4/6] net: dsa: microchip: ksz8: ksz8_fdb_dump: avoid extracting ghost entry from empty dynamic MAC table Oleksij Rempel
2023-03-24 4:04 ` Arun.Ramadoss
2023-03-22 14:31 ` [PATCH net v1 5/6] net: dsa: microchip: ksz8863_smi: fix bulk access Oleksij Rempel
2023-03-22 14:31 ` [PATCH net v1 6/6] net: dsa: microchip: ksz8: fix MDF configuration with non-zero VID Oleksij Rempel
2023-03-23 6:00 ` Oleksij Rempel
2023-03-24 4:08 ` Arun.Ramadoss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230324093812.331734c7@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.