From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25B188F71 for ; Fri, 24 Mar 2023 20:34:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 986E1C433D2; Fri, 24 Mar 2023 20:34:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1679690055; bh=0XrfIjT1HzllGbUgpFppNSNIjorIYRmjLQ/b09+uonc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Eax47RYlRW8awJxRcfVbThj3YrvrJpWoIOPvs/SovFqsP4ofR97yB+UnemOVMLk5D i+FEE2sBpwJIkEIReTSySu27giahCZ66EEveHK7vU21V46eCbxZlm04qdEiIGoG4vh DzBH8t2P3Qf2wIqr+0qQkf9efus8xEipDOz9MoRs= Date: Fri, 24 Mar 2023 13:34:14 -0700 From: Andrew Morton To: Shiyang Ruan Cc: , , , , Subject: Re: [PATCH] fsdax: dedupe should compare the min of two iters' length Message-Id: <20230324133414.c0fa29239383e8f5930c3ceb@linux-foundation.org> In-Reply-To: References: <1679469958-2-1-git-send-email-ruansy.fnst@fujitsu.com> <20230322161236.f90c21c8f668f551ee19d80b@linux-foundation.org> <0d219eb0-0f58-e667-0d86-be158ea2030f@fujitsu.com> <20230323151201.98d54f8d85f83c636568eacc@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 24 Mar 2023 12:19:46 +0800 Shiyang Ruan wrote: > > Again, how does the bug impact real-world kernel users? > > The dedupe command will fail with -EIO if the range is larger than one > page size and not aligned to the page size. Also report warning in dmesg: > > [ 4338.498374] ------------[ cut here ]------------ > [ 4338.498689] WARNING: CPU: 3 PID: 1415645 at fs/iomap/iter.c:16 OK, thanks. I added the above to the changelog and added cc:stable.