From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54AD5C76196 for ; Fri, 24 Mar 2023 15:56:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6CA88859F1; Fri, 24 Mar 2023 16:56:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="hieJHw8Z"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4BB0885B19; Fri, 24 Mar 2023 16:56:23 +0100 (CET) Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A233A8587B for ; Fri, 24 Mar 2023 16:56:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-5445009c26bso40427027b3.8 for ; Fri, 24 Mar 2023 08:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1679673379; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VyE3feqgWlY5yMxQOXInIWp+Dn/3k/+es+eWudh81wk=; b=hieJHw8ZP71LY+i0AcpKedNpUg78i3v7jFuOoEVmThFyrGl6FwyKIbhqok+EswgQs3 RfcoZM44eq85QYyw3H1dhmFQRsLVxlsUawQ89tRvSnjlEpGmoYrZCmMhEqXw5qT32/Kv KOd4xTYNTrQGIwq0AkTEqBBCZJtvI846QJxbk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679673379; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VyE3feqgWlY5yMxQOXInIWp+Dn/3k/+es+eWudh81wk=; b=Hl5wY83O923QLtg8vKRZWmFx2PV7FV6918fzmwYL84wsqh38PrzGQkqdSfZGo2hf3X xTNXQHqQ81xV/XYGn5xn3rci4alLiqemaiNnKPEMJlT/fr6qnhhs0W0bRxSK0oXRIjXG 1exR9oQBNRRuIPfNjLcmsJRQkgSfuaNcZj528b7pTUn4dPLqfr/ehkLU9ZAUqIcpsARj 1a2tesQgThwAcwlxBidgsKdjaClSQds2a7+imFZ+ojjTd662ICA8fk6difrD/kSNCeVU 77aq227GEXcTNGmIloIkdkIUwUXfTAm3XI6qLwOxzQ1nDLWIgGVNOe2T7s0hPp4rcXXz Emhg== X-Gm-Message-State: AAQBX9fGT3vcADbSR4bbrq6j5+Xp7IimYfBGYM2zCGyFS1O/0dsf5UEo edd3QwlALXyJzzncz18nux93Ww== X-Google-Smtp-Source: AKy350aAKJ6D4qKa30rI1Z84CEEMz9tNOAp42jstrKivYJEFuOY6yLll4Lz0r/I58u1meC7qX+O3Dg== X-Received: by 2002:a0d:ebc8:0:b0:53c:6e3e:607b with SMTP id u191-20020a0debc8000000b0053c6e3e607bmr2856937ywe.38.1679673379248; Fri, 24 Mar 2023 08:56:19 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-ef17-d9dc-8ac6-ade4.res6.spectrum.com. [2603:6081:7b00:6400:ef17:d9dc:8ac6:ade4]) by smtp.gmail.com with ESMTPSA id l186-20020a8157c3000000b00545a0818494sm475138ywb.36.2023.03.24.08.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 08:56:18 -0700 (PDT) Date: Fri, 24 Mar 2023 11:56:16 -0400 From: Tom Rini To: Bhupesh Sharma Cc: u-boot@lists.denx.de, jh80.chung@samsung.com, peng.fan@nxp.com, rfried.dev@gmail.com, sjg@chromium.org, dsankouski@gmail.com, bhupesh.linux@gmail.com Subject: Re: [PATCH 5/5] board: qualcomm: Add support for QRB4210-RB2 Message-ID: <20230324155616.GK8135@bill-the-cat> References: <20230324080418.3856409-1-bhupesh.sharma@linaro.org> <20230324080418.3856409-6-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="B/s4/rYFYxjFCM9e" Content-Disposition: inline In-Reply-To: <20230324080418.3856409-6-bhupesh.sharma@linaro.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --B/s4/rYFYxjFCM9e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 24, 2023 at 01:34:18PM +0530, Bhupesh Sharma wrote: > Add support for Qualcomm QRB4210-RB2 evaluation board > (based on Qualcomm QRB4210 SoC). >=20 > Features: > - Qualcomm Snapdragon QRB4210 (Robotics version of SM6115 SoC). > - 2GiB RAM (on-board) [max: 8 GiB]. > - 16GiB eMMC, uSD slot. >=20 > U-boot is chain loaded by ABL in 64-bit mode as part of boot.img. >=20 > For detailed build and boot instructions, refer to > doc/board/qualcomm/qrb4210-rb2.rst. >=20 > Signed-off-by: Bhupesh Sharma [snip] You don't say where the dtsi file is synced from, and it should be in linux-next or similar, at least. [snip] > diff --git a/arch/arm/dts/qrb4210-rb2-uboot.dtsi b/arch/arm/dts/qrb4210-r= b2-uboot.dtsi > new file mode 100644 > index 0000000000..8588dc2bf6 > --- /dev/null > +++ b/arch/arm/dts/qrb4210-rb2-uboot.dtsi "-u-boot.dtsi" is automatically included, but this needs #included, also: > @@ -0,0 +1,24 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * U-Boot addition to handle QRB4210-RB2 pre-relocation devices > + * > + * (C) Copyright 2023 Bhupesh Sharma > + */ > + > +/ { > + soc { > + u-boot,dm-pre-reloc; You didn't build-test on -next, where these are all bootph-* now. And, they go upstream too as the binding exists there. > diff --git a/board/qualcomm/qrb4210-rb2/MAINTAINERS b/board/qualcomm/qrb4= 210-rb2/MAINTAINERS > new file mode 100644 > index 0000000000..2b569bb983 > --- /dev/null > +++ b/board/qualcomm/qrb4210-rb2/MAINTAINERS > @@ -0,0 +1,6 @@ > +Qualcomm Technologies, Inc. QRB4210-RB2 evaluation board > +M: Bhupesh Sharma > +S: Maintained > +F: board/qualcomm/qrb4210-rb2/ > +F: include/configs/qrb4210-rb2.h > +F: configs/qrb4210rb2_defconfig Please list the board doc file as well here (which I'm quite glad to see you wrote!). > diff --git a/include/configs/qrb4210-rb2.h b/include/configs/qrb4210-rb2.h > new file mode 100644 > index 0000000000..80b9c5e2dd > --- /dev/null > +++ b/include/configs/qrb4210-rb2.h > @@ -0,0 +1,21 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * Configuration file for QRB4210-RB2 board > + * > + * (C) Copyright 2023 Bhupesh Sharma > + */ > + > +#ifndef __CONFIGS_QRB4210RB2_H > +#define __CONFIGS_QRB4210RB2_H > + > +#include > +#include We should really really not need include files here. You aren't using either of them directly. > +#define CFG_SYS_BAUDRATE_TABLE { 115200 } > + > +#define CFG_EXTRA_ENV_SETTINGS \ > + "bootm_size=3D0x5000000\0" \ > + "bootm_low=3D0x80000000\0" \ > + "bootcmd=3Dbootm $prevbl_initrd_start_addr\0" Shouldn't this be using either distro_bootcmd or bootstd (see doc/develop/bootstd.rst) instead? --=20 Tom --B/s4/rYFYxjFCM9e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQdyB0ACgkQFHw5/5Y0 tywq6wv/W2DjIAM5uC/VP7oUcOO7b6AZ3LDCyaOQ0Th53bfw233Ovj+XHApIMTEz Qwzmx+clOYqoDqCoWYYVXmz8PRPYw/AGfnhW1/aOjqynTqljee0wj79j6+8W9Viw ZIbpfRvuDn6IWEmH1Qv1vMSba0Wm0FXDyKHZcN5jOc5d+0rNMm757ucUQjQ6tGRH U6D0Shrftw1pjJYLxmhYSovXPHksP9DopcSF3frPoABl7MxIzahUrVbvIi54BaVx oqiediHkk+1w++8CElYULXMLo2A68299vq5BpFHvjRWqLFBGV/vCR5Z/iF41/Ipa bmbe0mfV59w3Hn7pMQpITaKc4lxAgrSfAz+q4fJR7BX4ggc833odG3+7wjngGOFZ dkh6GQP/h7LIKZqw0RXZpL+iYmWPx+PAIbwdE+c3URdAsyv6IhNH0wZy02NEMPyu gZ44GH/FnJopYrk4vC+NkNY3G2BJWRwKo7MA9yNdspXRQzPeJhS01/UJkpSBwaXS lXp+v7yC =igbx -----END PGP SIGNATURE----- --B/s4/rYFYxjFCM9e--